[jira] [Commented] (KAFKA-3051) security.protocol documentation is inaccurate

2016-01-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-3051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15081780#comment-15081780
 ] 

ASF GitHub Bot commented on KAFKA-3051:
---

Github user asfgit closed the pull request at:

https://github.com/apache/kafka/pull/724


> security.protocol documentation is inaccurate
> -
>
> Key: KAFKA-3051
> URL: https://issues.apache.org/jira/browse/KAFKA-3051
> Project: Kafka
>  Issue Type: Improvement
>  Components: clients
>Affects Versions: 0.9.0.0
>Reporter: Jun Rao
>Assignee: Ismael Juma
>  Labels: security
> Fix For: 0.9.0.1
>
>
> In CommonClientConfigs, the doc for security.protocol says "Currently only 
> PLAINTEXT and SSL are supported.". This is inaccurate since we support SASL 
> as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (KAFKA-3051) security.protocol documentation is inaccurate

2016-01-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-3051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15081028#comment-15081028
 ] 

ASF GitHub Bot commented on KAFKA-3051:
---

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/724

KAFKA-3051 KAFKA-3048; Security config docs improvements



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka minor-security-fixes

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/724.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #724


commit 9156fa3fb2dd90c3cf871d23a49b6ead149e29ad
Author: Ismael Juma 
Date:   2016-01-04T10:59:28Z

KAFKA-3051: security.protocol documentation is inaccurate

commit a9bae91039c63a32ec1c84c9a556a051a68d9373
Author: Ismael Juma 
Date:   2016-01-04T11:00:05Z

KAFKA-3048: incorrect property name ssl.want.client.auth

commit 6b3f87ee82266363584498df4a6fa99dc63eb47d
Author: Ismael Juma 
Date:   2016-01-04T11:17:44Z

Remove redundant default information in security-related config docs

I removed the cases where the value was the same as the one
that appears in the HTML table and left the cases where it adds
useful information.

commit 670363ec7846716c58d77ef266bea6a4e146084f
Author: Ismael Juma 
Date:   2016-01-04T11:18:41Z

Use `{` and `}` instead of `<` and `>` as placeholder to fix HTML rendering

commit b82ae369bd90fb63445efb6a022b5d4e5dbd93d6
Author: Ismael Juma 
Date:   2016-01-04T11:19:58Z

Fix `KafkaChannel.principal()` documentation

Also include minor `KafkaChannel` clean-ups.

commit 0fa85e5ab4acc7322fe07f79b9d2218fe2d08d2a
Author: Ismael Juma 
Date:   2016-01-04T11:20:36Z

Fix `SslTransportLayer` reference in `SslSelectorTest` comment




> security.protocol documentation is inaccurate
> -
>
> Key: KAFKA-3051
> URL: https://issues.apache.org/jira/browse/KAFKA-3051
> Project: Kafka
>  Issue Type: Improvement
>  Components: clients
>Affects Versions: 0.9.0.0
>Reporter: Jun Rao
>Assignee: Ismael Juma
>  Labels: security
> Fix For: 0.9.0.1
>
>
> In CommonClientConfigs, the doc for security.protocol says "Currently only 
> PLAINTEXT and SSL are supported.". This is inaccurate since we support SASL 
> as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)