[jira] [Commented] (KAFKA-3152) kafka-acl doesn't allow space in principal name
[ https://issues.apache.org/jira/browse/KAFKA-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15123233#comment-15123233 ] ASF GitHub Bot commented on KAFKA-3152: --- Github user ijuma closed the pull request at: https://github.com/apache/kafka/pull/820 > kafka-acl doesn't allow space in principal name > --- > > Key: KAFKA-3152 > URL: https://issues.apache.org/jira/browse/KAFKA-3152 > Project: Kafka > Issue Type: Bug > Components: core >Affects Versions: 0.9.0.0 >Reporter: Jun Rao >Assignee: Ismael Juma > Fix For: 0.9.0.1 > > > When running the following, > kafka-acls --authorizer kafka.security.auth.SimpleAclAuthorizer > --authorizer-properties zookeeper.connect=localhost:2181 --topic test --add > --producer --allow-host=* --allow-principal "User:CN=xxx,O=My Organization" > the acl is set as the following. The part after space is ignored. > Following is list of acls for resource: Topic:test > User:CN=xxx,O=My has Allow permission for operations: Describe from > hosts: * > User:CN=xxx,O=My has Allow permission for operations: Write from hosts: > * -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-3152) kafka-acl doesn't allow space in principal name
[ https://issues.apache.org/jira/browse/KAFKA-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15120007#comment-15120007 ] ASF GitHub Bot commented on KAFKA-3152: --- GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/820 KAFKA-3152; kafka-acl doesn't allow space in principal name (backport to 0.9.0) This is a backport of the trunk PR and it excludes the test changes due to conflicts and the fact that the changes were not directly related to the bug in the end (it was something we did not test for, but the non-shell code was already correct). Details: * Add quotes to `$` in shell scripts This is necessary for correct processing of quotes in the user command. * Minor improvements to AclCommand messages You can merge this pull request into a Git repository by running: $ git pull https://github.com/ijuma/kafka kafka-3152-backport-kafka-acl-space-in-principal-name Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/820.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #820 commit 20adaf6677c39865b3a288d112079f12f3842737 Author: Ismael Juma Date: 2016-01-27T16:23:25Z KAFKA-3152; kafka-acl doesn't allow space in principal name This is a backport of the trunk PR and it excludes the test changes due to conflicts and the fact that the changes were not directly related to the bug in the end (it was something we did not test for, but the non-shell code was already correct). Details: * Add quotes to `$` in shell scripts This is necessary for correct processing of quotes in the user command. * Minor improvements to AclCommand messages > kafka-acl doesn't allow space in principal name > --- > > Key: KAFKA-3152 > URL: https://issues.apache.org/jira/browse/KAFKA-3152 > Project: Kafka > Issue Type: Bug > Components: core >Affects Versions: 0.9.0.0 >Reporter: Jun Rao >Assignee: Ismael Juma > > When running the following, > kafka-acls --authorizer kafka.security.auth.SimpleAclAuthorizer > --authorizer-properties zookeeper.connect=localhost:2181 --topic test --add > --producer --allow-host=* --allow-principal "User:CN=xxx,O=My Organization" > the acl is set as the following. The part after space is ignored. > Following is list of acls for resource: Topic:test > User:CN=xxx,O=My has Allow permission for operations: Describe from > hosts: * > User:CN=xxx,O=My has Allow permission for operations: Write from hosts: > * -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-3152) kafka-acl doesn't allow space in principal name
[ https://issues.apache.org/jira/browse/KAFKA-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15119698#comment-15119698 ] ASF GitHub Bot commented on KAFKA-3152: --- Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/818 > kafka-acl doesn't allow space in principal name > --- > > Key: KAFKA-3152 > URL: https://issues.apache.org/jira/browse/KAFKA-3152 > Project: Kafka > Issue Type: Bug > Components: core >Affects Versions: 0.9.0.0 >Reporter: Jun Rao >Assignee: Ismael Juma > > When running the following, > kafka-acls --authorizer kafka.security.auth.SimpleAclAuthorizer > --authorizer-properties zookeeper.connect=localhost:2181 --topic test --add > --producer --allow-host=* --allow-principal "User:CN=xxx,O=My Organization" > the acl is set as the following. The part after space is ignored. > Following is list of acls for resource: Topic:test > User:CN=xxx,O=My has Allow permission for operations: Describe from > hosts: * > User:CN=xxx,O=My has Allow permission for operations: Write from hosts: > * -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-3152) kafka-acl doesn't allow space in principal name
[ https://issues.apache.org/jira/browse/KAFKA-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15119066#comment-15119066 ] ASF GitHub Bot commented on KAFKA-3152: --- GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/818 KAFKA-3152; kafka-acl doesn't allow space in principal name * Add quotes to `$@` in shell scripts This is necessary for correct processing of quotes in the user command. * Minor improvements to AclCommand messages * Use a principal with a space in `SslEndToEndAuthorizationTest` This passed without any other changes, but good avoid regressions. * Clean-up `TestSslUtils`: Remove unused methods, fix unnecessary verbosity and don't set security.protocol (it should be done at a higher-level). You can merge this pull request into a Git repository by running: $ git pull https://github.com/ijuma/kafka kafka-3152-kafka-acl-space-in-principal Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/818.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #818 commit 376b537f48dd593c68da7b296554b1ffb857ab98 Author: Ismael Juma Date: 2016-01-27T09:09:40Z Add quotes to `$@` in shell scripts This is necessary for correct processing of quotes in the user command. commit 24ca26bd32f763ce3945e0561ded05312594b3b3 Author: Ismael Juma Date: 2016-01-27T09:19:19Z Minor improvements to AclCommand messages commit 98cd852bb5ecfd4eece25737f1c27f89fdb48c65 Author: Ismael Juma Date: 2016-01-27T09:30:50Z Use a principal with a space in `SslEndToEndAuthorizationTest` Also clean-up `TestSslUtils`: * Remove unused methods * Fix unnecessary verbosity * Don't set security.protocol (it should be done at a higher-level) > kafka-acl doesn't allow space in principal name > --- > > Key: KAFKA-3152 > URL: https://issues.apache.org/jira/browse/KAFKA-3152 > Project: Kafka > Issue Type: Bug > Components: core >Affects Versions: 0.9.0.0 >Reporter: Jun Rao >Assignee: Ismael Juma > > When running the following, > kafka-acls --authorizer kafka.security.auth.SimpleAclAuthorizer > --authorizer-properties zookeeper.connect=localhost:2181 --topic test --add > --producer --allow-host=* --allow-principal "User:CN=xxx,O=My Organization" > the acl is set as the following. The part after space is ignored. > Following is list of acls for resource: Topic:test > User:CN=xxx,O=My has Allow permission for operations: Describe from > hosts: * > User:CN=xxx,O=My has Allow permission for operations: Write from hosts: > * -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-3152) kafka-acl doesn't allow space in principal name
[ https://issues.apache.org/jira/browse/KAFKA-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15118401#comment-15118401 ] Ismael Juma commented on KAFKA-3152: This is a trivial bug in the kafka-acls shell script. Many other shell scripts have the same problem. Will post a PR tomorrow. > kafka-acl doesn't allow space in principal name > --- > > Key: KAFKA-3152 > URL: https://issues.apache.org/jira/browse/KAFKA-3152 > Project: Kafka > Issue Type: Bug > Components: core >Affects Versions: 0.9.0.0 >Reporter: Jun Rao >Assignee: Ismael Juma > > When running the following, > kafka-acls --authorizer kafka.security.auth.SimpleAclAuthorizer > --authorizer-properties zookeeper.connect=localhost:2181 --topic test --add > --producer --allow-host=* --allow-principal "User:CN=xxx,O=My Organization" > the acl is set as the following. The part after space is ignored. > Following is list of acls for resource: Topic:test > User:CN=xxx,O=My has Allow permission for operations: Describe from > hosts: * > User:CN=xxx,O=My has Allow permission for operations: Write from hosts: > * -- This message was sent by Atlassian JIRA (v6.3.4#6332)
