[jira] [Commented] (KAFKA-3301) CommonClientConfigs.METRICS_SAMPLE_WINDOW_MS_DOC is incorrect

2016-03-22 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-3301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15207396#comment-15207396
 ] 

ASF GitHub Bot commented on KAFKA-3301:
---

Github user asfgit closed the pull request at:

https://github.com/apache/kafka/pull/1114


> CommonClientConfigs.METRICS_SAMPLE_WINDOW_MS_DOC  is incorrect
> --
>
> Key: KAFKA-3301
> URL: https://issues.apache.org/jira/browse/KAFKA-3301
> Project: Kafka
>  Issue Type: Improvement
>Reporter: Jun Rao
>Assignee: Grant Henke
> Fix For: 0.10.0.0
>
>
> The text says "The number of samples maintained to compute metrics.", which 
> is in correct.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (KAFKA-3301) CommonClientConfigs.METRICS_SAMPLE_WINDOW_MS_DOC is incorrect

2016-03-22 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-3301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15206866#comment-15206866
 ] 

ASF GitHub Bot commented on KAFKA-3301:
---

GitHub user granthenke opened a pull request:

https://github.com/apache/kafka/pull/1114

KAFKA-3301: CommonClientConfigs.METRICS_SAMPLE_WINDOW_MS_DOC is incor…

…rect

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/granthenke/kafka window-docs

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/1114.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1114


commit 0d64663754c801ad347098b6d321daa3c54d70a6
Author: Grant Henke 
Date:   2016-03-22T17:40:50Z

KAFKA-3301: CommonClientConfigs.METRICS_SAMPLE_WINDOW_MS_DOC is incorrect




> CommonClientConfigs.METRICS_SAMPLE_WINDOW_MS_DOC  is incorrect
> --
>
> Key: KAFKA-3301
> URL: https://issues.apache.org/jira/browse/KAFKA-3301
> Project: Kafka
>  Issue Type: Improvement
>Reporter: Jun Rao
>Assignee: Grant Henke
> Fix For: 0.10.1.0
>
>
> The text says "The number of samples maintained to compute metrics.", which 
> is in correct.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)