[jira] [Commented] (KAFKA-3352) Avoid DNS reverse lookups

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-3352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15188182#comment-15188182
 ] 

ASF GitHub Bot commented on KAFKA-3352:
---

Github user asfgit closed the pull request at:

https://github.com/apache/kafka/pull/1030


> Avoid DNS reverse lookups
> -
>
> Key: KAFKA-3352
> URL: https://issues.apache.org/jira/browse/KAFKA-3352
> Project: Kafka
>  Issue Type: Improvement
>Reporter: Ismael Juma
>Assignee: Ismael Juma
> Fix For: 0.10.0.0
>
>
> We use `InetSocketAddress.getHostName` in `Cluster.bootstrap` and 
> `SocketServer` This call can cause a reverse DNS look-up if an IP address is 
> used in the configuration. `getHostString` avoids the reverse DNS look-up.
> `InetAddress.getHostName` has the same issue and it's used in 
> `SaslChannelBuilder`, `SslChannelBuilder` and `ZookeeperConsumerConnector`. I 
> am not changing these because the the former two actually require the FQDN 
> while the latter is on its way to deprecation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (KAFKA-3352) Avoid DNS reverse lookups

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-3352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15185943#comment-15185943
 ] 

ASF GitHub Bot commented on KAFKA-3352:
---

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/1030

KAFKA-3352: Avoid DNS reverse lookups

By using `getHostString` (introduced in Java 7) instead of `getHostName`.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka 
kafka-3352-avoid-dns-reverse-look-ups

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/1030.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1030


commit 3da9c7ec7e137efab2ba300deb0a94918188eb5b
Author: Ismael Juma 
Date:   2016-03-08T22:11:36Z

Use `getHostString` instead of `getHostName` to avoid reverse DNS look-ups




> Avoid DNS reverse lookups
> -
>
> Key: KAFKA-3352
> URL: https://issues.apache.org/jira/browse/KAFKA-3352
> Project: Kafka
>  Issue Type: Improvement
>Reporter: Ismael Juma
>Assignee: Ismael Juma
>
> We use `InetSocketAddress.getHostName` in `Cluster.bootstrap` and 
> `SocketServer` This call can cause a reverse DNS look-up if an IP address is 
> used in the configuration. `getHostString` avoids the reverse DNS look-up.
> `InetAddress.getHostName` has the same issue and it's used in 
> `SaslChannelBuilder`, `SslChannelBuilder` and `ZookeeperConsumerConnector`. I 
> am not changing these because the the former two actually require the FQDN 
> while the latter is on its way to deprecation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)