[jira] [Commented] (KAFKA-3407) ErrorLoggingCallback trims helpful diagnostic information.

2016-03-24 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-3407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210671#comment-15210671
 ] 

ASF GitHub Bot commented on KAFKA-3407:
---

Github user asfgit closed the pull request at:

https://github.com/apache/kafka/pull/1079


> ErrorLoggingCallback trims helpful diagnostic information.
> --
>
> Key: KAFKA-3407
> URL: https://issues.apache.org/jira/browse/KAFKA-3407
> Project: Kafka
>  Issue Type: Improvement
>Reporter: Jeremy Custenborder
>Priority: Minor
> Fix For: 0.10.1.0
>
>
> ErrorLoggingCallback currently only returns the message of the message 
> returned. Any inner exception or callstack is not included. This makes 
> troubleshooting more difficult. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (KAFKA-3407) ErrorLoggingCallback trims helpful diagnostic information.

2016-03-15 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-3407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15196650#comment-15196650
 ] 

ASF GitHub Bot commented on KAFKA-3407:
---

GitHub user jcustenborder opened a pull request:

https://github.com/apache/kafka/pull/1079

KAFKA-3407 - ErrorLoggingCallback trims helpful diagnostic information.

This should help when diagnosing issues with the console producer. This 
allows the logger to use `exception` rather than `exception.getMessage()`.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jcustenborder/kafka KAFKA-3407

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/1079.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1079


commit fe80be8e3837dd6f03f69947e3ac8f7a8c4fe14b
Author: Jeremy Custenborder 
Date:   2016-03-16T02:21:01Z

KAFKA-3407 - Changed to use exception instead of exception.getMessage(). 
This will return callstack and inner exceptions.




> ErrorLoggingCallback trims helpful diagnostic information.
> --
>
> Key: KAFKA-3407
> URL: https://issues.apache.org/jira/browse/KAFKA-3407
> Project: Kafka
>  Issue Type: Improvement
>Reporter: Jeremy Custenborder
>Priority: Minor
>
> ErrorLoggingCallback currently only returns the message of the message 
> returned. Any inner exception or callstack is not included. This makes 
> troubleshooting more difficult. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)