[jira] [Commented] (KAFKA-3599) Minor code cleanup

2016-04-24 Thread Matthias J. Sax (JIRA) 

[ 
https://issues.apache.org/jira/browse/KAFKA-3599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15255733#comment-15255733
 ] 

Matthias J. Sax commented on KAFKA-3599:


Removing the `equals()` issue from this JIRA because this is covered by 
[~miguno] PRs for KAFKA-3613 already.

> Minor code cleanup
> --
>
> Key: KAFKA-3599
> URL: https://issues.apache.org/jira/browse/KAFKA-3599
> Project: Kafka
>  Issue Type: Sub-task
>  Components: streams
>Reporter: Matthias J. Sax
>Assignee: Matthias J. Sax
>Priority: Minor
>  Labels: api
>
> - Clean up {{Window.equals()}} and {{Window.equalsTo()}}. Both do the same.
> - remove {{WindowStoreUtils}} from public API, ie, move to sub-package 
> {{internals}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (KAFKA-3599) Minor code cleanup

2016-04-23 Thread Guozhang Wang (JIRA) 

[ 
https://issues.apache.org/jira/browse/KAFKA-3599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15255499#comment-15255499
 ] 

Guozhang Wang commented on KAFKA-3599:
--

I originally had `equalsTo` in `Windows` for comparing two window specs are 
`aligned` and of the same type, but that check gets replaced a while ago. Let's 
remove this function in `Windows` as well.

> Minor code cleanup
> --
>
> Key: KAFKA-3599
> URL: https://issues.apache.org/jira/browse/KAFKA-3599
> Project: Kafka
>  Issue Type: Sub-task
>  Components: streams
>Reporter: Matthias J. Sax
>Assignee: Matthias J. Sax
>Priority: Minor
>  Labels: api
>
> - Clean up {{Window.equals()}} and {{Window.equalsTo()}}. Both do the same.
> - remove {{WindowStoreUtils}} from public API, ie, move to sub-package 
> {{internals}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (KAFKA-3599) Minor code cleanup

2016-04-21 Thread Matthias J. Sax (JIRA) 

[ 
https://issues.apache.org/jira/browse/KAFKA-3599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15251933#comment-15251933
 ] 

Matthias J. Sax commented on KAFKA-3599:


[~guozhang] if I understand correctly, we remove {{equalsTo()}} and just use 
{{equals()}}. I also discovered, that {{Windows}} (plural, not singular) has 
{{equalsTo()}} as well, but the method is never used. For consistency, it might 
be good to remove {{equalsTo()}} from {{Windows}} completely or rename it to 
{{equals()}}? What do you think about it?

> Minor code cleanup
> --
>
> Key: KAFKA-3599
> URL: https://issues.apache.org/jira/browse/KAFKA-3599
> Project: Kafka
>  Issue Type: Sub-task
>  Components: streams
>Reporter: Matthias J. Sax
>Assignee: Matthias J. Sax
>Priority: Minor
>  Labels: api
>
> - Clean up {{Window.equals()}} and {{Window.equalsTo()}}. Both do the same.
> - remove {{WindowStoreUtils}} from public API, ie, move to sub-package 
> {{internals}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)