[jira] [Commented] (KAFKA-4092) retention.bytes should not be allowed to be less than segment.bytes

[Ismael Juma (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15892019#comment-15892019
 ] 

Ismael Juma commented on KAFKA-4092:


[~ewencp], yeah, I was thinking about what's the right thing to do here and was 
not sure. This JIRA was actually included in 0.10.2.0, but was reverted in 
0.10.2.1. I think I'll just remove the fix version and update the description.

> retention.bytes should not be allowed to be less than segment.bytes
> ---
>
> Key: KAFKA-4092
> URL: https://issues.apache.org/jira/browse/KAFKA-4092
> Project: Kafka
>  Issue Type: Improvement
>  Components: log
>Reporter: Dustin Cote
>Assignee: Dustin Cote
>Priority: Minor
>
> Right now retention.bytes can be as small as the user wants but it doesn't 
> really get acted on for the active segment if retention.bytes is smaller than 
> segment.bytes.  We shouldn't allow retention.bytes to be less than 
> segment.bytes and validate that at startup.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (KAFKA-4092) retention.bytes should not be allowed to be less than segment.bytes

[Ewen Cheslack-Postava (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891667#comment-15891667
 ] 

Ewen Cheslack-Postava commented on KAFKA-4092:
--

[~ijuma] Since this is still marked for a released version, can we retarget the 
fix version since it's been reopened? And possibly the status as well -- is 
there a blocker here, or still minor? At a minimum, we might need to remove the 
fix version if the change has been reverted.

> retention.bytes should not be allowed to be less than segment.bytes
> ---
>
> Key: KAFKA-4092
> URL: https://issues.apache.org/jira/browse/KAFKA-4092
> Project: Kafka
>  Issue Type: Improvement
>  Components: log
>Reporter: Dustin Cote
>Assignee: Dustin Cote
>Priority: Minor
> Fix For: 0.10.2.0
>
>
> Right now retention.bytes can be as small as the user wants but it doesn't 
> really get acted on for the active segment if retention.bytes is smaller than 
> segment.bytes.  We shouldn't allow retention.bytes to be less than 
> segment.bytes and validate that at startup.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (KAFKA-4092) retention.bytes should not be allowed to be less than segment.bytes

[Andrew Olson (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15890540#comment-15890540
 ] 

Andrew Olson commented on KAFKA-4092:
-

Note that this Jira is being reverted in 0.10.2.1 (see KAFKA-4788 for details).

> retention.bytes should not be allowed to be less than segment.bytes
> ---
>
> Key: KAFKA-4092
> URL: https://issues.apache.org/jira/browse/KAFKA-4092
> Project: Kafka
>  Issue Type: Improvement
>  Components: log
>Reporter: Dustin Cote
>Assignee: Dustin Cote
>Priority: Minor
> Fix For: 0.10.2.0
>
>
> Right now retention.bytes can be as small as the user wants but it doesn't 
> really get acted on for the active segment if retention.bytes is smaller than 
> segment.bytes.  We shouldn't allow retention.bytes to be less than 
> segment.bytes and validate that at startup.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (KAFKA-4092) retention.bytes should not be allowed to be less than segment.bytes

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15781163#comment-15781163
 ] 

ASF GitHub Bot commented on KAFKA-4092:
---

Github user asfgit closed the pull request at:

https://github.com/apache/kafka/pull/1796


> retention.bytes should not be allowed to be less than segment.bytes
> ---
>
> Key: KAFKA-4092
> URL: https://issues.apache.org/jira/browse/KAFKA-4092
> Project: Kafka
>  Issue Type: Improvement
>  Components: log
>Reporter: Dustin Cote
>Assignee: Dustin Cote
>Priority: Minor
>
> Right now retention.bytes can be as small as the user wants but it doesn't 
> really get acted on for the active segment if retention.bytes is smaller than 
> segment.bytes.  We shouldn't allow retention.bytes to be less than 
> segment.bytes and validate that at startup.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (KAFKA-4092) retention.bytes should not be allowed to be less than segment.bytes

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15446586#comment-15446586
 ] 

ASF GitHub Bot commented on KAFKA-4092:
---

GitHub user cotedm opened a pull request:

https://github.com/apache/kafka/pull/1796

KAFKA-4092: retention.bytes should not be allowed to be less than 
segment.bytes

adding a LogConfig value validator.  @gwenshap or @junrao would you mind 
taking a look?

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cotedm/kafka retentionbytesvalidation

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/1796.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1796


commit 9312611cb6b92bf17984bf6a499206634526db38
Author: Dustin Cote 
Date:   2016-08-29T18:01:01Z

add a LogConfig value validator




> retention.bytes should not be allowed to be less than segment.bytes
> ---
>
> Key: KAFKA-4092
> URL: https://issues.apache.org/jira/browse/KAFKA-4092
> Project: Kafka
>  Issue Type: Improvement
>  Components: log
>Reporter: Dustin Cote
>Assignee: Dustin Cote
>Priority: Minor
>
> Right now retention.bytes can be as small as the user wants but it doesn't 
> really get acted on for the active segment if retention.bytes is smaller than 
> segment.bytes.  We shouldn't allow retention.bytes to be less than 
> segment.bytes and validate that at startup.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)