[jira] [Commented] (KAFKA-4177) Replication Throttling: Remove ThrottledReplicationRateLimit from Server Config
[ https://issues.apache.org/jira/browse/KAFKA-4177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15527207#comment-15527207 ] ASF GitHub Bot commented on KAFKA-4177: --- Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/1864 > Replication Throttling: Remove ThrottledReplicationRateLimit from Server > Config > --- > > Key: KAFKA-4177 > URL: https://issues.apache.org/jira/browse/KAFKA-4177 > Project: Kafka > Issue Type: Improvement > Components: replication >Affects Versions: 0.10.1.0 >Reporter: Ben Stopford >Assignee: Ben Stopford > > Replication throttling included the concept of a dynamic broker config > (currently for just one property: ThrottledReplicationRateLimit). > On reflection it seems best to not include this in KafkaConfig, but rather > validate only in AdminUtils. Remove the property > ThrottledReplicationRateLimit and related config from KafkaConfig and add > validation in AdminUtils where the value can be applied/changed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-4177) Replication Throttling: Remove ThrottledReplicationRateLimit from Server Config
[ https://issues.apache.org/jira/browse/KAFKA-4177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15504230#comment-15504230 ] Ben Stopford commented on KAFKA-4177: - Patch submitted here: https://github.com/apache/kafka/pull/1864 > Replication Throttling: Remove ThrottledReplicationRateLimit from Server > Config > --- > > Key: KAFKA-4177 > URL: https://issues.apache.org/jira/browse/KAFKA-4177 > Project: Kafka > Issue Type: Improvement > Components: replication >Affects Versions: 0.10.1.0 >Reporter: Ben Stopford >Assignee: Ben Stopford > > Replication throttling included the concept of a dynamic broker config > (currently for just one property: ThrottledReplicationRateLimit). > On reflection it seems best to not include this in KafkaConfig, but rather > validate only in AdminUtils. Remove the property > ThrottledReplicationRateLimit and related config from KafkaConfig and add > validation in AdminUtils where the value can be applied/changed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
