[jira] [Commented] (KAFKA-5144) MinTimestampTracker uses confusing variable names

2017-05-03 Thread Eno Thereska (JIRA) 

[ 
https://issues.apache.org/jira/browse/KAFKA-5144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15995746#comment-15995746
 ] 

Eno Thereska commented on KAFKA-5144:
-

[~mihbor] thanks. I have a PR that cleans up the code further, would love your 
comments: https://github.com/apache/kafka/pull/2728

> MinTimestampTracker uses confusing variable names
> -
>
> Key: KAFKA-5144
> URL: https://issues.apache.org/jira/browse/KAFKA-5144
> Project: Kafka
>  Issue Type: Bug
>  Components: streams
>Affects Versions: 0.10.2.1
>Reporter: Michal Borowiecki
>Assignee: Michal Borowiecki
>Priority: Trivial
> Fix For: 0.11.0.0
>
>
> --When adding elements MinTimestampTracker removes all existing elements 
> greater than the added element.--
> --Perhaps I've missed something and this is intended behaviour but I can't 
> find any evidence for that in comments or tests.--
> {{MinTimestampTracker}} maintains a list of elements ascending by timestamp, 
> but calls the list var {{descendingSubsequence}} -- it also get the largest 
> element at the end and stores it in a var called {{minElem}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (KAFKA-5144) MinTimestampTracker uses confusing variable names

2017-05-03 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/KAFKA-5144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15995635#comment-15995635
 ] 

ASF GitHub Bot commented on KAFKA-5144:
---

Github user asfgit closed the pull request at:

https://github.com/apache/kafka/pull/2948


> MinTimestampTracker uses confusing variable names
> -
>
> Key: KAFKA-5144
> URL: https://issues.apache.org/jira/browse/KAFKA-5144
> Project: Kafka
>  Issue Type: Bug
>  Components: streams
>Affects Versions: 0.10.2.1
>Reporter: Michal Borowiecki
>Assignee: Michal Borowiecki
>Priority: Trivial
> Fix For: 0.11.0.0
>
>
> --When adding elements MinTimestampTracker removes all existing elements 
> greater than the added element.--
> --Perhaps I've missed something and this is intended behaviour but I can't 
> find any evidence for that in comments or tests.--
> {{MinTimestampTracker}} maintains a list of elements ascending by timestamp, 
> but calls the list var {{descendingSubsequence}} -- it also get the largest 
> element at the end and stores it in a var called {{minElem}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (KAFKA-5144) MinTimestampTracker uses confusing variable names

2017-05-01 Thread Matthias J. Sax (JIRA) 

[ 
https://issues.apache.org/jira/browse/KAFKA-5144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15990952#comment-15990952
 ] 

Matthias J. Sax commented on KAFKA-5144:


Makes sense. Thanks for your contribution!

> MinTimestampTracker uses confusing variable names
> -
>
> Key: KAFKA-5144
> URL: https://issues.apache.org/jira/browse/KAFKA-5144
> Project: Kafka
>  Issue Type: Bug
>  Components: streams
>Affects Versions: 0.10.2.1
>Reporter: Michal Borowiecki
>Assignee: Michal Borowiecki
>Priority: Trivial
> Fix For: 0.11.0.0
>
>
> --When adding elements MinTimestampTracker removes all existing elements 
> greater than the added element.--
> --Perhaps I've missed something and this is intended behaviour but I can't 
> find any evidence for that in comments or tests.--
> {{MinTimestampTracker}} maintains a list of elements ascending by timestamp, 
> but calls the list var {{descendingSubsequence}} -- it also get the largest 
> element at the end and stores it in a var called {{minElem}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)