[jira] [Commented] (KAFKA-5171) TC should not accept empty string transactional id
[ https://issues.apache.org/jira/browse/KAFKA-5171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16027185#comment-16027185 ] ASF GitHub Bot commented on KAFKA-5171: --- Github user umesh9794 closed the pull request at: https://github.com/apache/kafka/pull/2973 > TC should not accept empty string transactional id > -- > > Key: KAFKA-5171 > URL: https://issues.apache.org/jira/browse/KAFKA-5171 > Project: Kafka > Issue Type: Sub-task > Components: core >Reporter: Guozhang Wang > Fix For: 0.11.0.0 > > > Currently on TC, both `null` and `empty string` will be accepted and a new > pid will be returned. However, on the producer client end empty string > transactional id is not allowed, and if user specifically set it with empty > string RTE will be thrown. > We can make TC's behavior consistent with client to also reject empty string > transactional id. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (KAFKA-5171) TC should not accept empty string transactional id
[ https://issues.apache.org/jira/browse/KAFKA-5171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16016232#comment-16016232 ] ASF GitHub Bot commented on KAFKA-5171: --- Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/3086 > TC should not accept empty string transactional id > -- > > Key: KAFKA-5171 > URL: https://issues.apache.org/jira/browse/KAFKA-5171 > Project: Kafka > Issue Type: Sub-task > Components: core >Reporter: Guozhang Wang > Fix For: 0.11.0.0 > > > Currently on TC, both `null` and `empty string` will be accepted and a new > pid will be returned. However, on the producer client end empty string > transactional id is not allowed, and if user specifically set it with empty > string RTE will be thrown. > We can make TC's behavior consistent with client to also reject empty string > transactional id. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (KAFKA-5171) TC should not accept empty string transactional id
[ https://issues.apache.org/jira/browse/KAFKA-5171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015674#comment-16015674 ] ASF GitHub Bot commented on KAFKA-5171: --- GitHub user umesh9794 opened a pull request: https://github.com/apache/kafka/pull/3086 KAFKA-5171 : TC should not accept empty string transactional id This a rebase version of [PR#2973](https://github.com/apache/kafka/pull/2973). @guozhangwang , please review this updated PR. You can merge this pull request into a Git repository by running: $ git pull https://github.com/umesh9794/kafka mylocal Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3086.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3086 commit ed31c1c2f7f8d9b1ef675d80433154025fd2a639 Author: umesh chaudhary Date: 2017-05-18T12:18:02Z Rebase: KAFKA-5171 : TC should not accept empty string transactional id > TC should not accept empty string transactional id > -- > > Key: KAFKA-5171 > URL: https://issues.apache.org/jira/browse/KAFKA-5171 > Project: Kafka > Issue Type: Sub-task > Components: core >Reporter: Guozhang Wang > Fix For: 0.11.0.0 > > > Currently on TC, both `null` and `empty string` will be accepted and a new > pid will be returned. However, on the producer client end empty string > transactional id is not allowed, and if user specifically set it with empty > string RTE will be thrown. > We can make TC's behavior consistent with client to also reject empty string > transactional id. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (KAFKA-5171) TC should not accept empty string transactional id
[ https://issues.apache.org/jira/browse/KAFKA-5171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15996180#comment-15996180 ] Umesh Chaudhary commented on KAFKA-5171: [~guozhang] , Please review the PR. > TC should not accept empty string transactional id > -- > > Key: KAFKA-5171 > URL: https://issues.apache.org/jira/browse/KAFKA-5171 > Project: Kafka > Issue Type: Sub-task > Components: core >Reporter: Guozhang Wang > Fix For: 0.11.0.0 > > > Currently on TC, both `null` and `empty string` will be accepted and a new > pid will be returned. However, on the producer client end empty string > transactional id is not allowed, and if user specifically set it with empty > string RTE will be thrown. > We can make TC's behavior consistent with client to also reject empty string > transactional id. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
