[jira] [Commented] (KAFKA-5231) TransactinoCoordinator does not bump epoch when aborting open transactions

2017-05-17 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-5231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015019#comment-16015019
 ] 

ASF GitHub Bot commented on KAFKA-5231:
---

GitHub user guozhangwang opened a pull request:

https://github.com/apache/kafka/pull/3082

KAFKA-5231: Protect txn metadata map with read-write lock



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/guozhangwang/kafka K5231-read-write-lock

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3082.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3082


commit 6b5c6cf6042c61e785e9f005ea0b85ff8e5246c1
Author: Guozhang Wang 
Date:   2017-05-16T06:12:12Z

bump up producer epoch

commit b7884d106b8b8c10187b8748f5120728464acfc9
Author: Guozhang Wang 
Date:   2017-05-17T00:07:11Z

Jason's comments

commit 8f78d601beb52c90507c1307a5073e8100e98631
Author: Guozhang Wang 
Date:   2017-05-17T19:31:07Z

Jun's comments

commit 7c7f4da31191fce9935eecc65b6e3273bae520d1
Author: Guozhang Wang 
Date:   2017-05-17T19:52:50Z

bump up limit for class fanout to 40 for Sender class

commit c3aef033207f5f7da5ccc84c5dd6f71165d94f62
Author: Guozhang Wang 
Date:   2017-05-17T20:36:05Z

Jun's comments round two

commit ccf8fdc51c7aa066bf2f8098f0906ebf9f937a2d
Author: Guozhang Wang 
Date:   2017-05-17T23:44:48Z

rebased from trunk

commit 52ef07b060f59f7e0fe342faa5c040448ed1b2be
Author: Guozhang Wang 
Date:   2017-05-17T20:19:20Z

change the state lock to read-write lock

commit dd11d5d457ba09ed5a2a1a0d2d35712a0420b722
Author: Guozhang Wang 
Date:   2017-05-17T23:29:22Z

grab the read lock until append to local is done

commit 16c1791236d8bcf851fad93ef1b7a61170f62aa5
Author: Guozhang Wang 
Date:   2017-05-18T01:04:18Z

put the validation and return of metadata under the same lock




> TransactinoCoordinator does not bump epoch when aborting open transactions
> --
>
> Key: KAFKA-5231
> URL: https://issues.apache.org/jira/browse/KAFKA-5231
> Project: Kafka
>  Issue Type: Sub-task
>Reporter: Apurva Mehta
>Assignee: Guozhang Wang
>Priority: Blocker
>  Labels: exactly-once
> Fix For: 0.11.0.0
>
>
> When the TransactionCoordinator receives an InitPidRequest when there is an 
> open transaction for a transactional id, it should first bump the epoch and 
> then abort the open transaction.
> Currently, it aborts the open transaction with the existing epoch, hence the 
> old producer is never fenced.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (KAFKA-5231) TransactinoCoordinator does not bump epoch when aborting open transactions

2017-05-17 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-5231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015016#comment-16015016
 ] 

ASF GitHub Bot commented on KAFKA-5231:
---

Github user asfgit closed the pull request at:

https://github.com/apache/kafka/pull/3066


> TransactinoCoordinator does not bump epoch when aborting open transactions
> --
>
> Key: KAFKA-5231
> URL: https://issues.apache.org/jira/browse/KAFKA-5231
> Project: Kafka
>  Issue Type: Sub-task
>Reporter: Apurva Mehta
>Assignee: Guozhang Wang
>Priority: Blocker
>  Labels: exactly-once
> Fix For: 0.11.0.0
>
>
> When the TransactionCoordinator receives an InitPidRequest when there is an 
> open transaction for a transactional id, it should first bump the epoch and 
> then abort the open transaction.
> Currently, it aborts the open transaction with the existing epoch, hence the 
> old producer is never fenced.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (KAFKA-5231) TransactinoCoordinator does not bump epoch when aborting open transactions

2017-05-15 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-5231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16011817#comment-16011817
 ] 

ASF GitHub Bot commented on KAFKA-5231:
---

GitHub user guozhangwang opened a pull request:

https://github.com/apache/kafka/pull/3066

KAFKA-5231: Bump up producer epoch when sending abort txn markers on InitPid



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/guozhangwang/kafka 
K5231-bump-up-epoch-when-abort-txn

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3066.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3066


commit 6b5c6cf6042c61e785e9f005ea0b85ff8e5246c1
Author: Guozhang Wang 
Date:   2017-05-16T06:12:12Z

bump up producer epoch




> TransactinoCoordinator does not bump epoch when aborting open transactions
> --
>
> Key: KAFKA-5231
> URL: https://issues.apache.org/jira/browse/KAFKA-5231
> Project: Kafka
>  Issue Type: Sub-task
>Reporter: Apurva Mehta
>Assignee: Guozhang Wang
>Priority: Blocker
>  Labels: exactly-once
> Fix For: 0.11.0.0
>
>
> When the TransactionCoordinator receives an InitPidRequest when there is an 
> open transaction for a transactional id, it should first bump the epoch and 
> then abort the open transaction.
> Currently, it aborts the open transaction with the existing epoch, hence the 
> old producer is never fenced.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)