[jira] [Commented] (KAFKA-854) Upgrade dependencies for 0.8
[ https://issues.apache.org/jira/browse/KAFKA-854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13941580#comment-13941580 ] Michael Noll commented on KAFKA-854: Now that one year has passed since the last update to this ticket in 04/2013, what's the status/plan to upgrade Kafka's dependencies, notably on the ZooKeeper front? Anyone knows? Upgrade dependencies for 0.8 Key: KAFKA-854 URL: https://issues.apache.org/jira/browse/KAFKA-854 Project: Kafka Issue Type: Improvement Affects Versions: 0.8.0 Reporter: Scott Carey Attachments: 0001-KAFKA-854-Upgrade-Deps-to-latest.patch, KAFKA-854.patch, KAFKA-854.patch, KAFKA-854.patch Many of the dependencies that Kafka 0.8 uses are old. It would be a good idea to upgrade all of these where possible. log4j is set to 1.2.15, but the latest is 1.2.17 zookeeper is at 3.3.4, , there is 3.3.6 (August 2012), and 3.4.5 (Nov 2012. 3.4.x includes several major enhancements and fixes over the 3.3.x line. org.slf4j is at 1.6.4, there is 1.6.6 (June 2012) and 1.7.5 (March 2013) net.sf.jopt-simple is at 3.2, there is 3.3 (May 2011) and 4.4 (Jan 2013) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-854) Upgrade dependencies for 0.8
[ https://issues.apache.org/jira/browse/KAFKA-854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13630225#comment-13630225 ] Neha Narkhede commented on KAFKA-854: - Thanks for the rebased patch! 1. Can you describe the motivation and purpose of each of your changes ? it will make it easier to review. 2. What is the purpose of removing the core dependencies from core/build.sbt and putting them back into the main Build.sbt ? Upgrade dependencies for 0.8 Key: KAFKA-854 URL: https://issues.apache.org/jira/browse/KAFKA-854 Project: Kafka Issue Type: Improvement Affects Versions: 0.8 Reporter: Scott Carey Attachments: 0001-KAFKA-854-Upgrade-Deps-to-latest.patch, KAFKA-854.patch, KAFKA-854.patch, KAFKA-854.patch Many of the dependencies that Kafka 0.8 uses are old. It would be a good idea to upgrade all of these where possible. log4j is set to 1.2.15, but the latest is 1.2.17 zookeeper is at 3.3.4, , there is 3.3.6 (August 2012), and 3.4.5 (Nov 2012. 3.4.x includes several major enhancements and fixes over the 3.3.x line. org.slf4j is at 1.6.4, there is 1.6.6 (June 2012) and 1.7.5 (March 2013) net.sf.jopt-simple is at 3.2, there is 3.3 (May 2011) and 4.4 (Jan 2013) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-854) Upgrade dependencies for 0.8
[ https://issues.apache.org/jira/browse/KAFKA-854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13630579#comment-13630579 ] Scott Carey commented on KAFKA-854: --- 1. It is probably easier to review by looking at the final result than the diffs. The purpose was to simplify the build, following DRY principles and what appears to be the style that the latest sbt encourages: * using sbt files for settings and .scala files for build definitions and cross-module dependencies. Every sample / tutorial I found seemed to indicate that this was standard convention (none were passing settings in when defining the Project). 2. All version declarations in one file, centrally, with the DRY principle. I could not find a way to do this in the base .sbt file since you can only set configuration keys there, not define variables. If you want to see or change a dependency version, there is only one place to go. Unlike Maven, SBT does not provide a standard place to configure your dependency versions to promote sharing across multiple projects. Upgrade dependencies for 0.8 Key: KAFKA-854 URL: https://issues.apache.org/jira/browse/KAFKA-854 Project: Kafka Issue Type: Improvement Affects Versions: 0.8 Reporter: Scott Carey Attachments: 0001-KAFKA-854-Upgrade-Deps-to-latest.patch, KAFKA-854.patch, KAFKA-854.patch, KAFKA-854.patch Many of the dependencies that Kafka 0.8 uses are old. It would be a good idea to upgrade all of these where possible. log4j is set to 1.2.15, but the latest is 1.2.17 zookeeper is at 3.3.4, , there is 3.3.6 (August 2012), and 3.4.5 (Nov 2012. 3.4.x includes several major enhancements and fixes over the 3.3.x line. org.slf4j is at 1.6.4, there is 1.6.6 (June 2012) and 1.7.5 (March 2013) net.sf.jopt-simple is at 3.2, there is 3.3 (May 2011) and 4.4 (Jan 2013) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-854) Upgrade dependencies for 0.8
[ https://issues.apache.org/jira/browse/KAFKA-854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13630781#comment-13630781 ] Matt Christiansen commented on KAFKA-854: - I tested out this patch in my local kafka build (im trying to piecemeal together a 0.8 for some POC work at my company) and it looks great to me. Much cleaner and the resulting release jars are smaller as they now only have the dependencies they need (no more hadoop-core in kafka core). To nit pick it seems like the metrics-annotation dependency isn't needed in any code and from what I can tell; it also isn't a runtime dependency for metrics-core. Also its funny you bring up Maven Scott, I wonder why in most cases Maven isn't used for scala project like this. It would have a wider audience of people to maintain it, is more widely known and (to me) makes more sense to how functions and how projects are laid out in it. Upgrade dependencies for 0.8 Key: KAFKA-854 URL: https://issues.apache.org/jira/browse/KAFKA-854 Project: Kafka Issue Type: Improvement Affects Versions: 0.8 Reporter: Scott Carey Attachments: 0001-KAFKA-854-Upgrade-Deps-to-latest.patch, KAFKA-854.patch, KAFKA-854.patch, KAFKA-854.patch Many of the dependencies that Kafka 0.8 uses are old. It would be a good idea to upgrade all of these where possible. log4j is set to 1.2.15, but the latest is 1.2.17 zookeeper is at 3.3.4, , there is 3.3.6 (August 2012), and 3.4.5 (Nov 2012. 3.4.x includes several major enhancements and fixes over the 3.3.x line. org.slf4j is at 1.6.4, there is 1.6.6 (June 2012) and 1.7.5 (March 2013) net.sf.jopt-simple is at 3.2, there is 3.3 (May 2011) and 4.4 (Jan 2013) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-854) Upgrade dependencies for 0.8
[ https://issues.apache.org/jira/browse/KAFKA-854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13627242#comment-13627242 ] Neha Narkhede commented on KAFKA-854: - Scott, Please can you rebase the patch ? After checking in KAFKA-826, this patch no longer applies. Upgrade dependencies for 0.8 Key: KAFKA-854 URL: https://issues.apache.org/jira/browse/KAFKA-854 Project: Kafka Issue Type: Improvement Affects Versions: 0.8 Reporter: Scott Carey Attachments: 0001-KAFKA-854-Upgrade-Deps-to-latest.patch, KAFKA-854.patch Many of the dependencies that Kafka 0.8 uses are old. It would be a good idea to upgrade all of these where possible. log4j is set to 1.2.15, but the latest is 1.2.17 zookeeper is at 3.3.4, , there is 3.3.6 (August 2012), and 3.4.5 (Nov 2012. 3.4.x includes several major enhancements and fixes over the 3.3.x line. org.slf4j is at 1.6.4, there is 1.6.6 (June 2012) and 1.7.5 (March 2013) net.sf.jopt-simple is at 3.2, there is 3.3 (May 2011) and 4.4 (Jan 2013) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-854) Upgrade dependencies for 0.8
[ https://issues.apache.org/jira/browse/KAFKA-854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13625520#comment-13625520 ] Neha Narkhede commented on KAFKA-854: - Scott, I think that is a remainder that we forgot to delete when we upgraded to latest sbt version. We want to keep only the dependencies mentioned in project/Build.scala and the individual project build files . For example, core/build.sbt. Feel free to upload a patch to clean up the dependencies, it will be great help to us while releasing 0.8 Upgrade dependencies for 0.8 Key: KAFKA-854 URL: https://issues.apache.org/jira/browse/KAFKA-854 Project: Kafka Issue Type: Improvement Affects Versions: 0.8 Reporter: Scott Carey Attachments: 0001-KAFKA-854-Upgrade-Deps-to-latest.patch Many of the dependencies that Kafka 0.8 uses are old. It would be a good idea to upgrade all of these where possible. log4j is set to 1.2.15, but the latest is 1.2.17 zookeeper is at 3.3.4, , there is 3.3.6 (August 2012), and 3.4.5 (Nov 2012. 3.4.x includes several major enhancements and fixes over the 3.3.x line. org.slf4j is at 1.6.4, there is 1.6.6 (June 2012) and 1.7.5 (March 2013) net.sf.jopt-simple is at 3.2, there is 3.3 (May 2011) and 4.4 (Jan 2013) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-854) Upgrade dependencies for 0.8
[
https://issues.apache.org/jira/browse/KAFKA-854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13625652#comment-13625652
]
Scott Carey commented on KAFKA-854:
---
{quote}
While you're at it you could also upgrade Jackson. Currently the build file
references org.codehaus.jackson which is old. The upgrade may require some code
changes (the API differs in a few places), all trivial through.
{quote}
Where is the Jackson dependency specified?
find . -name *.sbt | xargs grep jackson
returns nothing, and in project/Build.scala it is only used in relation to the
hadoop settings. We could upgrade to the latest 1.x but not 2.x, because other
hadoop dependencies use it (like the also ancient avro 1.4).
What is the status of the contrib hadoop stuff?
Matt's patch already upgrades everything, if we want to upgrade only the core
Kafka dependencies, we can trim it down to those simpler, safer updates.
(As an SBT newbie) --
It appears that project/Build.scala is completely unnecessary, and could be
significantly simplified if moved to core/build.sbt. Most of the content of
Build.scala seems to be cruft or have simpler features available to do the same
thing.
Upgrade dependencies for 0.8
Key: KAFKA-854
URL: https://issues.apache.org/jira/browse/KAFKA-854
Project: Kafka
Issue Type: Improvement
Affects Versions: 0.8
Reporter: Scott Carey
Attachments: 0001-KAFKA-854-Upgrade-Deps-to-latest.patch
Many of the dependencies that Kafka 0.8 uses are old. It would be a good
idea to upgrade all of these where possible.
log4j is set to 1.2.15, but the latest is 1.2.17
zookeeper is at 3.3.4, , there is 3.3.6 (August 2012), and 3.4.5 (Nov 2012.
3.4.x includes several major enhancements and fixes over the 3.3.x line.
org.slf4j is at 1.6.4, there is 1.6.6 (June 2012) and 1.7.5 (March 2013)
net.sf.jopt-simple is at 3.2, there is 3.3 (May 2011) and 4.4 (Jan 2013)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-854) Upgrade dependencies for 0.8
[
https://issues.apache.org/jira/browse/KAFKA-854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13624250#comment-13624250
]
Scott Carey commented on KAFKA-854:
---
Also, upgrading log4j means that all of the ugly bits with:
{code}
//The issue is going from log4j 1.2.14 to 1.2.15, the developers added some
features which required
// some dependencies on various sun and javax packages.
override def ivyXML =
dependencies
exclude module=javax/
exclude module=jmxri/
exclude module=jmxtools/
exclude module=mail/
exclude module=jms/
/dependencies
{ocde}
can go away, they made all of the funky dependencies system provided, or
optional so they are not transitively pulled in (as they should have been to
begin with).
Upgrade dependencies for 0.8
Key: KAFKA-854
URL: https://issues.apache.org/jira/browse/KAFKA-854
Project: Kafka
Issue Type: Improvement
Affects Versions: 0.8
Reporter: Scott Carey
Attachments: 0001-KAFKA-854-Upgrade-Deps-to-latest.patch
Many of the dependencies that Kafka 0.8 uses are old. It would be a good
idea to upgrade all of these where possible.
log4j is set to 1.2.15, but the latest is 1.2.17
zookeeper is at 3.3.4, , there is 3.3.6 (August 2012), and 3.4.5 (Nov 2012.
3.4.x includes several major enhancements and fixes over the 3.3.x line.
org.slf4j is at 1.6.4, there is 1.6.6 (June 2012) and 1.7.5 (March 2013)
net.sf.jopt-simple is at 3.2, there is 3.3 (May 2011) and 4.4 (Jan 2013)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-854) Upgrade dependencies for 0.8
[
https://issues.apache.org/jira/browse/KAFKA-854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13624255#comment-13624255
]
Scott Carey commented on KAFKA-854:
---
Why are dependencies repeated?
project/build/KafkaProject.scala defines:
{code}
trait CoreDependencies {
val log4j = log4j % log4j % 1.2.15
val jopt = net.sf.jopt-simple % jopt-simple % 3.2
val slf4jSimple = org.slf4j % slf4j-simple % 1.6.4
}
{code}
and
project/Build.scala defines
{code}
libraryDependencies ++= Seq(
log4j % log4j% 1.2.15,
net.sf.jopt-simple% jopt-simple % 3.2,
org.slf4j % slf4j-simple % 1.6.4
),
{code}
Likewise the hadoop settings are repeated.
Upgrade dependencies for 0.8
Key: KAFKA-854
URL: https://issues.apache.org/jira/browse/KAFKA-854
Project: Kafka
Issue Type: Improvement
Affects Versions: 0.8
Reporter: Scott Carey
Attachments: 0001-KAFKA-854-Upgrade-Deps-to-latest.patch
Many of the dependencies that Kafka 0.8 uses are old. It would be a good
idea to upgrade all of these where possible.
log4j is set to 1.2.15, but the latest is 1.2.17
zookeeper is at 3.3.4, , there is 3.3.6 (August 2012), and 3.4.5 (Nov 2012.
3.4.x includes several major enhancements and fixes over the 3.3.x line.
org.slf4j is at 1.6.4, there is 1.6.6 (June 2012) and 1.7.5 (March 2013)
net.sf.jopt-simple is at 3.2, there is 3.3 (May 2011) and 4.4 (Jan 2013)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-854) Upgrade dependencies for 0.8
[ https://issues.apache.org/jira/browse/KAFKA-854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13624264#comment-13624264 ] Scott Carey commented on KAFKA-854: --- Ick, worse, some dependencies are listed three times -- once in SBT format, once in Maven XML format (bulky) and again Ivy xml fomat (yuck). The DRY principle gods are angry and are having their vengeance on any who wish to maintain this. Upgrade dependencies for 0.8 Key: KAFKA-854 URL: https://issues.apache.org/jira/browse/KAFKA-854 Project: Kafka Issue Type: Improvement Affects Versions: 0.8 Reporter: Scott Carey Attachments: 0001-KAFKA-854-Upgrade-Deps-to-latest.patch Many of the dependencies that Kafka 0.8 uses are old. It would be a good idea to upgrade all of these where possible. log4j is set to 1.2.15, but the latest is 1.2.17 zookeeper is at 3.3.4, , there is 3.3.6 (August 2012), and 3.4.5 (Nov 2012. 3.4.x includes several major enhancements and fixes over the 3.3.x line. org.slf4j is at 1.6.4, there is 1.6.6 (June 2012) and 1.7.5 (March 2013) net.sf.jopt-simple is at 3.2, there is 3.3 (May 2011) and 4.4 (Jan 2013) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
