Dong Lin created KAFKA-1550: ------------------------------- Summary: Patch review tool should use git format-patch to generate patch Key: KAFKA-1550 URL: https://issues.apache.org/jira/browse/KAFKA-1550 Project: Kafka Issue Type: Bug Reporter: Dong Lin Assignee: Dong Lin Priority: Minor
kafka-patch-review.py uses git-diff to generate patch for jira ticket. The resulting patch includes local uncommitted changes and is therefore different from the patch published to reviewboard. kafka-patch-review.py updates the jira ticket with attaching patch even if the reviewboard specified in --rb option is not found. -- This message was sent by Atlassian JIRA (v6.2#6252)