Bo Wang created KAFKA-2254:
------------------------------

             Summary: The shell script should be optimized , even 
kafka-run-class.sh has a syntax error.
                 Key: KAFKA-2254
                 URL: https://issues.apache.org/jira/browse/KAFKA-2254
             Project: Kafka
          Issue Type: Bug
          Components: build
    Affects Versions: 0.8.2.1
         Environment: linux
            Reporter: Bo Wang
            Priority: Critical
             Fix For: 0.8.2.1


 kafka-run-class.sh 128 line has a syntax error(missing a space):
127    -loggc)
128     if [ -z "$KAFKA_GC_LOG_OPTS"] ; then
129        GC_LOG_ENABLED="true"
130     fi


And use the ShellCheck to check the shell scripts, the results shows some 
errors and warnings and notes:
https://github.com/koalaman/shellcheck/wiki/SC2068
https://github.com/koalaman/shellcheck/wiki/Sc2046
https://github.com/koalaman/shellcheck/wiki/Sc2086




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to