[jira] [Updated] (KAFKA-1801) Remove non-functional variable definition in log4j.properties
[ https://issues.apache.org/jira/browse/KAFKA-1801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1801: --- Resolution: Fixed Fix Version/s: (was: 0.8.2) 0.8.3 Assignee: Raman Gupta (was: Jay Kreps) Status: Resolved (was: Patch Available) Thanks for the patch. +1 and committed to trunk. > Remove non-functional variable definition in log4j.properties > - > > Key: KAFKA-1801 > URL: https://issues.apache.org/jira/browse/KAFKA-1801 > Project: Kafka > Issue Type: Improvement > Components: log >Affects Versions: 0.8.2 >Reporter: Raman Gupta >Assignee: Raman Gupta >Priority: Trivial > Labels: easyfix, patch > Fix For: 0.8.3 > > Original Estimate: 5m > Remaining Estimate: 5m > > In log4j.properties, a property kafka.logs.dir is defined. However, modifying > this property has no effect because log4j will always use the system property > defined in kafka-run-class.sh before using the locally defined property in > log4j.properties. Therefore, its probably less confusing to simply remove > this property from here. > See > http://logging.apache.org/log4j/1.2/apidocs/org/apache/log4j/PropertyConfigurator.html > for the property search order (system property first, locally defined > property second). > An alternative solution: remove the system property from kafka-run-class.sh > and keep the one here. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (KAFKA-1801) Remove non-functional variable definition in log4j.properties
[ https://issues.apache.org/jira/browse/KAFKA-1801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raman Gupta updated KAFKA-1801: --- Status: Open (was: Patch Available) > Remove non-functional variable definition in log4j.properties > - > > Key: KAFKA-1801 > URL: https://issues.apache.org/jira/browse/KAFKA-1801 > Project: Kafka > Issue Type: Improvement > Components: log >Affects Versions: 0.8.2 >Reporter: Raman Gupta >Assignee: Jay Kreps >Priority: Trivial > Labels: easyfix, patch > Fix For: 0.8.1 > > Original Estimate: 5m > Remaining Estimate: 5m > > In log4j.properties, a property kafka.logs.dir is defined. However, modifying > this property has no effect because log4j will always use the system property > defined in kafka-run-class.sh before using the locally defined property in > log4j.properties. Therefore, its probably less confusing to simply remove > this property from here. > See > http://logging.apache.org/log4j/1.2/apidocs/org/apache/log4j/PropertyConfigurator.html > for the property search order (system property first, locally defined > property second). > An alternative solution: remove the system property from kafka-run-class.sh > and keep the one here. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (KAFKA-1801) Remove non-functional variable definition in log4j.properties
[ https://issues.apache.org/jira/browse/KAFKA-1801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raman Gupta updated KAFKA-1801: --- Fix Version/s: (was: 0.8.1) 0.8.2 Status: Patch Available (was: Open) In log4j.properties, a property kafka.logs.dir was defined. However, modifying this property has no effect because log4j.properties always uses the System property set in bin/kafka-run-class.sh before the locally set one. > Remove non-functional variable definition in log4j.properties > - > > Key: KAFKA-1801 > URL: https://issues.apache.org/jira/browse/KAFKA-1801 > Project: Kafka > Issue Type: Improvement > Components: log >Affects Versions: 0.8.2 >Reporter: Raman Gupta >Assignee: Jay Kreps >Priority: Trivial > Labels: easyfix, patch > Fix For: 0.8.2 > > Original Estimate: 5m > Remaining Estimate: 5m > > In log4j.properties, a property kafka.logs.dir is defined. However, modifying > this property has no effect because log4j will always use the system property > defined in kafka-run-class.sh before using the locally defined property in > log4j.properties. Therefore, its probably less confusing to simply remove > this property from here. > See > http://logging.apache.org/log4j/1.2/apidocs/org/apache/log4j/PropertyConfigurator.html > for the property search order (system property first, locally defined > property second). > An alternative solution: remove the system property from kafka-run-class.sh > and keep the one here. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (KAFKA-1801) Remove non-functional variable definition in log4j.properties
[ https://issues.apache.org/jira/browse/KAFKA-1801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raman Gupta updated KAFKA-1801: --- Fix Version/s: 0.8.1 Status: Patch Available (was: Open) In log4j.properties, a property kafka.logs.dir was defined. However, modifying this property has no effect because log4j.properties always uses the System property set in bin/kafka-run-class.sh before the locally set one. > Remove non-functional variable definition in log4j.properties > - > > Key: KAFKA-1801 > URL: https://issues.apache.org/jira/browse/KAFKA-1801 > Project: Kafka > Issue Type: Improvement > Components: log >Affects Versions: 0.8.2 >Reporter: Raman Gupta >Assignee: Jay Kreps >Priority: Trivial > Labels: easyfix, patch > Fix For: 0.8.1 > > Original Estimate: 5m > Remaining Estimate: 5m > > In log4j.properties, a property kafka.logs.dir is defined. However, modifying > this property has no effect because log4j will always use the system property > defined in kafka-run-class.sh before using the locally defined property in > log4j.properties. Therefore, its probably less confusing to simply remove > this property from here. > See > http://logging.apache.org/log4j/1.2/apidocs/org/apache/log4j/PropertyConfigurator.html > for the property search order (system property first, locally defined > property second). > An alternative solution: remove the system property from kafka-run-class.sh > and keep the one here. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
