[jira] [Updated] (KAFKA-1915) Integrate checkstyle for java code
[ https://issues.apache.org/jira/browse/KAFKA-1915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-1915: - Resolution: Fixed Reviewer: Joel Koshy Status: Resolved (was: Patch Available) Committed in 1c6d5bbac67. > Integrate checkstyle for java code > -- > > Key: KAFKA-1915 > URL: https://issues.apache.org/jira/browse/KAFKA-1915 > Project: Kafka > Issue Type: Improvement >Reporter: Jay Kreps >Assignee: Jay Kreps >Priority: Minor > Fix For: 0.8.3 > > Attachments: KAFKA-1915.patch, KAFKA-1915_2015-02-03_09:17:34.patch > > > There are a lot of little style and layering problems that tend to creep into > our code, especially with external patches and lax reviewers. > These are the usual style suspects--capitalization, spacing, bracket > placement, etc. > My personal pet peave is a lack of clear thinking about layers. These > layering problems crept in quite fast, and sad to say a number of them were > accidentally caused by me. This is things like o.a.k.common depending on > o.a.k.clients or the consumer depending on the producer. > I have a patch that integrates checkstyle to catch these issues at build > time, and which corrects the known problems. There are a fair number of very > small changes in this patch, all trivial. > Checkstyle can be slightly annoying, not least of which because it has a > couple minor bugs around anonymous inner class formatting, but I find it is > 98% real style issues so mostly worth it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (KAFKA-1915) Integrate checkstyle for java code
[ https://issues.apache.org/jira/browse/KAFKA-1915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-1915: - Attachment: KAFKA-1915_2015-02-03_09:17:34.patch > Integrate checkstyle for java code > -- > > Key: KAFKA-1915 > URL: https://issues.apache.org/jira/browse/KAFKA-1915 > Project: Kafka > Issue Type: Improvement >Reporter: Jay Kreps >Assignee: Jay Kreps >Priority: Minor > Fix For: 0.8.3 > > Attachments: KAFKA-1915.patch, KAFKA-1915_2015-02-03_09:17:34.patch > > > There are a lot of little style and layering problems that tend to creep into > our code, especially with external patches and lax reviewers. > These are the usual style suspects--capitalization, spacing, bracket > placement, etc. > My personal pet peave is a lack of clear thinking about layers. These > layering problems crept in quite fast, and sad to say a number of them were > accidentally caused by me. This is things like o.a.k.common depending on > o.a.k.clients or the consumer depending on the producer. > I have a patch that integrates checkstyle to catch these issues at build > time, and which corrects the known problems. There are a fair number of very > small changes in this patch, all trivial. > Checkstyle can be slightly annoying, not least of which because it has a > couple minor bugs around anonymous inner class formatting, but I find it is > 98% real style issues so mostly worth it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (KAFKA-1915) Integrate checkstyle for java code
[ https://issues.apache.org/jira/browse/KAFKA-1915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-1915: - Attachment: KAFKA-1915.patch > Integrate checkstyle for java code > -- > > Key: KAFKA-1915 > URL: https://issues.apache.org/jira/browse/KAFKA-1915 > Project: Kafka > Issue Type: Improvement >Reporter: Jay Kreps >Assignee: Jay Kreps >Priority: Minor > Fix For: 0.8.3 > > Attachments: KAFKA-1915.patch > > > There are a lot of little style and layering problems that tend to creep into > our code, especially with external patches and lax reviewers. > These are the usual style suspects--capitalization, spacing, bracket > placement, etc. > My personal pet peave is a lack of clear thinking about layers. These > layering problems crept in quite fast, and sad to say a number of them were > accidentally caused by me. This is things like o.a.k.common depending on > o.a.k.clients or the consumer depending on the producer. > I have a patch that integrates checkstyle to catch these issues at build > time, and which corrects the known problems. There are a fair number of very > small changes in this patch, all trivial. > Checkstyle can be slightly annoying, not least of which because it has a > couple minor bugs around anonymous inner class formatting, but I find it is > 98% real style issues so mostly worth it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (KAFKA-1915) Integrate checkstyle for java code
[ https://issues.apache.org/jira/browse/KAFKA-1915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-1915: - Status: Patch Available (was: Open) > Integrate checkstyle for java code > -- > > Key: KAFKA-1915 > URL: https://issues.apache.org/jira/browse/KAFKA-1915 > Project: Kafka > Issue Type: Improvement >Reporter: Jay Kreps >Assignee: Jay Kreps >Priority: Minor > Fix For: 0.8.3 > > Attachments: KAFKA-1915.patch > > > There are a lot of little style and layering problems that tend to creep into > our code, especially with external patches and lax reviewers. > These are the usual style suspects--capitalization, spacing, bracket > placement, etc. > My personal pet peave is a lack of clear thinking about layers. These > layering problems crept in quite fast, and sad to say a number of them were > accidentally caused by me. This is things like o.a.k.common depending on > o.a.k.clients or the consumer depending on the producer. > I have a patch that integrates checkstyle to catch these issues at build > time, and which corrects the known problems. There are a fair number of very > small changes in this patch, all trivial. > Checkstyle can be slightly annoying, not least of which because it has a > couple minor bugs around anonymous inner class formatting, but I find it is > 98% real style issues so mostly worth it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
