[jira] [Updated] (KAFKA-2461) request logger no longer logs extra information in debug mode
[ https://issues.apache.org/jira/browse/KAFKA-2461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-2461: Fix Version/s: 0.8.3 > request logger no longer logs extra information in debug mode > - > > Key: KAFKA-2461 > URL: https://issues.apache.org/jira/browse/KAFKA-2461 > Project: Kafka > Issue Type: Bug >Reporter: Gwen Shapira >Assignee: Ashish K Singh > Fix For: 0.8.3 > > > Currently request logging calls are identical for trace and debug: > {code} > if(requestLogger.isTraceEnabled) > requestLogger.trace("Completed request:%s from connection > %s;totalTime:%d,requestQueueTime:%d,localTime:%d,remoteTime:%d,responseQueueTime:%d,sendTime:%d" > .format(requestDesc, connectionId, totalTime, > requestQueueTime, apiLocalTime, apiRemoteTime, responseQueueTime, > responseSendTime)) > else if(requestLogger.isDebugEnabled) > requestLogger.debug("Completed request:%s from connection > %s;totalTime:%d,requestQueueTime:%d,localTime:%d,remoteTime:%d,responseQueueTime:%d,sendTime:%d" > .format(requestDesc, connectionId, totalTime, requestQueueTime, > apiLocalTime, apiRemoteTime, responseQueueTime, responseSendTime)) > {code} > I think in the past (3 refactoring steps ago), we used to print more > information about specific topics and partitions in debug mode. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (KAFKA-2461) request logger no longer logs extra information in debug mode
[ https://issues.apache.org/jira/browse/KAFKA-2461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish K Singh updated KAFKA-2461: -- Status: Patch Available (was: Open) > request logger no longer logs extra information in debug mode > - > > Key: KAFKA-2461 > URL: https://issues.apache.org/jira/browse/KAFKA-2461 > Project: Kafka > Issue Type: Bug >Reporter: Gwen Shapira >Assignee: Ashish K Singh > Fix For: 0.8.3 > > > Currently request logging calls are identical for trace and debug: > {code} > if(requestLogger.isTraceEnabled) > requestLogger.trace("Completed request:%s from connection > %s;totalTime:%d,requestQueueTime:%d,localTime:%d,remoteTime:%d,responseQueueTime:%d,sendTime:%d" > .format(requestDesc, connectionId, totalTime, > requestQueueTime, apiLocalTime, apiRemoteTime, responseQueueTime, > responseSendTime)) > else if(requestLogger.isDebugEnabled) > requestLogger.debug("Completed request:%s from connection > %s;totalTime:%d,requestQueueTime:%d,localTime:%d,remoteTime:%d,responseQueueTime:%d,sendTime:%d" > .format(requestDesc, connectionId, totalTime, requestQueueTime, > apiLocalTime, apiRemoteTime, responseQueueTime, responseSendTime)) > {code} > I think in the past (3 refactoring steps ago), we used to print more > information about specific topics and partitions in debug mode. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (KAFKA-2461) request logger no longer logs extra information in debug mode
[ https://issues.apache.org/jira/browse/KAFKA-2461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2461: --- Priority: Blocker (was: Major) > request logger no longer logs extra information in debug mode > - > > Key: KAFKA-2461 > URL: https://issues.apache.org/jira/browse/KAFKA-2461 > Project: Kafka > Issue Type: Bug >Reporter: Gwen Shapira >Assignee: Ashish K Singh >Priority: Blocker > Fix For: 0.8.3 > > > Currently request logging calls are identical for trace and debug: > {code} > if(requestLogger.isTraceEnabled) > requestLogger.trace("Completed request:%s from connection > %s;totalTime:%d,requestQueueTime:%d,localTime:%d,remoteTime:%d,responseQueueTime:%d,sendTime:%d" > .format(requestDesc, connectionId, totalTime, > requestQueueTime, apiLocalTime, apiRemoteTime, responseQueueTime, > responseSendTime)) > else if(requestLogger.isDebugEnabled) > requestLogger.debug("Completed request:%s from connection > %s;totalTime:%d,requestQueueTime:%d,localTime:%d,remoteTime:%d,responseQueueTime:%d,sendTime:%d" > .format(requestDesc, connectionId, totalTime, requestQueueTime, > apiLocalTime, apiRemoteTime, responseQueueTime, responseSendTime)) > {code} > I think in the past (3 refactoring steps ago), we used to print more > information about specific topics and partitions in debug mode. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (KAFKA-2461) request logger no longer logs extra information in debug mode
[ https://issues.apache.org/jira/browse/KAFKA-2461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-2461: Resolution: Fixed Status: Resolved (was: Patch Available) Issue resolved by pull request 169 [https://github.com/apache/kafka/pull/169] > request logger no longer logs extra information in debug mode > - > > Key: KAFKA-2461 > URL: https://issues.apache.org/jira/browse/KAFKA-2461 > Project: Kafka > Issue Type: Bug >Reporter: Gwen Shapira >Assignee: Ashish K Singh >Priority: Blocker > Fix For: 0.8.3 > > > Currently request logging calls are identical for trace and debug: > {code} > if(requestLogger.isTraceEnabled) > requestLogger.trace("Completed request:%s from connection > %s;totalTime:%d,requestQueueTime:%d,localTime:%d,remoteTime:%d,responseQueueTime:%d,sendTime:%d" > .format(requestDesc, connectionId, totalTime, > requestQueueTime, apiLocalTime, apiRemoteTime, responseQueueTime, > responseSendTime)) > else if(requestLogger.isDebugEnabled) > requestLogger.debug("Completed request:%s from connection > %s;totalTime:%d,requestQueueTime:%d,localTime:%d,remoteTime:%d,responseQueueTime:%d,sendTime:%d" > .format(requestDesc, connectionId, totalTime, requestQueueTime, > apiLocalTime, apiRemoteTime, responseQueueTime, responseSendTime)) > {code} > I think in the past (3 refactoring steps ago), we used to print more > information about specific topics and partitions in debug mode. -- This message was sent by Atlassian JIRA (v6.3.4#6332)