[jira] [Updated] (KAFKA-828) Preferred Replica Election does not delete the admin path on controller failover

2013-03-28 Thread Swapnil Ghike (JIRA)

 [ 
https://issues.apache.org/jira/browse/KAFKA-828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Swapnil Ghike updated KAFKA-828:


Attachment: kafka-828-v4.patch

Agree with all comments, uploading patch v4. 

Defined a new LeaderElectionNotNeededException that is thrown in selectLeader() 
when the current leader is the same as the preferred replica. 
electLeaderForPartition() swallows it.

Thanks for the reviews and sorry, I was quite lousy while including the patch 
for 814.

 Preferred Replica Election does not delete the admin path on controller 
 failover
 

 Key: KAFKA-828
 URL: https://issues.apache.org/jira/browse/KAFKA-828
 Project: Kafka
  Issue Type: Bug
Affects Versions: 0.8
Reporter: Swapnil Ghike
Assignee: Swapnil Ghike
Priority: Blocker
  Labels: bugs, kafka-0.8, p1
 Fix For: 0.8

 Attachments: kafka-828-v1.patch, kafka-828-v2.patch, 
 kafka-828-v3.patch, kafka-828-v4.patch




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (KAFKA-828) Preferred Replica Election does not delete the admin path on controller failover

2013-03-26 Thread Neha Narkhede (JIRA)

 [ 
https://issues.apache.org/jira/browse/KAFKA-828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neha Narkhede updated KAFKA-828:


Labels: bugs kafka-0.8 p1  (was: bugs)

 Preferred Replica Election does not delete the admin path on controller 
 failover
 

 Key: KAFKA-828
 URL: https://issues.apache.org/jira/browse/KAFKA-828
 Project: Kafka
  Issue Type: Bug
Affects Versions: 0.8
Reporter: Swapnil Ghike
Assignee: Swapnil Ghike
Priority: Blocker
  Labels: bugs, kafka-0.8, p1
 Fix For: 0.8




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (KAFKA-828) Preferred Replica Election does not delete the admin path on controller failover

2013-03-26 Thread Swapnil Ghike (JIRA)

 [ 
https://issues.apache.org/jira/browse/KAFKA-828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Swapnil Ghike updated KAFKA-828:


Attachment: kafka-828-v2.patch

Converted KAFKA-814 to subtask of this as Sriram asked to. Added a one line 
change to PreferredReplicaLeaderSelector to log instead of throwing an 
exception if the preferred leader is already the current leader.

 Preferred Replica Election does not delete the admin path on controller 
 failover
 

 Key: KAFKA-828
 URL: https://issues.apache.org/jira/browse/KAFKA-828
 Project: Kafka
  Issue Type: Bug
Affects Versions: 0.8
Reporter: Swapnil Ghike
Assignee: Swapnil Ghike
Priority: Blocker
  Labels: bugs, kafka-0.8, p1
 Fix For: 0.8

 Attachments: kafka-828-v1.patch, kafka-828-v2.patch




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (KAFKA-828) Preferred Replica Election does not delete the admin path on controller failover

2013-03-26 Thread Swapnil Ghike (JIRA)

 [ 
https://issues.apache.org/jira/browse/KAFKA-828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Swapnil Ghike updated KAFKA-828:


Attachment: kafka-828-v3.patch

Actually since preferred replica election is not a heavy weight operation like 
partition reassignment (where we need to wait until the new followers catch up 
etc), we can move reading of the 
controllerContext.partitionsUndergoingPreferredReplicaElection to inside the 
controllerLock. Attached patch v3.

 Preferred Replica Election does not delete the admin path on controller 
 failover
 

 Key: KAFKA-828
 URL: https://issues.apache.org/jira/browse/KAFKA-828
 Project: Kafka
  Issue Type: Bug
Affects Versions: 0.8
Reporter: Swapnil Ghike
Assignee: Swapnil Ghike
Priority: Blocker
  Labels: bugs, kafka-0.8, p1
 Fix For: 0.8

 Attachments: kafka-828-v1.patch, kafka-828-v2.patch, 
 kafka-828-v3.patch




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira