Re: Checking in on 2101, 2102, 2129

2015-06-15 Thread Guozhang Wang
Hi Tim,

Sorry for getting late on 2129, I will review it this week.

Guozhang

On Mon, Jun 15, 2015 at 6:11 PM, Jun Rao j...@confluent.io wrote:

 Hi, Tim,

 2101 looks good and I just committed it. I left a comment on 2102.

 Sorry for the delay.

 Jun

 On Mon, Jun 15, 2015 at 4:27 PM, Tim Brooks tbroo...@gmail.com wrote:

  I wanted to check in on these three tickets I opened in JIRA. I have not
  seen responses to them in a while.
 
 
  2101 and 2129 seem like straightforward issues that need to be resolved
  (2129 - related the consumer not entirely being thread safe; 2101 related
  to a full successful update back off on a metadata refresh even if the
 last
  update failed and slightly misleading metrics).
 
 
  I understand if 2102 has been determined to be unnecessary by the core
  team. But it seems like the other two need resolutions.
 
 
  Is there something I need to change about my patches?
 
 
  Thanks,
  Tim




-- 
-- Guozhang


Re: Checking in on 2101, 2102, 2129

2015-06-15 Thread Jun Rao
Hi, Tim,

2101 looks good and I just committed it. I left a comment on 2102.

Sorry for the delay.

Jun

On Mon, Jun 15, 2015 at 4:27 PM, Tim Brooks tbroo...@gmail.com wrote:

 I wanted to check in on these three tickets I opened in JIRA. I have not
 seen responses to them in a while.


 2101 and 2129 seem like straightforward issues that need to be resolved
 (2129 - related the consumer not entirely being thread safe; 2101 related
 to a full successful update back off on a metadata refresh even if the last
 update failed and slightly misleading metrics).


 I understand if 2102 has been determined to be unnecessary by the core
 team. But it seems like the other two need resolutions.


 Is there something I need to change about my patches?


 Thanks,
 Tim


Checking in on 2101, 2102, 2129

2015-06-15 Thread Tim Brooks
I wanted to check in on these three tickets I opened in JIRA. I have not seen 
responses to them in a while. 


2101 and 2129 seem like straightforward issues that need to be resolved (2129 - 
related the consumer not entirely being thread safe; 2101 related to a full 
successful update back off on a metadata refresh even if the last update failed 
and slightly misleading metrics).


I understand if 2102 has been determined to be unnecessary by the core team. 
But it seems like the other two need resolutions. 


Is there something I need to change about my patches?


Thanks,
Tim