[jira] [Updated] (KAFKA-1692) [Java New Producer] IO Thread Name Must include Client ID
[
https://issues.apache.org/jira/browse/KAFKA-1692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joe Stein updated KAFKA-1692:
-
Fix Version/s: 0.8.2
> [Java New Producer] IO Thread Name Must include Client ID
> ---
>
> Key: KAFKA-1692
> URL: https://issues.apache.org/jira/browse/KAFKA-1692
> Project: Kafka
> Issue Type: Improvement
> Components: producer
>Affects Versions: 0.8.2
>Reporter: Bhavesh Mistry
>Assignee: Ewen Cheslack-Postava
>Priority: Trivial
> Labels: newbie
> Fix For: 0.8.2
>
> Attachments: KAFKA-1692.patch
>
>
> Please add client id so people who are looking at Jconsole or Profile tool
> can see Thread by client id since single JVM can have multiple producer
> instance.
> org.apache.kafka.clients.producer.KafkaProducer
> {code}
> String ioThreadName = "kafka-producer-network-thread";
> if(clientId != null){
> ioThreadName = ioThreadName + " | "+clientId;
> }
> this.ioThread = new KafkaThread(ioThreadName, this.sender, true);
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (KAFKA-1692) [Java New Producer] IO Thread Name Must include Client ID
[
https://issues.apache.org/jira/browse/KAFKA-1692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14168831#comment-14168831
]
Neha Narkhede edited comment on KAFKA-1692 at 10/12/14 11:00 PM:
-
Thanks for the patch. Pushed to trunk and 0.8.2
was (Author: nehanarkhede):
Thanks for the patch. Pushed to trunk
> [Java New Producer] IO Thread Name Must include Client ID
> ---
>
> Key: KAFKA-1692
> URL: https://issues.apache.org/jira/browse/KAFKA-1692
> Project: Kafka
> Issue Type: Improvement
> Components: producer
>Affects Versions: 0.8.2
>Reporter: Bhavesh Mistry
>Assignee: Ewen Cheslack-Postava
>Priority: Trivial
> Labels: newbie
> Attachments: KAFKA-1692.patch
>
>
> Please add client id so people who are looking at Jconsole or Profile tool
> can see Thread by client id since single JVM can have multiple producer
> instance.
> org.apache.kafka.clients.producer.KafkaProducer
> {code}
> String ioThreadName = "kafka-producer-network-thread";
> if(clientId != null){
> ioThreadName = ioThreadName + " | "+clientId;
> }
> this.ioThread = new KafkaThread(ioThreadName, this.sender, true);
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (KAFKA-1692) [Java New Producer] IO Thread Name Must include Client ID
[
https://issues.apache.org/jira/browse/KAFKA-1692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-1692:
-
Resolution: Fixed
Status: Resolved (was: Patch Available)
Thanks for the patch. Pushed to trunk
> [Java New Producer] IO Thread Name Must include Client ID
> ---
>
> Key: KAFKA-1692
> URL: https://issues.apache.org/jira/browse/KAFKA-1692
> Project: Kafka
> Issue Type: Improvement
> Components: producer
>Affects Versions: 0.8.2
>Reporter: Bhavesh Mistry
>Assignee: Ewen Cheslack-Postava
>Priority: Trivial
> Labels: newbie
> Attachments: KAFKA-1692.patch
>
>
> Please add client id so people who are looking at Jconsole or Profile tool
> can see Thread by client id since single JVM can have multiple producer
> instance.
> org.apache.kafka.clients.producer.KafkaProducer
> {code}
> String ioThreadName = "kafka-producer-network-thread";
> if(clientId != null){
> ioThreadName = ioThreadName + " | "+clientId;
> }
> this.ioThread = new KafkaThread(ioThreadName, this.sender, true);
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (KAFKA-1692) [Java New Producer] IO Thread Name Must include Client ID
[
https://issues.apache.org/jira/browse/KAFKA-1692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ewen Cheslack-Postava updated KAFKA-1692:
-
Attachment: KAFKA-1692.patch
> [Java New Producer] IO Thread Name Must include Client ID
> ---
>
> Key: KAFKA-1692
> URL: https://issues.apache.org/jira/browse/KAFKA-1692
> Project: Kafka
> Issue Type: Improvement
> Components: producer
>Affects Versions: 0.8.2
>Reporter: Bhavesh Mistry
>Assignee: Jun Rao
>Priority: Trivial
> Labels: newbie
> Attachments: KAFKA-1692.patch
>
>
> Please add client id so people who are looking at Jconsole or Profile tool
> can see Thread by client id since single JVM can have multiple producer
> instance.
> org.apache.kafka.clients.producer.KafkaProducer
> {code}
> String ioThreadName = "kafka-producer-network-thread";
> if(clientId != null){
> ioThreadName = ioThreadName + " | "+clientId;
> }
> this.ioThread = new KafkaThread(ioThreadName, this.sender, true);
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (KAFKA-1692) [Java New Producer] IO Thread Name Must include Client ID
[
https://issues.apache.org/jira/browse/KAFKA-1692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14167169#comment-14167169
]
Ewen Cheslack-Postava commented on KAFKA-1692:
--
Created reviewboard https://reviews.apache.org/r/26563/diff/
against branch origin/trunk
> [Java New Producer] IO Thread Name Must include Client ID
> ---
>
> Key: KAFKA-1692
> URL: https://issues.apache.org/jira/browse/KAFKA-1692
> Project: Kafka
> Issue Type: Improvement
> Components: producer
>Affects Versions: 0.8.2
>Reporter: Bhavesh Mistry
>Assignee: Jun Rao
>Priority: Trivial
> Labels: newbie
> Attachments: KAFKA-1692.patch
>
>
> Please add client id so people who are looking at Jconsole or Profile tool
> can see Thread by client id since single JVM can have multiple producer
> instance.
> org.apache.kafka.clients.producer.KafkaProducer
> {code}
> String ioThreadName = "kafka-producer-network-thread";
> if(clientId != null){
> ioThreadName = ioThreadName + " | "+clientId;
> }
> this.ioThread = new KafkaThread(ioThreadName, this.sender, true);
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (KAFKA-1692) [Java New Producer] IO Thread Name Must include Client ID
[
https://issues.apache.org/jira/browse/KAFKA-1692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ewen Cheslack-Postava updated KAFKA-1692:
-
Assignee: Ewen Cheslack-Postava (was: Jun Rao)
Status: Patch Available (was: Open)
> [Java New Producer] IO Thread Name Must include Client ID
> ---
>
> Key: KAFKA-1692
> URL: https://issues.apache.org/jira/browse/KAFKA-1692
> Project: Kafka
> Issue Type: Improvement
> Components: producer
>Affects Versions: 0.8.2
>Reporter: Bhavesh Mistry
>Assignee: Ewen Cheslack-Postava
>Priority: Trivial
> Labels: newbie
> Attachments: KAFKA-1692.patch
>
>
> Please add client id so people who are looking at Jconsole or Profile tool
> can see Thread by client id since single JVM can have multiple producer
> instance.
> org.apache.kafka.clients.producer.KafkaProducer
> {code}
> String ioThreadName = "kafka-producer-network-thread";
> if(clientId != null){
> ioThreadName = ioThreadName + " | "+clientId;
> }
> this.ioThread = new KafkaThread(ioThreadName, this.sender, true);
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (KAFKA-1692) [Java New Producer] IO Thread Name Must include Client ID
[
https://issues.apache.org/jira/browse/KAFKA-1692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-1692:
-
Labels: newbie (was: )
> [Java New Producer] IO Thread Name Must include Client ID
> ---
>
> Key: KAFKA-1692
> URL: https://issues.apache.org/jira/browse/KAFKA-1692
> Project: Kafka
> Issue Type: Improvement
> Components: producer
>Affects Versions: 0.8.2
>Reporter: Bhavesh Mistry
>Assignee: Jun Rao
>Priority: Trivial
> Labels: newbie
>
> Please add client id so people who are looking at Jconsole or Profile tool
> can see Thread by client id since single JVM can have multiple producer
> instance.
> org.apache.kafka.clients.producer.KafkaProducer
> {code}
> String ioThreadName = "kafka-producer-network-thread";
> if(clientId != null){
> ioThreadName = ioThreadName + " | "+clientId;
> }
> this.ioThread = new KafkaThread(ioThreadName, this.sender, true);
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Re: Java New Producer IO Thread Name
Hi Jun, There is ticket with suggestion. https://issues.apache.org/jira/browse/KAFKA-1692 Thanks for your support. Thanks, Bhavesh On Tue, Oct 7, 2014 at 3:29 PM, Jun Rao wrote: > That sounds reasonable. Could you file a jira to track this? > > Thanks, > > Jun > > On Tue, Oct 7, 2014 at 7:47 AM, Bhavesh Mistry > > wrote: > > > Hi Kafka Dev Team, > > > > Since we have multiple instance of producers within one JVM, it would be > > good idea to name network IO thread name by associate with client.id > > configuration. > > > > kafka-producer-network-thread + client.tId > > > > Thanks, > > Bhavesh > > >
[jira] [Commented] (KAFKA-1692) [Java New Producer] IO Thread Name Must include Client ID
[
https://issues.apache.org/jira/browse/KAFKA-1692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14164275#comment-14164275
]
Bhavesh Mistry commented on KAFKA-1692:
---
Description is just suggestion. Sorry could not submit path since I have
release next week.
Thanks,
Bhavesh
> [Java New Producer] IO Thread Name Must include Client ID
> ---
>
> Key: KAFKA-1692
> URL: https://issues.apache.org/jira/browse/KAFKA-1692
> Project: Kafka
> Issue Type: Improvement
> Components: producer
>Affects Versions: 0.8.2
>Reporter: Bhavesh Mistry
>Assignee: Jun Rao
>Priority: Trivial
>
> Please add client id so people who are looking at Jconsole or Profile tool
> can see Thread by client id since single JVM can have multiple producer
> instance.
> org.apache.kafka.clients.producer.KafkaProducer
> {code}
> String ioThreadName = "kafka-producer-network-thread";
> if(clientId != null){
> ioThreadName = ioThreadName + " | "+clientId;
> }
> this.ioThread = new KafkaThread(ioThreadName, this.sender, true);
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (KAFKA-1692) [Java New Producer] IO Thread Name Must include Client ID
Bhavesh Mistry created KAFKA-1692:
-
Summary: [Java New Producer] IO Thread Name Must include Client
ID
Key: KAFKA-1692
URL: https://issues.apache.org/jira/browse/KAFKA-1692
Project: Kafka
Issue Type: Improvement
Components: producer
Affects Versions: 0.8.2
Reporter: Bhavesh Mistry
Assignee: Jun Rao
Priority: Trivial
Please add client id so people who are looking at Jconsole or Profile tool can
see Thread by client id since single JVM can have multiple producer instance.
org.apache.kafka.clients.producer.KafkaProducer
{code}
String ioThreadName = "kafka-producer-network-thread";
if(clientId != null){
ioThreadName = ioThreadName + " | "+clientId;
}
this.ioThread = new KafkaThread(ioThreadName, this.sender, true);
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Re: Java New Producer IO Thread Name
That sounds reasonable. Could you file a jira to track this? Thanks, Jun On Tue, Oct 7, 2014 at 7:47 AM, Bhavesh Mistry wrote: > Hi Kafka Dev Team, > > Since we have multiple instance of producers within one JVM, it would be > good idea to name network IO thread name by associate with client.id > configuration. > > kafka-producer-network-thread + client.tId > > Thanks, > Bhavesh >
Java New Producer IO Thread Name
Hi Kafka Dev Team, Since we have multiple instance of producers within one JVM, it would be good idea to name network IO thread name by associate with client.id configuration. kafka-producer-network-thread + client.tId Thanks, Bhavesh
