Re: [DISCUSS] KIP-1060: Expose advertised.listeners for KRaft controllers

2024-06-27 Thread José Armando García Sancio
Thanks.

I also created this Jira so that we document all of the changes and
what is the recommended configuration for new clusters.

https://issues.apache.org/jira/browse/KAFKA-17048

On Thu, Jun 27, 2024 at 11:05 AM Gantigmaa Selenge  wrote:
>
> Thanks José. Glad to see it already being implemented!
>
> I raised a small PR  to make
> users aware that they can configure advertised.listeners for controllers. I
> will also move the KIP to the discarded section.
>
> Regards,
> Gantigmaa Selenge
> On Mon, Jun 24, 2024 at 6:06 PM José Armando García Sancio
>  wrote:
>
> > Hi Gantigmaa,
> >
> > I am implementing this as part of the KIP-853 implementation. I have a
> > PR for this here: https://github.com/apache/kafka/pull/16235
> >
> > Take a look at my KafkaConfig changes and related code.
> >
> > Thanks
> >
> > On Mon, Jun 24, 2024 at 8:04 AM Gantigmaa Selenge 
> > wrote:
> > >
> > > Hello
> > >
> > > I would like to start a discussion for KIP-1060 that suggests allowing
> > > advertised.listeners configuration for KRaft controllers, which is
> > > currently forbidden.
> > >
> > >
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-1060%3A+Expose+advertised.listeners+for+KRaft+controllers
> > >
> > > Thanks,
> > > Tina Selenge
> >
> >
> >
> > --
> > -José
> >
> >



-- 
-José


Re: [DISCUSS] KIP-1060: Expose advertised.listeners for KRaft controllers

2024-06-27 Thread Gantigmaa Selenge
Thanks José. Glad to see it already being implemented!

I raised a small PR  to make
users aware that they can configure advertised.listeners for controllers. I
will also move the KIP to the discarded section.

Regards,
Gantigmaa Selenge
On Mon, Jun 24, 2024 at 6:06 PM José Armando García Sancio
 wrote:

> Hi Gantigmaa,
>
> I am implementing this as part of the KIP-853 implementation. I have a
> PR for this here: https://github.com/apache/kafka/pull/16235
>
> Take a look at my KafkaConfig changes and related code.
>
> Thanks
>
> On Mon, Jun 24, 2024 at 8:04 AM Gantigmaa Selenge 
> wrote:
> >
> > Hello
> >
> > I would like to start a discussion for KIP-1060 that suggests allowing
> > advertised.listeners configuration for KRaft controllers, which is
> > currently forbidden.
> >
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1060%3A+Expose+advertised.listeners+for+KRaft+controllers
> >
> > Thanks,
> > Tina Selenge
>
>
>
> --
> -José
>
>


Re: [DISCUSS] KIP-1060: Expose advertised.listeners for KRaft controllers

2024-06-24 Thread José Armando García Sancio
Hi Gantigmaa,

I am implementing this as part of the KIP-853 implementation. I have a
PR for this here: https://github.com/apache/kafka/pull/16235

Take a look at my KafkaConfig changes and related code.

Thanks

On Mon, Jun 24, 2024 at 8:04 AM Gantigmaa Selenge  wrote:
>
> Hello
>
> I would like to start a discussion for KIP-1060 that suggests allowing
> advertised.listeners configuration for KRaft controllers, which is
> currently forbidden.
>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1060%3A+Expose+advertised.listeners+for+KRaft+controllers
>
> Thanks,
> Tina Selenge



-- 
-José