Re: [PR] MINOR: Sort powered by page output alphabetically [kafka-site]

[via GitHub]

jolshan merged PR #567:
URL: https://github.com/apache/kafka-site/pull/567


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] MINOR: Sort powered by page output alphabetically [kafka-site]

[via GitHub]

dsmmcken commented on PR #567:
URL: https://github.com/apache/kafka-site/pull/567#issuecomment-1906929519

   Thanks! FYI I don't have write access, so please merge if you are able.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] MINOR: Sort powered by page output alphabetically [kafka-site]

[via GitHub]

jolshan commented on code in PR #567:
URL: https://github.com/apache/kafka-site/pull/567#discussion_r1463926267


##
powered-by.html:
##
@@ -808,6 +813,22 @@ Want to appear on this page?
 
 

Re: [PR] MINOR: Sort powered by page output alphabetically [kafka-site]

[via GitHub]

dsmmcken commented on code in PR #567:
URL: https://github.com/apache/kafka-site/pull/567#discussion_r1463920841


##
powered-by.html:
##
@@ -808,6 +813,22 @@ Want to appear on this page?
 
 

Re: [PR] MINOR: Sort powered by page output alphabetically [kafka-site]

[via GitHub]

jolshan commented on code in PR #567:
URL: https://github.com/apache/kafka-site/pull/567#discussion_r1463915381


##
powered-by.html:
##
@@ -808,6 +813,22 @@ Want to appear on this page?
 
 

Re: [PR] MINOR: Sort powered by page output alphabetically [kafka-site]

[via GitHub]

jolshan commented on code in PR #567:
URL: https://github.com/apache/kafka-site/pull/567#discussion_r1463915381


##
powered-by.html:
##
@@ -808,6 +813,22 @@ Want to appear on this page?
 
 

Re: [PR] MINOR: Sort powered by page output alphabetically [kafka-site]

[via GitHub]

dsmmcken commented on PR #567:
URL: https://github.com/apache/kafka-site/pull/567#issuecomment-1906805845

   Yeah, for some reason GitHub shows the sizes relative to the other one. So 
since the original was 7826px (!!), the new one at 320px looks tiny in the PR 
review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] MINOR: Sort powered by page output alphabetically [kafka-site]

[via GitHub]

jolshan commented on PR #567:
URL: https://github.com/apache/kafka-site/pull/567#issuecomment-1906803674

   ![Screen Shot 2024-01-23 at 11 41 51 
AM](https://github.com/apache/kafka-site/assets/25566826/5034a41d-066b-42a8-9261-98ea8c7d884d)
   ![Screen Shot 2024-01-23 at 11 41 40 
AM](https://github.com/apache/kafka-site/assets/25566826/112e52cd-d480-41b0-bd0b-5da1bb087e74)
   
   OK -- seems fine


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] MINOR: Sort powered by page output alphabetically [kafka-site]

[via GitHub]

jolshan commented on PR #567:
URL: https://github.com/apache/kafka-site/pull/567#issuecomment-1906795135

   The Cisco and Allegrograph images seem really tiny, but maybe they look ok 
on the page? Can you share a screenshot of the example? I can also pull this 
and run the pr code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] MINOR: Sort powered by page output alphabetically [kafka-site]

[via GitHub]

dsmmcken commented on PR #567:
URL: https://github.com/apache/kafka-site/pull/567#issuecomment-1906769939

   Anyone available to review this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org