Re: [VOTE] KIP-830: Allow disabling JMX Reporter
Hi, Thanks everybody for the votes and feedback! The vote passes with: - 3 +1 (binding) from Tom, Ismael and Luke - 1 +1 (non-binding) from Federico Mickael On Wed, Jun 8, 2022 at 12:23 PM Luke Chen wrote: > > Hi Mickael, > > Thanks for the KIP. > It's a good improvement. > Although it's a little weird that we introduce a "new deprecated" config, > it seems like this is the best solution we can have now. > > +1 (binding) from me. > > Thank you. > Luke > > On Thu, May 26, 2022 at 12:21 AM Ismael Juma wrote: > > > Thanks, +1 (binding). > > > > Ismael > > > > On Thu, May 19, 2022 at 5:04 AM Mickael Maison > > wrote: > > > > > Hi Ismael, > > > > > > That's a good idea, I've updated the KIP. > > > > > > Thanks, > > > Mickael > > > > > > On Tue, May 17, 2022 at 4:17 PM Federico Valeri > > > wrote: > > > > > > > > +1 (non binding) > > > > > > > > Thanks. > > > > > > > > On Tue, May 17, 2022 at 3:47 PM Mickael Maison < > > mickael.mai...@gmail.com> > > > wrote: > > > > > > > > > > Hi, > > > > > > > > > > I'd like to start a vote on KIP-830 which proposes a method for a > > > > > method for disabling JMXReporter and making JMXReporter behave like > > > > > other reporters in the next major release when it will need to be > > > > > explicitly listed in metric.reporters to be enabled. > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-830%3A+Allow+disabling+JMX+Reporter > > > > > > > > > > Let me know if you have feedback, > > > > > > > > > > Thanks, > > > > > Mickael > > > > >
Re: [VOTE] KIP-830: Allow disabling JMX Reporter
Hi Mickael, Thanks for the KIP. It's a good improvement. Although it's a little weird that we introduce a "new deprecated" config, it seems like this is the best solution we can have now. +1 (binding) from me. Thank you. Luke On Thu, May 26, 2022 at 12:21 AM Ismael Juma wrote: > Thanks, +1 (binding). > > Ismael > > On Thu, May 19, 2022 at 5:04 AM Mickael Maison > wrote: > > > Hi Ismael, > > > > That's a good idea, I've updated the KIP. > > > > Thanks, > > Mickael > > > > On Tue, May 17, 2022 at 4:17 PM Federico Valeri > > wrote: > > > > > > +1 (non binding) > > > > > > Thanks. > > > > > > On Tue, May 17, 2022 at 3:47 PM Mickael Maison < > mickael.mai...@gmail.com> > > wrote: > > > > > > > > Hi, > > > > > > > > I'd like to start a vote on KIP-830 which proposes a method for a > > > > method for disabling JMXReporter and making JMXReporter behave like > > > > other reporters in the next major release when it will need to be > > > > explicitly listed in metric.reporters to be enabled. > > > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-830%3A+Allow+disabling+JMX+Reporter > > > > > > > > Let me know if you have feedback, > > > > > > > > Thanks, > > > > Mickael > > >
Re: [VOTE] KIP-830: Allow disabling JMX Reporter
Thanks, +1 (binding). Ismael On Thu, May 19, 2022 at 5:04 AM Mickael Maison wrote: > Hi Ismael, > > That's a good idea, I've updated the KIP. > > Thanks, > Mickael > > On Tue, May 17, 2022 at 4:17 PM Federico Valeri > wrote: > > > > +1 (non binding) > > > > Thanks. > > > > On Tue, May 17, 2022 at 3:47 PM Mickael Maison > wrote: > > > > > > Hi, > > > > > > I'd like to start a vote on KIP-830 which proposes a method for a > > > method for disabling JMXReporter and making JMXReporter behave like > > > other reporters in the next major release when it will need to be > > > explicitly listed in metric.reporters to be enabled. > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-830%3A+Allow+disabling+JMX+Reporter > > > > > > Let me know if you have feedback, > > > > > > Thanks, > > > Mickael >
Re: [VOTE] KIP-830: Allow disabling JMX Reporter
Hi Mickael, Thanks for the KIP. +1 (binding). Kind regards, Tom On Thu, 19 May 2022 at 13:14, Mickael Maison wrote: > Hi Ismael, > > That's a good idea, I've updated the KIP. > > Thanks, > Mickael > > On Tue, May 17, 2022 at 4:17 PM Federico Valeri > wrote: > > > > +1 (non binding) > > > > Thanks. > > > > On Tue, May 17, 2022 at 3:47 PM Mickael Maison > wrote: > > > > > > Hi, > > > > > > I'd like to start a vote on KIP-830 which proposes a method for a > > > method for disabling JMXReporter and making JMXReporter behave like > > > other reporters in the next major release when it will need to be > > > explicitly listed in metric.reporters to be enabled. > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-830%3A+Allow+disabling+JMX+Reporter > > > > > > Let me know if you have feedback, > > > > > > Thanks, > > > Mickael > >
Re: [VOTE] KIP-830: Allow disabling JMX Reporter
Hi Ismael, That's a good idea, I've updated the KIP. Thanks, Mickael On Tue, May 17, 2022 at 4:17 PM Federico Valeri wrote: > > +1 (non binding) > > Thanks. > > On Tue, May 17, 2022 at 3:47 PM Mickael Maison > wrote: > > > > Hi, > > > > I'd like to start a vote on KIP-830 which proposes a method for a > > method for disabling JMXReporter and making JMXReporter behave like > > other reporters in the next major release when it will need to be > > explicitly listed in metric.reporters to be enabled. > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-830%3A+Allow+disabling+JMX+Reporter > > > > Let me know if you have feedback, > > > > Thanks, > > Mickael
Re: [VOTE] KIP-830: Allow disabling JMX Reporter
+1 (non binding) Thanks. On Tue, May 17, 2022 at 3:47 PM Mickael Maison wrote: > > Hi, > > I'd like to start a vote on KIP-830 which proposes a method for a > method for disabling JMXReporter and making JMXReporter behave like > other reporters in the next major release when it will need to be > explicitly listed in metric.reporters to be enabled. > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-830%3A+Allow+disabling+JMX+Reporter > > Let me know if you have feedback, > > Thanks, > Mickael
Re: [VOTE] KIP-830: Allow disabling JMX Reporter
Thanks Mickael. Quick question: "When set to true, a warning will be printed to indicate this setting is deprecated and recommend using metric.reporters instead." The config defaults to true, so I think we should be a bit clearer when the warning is printed. I was thinking we would print the warning if either: * The config is set to true explicitly (there isn't a reason to do this on its own since it's the default) OR * The config is true due to the default and metrics.reporters is configured without the jmx reporter (this particular scenario would have different behavior in AK 4.0) Does this make sense? Ismael On Tue, May 17, 2022 at 6:47 AM Mickael Maison wrote: > Hi, > > I'd like to start a vote on KIP-830 which proposes a method for a > method for disabling JMXReporter and making JMXReporter behave like > other reporters in the next major release when it will need to be > explicitly listed in metric.reporters to be enabled. > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-830%3A+Allow+disabling+JMX+Reporter > > Let me know if you have feedback, > > Thanks, > Mickael >
