Re: [VOTE] KIP-994: Minor Enhancements to ListTransactions and DescribeTransactions APIs
Hi, Raman, Thanks for the KIP. +1 from me. Jun On Tue, Dec 26, 2023 at 11:32 AM Raman Verma wrote: > I would like to start a Vote on KIP-994 > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-994%3A+Minor+Enhancements+to+ListTransactions+and+DescribeTransactions+APIs >
Re: [VOTE] KIP-994: Minor Enhancements to ListTransactions and DescribeTransactions APIs
Thanks Raman. +1 (binding) from me as well. Justine On Tue, Jan 9, 2024 at 10:12 AM Jun Rao wrote: > Hi, Raman, > > Thanks for the KIP. +1 from me. > > Jun > > On Tue, Dec 26, 2023 at 11:32 AM Raman Verma > wrote: > > > I would like to start a Vote on KIP-994 > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-994%3A+Minor+Enhancements+to+ListTransactions+and+DescribeTransactions+APIs > > >
Re: [VOTE] KIP-994: Minor Enhancements to ListTransactions and DescribeTransactions APIs
HI Raman, Thanks for the KIP! +1 from me. One small thing: we will probably have to overload the constructor for TransactionDescription in order to add the new update time field to avoid breaking the API. We might consider whether we need the overload to be public or not. Best, Jason On Tue, Jan 9, 2024 at 10:41 AM Justine Olshan wrote: > Thanks Raman. > > +1 (binding) from me as well. > > Justine > > On Tue, Jan 9, 2024 at 10:12 AM Jun Rao wrote: > > > Hi, Raman, > > > > Thanks for the KIP. +1 from me. > > > > Jun > > > > On Tue, Dec 26, 2023 at 11:32 AM Raman Verma > > > wrote: > > > > > I would like to start a Vote on KIP-994 > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-994%3A+Minor+Enhancements+to+ListTransactions+and+DescribeTransactions+APIs > > > > > >
Re: [VOTE] KIP-994: Minor Enhancements to ListTransactions and DescribeTransactions APIs
Thanks Jason, I have added a public constructor to TransactionDescription class and updated the KIP. On Thu, Jan 11, 2024 at 9:33 AM Jason Gustafson wrote: > > HI Raman, > > Thanks for the KIP! +1 from me. > > One small thing: we will probably have to overload the constructor for > TransactionDescription in order to add the new update time field to avoid > breaking the API. We might consider whether we need the overload to be > public or not. > > Best, > Jason > > On Tue, Jan 9, 2024 at 10:41 AM Justine Olshan > wrote: > > > Thanks Raman. > > > > +1 (binding) from me as well. > > > > Justine > > > > On Tue, Jan 9, 2024 at 10:12 AM Jun Rao wrote: > > > > > Hi, Raman, > > > > > > Thanks for the KIP. +1 from me. > > > > > > Jun > > > > > > On Tue, Dec 26, 2023 at 11:32 AM Raman Verma > > > > > wrote: > > > > > > > I would like to start a Vote on KIP-994 > > > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-994%3A+Minor+Enhancements+to+ListTransactions+and+DescribeTransactions+APIs > > > > > > > > >
Re: [VOTE] KIP-994: Minor Enhancements to ListTransactions and DescribeTransactions APIs
The KIP is accepted with 3 binding votes (Jun, Justine and Jason). Thank you all ! On Wed, Jan 17, 2024 at 1:49 PM Raman Verma wrote: > > Thanks Jason, > I have added a public constructor to TransactionDescription class and > updated the KIP. > > On Thu, Jan 11, 2024 at 9:33 AM Jason Gustafson > wrote: > > > > HI Raman, > > > > Thanks for the KIP! +1 from me. > > > > One small thing: we will probably have to overload the constructor for > > TransactionDescription in order to add the new update time field to avoid > > breaking the API. We might consider whether we need the overload to be > > public or not. > > > > Best, > > Jason > > > > On Tue, Jan 9, 2024 at 10:41 AM Justine Olshan > > > > wrote: > > > > > Thanks Raman. > > > > > > +1 (binding) from me as well. > > > > > > Justine > > > > > > On Tue, Jan 9, 2024 at 10:12 AM Jun Rao wrote: > > > > > > > Hi, Raman, > > > > > > > > Thanks for the KIP. +1 from me. > > > > > > > > Jun > > > > > > > > On Tue, Dec 26, 2023 at 11:32 AM Raman Verma > > > > > > > > > > > wrote: > > > > > > > > > I would like to start a Vote on KIP-994 > > > > > > > > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-994%3A+Minor+Enhancements+to+ListTransactions+and+DescribeTransactions+APIs > > > > > > > > > > > >