Re: ConsumerTest
Sounds good. Thanks! On Fri, Feb 27, 2015 at 3:01 PM, Guozhang Wang wrote: > Thanks Neha, I will make sure the ConsumerTest gets fixed when I check in > 1910. > > On Fri, Feb 27, 2015 at 2:12 PM, Neha Narkhede wrote: > > > Thanks for the quick responses. I deleted it for now, since commenting > out > > code is silly given that you can revive the file from version control > > later. > > > > On Fri, Feb 27, 2015 at 2:03 PM, Joel Koshy wrote: > > > > > +1 > > > > > > On Fri, Feb 27, 2015 at 01:50:07PM -0800, Neha Narkhede wrote: > > > > Wow. That was quick :-) > > > > Any committers who would also like to give a +1? > > > > > > > > On Fri, Feb 27, 2015 at 1:44 PM, Ashish Singh > > > wrote: > > > > > > > > > +1 > > > > > > > > > > On Fri, Feb 27, 2015 at 1:42 PM, Gwen Shapira < > gshap...@cloudera.com > > > > > > > > wrote: > > > > > > > > > > > Actually, we will greatly appreciate :) > > > > > > > > > > > > On Fri, Feb 27, 2015 at 1:37 PM, Neha Narkhede < > n...@confluent.io> > > > > > wrote: > > > > > > > Would anyone object if I commented out the > kafka.api.ConsumerTest > > > out > > > > > > until > > > > > > > it is fixed? It hangs and is making accepting patches very > > > > > > time-consuming. > > > > > > > > > > > > > > -- > > > > > > > Thanks, > > > > > > > Neha > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > Regards, > > > > > Ashish > > > > > > > > > > > > > > > > > > > > > -- > > > > Thanks, > > > > Neha > > > > > > > > > > > > -- > > Thanks, > > Neha > > > > > > -- > -- Guozhang > -- Thanks, Neha
Re: ConsumerTest
Thanks Neha, I will make sure the ConsumerTest gets fixed when I check in 1910. On Fri, Feb 27, 2015 at 2:12 PM, Neha Narkhede wrote: > Thanks for the quick responses. I deleted it for now, since commenting out > code is silly given that you can revive the file from version control > later. > > On Fri, Feb 27, 2015 at 2:03 PM, Joel Koshy wrote: > > > +1 > > > > On Fri, Feb 27, 2015 at 01:50:07PM -0800, Neha Narkhede wrote: > > > Wow. That was quick :-) > > > Any committers who would also like to give a +1? > > > > > > On Fri, Feb 27, 2015 at 1:44 PM, Ashish Singh > > wrote: > > > > > > > +1 > > > > > > > > On Fri, Feb 27, 2015 at 1:42 PM, Gwen Shapira > > > > > wrote: > > > > > > > > > Actually, we will greatly appreciate :) > > > > > > > > > > On Fri, Feb 27, 2015 at 1:37 PM, Neha Narkhede > > > > wrote: > > > > > > Would anyone object if I commented out the kafka.api.ConsumerTest > > out > > > > > until > > > > > > it is fixed? It hangs and is making accepting patches very > > > > > time-consuming. > > > > > > > > > > > > -- > > > > > > Thanks, > > > > > > Neha > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > Regards, > > > > Ashish > > > > > > > > > > > > > > > > -- > > > Thanks, > > > Neha > > > > > > > -- > Thanks, > Neha > -- -- Guozhang
Re: ConsumerTest
Thanks for the quick responses. I deleted it for now, since commenting out code is silly given that you can revive the file from version control later. On Fri, Feb 27, 2015 at 2:03 PM, Joel Koshy wrote: > +1 > > On Fri, Feb 27, 2015 at 01:50:07PM -0800, Neha Narkhede wrote: > > Wow. That was quick :-) > > Any committers who would also like to give a +1? > > > > On Fri, Feb 27, 2015 at 1:44 PM, Ashish Singh > wrote: > > > > > +1 > > > > > > On Fri, Feb 27, 2015 at 1:42 PM, Gwen Shapira > > > wrote: > > > > > > > Actually, we will greatly appreciate :) > > > > > > > > On Fri, Feb 27, 2015 at 1:37 PM, Neha Narkhede > > > wrote: > > > > > Would anyone object if I commented out the kafka.api.ConsumerTest > out > > > > until > > > > > it is fixed? It hangs and is making accepting patches very > > > > time-consuming. > > > > > > > > > > -- > > > > > Thanks, > > > > > Neha > > > > > > > > > > > > > > > > -- > > > > > > Regards, > > > Ashish > > > > > > > > > > > -- > > Thanks, > > Neha > > -- Thanks, Neha
Re: ConsumerTest
+1 On Fri, Feb 27, 2015 at 01:50:07PM -0800, Neha Narkhede wrote: > Wow. That was quick :-) > Any committers who would also like to give a +1? > > On Fri, Feb 27, 2015 at 1:44 PM, Ashish Singh wrote: > > > +1 > > > > On Fri, Feb 27, 2015 at 1:42 PM, Gwen Shapira > > wrote: > > > > > Actually, we will greatly appreciate :) > > > > > > On Fri, Feb 27, 2015 at 1:37 PM, Neha Narkhede > > wrote: > > > > Would anyone object if I commented out the kafka.api.ConsumerTest out > > > until > > > > it is fixed? It hangs and is making accepting patches very > > > time-consuming. > > > > > > > > -- > > > > Thanks, > > > > Neha > > > > > > > > > > > -- > > > > Regards, > > Ashish > > > > > > -- > Thanks, > Neha
Re: ConsumerTest
Wow. That was quick :-) Any committers who would also like to give a +1? On Fri, Feb 27, 2015 at 1:44 PM, Ashish Singh wrote: > +1 > > On Fri, Feb 27, 2015 at 1:42 PM, Gwen Shapira > wrote: > > > Actually, we will greatly appreciate :) > > > > On Fri, Feb 27, 2015 at 1:37 PM, Neha Narkhede > wrote: > > > Would anyone object if I commented out the kafka.api.ConsumerTest out > > until > > > it is fixed? It hangs and is making accepting patches very > > time-consuming. > > > > > > -- > > > Thanks, > > > Neha > > > > > > -- > > Regards, > Ashish > -- Thanks, Neha
Re: ConsumerTest
+1 On Fri, Feb 27, 2015 at 1:42 PM, Gwen Shapira wrote: > Actually, we will greatly appreciate :) > > On Fri, Feb 27, 2015 at 1:37 PM, Neha Narkhede wrote: > > Would anyone object if I commented out the kafka.api.ConsumerTest out > until > > it is fixed? It hangs and is making accepting patches very > time-consuming. > > > > -- > > Thanks, > > Neha > -- Regards, Ashish
Re: ConsumerTest
+1 On 2/27/15, 1:41 PM, "Harsha" wrote: >+1 > >On Fri, Feb 27, 2015, at 01:37 PM, Neha Narkhede wrote: >> Would anyone object if I commented out the kafka.api.ConsumerTest out >> until >> it is fixed? It hangs and is making accepting patches very >> time-consuming. >> >> -- >> Thanks, >> Neha
Re: ConsumerTest
Actually, we will greatly appreciate :) On Fri, Feb 27, 2015 at 1:37 PM, Neha Narkhede wrote: > Would anyone object if I commented out the kafka.api.ConsumerTest out until > it is fixed? It hangs and is making accepting patches very time-consuming. > > -- > Thanks, > Neha
Re: ConsumerTest
+1 On Fri, Feb 27, 2015, at 01:37 PM, Neha Narkhede wrote: > Would anyone object if I commented out the kafka.api.ConsumerTest out > until > it is fixed? It hangs and is making accepting patches very > time-consuming. > > -- > Thanks, > Neha
