Re: Review Request 14399: OfflinePartitionCount metrics may be incorrect after the controller failover

2013-09-30 Thread Guozhang Wang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14399/#review26469
---

Ship it!


Ship It!

- Guozhang Wang


On Sept. 29, 2013, 11:25 p.m., Jun Rao wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/14399/
 ---
 
 (Updated Sept. 29, 2013, 11:25 p.m.)
 
 
 Review request for kafka.
 
 
 Bugs: KAFKA-1068
 https://issues.apache.org/jira/browse/KAFKA-1068
 
 
 Repository: kafka
 
 
 Description
 ---
 
 kafka-1068
 
 
 Diffs
 -
 
   core/src/main/scala/kafka/controller/KafkaController.scala 
 aef41ad5f087817862dcbd9dfbb4674e49e21f91 
 
 Diff: https://reviews.apache.org/r/14399/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Jun Rao
 




Re: Review Request 14399: OfflinePartitionCount metrics may be incorrect after the controller failover

2013-09-30 Thread Neha Narkhede

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14399/#review26489
---

Ship it!


Ship It!

- Neha Narkhede


On Sept. 29, 2013, 11:25 p.m., Jun Rao wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/14399/
 ---
 
 (Updated Sept. 29, 2013, 11:25 p.m.)
 
 
 Review request for kafka.
 
 
 Bugs: KAFKA-1068
 https://issues.apache.org/jira/browse/KAFKA-1068
 
 
 Repository: kafka
 
 
 Description
 ---
 
 kafka-1068
 
 
 Diffs
 -
 
   core/src/main/scala/kafka/controller/KafkaController.scala 
 aef41ad5f087817862dcbd9dfbb4674e49e21f91 
 
 Diff: https://reviews.apache.org/r/14399/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Jun Rao