Re: the migration of command tools
Hi, if a tool already has a wrapper bash script in bin and bin/windows, then there is no need to create a redirection in Scala, as users are supposed to use the script. If there is any ST left which is using the tool directly, a bash script should be created, and the ST changed to use the script with new releases only. On Wed, Apr 10, 2024 at 3:08 PM Chia-Ping Tsai wrote: > > hi David > > thanks for quickly response!! > > According to KIP-906, the BC rules are > > 1) The old package name must be deprecated in the target release (e.g. 3.5) > and redirection removed in the next major release (e.g. 4.0). > 2) Existing users will get a deprecation warning when using the old package > name, while old SPIs and classes will be marked as deprecated. > > I will file a jira to make sure we don't violate that rules > > Best, > Chia-Ping > > David Jacot 於 2024年4月10日 週三 下午8:57寫道： > > > Hey, > > > > I think that we discussed this in this KIP: > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-906%3A+Tools+migration+guidelines > > . > > I don't remember all the details though. > > > > Best, > > David > > > > On Wed, Apr 10, 2024 at 2:54 PM Chia-Ping Tsai wrote: > > > > > Dear Kafka, > > > > > > Migrating command tools from core module to tools module is not news. > > > However, I want to make sure I don't misunderstand the BC rules. > > > > > > The question is "Should we keep origin class?" > > > > > > FeatureCommand ( > > > > > > > > https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/admin/FeatureCommand.scala > > > ) > > > is a good example. We keep the origin class file due to backward > > > compatibility. However, we don't do that to other tools. > > > > > > It seems to me that we should align the BC rules for all tools. And here > > is > > > my two cents: the expected way of using command tool is by script file, > > so > > > we DON'T need to keep origin class file. > > > > > > WDYT? > > > > > > Best, > > > Chia-Ping > > > > >
Re: the migration of command tools
hi David thanks for quickly response!! According to KIP-906, the BC rules are 1) The old package name must be deprecated in the target release (e.g. 3.5) and redirection removed in the next major release (e.g. 4.0). 2) Existing users will get a deprecation warning when using the old package name, while old SPIs and classes will be marked as deprecated. I will file a jira to make sure we don't violate that rules Best, Chia-Ping David Jacot 於 2024年4月10日 週三 下午8:57寫道： > Hey, > > I think that we discussed this in this KIP: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-906%3A+Tools+migration+guidelines > . > I don't remember all the details though. > > Best, > David > > On Wed, Apr 10, 2024 at 2:54 PM Chia-Ping Tsai wrote: > > > Dear Kafka, > > > > Migrating command tools from core module to tools module is not news. > > However, I want to make sure I don't misunderstand the BC rules. > > > > The question is "Should we keep origin class?" > > > > FeatureCommand ( > > > > > https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/admin/FeatureCommand.scala > > ) > > is a good example. We keep the origin class file due to backward > > compatibility. However, we don't do that to other tools. > > > > It seems to me that we should align the BC rules for all tools. And here > is > > my two cents: the expected way of using command tool is by script file, > so > > we DON'T need to keep origin class file. > > > > WDYT? > > > > Best, > > Chia-Ping > > >
Re: the migration of command tools
Hey, I think that we discussed this in this KIP: https://cwiki.apache.org/confluence/display/KAFKA/KIP-906%3A+Tools+migration+guidelines. I don't remember all the details though. Best, David On Wed, Apr 10, 2024 at 2:54 PM Chia-Ping Tsai wrote: > Dear Kafka, > > Migrating command tools from core module to tools module is not news. > However, I want to make sure I don't misunderstand the BC rules. > > The question is "Should we keep origin class?" > > FeatureCommand ( > > https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/admin/FeatureCommand.scala > ) > is a good example. We keep the origin class file due to backward > compatibility. However, we don't do that to other tools. > > It seems to me that we should align the BC rules for all tools. And here is > my two cents: the expected way of using command tool is by script file, so > we DON'T need to keep origin class file. > > WDYT? > > Best, > Chia-Ping >
