subject:"Review Request 22131\: Patch for KAFKA\-1477"

Re: Review Request 22131: Patch for KAFKA-1477

2014-09-24 Thread Rajasekar Elango


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22131/#review54412
---



core/src/main/scala/kafka/utils/ZkUtils.scala
https://reviews.apache.org/r/22131/#comment94544

Can we please register secure value of broker in zookeeper as a boolean 
true/false instead of number 1|0? Two reasons for this request 
1. It's really a boolean, not an number.
2. It's breaks backward compactibility with our (salesforce's) original 
implementation. Our older secure client can no longer work with this newer 
version of secure broker.


- Rajasekar Elango


On Sept. 23, 2014, 11:14 a.m., Ivan Lyutov wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/22131/
 ---
 
 (Updated Sept. 23, 2014, 11:14 a.m.)
 
 
 Review request for kafka.
 
 
 Bugs: KAFKA-1477
 https://issues.apache.org/jira/browse/KAFKA-1477
 
 
 Repository: kafka
 
 
 Description
 ---
 
 Minor fixes, cleanup
 
 Refactoring
 
 Fixed tests compilation error.
 
 Updated according to requested changes: refactoring, minor edits.
 
 
 Added basic functionality for new producer.
 
 
 bug fixes after rebase
 
 
 bug fix after rebase
 
 
 updated tests after rebase
 
 
 changed default security to false
 
 
 Diffs
 -
 
   clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java 
 f58b8508d3f813a51015abed772c704390887d7e 
   clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java 
 f9de4af426449cceca12a8de9a9f54a6241d28d8 
   
 clients/src/main/java/org/apache/kafka/clients/producer/internals/SSLSocketChannel.java
  PRE-CREATION 
   
 clients/src/main/java/org/apache/kafka/common/errors/UnknownKeyStoreException.java
  PRE-CREATION 
   clients/src/main/java/org/apache/kafka/common/network/Selector.java 
 4dd2cdf773f7eb01a93d7f994383088960303dfc 
   
 clients/src/main/java/org/apache/kafka/common/network/security/AuthConfig.java
  PRE-CREATION 
   
 clients/src/main/java/org/apache/kafka/common/network/security/KeyStores.java 
 PRE-CREATION 
   
 clients/src/main/java/org/apache/kafka/common/network/security/SecureAuth.java
  PRE-CREATION 
   
 clients/src/main/java/org/apache/kafka/common/network/security/StoreInitializer.java
  PRE-CREATION 
   
 clients/src/main/java/org/apache/kafka/common/network/security/store/JKSInitializer.java
  PRE-CREATION 
   clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java 
 5c5e3d40819e41cab7b52a0eeaee5f2e7317b7b3 
   config/client.keystore PRE-CREATION 
   config/client.public-key PRE-CREATION 
   config/client.security.properties PRE-CREATION 
   config/consumer.properties 83847de30d10b6e78bb8de28e0bb925d7c0e6ca2 
   config/producer.properties 39d65d7c6c21f4fccd7af89be6ca12a088d5dd98 
   config/server.keystore PRE-CREATION 
   config/server.properties 5c0905a572b1f0d8b07bfca967a09cb856a6b09f 
   config/server.public-key PRE-CREATION 
   config/server.security.properties PRE-CREATION 
   core/src/main/scala/kafka/api/FetchRequest.scala 
 59c09155dd25fad7bed07d3d00039e3dc66db95c 
   core/src/main/scala/kafka/client/ClientUtils.scala 
 ebba87f0566684c796c26cb76c64b4640a5ccfde 
   core/src/main/scala/kafka/cluster/Broker.scala 
 0060add008bb3bc4b0092f2173c469fce0120be6 
   core/src/main/scala/kafka/common/UnknownKeyStoreException.scala 
 PRE-CREATION 
   core/src/main/scala/kafka/consumer/ConsumerConfig.scala 
 9ebbee6c16dc83767297c729d2d74ebbd063a993 
   core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala 
 b9e2bea7b442a19bcebd1b350d39541a8c9dd068 
   core/src/main/scala/kafka/consumer/SimpleConsumer.scala 
 d349a3000feb9ccd57d1f3cb163548d5bf432186 
   core/src/main/scala/kafka/controller/ControllerChannelManager.scala 
 ecbfa0f328ba6a652a758ab20cacef324a8b2fb8 
   core/src/main/scala/kafka/network/BlockingChannel.scala 
 eb7bb14d94cb3648c06d4de36a3b34aacbde4556 
   core/src/main/scala/kafka/network/SocketServer.scala 
 3a6f8d121e822e7b6ec32c9147829e91f40e9038 
   core/src/main/scala/kafka/network/security/AuthConfig.scala PRE-CREATION 
   core/src/main/scala/kafka/network/security/KeyStores.scala PRE-CREATION 
   core/src/main/scala/kafka/network/security/SSLSocketChannel.scala 
 PRE-CREATION 
   core/src/main/scala/kafka/network/security/SecureAuth.scala PRE-CREATION 
   core/src/main/scala/kafka/network/security/store/JKSInitializer.scala 
 PRE-CREATION 
   core/src/main/scala/kafka/producer/ProducerConfig.scala 
 3cdf23dce3407f1770b9c6543e3a8ae8ab3ff255 
   core/src/main/scala/kafka/producer/ProducerPool.scala 
 43df70bb461dd3e385e6b20396adef3c4016a3fc 
   core/src/main/scala/kafka/producer/SyncProducer.scala 
 42c950375098b51f45c79c6a4a99a36f387bf02b 
   core/src/main/scala/kafka/producer/SyncProducerConfig.scala

Re: Review Request 22131: Patch for KAFKA-1477

2014-09-23 Thread Ivan Lyutov


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22131/
---

(Updated Sept. 23, 2014, 11:11 a.m.)


Review request for kafka.


Bugs: KAFKA-1477
https://issues.apache.org/jira/browse/KAFKA-1477


Repository: kafka


Description (updated)
---

Minor fixes, cleanup

Refactoring

Fixed tests compilation error.

Updated according to requested changes: refactoring, minor edits.


Added basic functionality for new producer.


bug fixes after rebase


bug fix after rebase


updated tests after rebase


Diffs (updated)
-

  clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java 
f58b8508d3f813a51015abed772c704390887d7e 
  clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java 
f9de4af426449cceca12a8de9a9f54a6241d28d8 
  
clients/src/main/java/org/apache/kafka/clients/producer/internals/SSLSocketChannel.java
 PRE-CREATION 
  
clients/src/main/java/org/apache/kafka/common/errors/UnknownKeyStoreException.java
 PRE-CREATION 
  clients/src/main/java/org/apache/kafka/common/network/Selector.java 
4dd2cdf773f7eb01a93d7f994383088960303dfc 
  
clients/src/main/java/org/apache/kafka/common/network/security/AuthConfig.java 
PRE-CREATION 
  clients/src/main/java/org/apache/kafka/common/network/security/KeyStores.java 
PRE-CREATION 
  
clients/src/main/java/org/apache/kafka/common/network/security/SecureAuth.java 
PRE-CREATION 
  
clients/src/main/java/org/apache/kafka/common/network/security/StoreInitializer.java
 PRE-CREATION 
  
clients/src/main/java/org/apache/kafka/common/network/security/store/JKSInitializer.java
 PRE-CREATION 
  clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java 
5c5e3d40819e41cab7b52a0eeaee5f2e7317b7b3 
  config/client.keystore PRE-CREATION 
  config/client.public-key PRE-CREATION 
  config/client.security.properties PRE-CREATION 
  config/consumer.properties 83847de30d10b6e78bb8de28e0bb925d7c0e6ca2 
  config/producer.properties 39d65d7c6c21f4fccd7af89be6ca12a088d5dd98 
  config/server.keystore PRE-CREATION 
  config/server.properties 5c0905a572b1f0d8b07bfca967a09cb856a6b09f 
  config/server.public-key PRE-CREATION 
  config/server.security.properties PRE-CREATION 
  core/src/main/scala/kafka/api/FetchRequest.scala 
59c09155dd25fad7bed07d3d00039e3dc66db95c 
  core/src/main/scala/kafka/client/ClientUtils.scala 
ebba87f0566684c796c26cb76c64b4640a5ccfde 
  core/src/main/scala/kafka/cluster/Broker.scala 
0060add008bb3bc4b0092f2173c469fce0120be6 
  core/src/main/scala/kafka/common/UnknownKeyStoreException.scala PRE-CREATION 
  core/src/main/scala/kafka/consumer/ConsumerConfig.scala 
9ebbee6c16dc83767297c729d2d74ebbd063a993 
  core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala 
b9e2bea7b442a19bcebd1b350d39541a8c9dd068 
  core/src/main/scala/kafka/consumer/SimpleConsumer.scala 
d349a3000feb9ccd57d1f3cb163548d5bf432186 
  core/src/main/scala/kafka/controller/ControllerChannelManager.scala 
ecbfa0f328ba6a652a758ab20cacef324a8b2fb8 
  core/src/main/scala/kafka/network/BlockingChannel.scala 
eb7bb14d94cb3648c06d4de36a3b34aacbde4556 
  core/src/main/scala/kafka/network/SocketServer.scala 
3a6f8d121e822e7b6ec32c9147829e91f40e9038 
  core/src/main/scala/kafka/network/security/AuthConfig.scala PRE-CREATION 
  core/src/main/scala/kafka/network/security/KeyStores.scala PRE-CREATION 
  core/src/main/scala/kafka/network/security/SSLSocketChannel.scala 
PRE-CREATION 
  core/src/main/scala/kafka/network/security/SecureAuth.scala PRE-CREATION 
  core/src/main/scala/kafka/network/security/store/JKSInitializer.scala 
PRE-CREATION 
  core/src/main/scala/kafka/producer/ProducerConfig.scala 
3cdf23dce3407f1770b9c6543e3a8ae8ab3ff255 
  core/src/main/scala/kafka/producer/ProducerPool.scala 
43df70bb461dd3e385e6b20396adef3c4016a3fc 
  core/src/main/scala/kafka/producer/SyncProducer.scala 
42c950375098b51f45c79c6a4a99a36f387bf02b 
  core/src/main/scala/kafka/producer/SyncProducerConfig.scala 
69b2d0c11bb1412ce76d566f285333c806be301a 
  core/src/main/scala/kafka/server/AbstractFetcherThread.scala 
2e9532e820b5b5c63dfd55f5454b32866d084a37 
  core/src/main/scala/kafka/server/KafkaConfig.scala 
165c816a9f4c925f6e46560e7e2ff9cf7591946b 
  core/src/main/scala/kafka/server/KafkaHealthcheck.scala 
4acdd70fe9c1ee78d6510741006c2ece65450671 
  core/src/main/scala/kafka/server/KafkaServer.scala 
390fef500d7e0027e698c259d777454ba5a0f5e8 
  core/src/main/scala/kafka/tools/ConsoleConsumer.scala 
323fc8566d974acc4e5c7d7c2a065794f3b5df4a 
  core/src/main/scala/kafka/tools/ConsoleProducer.scala 
da4dad405c8d8f26a64cda78a292e1f5bfbdcc22 
  core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala 
d1e7c434e77859d746b8dc68dd5d5a3740425e79 
  core/src/main/scala/kafka/tools/GetOffsetShell.scala 
9c6064e201eebbcd5b276a0dedd02937439edc94 
  core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala

Re: Review Request 22131: Patch for KAFKA-1477

2014-09-23 Thread Ivan Lyutov


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22131/
---

(Updated Sept. 23, 2014, 11:14 a.m.)


Review request for kafka.


Bugs: KAFKA-1477
https://issues.apache.org/jira/browse/KAFKA-1477


Repository: kafka


Description (updated)
---

Minor fixes, cleanup

Refactoring

Fixed tests compilation error.

Updated according to requested changes: refactoring, minor edits.


Added basic functionality for new producer.


bug fixes after rebase


bug fix after rebase


updated tests after rebase


changed default security to false


Diffs (updated)
-

  clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java 
f58b8508d3f813a51015abed772c704390887d7e 
  clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java 
f9de4af426449cceca12a8de9a9f54a6241d28d8 
  
clients/src/main/java/org/apache/kafka/clients/producer/internals/SSLSocketChannel.java
 PRE-CREATION 
  
clients/src/main/java/org/apache/kafka/common/errors/UnknownKeyStoreException.java
 PRE-CREATION 
  clients/src/main/java/org/apache/kafka/common/network/Selector.java 
4dd2cdf773f7eb01a93d7f994383088960303dfc 
  
clients/src/main/java/org/apache/kafka/common/network/security/AuthConfig.java 
PRE-CREATION 
  clients/src/main/java/org/apache/kafka/common/network/security/KeyStores.java 
PRE-CREATION 
  
clients/src/main/java/org/apache/kafka/common/network/security/SecureAuth.java 
PRE-CREATION 
  
clients/src/main/java/org/apache/kafka/common/network/security/StoreInitializer.java
 PRE-CREATION 
  
clients/src/main/java/org/apache/kafka/common/network/security/store/JKSInitializer.java
 PRE-CREATION 
  clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java 
5c5e3d40819e41cab7b52a0eeaee5f2e7317b7b3 
  config/client.keystore PRE-CREATION 
  config/client.public-key PRE-CREATION 
  config/client.security.properties PRE-CREATION 
  config/consumer.properties 83847de30d10b6e78bb8de28e0bb925d7c0e6ca2 
  config/producer.properties 39d65d7c6c21f4fccd7af89be6ca12a088d5dd98 
  config/server.keystore PRE-CREATION 
  config/server.properties 5c0905a572b1f0d8b07bfca967a09cb856a6b09f 
  config/server.public-key PRE-CREATION 
  config/server.security.properties PRE-CREATION 
  core/src/main/scala/kafka/api/FetchRequest.scala 
59c09155dd25fad7bed07d3d00039e3dc66db95c 
  core/src/main/scala/kafka/client/ClientUtils.scala 
ebba87f0566684c796c26cb76c64b4640a5ccfde 
  core/src/main/scala/kafka/cluster/Broker.scala 
0060add008bb3bc4b0092f2173c469fce0120be6 
  core/src/main/scala/kafka/common/UnknownKeyStoreException.scala PRE-CREATION 
  core/src/main/scala/kafka/consumer/ConsumerConfig.scala 
9ebbee6c16dc83767297c729d2d74ebbd063a993 
  core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala 
b9e2bea7b442a19bcebd1b350d39541a8c9dd068 
  core/src/main/scala/kafka/consumer/SimpleConsumer.scala 
d349a3000feb9ccd57d1f3cb163548d5bf432186 
  core/src/main/scala/kafka/controller/ControllerChannelManager.scala 
ecbfa0f328ba6a652a758ab20cacef324a8b2fb8 
  core/src/main/scala/kafka/network/BlockingChannel.scala 
eb7bb14d94cb3648c06d4de36a3b34aacbde4556 
  core/src/main/scala/kafka/network/SocketServer.scala 
3a6f8d121e822e7b6ec32c9147829e91f40e9038 
  core/src/main/scala/kafka/network/security/AuthConfig.scala PRE-CREATION 
  core/src/main/scala/kafka/network/security/KeyStores.scala PRE-CREATION 
  core/src/main/scala/kafka/network/security/SSLSocketChannel.scala 
PRE-CREATION 
  core/src/main/scala/kafka/network/security/SecureAuth.scala PRE-CREATION 
  core/src/main/scala/kafka/network/security/store/JKSInitializer.scala 
PRE-CREATION 
  core/src/main/scala/kafka/producer/ProducerConfig.scala 
3cdf23dce3407f1770b9c6543e3a8ae8ab3ff255 
  core/src/main/scala/kafka/producer/ProducerPool.scala 
43df70bb461dd3e385e6b20396adef3c4016a3fc 
  core/src/main/scala/kafka/producer/SyncProducer.scala 
42c950375098b51f45c79c6a4a99a36f387bf02b 
  core/src/main/scala/kafka/producer/SyncProducerConfig.scala 
69b2d0c11bb1412ce76d566f285333c806be301a 
  core/src/main/scala/kafka/server/AbstractFetcherThread.scala 
2e9532e820b5b5c63dfd55f5454b32866d084a37 
  core/src/main/scala/kafka/server/KafkaConfig.scala 
165c816a9f4c925f6e46560e7e2ff9cf7591946b 
  core/src/main/scala/kafka/server/KafkaHealthcheck.scala 
4acdd70fe9c1ee78d6510741006c2ece65450671 
  core/src/main/scala/kafka/server/KafkaServer.scala 
390fef500d7e0027e698c259d777454ba5a0f5e8 
  core/src/main/scala/kafka/tools/ConsoleConsumer.scala 
323fc8566d974acc4e5c7d7c2a065794f3b5df4a 
  core/src/main/scala/kafka/tools/ConsoleProducer.scala 
da4dad405c8d8f26a64cda78a292e1f5bfbdcc22 
  core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala 
d1e7c434e77859d746b8dc68dd5d5a3740425e79 
  core/src/main/scala/kafka/tools/GetOffsetShell.scala 
9c6064e201eebbcd5b276a0dedd02937439edc94

Re: Review Request 22131: Patch for KAFKA-1477

2014-09-22 Thread Rajasekar Elango


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22131/#review54191
---



config/server.properties
https://reviews.apache.org/r/22131/#comment94187

Can we set secure property to ***false*** to make kafka run in non-secure 
mode by default so it won't impact existing users


- Rajasekar Elango


On Sept. 18, 2014, 12:43 p.m., Ivan Lyutov wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/22131/
 ---
 
 (Updated Sept. 18, 2014, 12:43 p.m.)
 
 
 Review request for kafka.
 
 
 Bugs: KAFKA-1477
 https://issues.apache.org/jira/browse/KAFKA-1477
 
 
 Repository: kafka
 
 
 Description
 ---
 
 Minor fixes, cleanup
 
 Refactoring
 
 Fixed tests compilation error.
 
 Updated according to requested changes: refactoring, minor edits.
 
 
 Added basic functionality for new producer.
 
 
 bug fixes after rebase
 
 
 bug fix after rebase
 
 
 Diffs
 -
 
   clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java 
 f58b8508d3f813a51015abed772c704390887d7e 
   clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java 
 f9de4af426449cceca12a8de9a9f54a6241d28d8 
   
 clients/src/main/java/org/apache/kafka/clients/producer/internals/SSLSocketChannel.java
  PRE-CREATION 
   
 clients/src/main/java/org/apache/kafka/common/errors/UnknownKeyStoreException.java
  PRE-CREATION 
   clients/src/main/java/org/apache/kafka/common/network/Selector.java 
 4dd2cdf773f7eb01a93d7f994383088960303dfc 
   
 clients/src/main/java/org/apache/kafka/common/network/security/AuthConfig.java
  PRE-CREATION 
   
 clients/src/main/java/org/apache/kafka/common/network/security/KeyStores.java 
 PRE-CREATION 
   
 clients/src/main/java/org/apache/kafka/common/network/security/SecureAuth.java
  PRE-CREATION 
   
 clients/src/main/java/org/apache/kafka/common/network/security/StoreInitializer.java
  PRE-CREATION 
   
 clients/src/main/java/org/apache/kafka/common/network/security/store/JKSInitializer.java
  PRE-CREATION 
   clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java 
 5c5e3d40819e41cab7b52a0eeaee5f2e7317b7b3 
   config/client.keystore PRE-CREATION 
   config/client.public-key PRE-CREATION 
   config/client.security.properties PRE-CREATION 
   config/consumer.properties 83847de30d10b6e78bb8de28e0bb925d7c0e6ca2 
   config/producer.properties 39d65d7c6c21f4fccd7af89be6ca12a088d5dd98 
   config/server.keystore PRE-CREATION 
   config/server.properties 5c0905a572b1f0d8b07bfca967a09cb856a6b09f 
   config/server.public-key PRE-CREATION 
   config/server.security.properties PRE-CREATION 
   core/src/main/scala/kafka/api/FetchRequest.scala 
 51cdccf7f90eb530cc62b094ed822b8469d50b12 
   core/src/main/scala/kafka/client/ClientUtils.scala 
 ce7ede3f6d60e756e252257bd8c6fedc21f21e1c 
   core/src/main/scala/kafka/cluster/Broker.scala 
 9407ed21fbbd57edeecd888edc32bea6a05d95b3 
   core/src/main/scala/kafka/common/UnknownKeyStoreException.scala 
 PRE-CREATION 
   core/src/main/scala/kafka/consumer/ConsumerConfig.scala 
 9ebbee6c16dc83767297c729d2d74ebbd063a993 
   core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala 
 b9e2bea7b442a19bcebd1b350d39541a8c9dd068 
   core/src/main/scala/kafka/consumer/SimpleConsumer.scala 
 8db9203d164a4a54f94d8d289e070a0f61e03ff9 
   core/src/main/scala/kafka/controller/ControllerChannelManager.scala 
 ecbfa0f328ba6a652a758ab20cacef324a8b2fb8 
   core/src/main/scala/kafka/network/BlockingChannel.scala 
 eb7bb14d94cb3648c06d4de36a3b34aacbde4556 
   core/src/main/scala/kafka/network/SocketServer.scala 
 d67899080c21e0b6db84657d6845c7ef23b59b0e 
   core/src/main/scala/kafka/network/security/AuthConfig.scala PRE-CREATION 
   core/src/main/scala/kafka/network/security/KeyStores.scala PRE-CREATION 
   core/src/main/scala/kafka/network/security/SSLSocketChannel.scala 
 PRE-CREATION 
   core/src/main/scala/kafka/network/security/SecureAuth.scala PRE-CREATION 
   core/src/main/scala/kafka/network/security/store/JKSInitializer.scala 
 PRE-CREATION 
   core/src/main/scala/kafka/producer/ProducerConfig.scala 
 3cdf23dce3407f1770b9c6543e3a8ae8ab3ff255 
   core/src/main/scala/kafka/producer/ProducerPool.scala 
 43df70bb461dd3e385e6b20396adef3c4016a3fc 
   core/src/main/scala/kafka/producer/SyncProducer.scala 
 489f0077512d9a69be81649c490274964290fa40 
   core/src/main/scala/kafka/producer/SyncProducerConfig.scala 
 69b2d0c11bb1412ce76d566f285333c806be301a 
   core/src/main/scala/kafka/server/AbstractFetcherThread.scala 
 2e9532e820b5b5c63dfd55f5454b32866d084a37 
   core/src/main/scala/kafka/server/KafkaConfig.scala 
 dce48db175d6ea379f848a7768de0b1c8e4b929f 
   core/src/main/scala/kafka/server/KafkaHealthcheck.scala

Re: Review Request 22131: Patch for KAFKA-1477

2014-09-18 Thread Ivan Lyutov


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22131/
---

(Updated Sept. 18, 2014, 12:43 p.m.)


Review request for kafka.


Bugs: KAFKA-1477
https://issues.apache.org/jira/browse/KAFKA-1477


Repository: kafka


Description (updated)
---

Minor fixes, cleanup

Refactoring

Fixed tests compilation error.

Updated according to requested changes: refactoring, minor edits.


Added basic functionality for new producer.


bug fixes after rebase


bug fix after rebase


Diffs (updated)
-

  clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java 
f58b8508d3f813a51015abed772c704390887d7e 
  clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java 
f9de4af426449cceca12a8de9a9f54a6241d28d8 
  
clients/src/main/java/org/apache/kafka/clients/producer/internals/SSLSocketChannel.java
 PRE-CREATION 
  
clients/src/main/java/org/apache/kafka/common/errors/UnknownKeyStoreException.java
 PRE-CREATION 
  clients/src/main/java/org/apache/kafka/common/network/Selector.java 
4dd2cdf773f7eb01a93d7f994383088960303dfc 
  
clients/src/main/java/org/apache/kafka/common/network/security/AuthConfig.java 
PRE-CREATION 
  clients/src/main/java/org/apache/kafka/common/network/security/KeyStores.java 
PRE-CREATION 
  
clients/src/main/java/org/apache/kafka/common/network/security/SecureAuth.java 
PRE-CREATION 
  
clients/src/main/java/org/apache/kafka/common/network/security/StoreInitializer.java
 PRE-CREATION 
  
clients/src/main/java/org/apache/kafka/common/network/security/store/JKSInitializer.java
 PRE-CREATION 
  clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java 
5c5e3d40819e41cab7b52a0eeaee5f2e7317b7b3 
  config/client.keystore PRE-CREATION 
  config/client.public-key PRE-CREATION 
  config/client.security.properties PRE-CREATION 
  config/consumer.properties 83847de30d10b6e78bb8de28e0bb925d7c0e6ca2 
  config/producer.properties 39d65d7c6c21f4fccd7af89be6ca12a088d5dd98 
  config/server.keystore PRE-CREATION 
  config/server.properties 5c0905a572b1f0d8b07bfca967a09cb856a6b09f 
  config/server.public-key PRE-CREATION 
  config/server.security.properties PRE-CREATION 
  core/src/main/scala/kafka/api/FetchRequest.scala 
51cdccf7f90eb530cc62b094ed822b8469d50b12 
  core/src/main/scala/kafka/client/ClientUtils.scala 
ce7ede3f6d60e756e252257bd8c6fedc21f21e1c 
  core/src/main/scala/kafka/cluster/Broker.scala 
9407ed21fbbd57edeecd888edc32bea6a05d95b3 
  core/src/main/scala/kafka/common/UnknownKeyStoreException.scala PRE-CREATION 
  core/src/main/scala/kafka/consumer/ConsumerConfig.scala 
9ebbee6c16dc83767297c729d2d74ebbd063a993 
  core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala 
b9e2bea7b442a19bcebd1b350d39541a8c9dd068 
  core/src/main/scala/kafka/consumer/SimpleConsumer.scala 
8db9203d164a4a54f94d8d289e070a0f61e03ff9 
  core/src/main/scala/kafka/controller/ControllerChannelManager.scala 
ecbfa0f328ba6a652a758ab20cacef324a8b2fb8 
  core/src/main/scala/kafka/network/BlockingChannel.scala 
eb7bb14d94cb3648c06d4de36a3b34aacbde4556 
  core/src/main/scala/kafka/network/SocketServer.scala 
d67899080c21e0b6db84657d6845c7ef23b59b0e 
  core/src/main/scala/kafka/network/security/AuthConfig.scala PRE-CREATION 
  core/src/main/scala/kafka/network/security/KeyStores.scala PRE-CREATION 
  core/src/main/scala/kafka/network/security/SSLSocketChannel.scala 
PRE-CREATION 
  core/src/main/scala/kafka/network/security/SecureAuth.scala PRE-CREATION 
  core/src/main/scala/kafka/network/security/store/JKSInitializer.scala 
PRE-CREATION 
  core/src/main/scala/kafka/producer/ProducerConfig.scala 
3cdf23dce3407f1770b9c6543e3a8ae8ab3ff255 
  core/src/main/scala/kafka/producer/ProducerPool.scala 
43df70bb461dd3e385e6b20396adef3c4016a3fc 
  core/src/main/scala/kafka/producer/SyncProducer.scala 
489f0077512d9a69be81649c490274964290fa40 
  core/src/main/scala/kafka/producer/SyncProducerConfig.scala 
69b2d0c11bb1412ce76d566f285333c806be301a 
  core/src/main/scala/kafka/server/AbstractFetcherThread.scala 
2e9532e820b5b5c63dfd55f5454b32866d084a37 
  core/src/main/scala/kafka/server/KafkaConfig.scala 
dce48db175d6ea379f848a7768de0b1c8e4b929f 
  core/src/main/scala/kafka/server/KafkaHealthcheck.scala 
4acdd70fe9c1ee78d6510741006c2ece65450671 
  core/src/main/scala/kafka/server/KafkaServer.scala 
28711182aaa70eaa623de858bc063cb2613b2a4d 
  core/src/main/scala/kafka/tools/ConsoleConsumer.scala 
323fc8566d974acc4e5c7d7c2a065794f3b5df4a 
  core/src/main/scala/kafka/tools/ConsoleProducer.scala 
da4dad405c8d8f26a64cda78a292e1f5bfbdcc22 
  core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala 
d1e7c434e77859d746b8dc68dd5d5a3740425e79 
  core/src/main/scala/kafka/tools/GetOffsetShell.scala 
9c6064e201eebbcd5b276a0dedd02937439edc94 
  core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala

Re: Review Request 22131: Patch for KAFKA-1477

2014-06-06 Thread Rajasekar Elango


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22131/#review44914
---

Ship it!


Looks like the changes we did on this commit 
https://github.com/relango/kafka/commit/0ec255e94973df995c43818bb09d1246440aded9
 is not included in patch. We made those changes to fix BadVersion Error thrown 
by zookeeper. Hopefully they don't happen anymore with latest code in trunk. If 
it comes back we can create another patch since it is not related to security. 
So ok with not including it.

- Rajasekar Elango


On June 3, 2014, 10:53 a.m., Ivan Lyutov wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/22131/
 ---
 
 (Updated June 3, 2014, 10:53 a.m.)
 
 
 Review request for kafka.
 
 
 Bugs: KAFKA-1477
 https://issues.apache.org/jira/browse/KAFKA-1477
 
 
 Repository: kafka
 
 
 Description
 ---
 
 Updated according to requested changes: refactoring, minor edits.
 
 
 Reverted gradle version
 
 
 Added SSL for Kafka
 
 Minor fixes, cleanup
 
 Refactoring
 
 Fixed tests compilation error.
 
 
 Diffs
 -
 
   config/client.keystore PRE-CREATION 
   config/client.public-key PRE-CREATION 
   config/client.security.properties PRE-CREATION 
   config/consumer.properties 7343cbc28cf8b8de3f096d09c2be955bea73164f 
   config/producer.properties 39d65d7c6c21f4fccd7af89be6ca12a088d5dd98 
   config/server.keystore PRE-CREATION 
   config/server.properties c9e923aed8551e0797b1ea6f69628b277faf8f48 
   config/server.public-key PRE-CREATION 
   config/server.security.properties PRE-CREATION 
   core/src/main/scala/kafka/api/FetchRequest.scala 
 a8b73acd1a813284744359e8434cb52d22063c99 
   core/src/main/scala/kafka/client/ClientUtils.scala 
 ba5fbdcd9e60f953575e529325caf4c41e22f22d 
   core/src/main/scala/kafka/cluster/Broker.scala 
 9407ed21fbbd57edeecd888edc32bea6a05d95b3 
   core/src/main/scala/kafka/common/UnknownKeyStoreException.scala 
 PRE-CREATION 
   core/src/main/scala/kafka/consumer/ConsoleConsumer.scala 
 1a16c691683dda0c53f316e3c4797ea38e776574 
   core/src/main/scala/kafka/consumer/ConsumerConfig.scala 
 1cf2f62ba02e4aa66bfa7575865e5d57baf82212 
   core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala 
 b9e2bea7b442a19bcebd1b350d39541a8c9dd068 
   core/src/main/scala/kafka/consumer/SimpleConsumer.scala 
 0e64632210385ef63c2ad3445b55ac4f37a63df2 
   core/src/main/scala/kafka/controller/ControllerChannelManager.scala 
 8763968fbff697e4c5c98ab1274627c192a4d26a 
   core/src/main/scala/kafka/network/BlockingChannel.scala 
 eb7bb14d94cb3648c06d4de36a3b34aacbde4556 
   core/src/main/scala/kafka/network/SocketServer.scala 
 4976d9c3a66bc965f5870a0736e21c7b32650bab 
   core/src/main/scala/kafka/network/security/AuthConfig.scala PRE-CREATION 
   core/src/main/scala/kafka/network/security/KeyStores.scala PRE-CREATION 
   core/src/main/scala/kafka/network/security/SSLSocketChannel.scala 
 PRE-CREATION 
   core/src/main/scala/kafka/network/security/SecureAuth.scala PRE-CREATION 
   core/src/main/scala/kafka/network/security/store/JKSInitializer.scala 
 PRE-CREATION 
   core/src/main/scala/kafka/producer/ConsoleProducer.scala 
 a2af988d99a94a20291d6a2dc9bec73197f1b756 
   core/src/main/scala/kafka/producer/ProducerConfig.scala 
 3cdf23dce3407f1770b9c6543e3a8ae8ab3ff255 
   core/src/main/scala/kafka/producer/ProducerPool.scala 
 43df70bb461dd3e385e6b20396adef3c4016a3fc 
   core/src/main/scala/kafka/producer/SyncProducer.scala 
 489f0077512d9a69be81649c490274964290fa40 
   core/src/main/scala/kafka/producer/SyncProducerConfig.scala 
 69b2d0c11bb1412ce76d566f285333c806be301a 
   core/src/main/scala/kafka/server/AbstractFetcherThread.scala 
 3b15254f32252cf824d7a292889ac7662d73ada1 
   core/src/main/scala/kafka/server/KafkaConfig.scala 
 ef75b67b67676ae5b8931902cbc8c0c2cc72c0d3 
   core/src/main/scala/kafka/server/KafkaHealthcheck.scala 
 4acdd70fe9c1ee78d6510741006c2ece65450671 
   core/src/main/scala/kafka/server/KafkaServer.scala 
 c22e51e0412843ec993721ad3230824c0aadd2ba 
   core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala 
 19df757d75fdbb3ff0b434b6cb10338ff5cc32da 
   core/src/main/scala/kafka/tools/GetOffsetShell.scala 
 fba652e3716a67b04431fc46790ad255201b639f 
   core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala 
 91f072816418040a396a0cad26bc889f539dadd6 
   core/src/main/scala/kafka/tools/SimpleConsumerShell.scala 
 747e07280cce72d621acbc771337b909a9b2487e 
   core/src/main/scala/kafka/utils/ZkUtils.scala 
 fcbe269b6057b45793ea95f357890d5d6922e8d4 
   core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala 
 fcd5eee09fc1831e7fac4c3f1151e9708dc6f5f1 
   core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala 
 35dc071b1056e775326981573c9618d8046e601d

Re: Review Request 22131: Patch for KAFKA-1477

2014-06-06 Thread Rajasekar Elango


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22131/#review44916
---

Ship it!


Looks like the changes we did on this commit 
https://github.com/relango/kafka/commit/0ec255e94973df995c43818bb09d1246440aded9
 is not included in patch. We made those changes to fix BadVersion Error thrown 
by zookeeper. Hopefully they don't happen anymore with latest code in trunk. If 
it comes back we can create another patch since it is not related to security. 
So ok with not including it.

- Rajasekar Elango


On June 3, 2014, 10:53 a.m., Ivan Lyutov wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/22131/
 ---
 
 (Updated June 3, 2014, 10:53 a.m.)
 
 
 Review request for kafka.
 
 
 Bugs: KAFKA-1477
 https://issues.apache.org/jira/browse/KAFKA-1477
 
 
 Repository: kafka
 
 
 Description
 ---
 
 Updated according to requested changes: refactoring, minor edits.
 
 
 Reverted gradle version
 
 
 Added SSL for Kafka
 
 Minor fixes, cleanup
 
 Refactoring
 
 Fixed tests compilation error.
 
 
 Diffs
 -
 
   config/client.keystore PRE-CREATION 
   config/client.public-key PRE-CREATION 
   config/client.security.properties PRE-CREATION 
   config/consumer.properties 7343cbc28cf8b8de3f096d09c2be955bea73164f 
   config/producer.properties 39d65d7c6c21f4fccd7af89be6ca12a088d5dd98 
   config/server.keystore PRE-CREATION 
   config/server.properties c9e923aed8551e0797b1ea6f69628b277faf8f48 
   config/server.public-key PRE-CREATION 
   config/server.security.properties PRE-CREATION 
   core/src/main/scala/kafka/api/FetchRequest.scala 
 a8b73acd1a813284744359e8434cb52d22063c99 
   core/src/main/scala/kafka/client/ClientUtils.scala 
 ba5fbdcd9e60f953575e529325caf4c41e22f22d 
   core/src/main/scala/kafka/cluster/Broker.scala 
 9407ed21fbbd57edeecd888edc32bea6a05d95b3 
   core/src/main/scala/kafka/common/UnknownKeyStoreException.scala 
 PRE-CREATION 
   core/src/main/scala/kafka/consumer/ConsoleConsumer.scala 
 1a16c691683dda0c53f316e3c4797ea38e776574 
   core/src/main/scala/kafka/consumer/ConsumerConfig.scala 
 1cf2f62ba02e4aa66bfa7575865e5d57baf82212 
   core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala 
 b9e2bea7b442a19bcebd1b350d39541a8c9dd068 
   core/src/main/scala/kafka/consumer/SimpleConsumer.scala 
 0e64632210385ef63c2ad3445b55ac4f37a63df2 
   core/src/main/scala/kafka/controller/ControllerChannelManager.scala 
 8763968fbff697e4c5c98ab1274627c192a4d26a 
   core/src/main/scala/kafka/network/BlockingChannel.scala 
 eb7bb14d94cb3648c06d4de36a3b34aacbde4556 
   core/src/main/scala/kafka/network/SocketServer.scala 
 4976d9c3a66bc965f5870a0736e21c7b32650bab 
   core/src/main/scala/kafka/network/security/AuthConfig.scala PRE-CREATION 
   core/src/main/scala/kafka/network/security/KeyStores.scala PRE-CREATION 
   core/src/main/scala/kafka/network/security/SSLSocketChannel.scala 
 PRE-CREATION 
   core/src/main/scala/kafka/network/security/SecureAuth.scala PRE-CREATION 
   core/src/main/scala/kafka/network/security/store/JKSInitializer.scala 
 PRE-CREATION 
   core/src/main/scala/kafka/producer/ConsoleProducer.scala 
 a2af988d99a94a20291d6a2dc9bec73197f1b756 
   core/src/main/scala/kafka/producer/ProducerConfig.scala 
 3cdf23dce3407f1770b9c6543e3a8ae8ab3ff255 
   core/src/main/scala/kafka/producer/ProducerPool.scala 
 43df70bb461dd3e385e6b20396adef3c4016a3fc 
   core/src/main/scala/kafka/producer/SyncProducer.scala 
 489f0077512d9a69be81649c490274964290fa40 
   core/src/main/scala/kafka/producer/SyncProducerConfig.scala 
 69b2d0c11bb1412ce76d566f285333c806be301a 
   core/src/main/scala/kafka/server/AbstractFetcherThread.scala 
 3b15254f32252cf824d7a292889ac7662d73ada1 
   core/src/main/scala/kafka/server/KafkaConfig.scala 
 ef75b67b67676ae5b8931902cbc8c0c2cc72c0d3 
   core/src/main/scala/kafka/server/KafkaHealthcheck.scala 
 4acdd70fe9c1ee78d6510741006c2ece65450671 
   core/src/main/scala/kafka/server/KafkaServer.scala 
 c22e51e0412843ec993721ad3230824c0aadd2ba 
   core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala 
 19df757d75fdbb3ff0b434b6cb10338ff5cc32da 
   core/src/main/scala/kafka/tools/GetOffsetShell.scala 
 fba652e3716a67b04431fc46790ad255201b639f 
   core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala 
 91f072816418040a396a0cad26bc889f539dadd6 
   core/src/main/scala/kafka/tools/SimpleConsumerShell.scala 
 747e07280cce72d621acbc771337b909a9b2487e 
   core/src/main/scala/kafka/utils/ZkUtils.scala 
 fcbe269b6057b45793ea95f357890d5d6922e8d4 
   core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala 
 fcd5eee09fc1831e7fac4c3f1151e9708dc6f5f1 
   core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala 
 35dc071b1056e775326981573c9618d8046e601d

Re: Review Request 22131: Patch for KAFKA-1477

2014-06-06 Thread Rajasekar Elango


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22131/#review44927
---



config/server.properties
https://reviews.apache.org/r/22131/#comment79513

Should we secure property to false to make kafka run in non-secure mode by 
default so it won't impact existing users.


- Rajasekar Elango


On June 3, 2014, 10:53 a.m., Ivan Lyutov wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/22131/
 ---
 
 (Updated June 3, 2014, 10:53 a.m.)
 
 
 Review request for kafka.
 
 
 Bugs: KAFKA-1477
 https://issues.apache.org/jira/browse/KAFKA-1477
 
 
 Repository: kafka
 
 
 Description
 ---
 
 Updated according to requested changes: refactoring, minor edits.
 
 
 Reverted gradle version
 
 
 Added SSL for Kafka
 
 Minor fixes, cleanup
 
 Refactoring
 
 Fixed tests compilation error.
 
 
 Diffs
 -
 
   config/client.keystore PRE-CREATION 
   config/client.public-key PRE-CREATION 
   config/client.security.properties PRE-CREATION 
   config/consumer.properties 7343cbc28cf8b8de3f096d09c2be955bea73164f 
   config/producer.properties 39d65d7c6c21f4fccd7af89be6ca12a088d5dd98 
   config/server.keystore PRE-CREATION 
   config/server.properties c9e923aed8551e0797b1ea6f69628b277faf8f48 
   config/server.public-key PRE-CREATION 
   config/server.security.properties PRE-CREATION 
   core/src/main/scala/kafka/api/FetchRequest.scala 
 a8b73acd1a813284744359e8434cb52d22063c99 
   core/src/main/scala/kafka/client/ClientUtils.scala 
 ba5fbdcd9e60f953575e529325caf4c41e22f22d 
   core/src/main/scala/kafka/cluster/Broker.scala 
 9407ed21fbbd57edeecd888edc32bea6a05d95b3 
   core/src/main/scala/kafka/common/UnknownKeyStoreException.scala 
 PRE-CREATION 
   core/src/main/scala/kafka/consumer/ConsoleConsumer.scala 
 1a16c691683dda0c53f316e3c4797ea38e776574 
   core/src/main/scala/kafka/consumer/ConsumerConfig.scala 
 1cf2f62ba02e4aa66bfa7575865e5d57baf82212 
   core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala 
 b9e2bea7b442a19bcebd1b350d39541a8c9dd068 
   core/src/main/scala/kafka/consumer/SimpleConsumer.scala 
 0e64632210385ef63c2ad3445b55ac4f37a63df2 
   core/src/main/scala/kafka/controller/ControllerChannelManager.scala 
 8763968fbff697e4c5c98ab1274627c192a4d26a 
   core/src/main/scala/kafka/network/BlockingChannel.scala 
 eb7bb14d94cb3648c06d4de36a3b34aacbde4556 
   core/src/main/scala/kafka/network/SocketServer.scala 
 4976d9c3a66bc965f5870a0736e21c7b32650bab 
   core/src/main/scala/kafka/network/security/AuthConfig.scala PRE-CREATION 
   core/src/main/scala/kafka/network/security/KeyStores.scala PRE-CREATION 
   core/src/main/scala/kafka/network/security/SSLSocketChannel.scala 
 PRE-CREATION 
   core/src/main/scala/kafka/network/security/SecureAuth.scala PRE-CREATION 
   core/src/main/scala/kafka/network/security/store/JKSInitializer.scala 
 PRE-CREATION 
   core/src/main/scala/kafka/producer/ConsoleProducer.scala 
 a2af988d99a94a20291d6a2dc9bec73197f1b756 
   core/src/main/scala/kafka/producer/ProducerConfig.scala 
 3cdf23dce3407f1770b9c6543e3a8ae8ab3ff255 
   core/src/main/scala/kafka/producer/ProducerPool.scala 
 43df70bb461dd3e385e6b20396adef3c4016a3fc 
   core/src/main/scala/kafka/producer/SyncProducer.scala 
 489f0077512d9a69be81649c490274964290fa40 
   core/src/main/scala/kafka/producer/SyncProducerConfig.scala 
 69b2d0c11bb1412ce76d566f285333c806be301a 
   core/src/main/scala/kafka/server/AbstractFetcherThread.scala 
 3b15254f32252cf824d7a292889ac7662d73ada1 
   core/src/main/scala/kafka/server/KafkaConfig.scala 
 ef75b67b67676ae5b8931902cbc8c0c2cc72c0d3 
   core/src/main/scala/kafka/server/KafkaHealthcheck.scala 
 4acdd70fe9c1ee78d6510741006c2ece65450671 
   core/src/main/scala/kafka/server/KafkaServer.scala 
 c22e51e0412843ec993721ad3230824c0aadd2ba 
   core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala 
 19df757d75fdbb3ff0b434b6cb10338ff5cc32da 
   core/src/main/scala/kafka/tools/GetOffsetShell.scala 
 fba652e3716a67b04431fc46790ad255201b639f 
   core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala 
 91f072816418040a396a0cad26bc889f539dadd6 
   core/src/main/scala/kafka/tools/SimpleConsumerShell.scala 
 747e07280cce72d621acbc771337b909a9b2487e 
   core/src/main/scala/kafka/utils/ZkUtils.scala 
 fcbe269b6057b45793ea95f357890d5d6922e8d4 
   core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala 
 fcd5eee09fc1831e7fac4c3f1151e9708dc6f5f1 
   core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala 
 35dc071b1056e775326981573c9618d8046e601d 
   core/src/test/scala/unit/kafka/network/SocketServerTest.scala 
 62fb02cf02d3876b9804d756c4bf8514554cc836 
   core/src/test/scala/unit/kafka/utils/TestUtils.scala 
 4da0f2c245f75ff0dcab4ecf0af085ab9f8da1bb

Re: Review Request 22131: Patch for KAFKA-1477

2014-06-05 Thread Rajasekar Elango


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22131/#review44855
---


Looks like change to UpdateOffsetsInZK.scala 
(https://github.com/relango/kafka/compare/0.8-snapshot...kafka_security#diff-43)
 is not included in the patch (=

- Rajasekar Elango


On June 3, 2014, 10:53 a.m., Ivan Lyutov wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/22131/
 ---
 
 (Updated June 3, 2014, 10:53 a.m.)
 
 
 Review request for kafka.
 
 
 Bugs: KAFKA-1477
 https://issues.apache.org/jira/browse/KAFKA-1477
 
 
 Repository: kafka
 
 
 Description
 ---
 
 Updated according to requested changes: refactoring, minor edits.
 
 
 Reverted gradle version
 
 
 Added SSL for Kafka
 
 Minor fixes, cleanup
 
 Refactoring
 
 Fixed tests compilation error.
 
 
 Diffs
 -
 
   config/client.keystore PRE-CREATION 
   config/client.public-key PRE-CREATION 
   config/client.security.properties PRE-CREATION 
   config/consumer.properties 7343cbc28cf8b8de3f096d09c2be955bea73164f 
   config/producer.properties 39d65d7c6c21f4fccd7af89be6ca12a088d5dd98 
   config/server.keystore PRE-CREATION 
   config/server.properties c9e923aed8551e0797b1ea6f69628b277faf8f48 
   config/server.public-key PRE-CREATION 
   config/server.security.properties PRE-CREATION 
   core/src/main/scala/kafka/api/FetchRequest.scala 
 a8b73acd1a813284744359e8434cb52d22063c99 
   core/src/main/scala/kafka/client/ClientUtils.scala 
 ba5fbdcd9e60f953575e529325caf4c41e22f22d 
   core/src/main/scala/kafka/cluster/Broker.scala 
 9407ed21fbbd57edeecd888edc32bea6a05d95b3 
   core/src/main/scala/kafka/common/UnknownKeyStoreException.scala 
 PRE-CREATION 
   core/src/main/scala/kafka/consumer/ConsoleConsumer.scala 
 1a16c691683dda0c53f316e3c4797ea38e776574 
   core/src/main/scala/kafka/consumer/ConsumerConfig.scala 
 1cf2f62ba02e4aa66bfa7575865e5d57baf82212 
   core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala 
 b9e2bea7b442a19bcebd1b350d39541a8c9dd068 
   core/src/main/scala/kafka/consumer/SimpleConsumer.scala 
 0e64632210385ef63c2ad3445b55ac4f37a63df2 
   core/src/main/scala/kafka/controller/ControllerChannelManager.scala 
 8763968fbff697e4c5c98ab1274627c192a4d26a 
   core/src/main/scala/kafka/network/BlockingChannel.scala 
 eb7bb14d94cb3648c06d4de36a3b34aacbde4556 
   core/src/main/scala/kafka/network/SocketServer.scala 
 4976d9c3a66bc965f5870a0736e21c7b32650bab 
   core/src/main/scala/kafka/network/security/AuthConfig.scala PRE-CREATION 
   core/src/main/scala/kafka/network/security/KeyStores.scala PRE-CREATION 
   core/src/main/scala/kafka/network/security/SSLSocketChannel.scala 
 PRE-CREATION 
   core/src/main/scala/kafka/network/security/SecureAuth.scala PRE-CREATION 
   core/src/main/scala/kafka/network/security/store/JKSInitializer.scala 
 PRE-CREATION 
   core/src/main/scala/kafka/producer/ConsoleProducer.scala 
 a2af988d99a94a20291d6a2dc9bec73197f1b756 
   core/src/main/scala/kafka/producer/ProducerConfig.scala 
 3cdf23dce3407f1770b9c6543e3a8ae8ab3ff255 
   core/src/main/scala/kafka/producer/ProducerPool.scala 
 43df70bb461dd3e385e6b20396adef3c4016a3fc 
   core/src/main/scala/kafka/producer/SyncProducer.scala 
 489f0077512d9a69be81649c490274964290fa40 
   core/src/main/scala/kafka/producer/SyncProducerConfig.scala 
 69b2d0c11bb1412ce76d566f285333c806be301a 
   core/src/main/scala/kafka/server/AbstractFetcherThread.scala 
 3b15254f32252cf824d7a292889ac7662d73ada1 
   core/src/main/scala/kafka/server/KafkaConfig.scala 
 ef75b67b67676ae5b8931902cbc8c0c2cc72c0d3 
   core/src/main/scala/kafka/server/KafkaHealthcheck.scala 
 4acdd70fe9c1ee78d6510741006c2ece65450671 
   core/src/main/scala/kafka/server/KafkaServer.scala 
 c22e51e0412843ec993721ad3230824c0aadd2ba 
   core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala 
 19df757d75fdbb3ff0b434b6cb10338ff5cc32da 
   core/src/main/scala/kafka/tools/GetOffsetShell.scala 
 fba652e3716a67b04431fc46790ad255201b639f 
   core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala 
 91f072816418040a396a0cad26bc889f539dadd6 
   core/src/main/scala/kafka/tools/SimpleConsumerShell.scala 
 747e07280cce72d621acbc771337b909a9b2487e 
   core/src/main/scala/kafka/utils/ZkUtils.scala 
 fcbe269b6057b45793ea95f357890d5d6922e8d4 
   core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala 
 fcd5eee09fc1831e7fac4c3f1151e9708dc6f5f1 
   core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala 
 35dc071b1056e775326981573c9618d8046e601d 
   core/src/test/scala/unit/kafka/network/SocketServerTest.scala 
 62fb02cf02d3876b9804d756c4bf8514554cc836 
   core/src/test/scala/unit/kafka/utils/TestUtils.scala 
 4da0f2c245f75ff0dcab4ecf0af085ab9f8da1bb 
 
 Diff:

Re: Review Request 22131: Patch for KAFKA-1477

2014-06-03 Thread Ivan Lyutov



 On June 3, 2014, 3:14 a.m., Joe Stein wrote:
  core/src/main/scala/kafka/network/BlockingChannel.scala, line 80
  https://reviews.apache.org/r/22131/diff/3/?file=601681#file601681line80
 
  is this change and the ones below it, are they really required?

Yes. Otherwise, there will be an exception thrown on consumer close.


- Ivan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22131/#review44591
---


On June 3, 2014, 10:53 a.m., Ivan Lyutov wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/22131/
 ---
 
 (Updated June 3, 2014, 10:53 a.m.)
 
 
 Review request for kafka.
 
 
 Bugs: KAFKA-1477
 https://issues.apache.org/jira/browse/KAFKA-1477
 
 
 Repository: kafka
 
 
 Description
 ---
 
 Updated according to requested changes: refactoring, minor edits.
 
 
 Reverted gradle version
 
 
 Added SSL for Kafka
 
 Minor fixes, cleanup
 
 Refactoring
 
 Fixed tests compilation error.
 
 
 Diffs
 -
 
   config/client.keystore PRE-CREATION 
   config/client.public-key PRE-CREATION 
   config/client.security.properties PRE-CREATION 
   config/consumer.properties 7343cbc28cf8b8de3f096d09c2be955bea73164f 
   config/producer.properties 39d65d7c6c21f4fccd7af89be6ca12a088d5dd98 
   config/server.keystore PRE-CREATION 
   config/server.properties c9e923aed8551e0797b1ea6f69628b277faf8f48 
   config/server.public-key PRE-CREATION 
   config/server.security.properties PRE-CREATION 
   core/src/main/scala/kafka/api/FetchRequest.scala 
 a8b73acd1a813284744359e8434cb52d22063c99 
   core/src/main/scala/kafka/client/ClientUtils.scala 
 ba5fbdcd9e60f953575e529325caf4c41e22f22d 
   core/src/main/scala/kafka/cluster/Broker.scala 
 9407ed21fbbd57edeecd888edc32bea6a05d95b3 
   core/src/main/scala/kafka/common/UnknownKeyStoreException.scala 
 PRE-CREATION 
   core/src/main/scala/kafka/consumer/ConsoleConsumer.scala 
 1a16c691683dda0c53f316e3c4797ea38e776574 
   core/src/main/scala/kafka/consumer/ConsumerConfig.scala 
 1cf2f62ba02e4aa66bfa7575865e5d57baf82212 
   core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala 
 b9e2bea7b442a19bcebd1b350d39541a8c9dd068 
   core/src/main/scala/kafka/consumer/SimpleConsumer.scala 
 0e64632210385ef63c2ad3445b55ac4f37a63df2 
   core/src/main/scala/kafka/controller/ControllerChannelManager.scala 
 8763968fbff697e4c5c98ab1274627c192a4d26a 
   core/src/main/scala/kafka/network/BlockingChannel.scala 
 eb7bb14d94cb3648c06d4de36a3b34aacbde4556 
   core/src/main/scala/kafka/network/SocketServer.scala 
 4976d9c3a66bc965f5870a0736e21c7b32650bab 
   core/src/main/scala/kafka/network/security/AuthConfig.scala PRE-CREATION 
   core/src/main/scala/kafka/network/security/KeyStores.scala PRE-CREATION 
   core/src/main/scala/kafka/network/security/SSLSocketChannel.scala 
 PRE-CREATION 
   core/src/main/scala/kafka/network/security/SecureAuth.scala PRE-CREATION 
   core/src/main/scala/kafka/network/security/store/JKSInitializer.scala 
 PRE-CREATION 
   core/src/main/scala/kafka/producer/ConsoleProducer.scala 
 a2af988d99a94a20291d6a2dc9bec73197f1b756 
   core/src/main/scala/kafka/producer/ProducerConfig.scala 
 3cdf23dce3407f1770b9c6543e3a8ae8ab3ff255 
   core/src/main/scala/kafka/producer/ProducerPool.scala 
 43df70bb461dd3e385e6b20396adef3c4016a3fc 
   core/src/main/scala/kafka/producer/SyncProducer.scala 
 489f0077512d9a69be81649c490274964290fa40 
   core/src/main/scala/kafka/producer/SyncProducerConfig.scala 
 69b2d0c11bb1412ce76d566f285333c806be301a 
   core/src/main/scala/kafka/server/AbstractFetcherThread.scala 
 3b15254f32252cf824d7a292889ac7662d73ada1 
   core/src/main/scala/kafka/server/KafkaConfig.scala 
 ef75b67b67676ae5b8931902cbc8c0c2cc72c0d3 
   core/src/main/scala/kafka/server/KafkaHealthcheck.scala 
 4acdd70fe9c1ee78d6510741006c2ece65450671 
   core/src/main/scala/kafka/server/KafkaServer.scala 
 c22e51e0412843ec993721ad3230824c0aadd2ba 
   core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala 
 19df757d75fdbb3ff0b434b6cb10338ff5cc32da 
   core/src/main/scala/kafka/tools/GetOffsetShell.scala 
 fba652e3716a67b04431fc46790ad255201b639f 
   core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala 
 91f072816418040a396a0cad26bc889f539dadd6 
   core/src/main/scala/kafka/tools/SimpleConsumerShell.scala 
 747e07280cce72d621acbc771337b909a9b2487e 
   core/src/main/scala/kafka/utils/ZkUtils.scala 
 fcbe269b6057b45793ea95f357890d5d6922e8d4 
   core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala 
 fcd5eee09fc1831e7fac4c3f1151e9708dc6f5f1 
   core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala 
 35dc071b1056e775326981573c9618d8046e601d 
   core/src/test/scala/unit/kafka/network/SocketServerTest.scala

Re: Review Request 22131: Patch for KAFKA-1477

2014-06-03 Thread Joe Stein


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22131/#review44618
---



core/src/main/scala/kafka/network/BlockingChannel.scala
https://reviews.apache.org/r/22131/#comment79038

ok, then can you make that log line info instead of debug please.  thanks!


- Joe Stein


On June 3, 2014, 10:53 a.m., Ivan Lyutov wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/22131/
 ---
 
 (Updated June 3, 2014, 10:53 a.m.)
 
 
 Review request for kafka.
 
 
 Bugs: KAFKA-1477
 https://issues.apache.org/jira/browse/KAFKA-1477
 
 
 Repository: kafka
 
 
 Description
 ---
 
 Updated according to requested changes: refactoring, minor edits.
 
 
 Reverted gradle version
 
 
 Added SSL for Kafka
 
 Minor fixes, cleanup
 
 Refactoring
 
 Fixed tests compilation error.
 
 
 Diffs
 -
 
   config/client.keystore PRE-CREATION 
   config/client.public-key PRE-CREATION 
   config/client.security.properties PRE-CREATION 
   config/consumer.properties 7343cbc28cf8b8de3f096d09c2be955bea73164f 
   config/producer.properties 39d65d7c6c21f4fccd7af89be6ca12a088d5dd98 
   config/server.keystore PRE-CREATION 
   config/server.properties c9e923aed8551e0797b1ea6f69628b277faf8f48 
   config/server.public-key PRE-CREATION 
   config/server.security.properties PRE-CREATION 
   core/src/main/scala/kafka/api/FetchRequest.scala 
 a8b73acd1a813284744359e8434cb52d22063c99 
   core/src/main/scala/kafka/client/ClientUtils.scala 
 ba5fbdcd9e60f953575e529325caf4c41e22f22d 
   core/src/main/scala/kafka/cluster/Broker.scala 
 9407ed21fbbd57edeecd888edc32bea6a05d95b3 
   core/src/main/scala/kafka/common/UnknownKeyStoreException.scala 
 PRE-CREATION 
   core/src/main/scala/kafka/consumer/ConsoleConsumer.scala 
 1a16c691683dda0c53f316e3c4797ea38e776574 
   core/src/main/scala/kafka/consumer/ConsumerConfig.scala 
 1cf2f62ba02e4aa66bfa7575865e5d57baf82212 
   core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala 
 b9e2bea7b442a19bcebd1b350d39541a8c9dd068 
   core/src/main/scala/kafka/consumer/SimpleConsumer.scala 
 0e64632210385ef63c2ad3445b55ac4f37a63df2 
   core/src/main/scala/kafka/controller/ControllerChannelManager.scala 
 8763968fbff697e4c5c98ab1274627c192a4d26a 
   core/src/main/scala/kafka/network/BlockingChannel.scala 
 eb7bb14d94cb3648c06d4de36a3b34aacbde4556 
   core/src/main/scala/kafka/network/SocketServer.scala 
 4976d9c3a66bc965f5870a0736e21c7b32650bab 
   core/src/main/scala/kafka/network/security/AuthConfig.scala PRE-CREATION 
   core/src/main/scala/kafka/network/security/KeyStores.scala PRE-CREATION 
   core/src/main/scala/kafka/network/security/SSLSocketChannel.scala 
 PRE-CREATION 
   core/src/main/scala/kafka/network/security/SecureAuth.scala PRE-CREATION 
   core/src/main/scala/kafka/network/security/store/JKSInitializer.scala 
 PRE-CREATION 
   core/src/main/scala/kafka/producer/ConsoleProducer.scala 
 a2af988d99a94a20291d6a2dc9bec73197f1b756 
   core/src/main/scala/kafka/producer/ProducerConfig.scala 
 3cdf23dce3407f1770b9c6543e3a8ae8ab3ff255 
   core/src/main/scala/kafka/producer/ProducerPool.scala 
 43df70bb461dd3e385e6b20396adef3c4016a3fc 
   core/src/main/scala/kafka/producer/SyncProducer.scala 
 489f0077512d9a69be81649c490274964290fa40 
   core/src/main/scala/kafka/producer/SyncProducerConfig.scala 
 69b2d0c11bb1412ce76d566f285333c806be301a 
   core/src/main/scala/kafka/server/AbstractFetcherThread.scala 
 3b15254f32252cf824d7a292889ac7662d73ada1 
   core/src/main/scala/kafka/server/KafkaConfig.scala 
 ef75b67b67676ae5b8931902cbc8c0c2cc72c0d3 
   core/src/main/scala/kafka/server/KafkaHealthcheck.scala 
 4acdd70fe9c1ee78d6510741006c2ece65450671 
   core/src/main/scala/kafka/server/KafkaServer.scala 
 c22e51e0412843ec993721ad3230824c0aadd2ba 
   core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala 
 19df757d75fdbb3ff0b434b6cb10338ff5cc32da 
   core/src/main/scala/kafka/tools/GetOffsetShell.scala 
 fba652e3716a67b04431fc46790ad255201b639f 
   core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala 
 91f072816418040a396a0cad26bc889f539dadd6 
   core/src/main/scala/kafka/tools/SimpleConsumerShell.scala 
 747e07280cce72d621acbc771337b909a9b2487e 
   core/src/main/scala/kafka/utils/ZkUtils.scala 
 fcbe269b6057b45793ea95f357890d5d6922e8d4 
   core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala 
 fcd5eee09fc1831e7fac4c3f1151e9708dc6f5f1 
   core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala 
 35dc071b1056e775326981573c9618d8046e601d 
   core/src/test/scala/unit/kafka/network/SocketServerTest.scala 
 62fb02cf02d3876b9804d756c4bf8514554cc836 
   core/src/test/scala/unit/kafka/utils/TestUtils.scala 
 4da0f2c245f75ff0dcab4ecf0af085ab9f8da1bb 
 
 Diff:

Re: Review Request 22131: Patch for KAFKA-1477

2014-06-03 Thread Joe Stein



 On June 3, 2014, 12:37 p.m., Joe Stein wrote:
  core/src/main/scala/kafka/network/BlockingChannel.scala, line 80
  https://reviews.apache.org/r/22131/diff/3/?file=601681#file601681line80
 
  ok, then can you make that log line info instead of debug please.  
  thanks!

never mind, keep it as debug please


- Joe


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22131/#review44618
---


On June 3, 2014, 10:53 a.m., Ivan Lyutov wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/22131/
 ---
 
 (Updated June 3, 2014, 10:53 a.m.)
 
 
 Review request for kafka.
 
 
 Bugs: KAFKA-1477
 https://issues.apache.org/jira/browse/KAFKA-1477
 
 
 Repository: kafka
 
 
 Description
 ---
 
 Updated according to requested changes: refactoring, minor edits.
 
 
 Reverted gradle version
 
 
 Added SSL for Kafka
 
 Minor fixes, cleanup
 
 Refactoring
 
 Fixed tests compilation error.
 
 
 Diffs
 -
 
   config/client.keystore PRE-CREATION 
   config/client.public-key PRE-CREATION 
   config/client.security.properties PRE-CREATION 
   config/consumer.properties 7343cbc28cf8b8de3f096d09c2be955bea73164f 
   config/producer.properties 39d65d7c6c21f4fccd7af89be6ca12a088d5dd98 
   config/server.keystore PRE-CREATION 
   config/server.properties c9e923aed8551e0797b1ea6f69628b277faf8f48 
   config/server.public-key PRE-CREATION 
   config/server.security.properties PRE-CREATION 
   core/src/main/scala/kafka/api/FetchRequest.scala 
 a8b73acd1a813284744359e8434cb52d22063c99 
   core/src/main/scala/kafka/client/ClientUtils.scala 
 ba5fbdcd9e60f953575e529325caf4c41e22f22d 
   core/src/main/scala/kafka/cluster/Broker.scala 
 9407ed21fbbd57edeecd888edc32bea6a05d95b3 
   core/src/main/scala/kafka/common/UnknownKeyStoreException.scala 
 PRE-CREATION 
   core/src/main/scala/kafka/consumer/ConsoleConsumer.scala 
 1a16c691683dda0c53f316e3c4797ea38e776574 
   core/src/main/scala/kafka/consumer/ConsumerConfig.scala 
 1cf2f62ba02e4aa66bfa7575865e5d57baf82212 
   core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala 
 b9e2bea7b442a19bcebd1b350d39541a8c9dd068 
   core/src/main/scala/kafka/consumer/SimpleConsumer.scala 
 0e64632210385ef63c2ad3445b55ac4f37a63df2 
   core/src/main/scala/kafka/controller/ControllerChannelManager.scala 
 8763968fbff697e4c5c98ab1274627c192a4d26a 
   core/src/main/scala/kafka/network/BlockingChannel.scala 
 eb7bb14d94cb3648c06d4de36a3b34aacbde4556 
   core/src/main/scala/kafka/network/SocketServer.scala 
 4976d9c3a66bc965f5870a0736e21c7b32650bab 
   core/src/main/scala/kafka/network/security/AuthConfig.scala PRE-CREATION 
   core/src/main/scala/kafka/network/security/KeyStores.scala PRE-CREATION 
   core/src/main/scala/kafka/network/security/SSLSocketChannel.scala 
 PRE-CREATION 
   core/src/main/scala/kafka/network/security/SecureAuth.scala PRE-CREATION 
   core/src/main/scala/kafka/network/security/store/JKSInitializer.scala 
 PRE-CREATION 
   core/src/main/scala/kafka/producer/ConsoleProducer.scala 
 a2af988d99a94a20291d6a2dc9bec73197f1b756 
   core/src/main/scala/kafka/producer/ProducerConfig.scala 
 3cdf23dce3407f1770b9c6543e3a8ae8ab3ff255 
   core/src/main/scala/kafka/producer/ProducerPool.scala 
 43df70bb461dd3e385e6b20396adef3c4016a3fc 
   core/src/main/scala/kafka/producer/SyncProducer.scala 
 489f0077512d9a69be81649c490274964290fa40 
   core/src/main/scala/kafka/producer/SyncProducerConfig.scala 
 69b2d0c11bb1412ce76d566f285333c806be301a 
   core/src/main/scala/kafka/server/AbstractFetcherThread.scala 
 3b15254f32252cf824d7a292889ac7662d73ada1 
   core/src/main/scala/kafka/server/KafkaConfig.scala 
 ef75b67b67676ae5b8931902cbc8c0c2cc72c0d3 
   core/src/main/scala/kafka/server/KafkaHealthcheck.scala 
 4acdd70fe9c1ee78d6510741006c2ece65450671 
   core/src/main/scala/kafka/server/KafkaServer.scala 
 c22e51e0412843ec993721ad3230824c0aadd2ba 
   core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala 
 19df757d75fdbb3ff0b434b6cb10338ff5cc32da 
   core/src/main/scala/kafka/tools/GetOffsetShell.scala 
 fba652e3716a67b04431fc46790ad255201b639f 
   core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala 
 91f072816418040a396a0cad26bc889f539dadd6 
   core/src/main/scala/kafka/tools/SimpleConsumerShell.scala 
 747e07280cce72d621acbc771337b909a9b2487e 
   core/src/main/scala/kafka/utils/ZkUtils.scala 
 fcbe269b6057b45793ea95f357890d5d6922e8d4 
   core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala 
 fcd5eee09fc1831e7fac4c3f1151e9708dc6f5f1 
   core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala 
 35dc071b1056e775326981573c9618d8046e601d 
   core/src/test/scala/unit/kafka/network/SocketServerTest.scala 
 62fb02cf02d3876b9804d756c4bf8514554cc836

Review Request 22131: Patch for KAFKA-1477

2014-06-02 Thread Ivan Lyutov


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22131/
---

Review request for kafka.


Bugs: KAFKA-1477
https://issues.apache.org/jira/browse/KAFKA-1477


Repository: kafka


Description
---

Added SSL for Kafka

Minor fixes, cleanup

Refactoring

Fixed tests compilation error.

KAFKA-924. Specify console consumer properties via a single --property command 
line parameter; reviewed by Neha Narkhede


KAFKA-1459 kafka.tools.ConsumerOffsetChecker throws NoNodeException; reviewed 
by Neha Narkhede


KAFKA-1444 kafka.javaapi.TopicMetadata and PartitionMetadata doesn't forward 
the toString method; reviewed by Neha Narkhede


KAFKA-1456 Add LZ4 and LZ4C as a compression codec patch by James Oliver 
reviewed by Joe Stein


KAFKA-1446 Consumer metrics for rebalance; reviewed by Neha Narkhede and Joel 
Koshy


KAFKA-1298 Controlled shutdown tool doesn't seem to work out of the box; 
reviewed by Neha Narkhede


KAFKA-1328 follow up: Updated javadoc


KAFKA-1328 New consumer APIs; reviewed by Jun Rao and Guozhang Wang


kafka-1453 (2nd follow-up); Add a channel queue jmx in Mirror Maker;  patched 
by Guozhang Wang; reviewed by Jun Rao


kafka-1453 (follow-up); Add a channel queue jmx in Mirror Maker;  patched by 
Guozhang Wang; reviewed by Jun Rao


kafka-1453; Add a channel queue jmx in Mirror Maker;  patched by Guozhang Wang; 
reviewed by Jun Rao


KAFKA-1179 createMessageStreams() in javaapi.ZookeeperConsumerConnector does 
not throw; reviewed by Neha Narkhede


KAFKA-1445 Send all partitions, regardless of how full, whenever we are sending 
a request to a broker. Patch from Guozhang.


KAFKA-1431 ConsoleConsumer - Option to clean zk consumer path;reviewed by Neha 
Narkhede and Jun Rao


KAFKA-1437; Consumer metadata response should include (empty) coordinator 
information if the coordinator is unavailable; reviewed by Neha Narkhede and 
Guozhang Wang.


kafka-1396; fix transient unit test 
ProducerFailureHandlingTest.testBrokerFailure;  patched by Guozhang Wang; 
reviewed by Jun Rao


KAFKA-1442 RBTools post-review is deprecated; reviewed by Neha Narkhede


kafka-1432; followup patch to enable new producer in system test;  patched by 
Guozhang Wang; reviewed by Neha Narkhede, Jun Rao


KAFKA-1432 followup - Fixing the shutdown sequence furthermore; reviewed by 
Neha Narkhede


kafka-1384; Log Broker state; followup commit to add the missing new file


kafka-1384; Log Broker state; patched by Timothy Chen; reviewed by Joel Koshy 
and Jun Rao


kafka-1397; delete topic is not working; patched by Timothy Chen; reviewed by 
Neha Narkhede and Jun Rao


KAFKA-1432 Make num.producerThreads configurable on new MirrrorMaker; reviewed 
by Neha Narkhede, Jun Rao


kafka-1146; toString() on KafkaStream gets stuck indefinitely; patched by Arup 
Malakar; reviewed by Jun Rao


kafka-1412; transient unit test failure in 
ProducerSendTest.testAutoCreateTopic; patched by Jun Rao; reviewed by Guozhang 
Wang and Neha Narkhede


KAFKA-1425; Expose metric for LogStartOffset; reviewed by Joel Koshy and Jun Rao


kafka-1433; transient unit test failure in ZookeeperConsumerConnectorTest; 
patched by Jun Rao; reviewed by Guozhang Wang


kafka-1400; transient unit test failure in SocketServerTest; patched by Neha 
Narkhede; reviewed by Guozhang and Jun Rao


KAFKA-1428 Ensure we close the file handle when reading the config.


kafka-1383; transient unit test failure in SocketServerTest; patched by Jun 
Rao; reviewed by Guozhang Wang and Neha Narkhede


kafka-1424; (followup patch) transient unit test failure in 
testSendWithDeadBroker; patched by Jun Rao; reviewed by Guozhang Wang and Neha 
Narkhede


kafka-1395; fix unit tests in AutoOffsetResetTest; patched by Guozhang Wang; 
reviewed by Neha Narkhede, Jun Rao


kafka-1392; all TestUtiles.waitUntilTrue() should throw an exception if the 
return value is false; patched by Jun Rao; reviewed by Guozhang Wang, Neha 
Narkhede and Joel Koshy


kafka-1409; oversized messages can slow down the brokers; patched by Guozhang 
Wang; reviewed by Neha Narkhede, Jun Rao


kafka-1424; transient unit test failure in testSendWithDeadBroker; patched by 
Jun Rao; reviewed by Timothy Chen


kafka-1418; transient unit test failure in ProducerFailureHandlingTest; patched 
by Jun Rao; reviewed by Guozhang Wang and Joel Koshy


kafka-1389; transient unit test failure in ProducerFailureHandlingTest; patched 
by Jun Rao; reviewed by Guozhang Wang and Neha Narkhede


kafka-1359; Followup on K1359: change nanoTime to currentTimeMillis in metrics; 
patched by Guozhang Wang; reviewed by Neha Narkhede, Jun Rao


kafka-1410; MetadataCache cleanup; patched by Jun Rao; reviewed by Timothy 
Chen, Joel Koshy


kafka-1411; remove unused test cases; patched by Jun Rao; reviewed by Guozhang 
Wang


KAFKA-1327; Log cleaner metrics follow-up patch to reset

Re: Review Request 22131: Patch for KAFKA-1477

2014-06-02 Thread Ivan Lyutov


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22131/
---

(Updated June 2, 2014, 2:07 p.m.)


Review request for kafka.


Bugs: KAFKA-1477
https://issues.apache.org/jira/browse/KAFKA-1477


Repository: kafka


Description (updated)
---

Added SSL for Kafka

Minor fixes, cleanup

Refactoring

Fixed tests compilation error.


Diffs (updated)
-

  config/client.keystore PRE-CREATION 
  config/client.public-key PRE-CREATION 
  config/client.security.properties PRE-CREATION 
  config/consumer.properties 7343cbc28cf8b8de3f096d09c2be955bea73164f 
  config/producer.properties 39d65d7c6c21f4fccd7af89be6ca12a088d5dd98 
  config/server.keystore PRE-CREATION 
  config/server.properties c9e923aed8551e0797b1ea6f69628b277faf8f48 
  config/server.public-key PRE-CREATION 
  config/server.security.properties PRE-CREATION 
  core/src/main/scala/kafka/api/FetchRequest.scala 
a8b73acd1a813284744359e8434cb52d22063c99 
  core/src/main/scala/kafka/client/ClientUtils.scala 
ba5fbdcd9e60f953575e529325caf4c41e22f22d 
  core/src/main/scala/kafka/cluster/Broker.scala 
9407ed21fbbd57edeecd888edc32bea6a05d95b3 
  core/src/main/scala/kafka/common/UnknownKeyStoreException.scala PRE-CREATION 
  core/src/main/scala/kafka/consumer/ConsoleConsumer.scala 
1a16c691683dda0c53f316e3c4797ea38e776574 
  core/src/main/scala/kafka/consumer/ConsumerConfig.scala 
1cf2f62ba02e4aa66bfa7575865e5d57baf82212 
  core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala 
b9e2bea7b442a19bcebd1b350d39541a8c9dd068 
  core/src/main/scala/kafka/consumer/SimpleConsumer.scala 
0e64632210385ef63c2ad3445b55ac4f37a63df2 
  core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala 
65f518d47c7555c42c4bff39c211814831f4b8b6 
  core/src/main/scala/kafka/controller/ControllerChannelManager.scala 
8763968fbff697e4c5c98ab1274627c192a4d26a 
  core/src/main/scala/kafka/network/BlockingChannel.scala 
eb7bb14d94cb3648c06d4de36a3b34aacbde4556 
  core/src/main/scala/kafka/network/SocketServer.scala 
4976d9c3a66bc965f5870a0736e21c7b32650bab 
  core/src/main/scala/kafka/network/security/AuthConfig.scala PRE-CREATION 
  core/src/main/scala/kafka/network/security/KeyStores.scala PRE-CREATION 
  core/src/main/scala/kafka/network/security/SSLSocketChannel.scala 
PRE-CREATION 
  core/src/main/scala/kafka/network/security/SecureAuth.scala PRE-CREATION 
  core/src/main/scala/kafka/network/security/store/JKSInitializer.scala 
PRE-CREATION 
  core/src/main/scala/kafka/producer/ConsoleProducer.scala 
a2af988d99a94a20291d6a2dc9bec73197f1b756 
  core/src/main/scala/kafka/producer/ProducerConfig.scala 
3cdf23dce3407f1770b9c6543e3a8ae8ab3ff255 
  core/src/main/scala/kafka/producer/ProducerPool.scala 
43df70bb461dd3e385e6b20396adef3c4016a3fc 
  core/src/main/scala/kafka/producer/SyncProducer.scala 
489f0077512d9a69be81649c490274964290fa40 
  core/src/main/scala/kafka/producer/SyncProducerConfig.scala 
69b2d0c11bb1412ce76d566f285333c806be301a 
  core/src/main/scala/kafka/server/AbstractFetcherThread.scala 
3b15254f32252cf824d7a292889ac7662d73ada1 
  core/src/main/scala/kafka/server/KafkaConfig.scala 
ef75b67b67676ae5b8931902cbc8c0c2cc72c0d3 
  core/src/main/scala/kafka/server/KafkaHealthcheck.scala 
4acdd70fe9c1ee78d6510741006c2ece65450671 
  core/src/main/scala/kafka/server/KafkaServer.scala 
c22e51e0412843ec993721ad3230824c0aadd2ba 
  core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala 
19df757d75fdbb3ff0b434b6cb10338ff5cc32da 
  core/src/main/scala/kafka/tools/GetOffsetShell.scala 
fba652e3716a67b04431fc46790ad255201b639f 
  core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala 
91f072816418040a396a0cad26bc889f539dadd6 
  core/src/main/scala/kafka/tools/SimpleConsumerShell.scala 
747e07280cce72d621acbc771337b909a9b2487e 
  core/src/main/scala/kafka/utils/ZkUtils.scala 
fcbe269b6057b45793ea95f357890d5d6922e8d4 
  core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala 
fcd5eee09fc1831e7fac4c3f1151e9708dc6f5f1 
  core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala 
35dc071b1056e775326981573c9618d8046e601d 
  core/src/test/scala/unit/kafka/network/SocketServerTest.scala 
62fb02cf02d3876b9804d756c4bf8514554cc836 
  core/src/test/scala/unit/kafka/utils/TestUtils.scala 
4da0f2c245f75ff0dcab4ecf0af085ab9f8da1bb 
  gradle/wrapper/gradle-wrapper.properties 
610282a699afc89a82203ef0e4e71ecc53761039 

Diff: https://reviews.apache.org/r/22131/diff/


Testing
---


Thanks,

Ivan Lyutov

Re: Review Request 22131: Patch for KAFKA-1477

2014-06-02 Thread Ivan Lyutov


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22131/
---

(Updated June 2, 2014, 2:32 p.m.)


Review request for kafka.


Bugs: KAFKA-1477
https://issues.apache.org/jira/browse/KAFKA-1477


Repository: kafka


Description (updated)
---

Reverted gradle version


Added SSL for Kafka

Minor fixes, cleanup

Refactoring

Fixed tests compilation error.


Diffs (updated)
-

  config/client.keystore PRE-CREATION 
  config/client.public-key PRE-CREATION 
  config/client.security.properties PRE-CREATION 
  config/consumer.properties 7343cbc28cf8b8de3f096d09c2be955bea73164f 
  config/producer.properties 39d65d7c6c21f4fccd7af89be6ca12a088d5dd98 
  config/server.keystore PRE-CREATION 
  config/server.properties c9e923aed8551e0797b1ea6f69628b277faf8f48 
  config/server.public-key PRE-CREATION 
  config/server.security.properties PRE-CREATION 
  core/src/main/scala/kafka/api/FetchRequest.scala 
a8b73acd1a813284744359e8434cb52d22063c99 
  core/src/main/scala/kafka/client/ClientUtils.scala 
ba5fbdcd9e60f953575e529325caf4c41e22f22d 
  core/src/main/scala/kafka/cluster/Broker.scala 
9407ed21fbbd57edeecd888edc32bea6a05d95b3 
  core/src/main/scala/kafka/common/UnknownKeyStoreException.scala PRE-CREATION 
  core/src/main/scala/kafka/consumer/ConsoleConsumer.scala 
1a16c691683dda0c53f316e3c4797ea38e776574 
  core/src/main/scala/kafka/consumer/ConsumerConfig.scala 
1cf2f62ba02e4aa66bfa7575865e5d57baf82212 
  core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala 
b9e2bea7b442a19bcebd1b350d39541a8c9dd068 
  core/src/main/scala/kafka/consumer/SimpleConsumer.scala 
0e64632210385ef63c2ad3445b55ac4f37a63df2 
  core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala 
65f518d47c7555c42c4bff39c211814831f4b8b6 
  core/src/main/scala/kafka/controller/ControllerChannelManager.scala 
8763968fbff697e4c5c98ab1274627c192a4d26a 
  core/src/main/scala/kafka/network/BlockingChannel.scala 
eb7bb14d94cb3648c06d4de36a3b34aacbde4556 
  core/src/main/scala/kafka/network/SocketServer.scala 
4976d9c3a66bc965f5870a0736e21c7b32650bab 
  core/src/main/scala/kafka/network/security/AuthConfig.scala PRE-CREATION 
  core/src/main/scala/kafka/network/security/KeyStores.scala PRE-CREATION 
  core/src/main/scala/kafka/network/security/SSLSocketChannel.scala 
PRE-CREATION 
  core/src/main/scala/kafka/network/security/SecureAuth.scala PRE-CREATION 
  core/src/main/scala/kafka/network/security/store/JKSInitializer.scala 
PRE-CREATION 
  core/src/main/scala/kafka/producer/ConsoleProducer.scala 
a2af988d99a94a20291d6a2dc9bec73197f1b756 
  core/src/main/scala/kafka/producer/ProducerConfig.scala 
3cdf23dce3407f1770b9c6543e3a8ae8ab3ff255 
  core/src/main/scala/kafka/producer/ProducerPool.scala 
43df70bb461dd3e385e6b20396adef3c4016a3fc 
  core/src/main/scala/kafka/producer/SyncProducer.scala 
489f0077512d9a69be81649c490274964290fa40 
  core/src/main/scala/kafka/producer/SyncProducerConfig.scala 
69b2d0c11bb1412ce76d566f285333c806be301a 
  core/src/main/scala/kafka/server/AbstractFetcherThread.scala 
3b15254f32252cf824d7a292889ac7662d73ada1 
  core/src/main/scala/kafka/server/KafkaConfig.scala 
ef75b67b67676ae5b8931902cbc8c0c2cc72c0d3 
  core/src/main/scala/kafka/server/KafkaHealthcheck.scala 
4acdd70fe9c1ee78d6510741006c2ece65450671 
  core/src/main/scala/kafka/server/KafkaServer.scala 
c22e51e0412843ec993721ad3230824c0aadd2ba 
  core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala 
19df757d75fdbb3ff0b434b6cb10338ff5cc32da 
  core/src/main/scala/kafka/tools/GetOffsetShell.scala 
fba652e3716a67b04431fc46790ad255201b639f 
  core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala 
91f072816418040a396a0cad26bc889f539dadd6 
  core/src/main/scala/kafka/tools/SimpleConsumerShell.scala 
747e07280cce72d621acbc771337b909a9b2487e 
  core/src/main/scala/kafka/utils/ZkUtils.scala 
fcbe269b6057b45793ea95f357890d5d6922e8d4 
  core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala 
fcd5eee09fc1831e7fac4c3f1151e9708dc6f5f1 
  core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala 
35dc071b1056e775326981573c9618d8046e601d 
  core/src/test/scala/unit/kafka/network/SocketServerTest.scala 
62fb02cf02d3876b9804d756c4bf8514554cc836 
  core/src/test/scala/unit/kafka/utils/TestUtils.scala 
4da0f2c245f75ff0dcab4ecf0af085ab9f8da1bb 
  gradle/wrapper/gradle-wrapper.properties 
610282a699afc89a82203ef0e4e71ecc53761039 

Diff: https://reviews.apache.org/r/22131/diff/


Testing
---


Thanks,

Ivan Lyutov

Re: Review Request 22131: Patch for KAFKA-1477

2014-06-02 Thread Joe Stein


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22131/#review44585
---



core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala
https://reviews.apache.org/r/22131/#comment79005

this shouldn't change, it should be info


- Joe Stein


On June 2, 2014, 2:32 p.m., Ivan Lyutov wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/22131/
 ---
 
 (Updated June 2, 2014, 2:32 p.m.)
 
 
 Review request for kafka.
 
 
 Bugs: KAFKA-1477
 https://issues.apache.org/jira/browse/KAFKA-1477
 
 
 Repository: kafka
 
 
 Description
 ---
 
 Reverted gradle version
 
 
 Added SSL for Kafka
 
 Minor fixes, cleanup
 
 Refactoring
 
 Fixed tests compilation error.
 
 
 Diffs
 -
 
   config/client.keystore PRE-CREATION 
   config/client.public-key PRE-CREATION 
   config/client.security.properties PRE-CREATION 
   config/consumer.properties 7343cbc28cf8b8de3f096d09c2be955bea73164f 
   config/producer.properties 39d65d7c6c21f4fccd7af89be6ca12a088d5dd98 
   config/server.keystore PRE-CREATION 
   config/server.properties c9e923aed8551e0797b1ea6f69628b277faf8f48 
   config/server.public-key PRE-CREATION 
   config/server.security.properties PRE-CREATION 
   core/src/main/scala/kafka/api/FetchRequest.scala 
 a8b73acd1a813284744359e8434cb52d22063c99 
   core/src/main/scala/kafka/client/ClientUtils.scala 
 ba5fbdcd9e60f953575e529325caf4c41e22f22d 
   core/src/main/scala/kafka/cluster/Broker.scala 
 9407ed21fbbd57edeecd888edc32bea6a05d95b3 
   core/src/main/scala/kafka/common/UnknownKeyStoreException.scala 
 PRE-CREATION 
   core/src/main/scala/kafka/consumer/ConsoleConsumer.scala 
 1a16c691683dda0c53f316e3c4797ea38e776574 
   core/src/main/scala/kafka/consumer/ConsumerConfig.scala 
 1cf2f62ba02e4aa66bfa7575865e5d57baf82212 
   core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala 
 b9e2bea7b442a19bcebd1b350d39541a8c9dd068 
   core/src/main/scala/kafka/consumer/SimpleConsumer.scala 
 0e64632210385ef63c2ad3445b55ac4f37a63df2 
   core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala 
 65f518d47c7555c42c4bff39c211814831f4b8b6 
   core/src/main/scala/kafka/controller/ControllerChannelManager.scala 
 8763968fbff697e4c5c98ab1274627c192a4d26a 
   core/src/main/scala/kafka/network/BlockingChannel.scala 
 eb7bb14d94cb3648c06d4de36a3b34aacbde4556 
   core/src/main/scala/kafka/network/SocketServer.scala 
 4976d9c3a66bc965f5870a0736e21c7b32650bab 
   core/src/main/scala/kafka/network/security/AuthConfig.scala PRE-CREATION 
   core/src/main/scala/kafka/network/security/KeyStores.scala PRE-CREATION 
   core/src/main/scala/kafka/network/security/SSLSocketChannel.scala 
 PRE-CREATION 
   core/src/main/scala/kafka/network/security/SecureAuth.scala PRE-CREATION 
   core/src/main/scala/kafka/network/security/store/JKSInitializer.scala 
 PRE-CREATION 
   core/src/main/scala/kafka/producer/ConsoleProducer.scala 
 a2af988d99a94a20291d6a2dc9bec73197f1b756 
   core/src/main/scala/kafka/producer/ProducerConfig.scala 
 3cdf23dce3407f1770b9c6543e3a8ae8ab3ff255 
   core/src/main/scala/kafka/producer/ProducerPool.scala 
 43df70bb461dd3e385e6b20396adef3c4016a3fc 
   core/src/main/scala/kafka/producer/SyncProducer.scala 
 489f0077512d9a69be81649c490274964290fa40 
   core/src/main/scala/kafka/producer/SyncProducerConfig.scala 
 69b2d0c11bb1412ce76d566f285333c806be301a 
   core/src/main/scala/kafka/server/AbstractFetcherThread.scala 
 3b15254f32252cf824d7a292889ac7662d73ada1 
   core/src/main/scala/kafka/server/KafkaConfig.scala 
 ef75b67b67676ae5b8931902cbc8c0c2cc72c0d3 
   core/src/main/scala/kafka/server/KafkaHealthcheck.scala 
 4acdd70fe9c1ee78d6510741006c2ece65450671 
   core/src/main/scala/kafka/server/KafkaServer.scala 
 c22e51e0412843ec993721ad3230824c0aadd2ba 
   core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala 
 19df757d75fdbb3ff0b434b6cb10338ff5cc32da 
   core/src/main/scala/kafka/tools/GetOffsetShell.scala 
 fba652e3716a67b04431fc46790ad255201b639f 
   core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala 
 91f072816418040a396a0cad26bc889f539dadd6 
   core/src/main/scala/kafka/tools/SimpleConsumerShell.scala 
 747e07280cce72d621acbc771337b909a9b2487e 
   core/src/main/scala/kafka/utils/ZkUtils.scala 
 fcbe269b6057b45793ea95f357890d5d6922e8d4 
   core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala 
 fcd5eee09fc1831e7fac4c3f1151e9708dc6f5f1 
   core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala 
 35dc071b1056e775326981573c9618d8046e601d 
   core/src/test/scala/unit/kafka/network/SocketServerTest.scala 
 62fb02cf02d3876b9804d756c4bf8514554cc836 
   core/src/test/scala/unit/kafka/utils/TestUtils.scala 
 4da0f2c245f75ff0dcab4ecf0af085ab9f8da1bb

Re: Review Request 22131: Patch for KAFKA-1477

2014-06-02 Thread Joe Stein


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22131/#review44586
---



config/server.properties
https://reviews.apache.org/r/22131/#comment79006

The old property file should be preserved with only the new additions to it 
please that are required, thanks


- Joe Stein


On June 2, 2014, 2:32 p.m., Ivan Lyutov wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/22131/
 ---
 
 (Updated June 2, 2014, 2:32 p.m.)
 
 
 Review request for kafka.
 
 
 Bugs: KAFKA-1477
 https://issues.apache.org/jira/browse/KAFKA-1477
 
 
 Repository: kafka
 
 
 Description
 ---
 
 Reverted gradle version
 
 
 Added SSL for Kafka
 
 Minor fixes, cleanup
 
 Refactoring
 
 Fixed tests compilation error.
 
 
 Diffs
 -
 
   config/client.keystore PRE-CREATION 
   config/client.public-key PRE-CREATION 
   config/client.security.properties PRE-CREATION 
   config/consumer.properties 7343cbc28cf8b8de3f096d09c2be955bea73164f 
   config/producer.properties 39d65d7c6c21f4fccd7af89be6ca12a088d5dd98 
   config/server.keystore PRE-CREATION 
   config/server.properties c9e923aed8551e0797b1ea6f69628b277faf8f48 
   config/server.public-key PRE-CREATION 
   config/server.security.properties PRE-CREATION 
   core/src/main/scala/kafka/api/FetchRequest.scala 
 a8b73acd1a813284744359e8434cb52d22063c99 
   core/src/main/scala/kafka/client/ClientUtils.scala 
 ba5fbdcd9e60f953575e529325caf4c41e22f22d 
   core/src/main/scala/kafka/cluster/Broker.scala 
 9407ed21fbbd57edeecd888edc32bea6a05d95b3 
   core/src/main/scala/kafka/common/UnknownKeyStoreException.scala 
 PRE-CREATION 
   core/src/main/scala/kafka/consumer/ConsoleConsumer.scala 
 1a16c691683dda0c53f316e3c4797ea38e776574 
   core/src/main/scala/kafka/consumer/ConsumerConfig.scala 
 1cf2f62ba02e4aa66bfa7575865e5d57baf82212 
   core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala 
 b9e2bea7b442a19bcebd1b350d39541a8c9dd068 
   core/src/main/scala/kafka/consumer/SimpleConsumer.scala 
 0e64632210385ef63c2ad3445b55ac4f37a63df2 
   core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala 
 65f518d47c7555c42c4bff39c211814831f4b8b6 
   core/src/main/scala/kafka/controller/ControllerChannelManager.scala 
 8763968fbff697e4c5c98ab1274627c192a4d26a 
   core/src/main/scala/kafka/network/BlockingChannel.scala 
 eb7bb14d94cb3648c06d4de36a3b34aacbde4556 
   core/src/main/scala/kafka/network/SocketServer.scala 
 4976d9c3a66bc965f5870a0736e21c7b32650bab 
   core/src/main/scala/kafka/network/security/AuthConfig.scala PRE-CREATION 
   core/src/main/scala/kafka/network/security/KeyStores.scala PRE-CREATION 
   core/src/main/scala/kafka/network/security/SSLSocketChannel.scala 
 PRE-CREATION 
   core/src/main/scala/kafka/network/security/SecureAuth.scala PRE-CREATION 
   core/src/main/scala/kafka/network/security/store/JKSInitializer.scala 
 PRE-CREATION 
   core/src/main/scala/kafka/producer/ConsoleProducer.scala 
 a2af988d99a94a20291d6a2dc9bec73197f1b756 
   core/src/main/scala/kafka/producer/ProducerConfig.scala 
 3cdf23dce3407f1770b9c6543e3a8ae8ab3ff255 
   core/src/main/scala/kafka/producer/ProducerPool.scala 
 43df70bb461dd3e385e6b20396adef3c4016a3fc 
   core/src/main/scala/kafka/producer/SyncProducer.scala 
 489f0077512d9a69be81649c490274964290fa40 
   core/src/main/scala/kafka/producer/SyncProducerConfig.scala 
 69b2d0c11bb1412ce76d566f285333c806be301a 
   core/src/main/scala/kafka/server/AbstractFetcherThread.scala 
 3b15254f32252cf824d7a292889ac7662d73ada1 
   core/src/main/scala/kafka/server/KafkaConfig.scala 
 ef75b67b67676ae5b8931902cbc8c0c2cc72c0d3 
   core/src/main/scala/kafka/server/KafkaHealthcheck.scala 
 4acdd70fe9c1ee78d6510741006c2ece65450671 
   core/src/main/scala/kafka/server/KafkaServer.scala 
 c22e51e0412843ec993721ad3230824c0aadd2ba 
   core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala 
 19df757d75fdbb3ff0b434b6cb10338ff5cc32da 
   core/src/main/scala/kafka/tools/GetOffsetShell.scala 
 fba652e3716a67b04431fc46790ad255201b639f 
   core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala 
 91f072816418040a396a0cad26bc889f539dadd6 
   core/src/main/scala/kafka/tools/SimpleConsumerShell.scala 
 747e07280cce72d621acbc771337b909a9b2487e 
   core/src/main/scala/kafka/utils/ZkUtils.scala 
 fcbe269b6057b45793ea95f357890d5d6922e8d4 
   core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala 
 fcd5eee09fc1831e7fac4c3f1151e9708dc6f5f1 
   core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala 
 35dc071b1056e775326981573c9618d8046e601d 
   core/src/test/scala/unit/kafka/network/SocketServerTest.scala 
 62fb02cf02d3876b9804d756c4bf8514554cc836 
   core/src/test/scala/unit/kafka/utils/TestUtils.scala

Re: Review Request 22131: Patch for KAFKA-1477

2014-06-02 Thread Joe Stein


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22131/#review44587
---



core/src/main/scala/kafka/common/UnknownKeyStoreException.scala
https://reviews.apache.org/r/22131/#comment79007

This file needs apache header license please


- Joe Stein


On June 2, 2014, 2:32 p.m., Ivan Lyutov wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/22131/
 ---
 
 (Updated June 2, 2014, 2:32 p.m.)
 
 
 Review request for kafka.
 
 
 Bugs: KAFKA-1477
 https://issues.apache.org/jira/browse/KAFKA-1477
 
 
 Repository: kafka
 
 
 Description
 ---
 
 Reverted gradle version
 
 
 Added SSL for Kafka
 
 Minor fixes, cleanup
 
 Refactoring
 
 Fixed tests compilation error.
 
 
 Diffs
 -
 
   config/client.keystore PRE-CREATION 
   config/client.public-key PRE-CREATION 
   config/client.security.properties PRE-CREATION 
   config/consumer.properties 7343cbc28cf8b8de3f096d09c2be955bea73164f 
   config/producer.properties 39d65d7c6c21f4fccd7af89be6ca12a088d5dd98 
   config/server.keystore PRE-CREATION 
   config/server.properties c9e923aed8551e0797b1ea6f69628b277faf8f48 
   config/server.public-key PRE-CREATION 
   config/server.security.properties PRE-CREATION 
   core/src/main/scala/kafka/api/FetchRequest.scala 
 a8b73acd1a813284744359e8434cb52d22063c99 
   core/src/main/scala/kafka/client/ClientUtils.scala 
 ba5fbdcd9e60f953575e529325caf4c41e22f22d 
   core/src/main/scala/kafka/cluster/Broker.scala 
 9407ed21fbbd57edeecd888edc32bea6a05d95b3 
   core/src/main/scala/kafka/common/UnknownKeyStoreException.scala 
 PRE-CREATION 
   core/src/main/scala/kafka/consumer/ConsoleConsumer.scala 
 1a16c691683dda0c53f316e3c4797ea38e776574 
   core/src/main/scala/kafka/consumer/ConsumerConfig.scala 
 1cf2f62ba02e4aa66bfa7575865e5d57baf82212 
   core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala 
 b9e2bea7b442a19bcebd1b350d39541a8c9dd068 
   core/src/main/scala/kafka/consumer/SimpleConsumer.scala 
 0e64632210385ef63c2ad3445b55ac4f37a63df2 
   core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala 
 65f518d47c7555c42c4bff39c211814831f4b8b6 
   core/src/main/scala/kafka/controller/ControllerChannelManager.scala 
 8763968fbff697e4c5c98ab1274627c192a4d26a 
   core/src/main/scala/kafka/network/BlockingChannel.scala 
 eb7bb14d94cb3648c06d4de36a3b34aacbde4556 
   core/src/main/scala/kafka/network/SocketServer.scala 
 4976d9c3a66bc965f5870a0736e21c7b32650bab 
   core/src/main/scala/kafka/network/security/AuthConfig.scala PRE-CREATION 
   core/src/main/scala/kafka/network/security/KeyStores.scala PRE-CREATION 
   core/src/main/scala/kafka/network/security/SSLSocketChannel.scala 
 PRE-CREATION 
   core/src/main/scala/kafka/network/security/SecureAuth.scala PRE-CREATION 
   core/src/main/scala/kafka/network/security/store/JKSInitializer.scala 
 PRE-CREATION 
   core/src/main/scala/kafka/producer/ConsoleProducer.scala 
 a2af988d99a94a20291d6a2dc9bec73197f1b756 
   core/src/main/scala/kafka/producer/ProducerConfig.scala 
 3cdf23dce3407f1770b9c6543e3a8ae8ab3ff255 
   core/src/main/scala/kafka/producer/ProducerPool.scala 
 43df70bb461dd3e385e6b20396adef3c4016a3fc 
   core/src/main/scala/kafka/producer/SyncProducer.scala 
 489f0077512d9a69be81649c490274964290fa40 
   core/src/main/scala/kafka/producer/SyncProducerConfig.scala 
 69b2d0c11bb1412ce76d566f285333c806be301a 
   core/src/main/scala/kafka/server/AbstractFetcherThread.scala 
 3b15254f32252cf824d7a292889ac7662d73ada1 
   core/src/main/scala/kafka/server/KafkaConfig.scala 
 ef75b67b67676ae5b8931902cbc8c0c2cc72c0d3 
   core/src/main/scala/kafka/server/KafkaHealthcheck.scala 
 4acdd70fe9c1ee78d6510741006c2ece65450671 
   core/src/main/scala/kafka/server/KafkaServer.scala 
 c22e51e0412843ec993721ad3230824c0aadd2ba 
   core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala 
 19df757d75fdbb3ff0b434b6cb10338ff5cc32da 
   core/src/main/scala/kafka/tools/GetOffsetShell.scala 
 fba652e3716a67b04431fc46790ad255201b639f 
   core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala 
 91f072816418040a396a0cad26bc889f539dadd6 
   core/src/main/scala/kafka/tools/SimpleConsumerShell.scala 
 747e07280cce72d621acbc771337b909a9b2487e 
   core/src/main/scala/kafka/utils/ZkUtils.scala 
 fcbe269b6057b45793ea95f357890d5d6922e8d4 
   core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala 
 fcd5eee09fc1831e7fac4c3f1151e9708dc6f5f1 
   core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala 
 35dc071b1056e775326981573c9618d8046e601d 
   core/src/test/scala/unit/kafka/network/SocketServerTest.scala 
 62fb02cf02d3876b9804d756c4bf8514554cc836 
   core/src/test/scala/unit/kafka/utils/TestUtils.scala 
 4da0f2c245f75ff0dcab4ecf0af085ab9f8da1bb

Re: Review Request 22131: Patch for KAFKA-1477

2014-06-02 Thread Joe Stein


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22131/#review44588
---



core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala
https://reviews.apache.org/r/22131/#comment79008

this should not be part of this ticket


- Joe Stein


On June 2, 2014, 2:32 p.m., Ivan Lyutov wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/22131/
 ---
 
 (Updated June 2, 2014, 2:32 p.m.)
 
 
 Review request for kafka.
 
 
 Bugs: KAFKA-1477
 https://issues.apache.org/jira/browse/KAFKA-1477
 
 
 Repository: kafka
 
 
 Description
 ---
 
 Reverted gradle version
 
 
 Added SSL for Kafka
 
 Minor fixes, cleanup
 
 Refactoring
 
 Fixed tests compilation error.
 
 
 Diffs
 -
 
   config/client.keystore PRE-CREATION 
   config/client.public-key PRE-CREATION 
   config/client.security.properties PRE-CREATION 
   config/consumer.properties 7343cbc28cf8b8de3f096d09c2be955bea73164f 
   config/producer.properties 39d65d7c6c21f4fccd7af89be6ca12a088d5dd98 
   config/server.keystore PRE-CREATION 
   config/server.properties c9e923aed8551e0797b1ea6f69628b277faf8f48 
   config/server.public-key PRE-CREATION 
   config/server.security.properties PRE-CREATION 
   core/src/main/scala/kafka/api/FetchRequest.scala 
 a8b73acd1a813284744359e8434cb52d22063c99 
   core/src/main/scala/kafka/client/ClientUtils.scala 
 ba5fbdcd9e60f953575e529325caf4c41e22f22d 
   core/src/main/scala/kafka/cluster/Broker.scala 
 9407ed21fbbd57edeecd888edc32bea6a05d95b3 
   core/src/main/scala/kafka/common/UnknownKeyStoreException.scala 
 PRE-CREATION 
   core/src/main/scala/kafka/consumer/ConsoleConsumer.scala 
 1a16c691683dda0c53f316e3c4797ea38e776574 
   core/src/main/scala/kafka/consumer/ConsumerConfig.scala 
 1cf2f62ba02e4aa66bfa7575865e5d57baf82212 
   core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala 
 b9e2bea7b442a19bcebd1b350d39541a8c9dd068 
   core/src/main/scala/kafka/consumer/SimpleConsumer.scala 
 0e64632210385ef63c2ad3445b55ac4f37a63df2 
   core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala 
 65f518d47c7555c42c4bff39c211814831f4b8b6 
   core/src/main/scala/kafka/controller/ControllerChannelManager.scala 
 8763968fbff697e4c5c98ab1274627c192a4d26a 
   core/src/main/scala/kafka/network/BlockingChannel.scala 
 eb7bb14d94cb3648c06d4de36a3b34aacbde4556 
   core/src/main/scala/kafka/network/SocketServer.scala 
 4976d9c3a66bc965f5870a0736e21c7b32650bab 
   core/src/main/scala/kafka/network/security/AuthConfig.scala PRE-CREATION 
   core/src/main/scala/kafka/network/security/KeyStores.scala PRE-CREATION 
   core/src/main/scala/kafka/network/security/SSLSocketChannel.scala 
 PRE-CREATION 
   core/src/main/scala/kafka/network/security/SecureAuth.scala PRE-CREATION 
   core/src/main/scala/kafka/network/security/store/JKSInitializer.scala 
 PRE-CREATION 
   core/src/main/scala/kafka/producer/ConsoleProducer.scala 
 a2af988d99a94a20291d6a2dc9bec73197f1b756 
   core/src/main/scala/kafka/producer/ProducerConfig.scala 
 3cdf23dce3407f1770b9c6543e3a8ae8ab3ff255 
   core/src/main/scala/kafka/producer/ProducerPool.scala 
 43df70bb461dd3e385e6b20396adef3c4016a3fc 
   core/src/main/scala/kafka/producer/SyncProducer.scala 
 489f0077512d9a69be81649c490274964290fa40 
   core/src/main/scala/kafka/producer/SyncProducerConfig.scala 
 69b2d0c11bb1412ce76d566f285333c806be301a 
   core/src/main/scala/kafka/server/AbstractFetcherThread.scala 
 3b15254f32252cf824d7a292889ac7662d73ada1 
   core/src/main/scala/kafka/server/KafkaConfig.scala 
 ef75b67b67676ae5b8931902cbc8c0c2cc72c0d3 
   core/src/main/scala/kafka/server/KafkaHealthcheck.scala 
 4acdd70fe9c1ee78d6510741006c2ece65450671 
   core/src/main/scala/kafka/server/KafkaServer.scala 
 c22e51e0412843ec993721ad3230824c0aadd2ba 
   core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala 
 19df757d75fdbb3ff0b434b6cb10338ff5cc32da 
   core/src/main/scala/kafka/tools/GetOffsetShell.scala 
 fba652e3716a67b04431fc46790ad255201b639f 
   core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala 
 91f072816418040a396a0cad26bc889f539dadd6 
   core/src/main/scala/kafka/tools/SimpleConsumerShell.scala 
 747e07280cce72d621acbc771337b909a9b2487e 
   core/src/main/scala/kafka/utils/ZkUtils.scala 
 fcbe269b6057b45793ea95f357890d5d6922e8d4 
   core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala 
 fcd5eee09fc1831e7fac4c3f1151e9708dc6f5f1 
   core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala 
 35dc071b1056e775326981573c9618d8046e601d 
   core/src/test/scala/unit/kafka/network/SocketServerTest.scala 
 62fb02cf02d3876b9804d756c4bf8514554cc836 
   core/src/test/scala/unit/kafka/utils/TestUtils.scala 
 4da0f2c245f75ff0dcab4ecf0af085ab9f8da1bb

Re: Review Request 22131: Patch for KAFKA-1477

2014-06-02 Thread Joe Stein


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22131/#review44589
---



core/src/main/scala/kafka/consumer/SimpleConsumer.scala
https://reviews.apache.org/r/22131/#comment79009

can we do this with an atomic bool instead?


- Joe Stein


On June 2, 2014, 2:32 p.m., Ivan Lyutov wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/22131/
 ---
 
 (Updated June 2, 2014, 2:32 p.m.)
 
 
 Review request for kafka.
 
 
 Bugs: KAFKA-1477
 https://issues.apache.org/jira/browse/KAFKA-1477
 
 
 Repository: kafka
 
 
 Description
 ---
 
 Reverted gradle version
 
 
 Added SSL for Kafka
 
 Minor fixes, cleanup
 
 Refactoring
 
 Fixed tests compilation error.
 
 
 Diffs
 -
 
   config/client.keystore PRE-CREATION 
   config/client.public-key PRE-CREATION 
   config/client.security.properties PRE-CREATION 
   config/consumer.properties 7343cbc28cf8b8de3f096d09c2be955bea73164f 
   config/producer.properties 39d65d7c6c21f4fccd7af89be6ca12a088d5dd98 
   config/server.keystore PRE-CREATION 
   config/server.properties c9e923aed8551e0797b1ea6f69628b277faf8f48 
   config/server.public-key PRE-CREATION 
   config/server.security.properties PRE-CREATION 
   core/src/main/scala/kafka/api/FetchRequest.scala 
 a8b73acd1a813284744359e8434cb52d22063c99 
   core/src/main/scala/kafka/client/ClientUtils.scala 
 ba5fbdcd9e60f953575e529325caf4c41e22f22d 
   core/src/main/scala/kafka/cluster/Broker.scala 
 9407ed21fbbd57edeecd888edc32bea6a05d95b3 
   core/src/main/scala/kafka/common/UnknownKeyStoreException.scala 
 PRE-CREATION 
   core/src/main/scala/kafka/consumer/ConsoleConsumer.scala 
 1a16c691683dda0c53f316e3c4797ea38e776574 
   core/src/main/scala/kafka/consumer/ConsumerConfig.scala 
 1cf2f62ba02e4aa66bfa7575865e5d57baf82212 
   core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala 
 b9e2bea7b442a19bcebd1b350d39541a8c9dd068 
   core/src/main/scala/kafka/consumer/SimpleConsumer.scala 
 0e64632210385ef63c2ad3445b55ac4f37a63df2 
   core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala 
 65f518d47c7555c42c4bff39c211814831f4b8b6 
   core/src/main/scala/kafka/controller/ControllerChannelManager.scala 
 8763968fbff697e4c5c98ab1274627c192a4d26a 
   core/src/main/scala/kafka/network/BlockingChannel.scala 
 eb7bb14d94cb3648c06d4de36a3b34aacbde4556 
   core/src/main/scala/kafka/network/SocketServer.scala 
 4976d9c3a66bc965f5870a0736e21c7b32650bab 
   core/src/main/scala/kafka/network/security/AuthConfig.scala PRE-CREATION 
   core/src/main/scala/kafka/network/security/KeyStores.scala PRE-CREATION 
   core/src/main/scala/kafka/network/security/SSLSocketChannel.scala 
 PRE-CREATION 
   core/src/main/scala/kafka/network/security/SecureAuth.scala PRE-CREATION 
   core/src/main/scala/kafka/network/security/store/JKSInitializer.scala 
 PRE-CREATION 
   core/src/main/scala/kafka/producer/ConsoleProducer.scala 
 a2af988d99a94a20291d6a2dc9bec73197f1b756 
   core/src/main/scala/kafka/producer/ProducerConfig.scala 
 3cdf23dce3407f1770b9c6543e3a8ae8ab3ff255 
   core/src/main/scala/kafka/producer/ProducerPool.scala 
 43df70bb461dd3e385e6b20396adef3c4016a3fc 
   core/src/main/scala/kafka/producer/SyncProducer.scala 
 489f0077512d9a69be81649c490274964290fa40 
   core/src/main/scala/kafka/producer/SyncProducerConfig.scala 
 69b2d0c11bb1412ce76d566f285333c806be301a 
   core/src/main/scala/kafka/server/AbstractFetcherThread.scala 
 3b15254f32252cf824d7a292889ac7662d73ada1 
   core/src/main/scala/kafka/server/KafkaConfig.scala 
 ef75b67b67676ae5b8931902cbc8c0c2cc72c0d3 
   core/src/main/scala/kafka/server/KafkaHealthcheck.scala 
 4acdd70fe9c1ee78d6510741006c2ece65450671 
   core/src/main/scala/kafka/server/KafkaServer.scala 
 c22e51e0412843ec993721ad3230824c0aadd2ba 
   core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala 
 19df757d75fdbb3ff0b434b6cb10338ff5cc32da 
   core/src/main/scala/kafka/tools/GetOffsetShell.scala 
 fba652e3716a67b04431fc46790ad255201b639f 
   core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala 
 91f072816418040a396a0cad26bc889f539dadd6 
   core/src/main/scala/kafka/tools/SimpleConsumerShell.scala 
 747e07280cce72d621acbc771337b909a9b2487e 
   core/src/main/scala/kafka/utils/ZkUtils.scala 
 fcbe269b6057b45793ea95f357890d5d6922e8d4 
   core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala 
 fcd5eee09fc1831e7fac4c3f1151e9708dc6f5f1 
   core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala 
 35dc071b1056e775326981573c9618d8046e601d 
   core/src/test/scala/unit/kafka/network/SocketServerTest.scala 
 62fb02cf02d3876b9804d756c4bf8514554cc836 
   core/src/test/scala/unit/kafka/utils/TestUtils.scala 
 4da0f2c245f75ff0dcab4ecf0af085ab9f8da1bb

Re: Review Request 22131: Patch for KAFKA-1477

2014-06-02 Thread Joe Stein


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22131/#review44590
---



core/src/main/scala/kafka/network/BlockingChannel.scala
https://reviews.apache.org/r/22131/#comment79010

is this change really required?


- Joe Stein


On June 2, 2014, 2:32 p.m., Ivan Lyutov wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/22131/
 ---
 
 (Updated June 2, 2014, 2:32 p.m.)
 
 
 Review request for kafka.
 
 
 Bugs: KAFKA-1477
 https://issues.apache.org/jira/browse/KAFKA-1477
 
 
 Repository: kafka
 
 
 Description
 ---
 
 Reverted gradle version
 
 
 Added SSL for Kafka
 
 Minor fixes, cleanup
 
 Refactoring
 
 Fixed tests compilation error.
 
 
 Diffs
 -
 
   config/client.keystore PRE-CREATION 
   config/client.public-key PRE-CREATION 
   config/client.security.properties PRE-CREATION 
   config/consumer.properties 7343cbc28cf8b8de3f096d09c2be955bea73164f 
   config/producer.properties 39d65d7c6c21f4fccd7af89be6ca12a088d5dd98 
   config/server.keystore PRE-CREATION 
   config/server.properties c9e923aed8551e0797b1ea6f69628b277faf8f48 
   config/server.public-key PRE-CREATION 
   config/server.security.properties PRE-CREATION 
   core/src/main/scala/kafka/api/FetchRequest.scala 
 a8b73acd1a813284744359e8434cb52d22063c99 
   core/src/main/scala/kafka/client/ClientUtils.scala 
 ba5fbdcd9e60f953575e529325caf4c41e22f22d 
   core/src/main/scala/kafka/cluster/Broker.scala 
 9407ed21fbbd57edeecd888edc32bea6a05d95b3 
   core/src/main/scala/kafka/common/UnknownKeyStoreException.scala 
 PRE-CREATION 
   core/src/main/scala/kafka/consumer/ConsoleConsumer.scala 
 1a16c691683dda0c53f316e3c4797ea38e776574 
   core/src/main/scala/kafka/consumer/ConsumerConfig.scala 
 1cf2f62ba02e4aa66bfa7575865e5d57baf82212 
   core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala 
 b9e2bea7b442a19bcebd1b350d39541a8c9dd068 
   core/src/main/scala/kafka/consumer/SimpleConsumer.scala 
 0e64632210385ef63c2ad3445b55ac4f37a63df2 
   core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala 
 65f518d47c7555c42c4bff39c211814831f4b8b6 
   core/src/main/scala/kafka/controller/ControllerChannelManager.scala 
 8763968fbff697e4c5c98ab1274627c192a4d26a 
   core/src/main/scala/kafka/network/BlockingChannel.scala 
 eb7bb14d94cb3648c06d4de36a3b34aacbde4556 
   core/src/main/scala/kafka/network/SocketServer.scala 
 4976d9c3a66bc965f5870a0736e21c7b32650bab 
   core/src/main/scala/kafka/network/security/AuthConfig.scala PRE-CREATION 
   core/src/main/scala/kafka/network/security/KeyStores.scala PRE-CREATION 
   core/src/main/scala/kafka/network/security/SSLSocketChannel.scala 
 PRE-CREATION 
   core/src/main/scala/kafka/network/security/SecureAuth.scala PRE-CREATION 
   core/src/main/scala/kafka/network/security/store/JKSInitializer.scala 
 PRE-CREATION 
   core/src/main/scala/kafka/producer/ConsoleProducer.scala 
 a2af988d99a94a20291d6a2dc9bec73197f1b756 
   core/src/main/scala/kafka/producer/ProducerConfig.scala 
 3cdf23dce3407f1770b9c6543e3a8ae8ab3ff255 
   core/src/main/scala/kafka/producer/ProducerPool.scala 
 43df70bb461dd3e385e6b20396adef3c4016a3fc 
   core/src/main/scala/kafka/producer/SyncProducer.scala 
 489f0077512d9a69be81649c490274964290fa40 
   core/src/main/scala/kafka/producer/SyncProducerConfig.scala 
 69b2d0c11bb1412ce76d566f285333c806be301a 
   core/src/main/scala/kafka/server/AbstractFetcherThread.scala 
 3b15254f32252cf824d7a292889ac7662d73ada1 
   core/src/main/scala/kafka/server/KafkaConfig.scala 
 ef75b67b67676ae5b8931902cbc8c0c2cc72c0d3 
   core/src/main/scala/kafka/server/KafkaHealthcheck.scala 
 4acdd70fe9c1ee78d6510741006c2ece65450671 
   core/src/main/scala/kafka/server/KafkaServer.scala 
 c22e51e0412843ec993721ad3230824c0aadd2ba 
   core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala 
 19df757d75fdbb3ff0b434b6cb10338ff5cc32da 
   core/src/main/scala/kafka/tools/GetOffsetShell.scala 
 fba652e3716a67b04431fc46790ad255201b639f 
   core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala 
 91f072816418040a396a0cad26bc889f539dadd6 
   core/src/main/scala/kafka/tools/SimpleConsumerShell.scala 
 747e07280cce72d621acbc771337b909a9b2487e 
   core/src/main/scala/kafka/utils/ZkUtils.scala 
 fcbe269b6057b45793ea95f357890d5d6922e8d4 
   core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala 
 fcd5eee09fc1831e7fac4c3f1151e9708dc6f5f1 
   core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala 
 35dc071b1056e775326981573c9618d8046e601d 
   core/src/test/scala/unit/kafka/network/SocketServerTest.scala 
 62fb02cf02d3876b9804d756c4bf8514554cc836 
   core/src/test/scala/unit/kafka/utils/TestUtils.scala 
 4da0f2c245f75ff0dcab4ecf0af085ab9f8da1bb

Re: Review Request 22131: Patch for KAFKA-1477

2014-06-02 Thread Joe Stein


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22131/#review44591
---



core/src/main/scala/kafka/network/BlockingChannel.scala
https://reviews.apache.org/r/22131/#comment79011

is this change and the ones below it, are they really required?


- Joe Stein


On June 2, 2014, 2:32 p.m., Ivan Lyutov wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/22131/
 ---
 
 (Updated June 2, 2014, 2:32 p.m.)
 
 
 Review request for kafka.
 
 
 Bugs: KAFKA-1477
 https://issues.apache.org/jira/browse/KAFKA-1477
 
 
 Repository: kafka
 
 
 Description
 ---
 
 Reverted gradle version
 
 
 Added SSL for Kafka
 
 Minor fixes, cleanup
 
 Refactoring
 
 Fixed tests compilation error.
 
 
 Diffs
 -
 
   config/client.keystore PRE-CREATION 
   config/client.public-key PRE-CREATION 
   config/client.security.properties PRE-CREATION 
   config/consumer.properties 7343cbc28cf8b8de3f096d09c2be955bea73164f 
   config/producer.properties 39d65d7c6c21f4fccd7af89be6ca12a088d5dd98 
   config/server.keystore PRE-CREATION 
   config/server.properties c9e923aed8551e0797b1ea6f69628b277faf8f48 
   config/server.public-key PRE-CREATION 
   config/server.security.properties PRE-CREATION 
   core/src/main/scala/kafka/api/FetchRequest.scala 
 a8b73acd1a813284744359e8434cb52d22063c99 
   core/src/main/scala/kafka/client/ClientUtils.scala 
 ba5fbdcd9e60f953575e529325caf4c41e22f22d 
   core/src/main/scala/kafka/cluster/Broker.scala 
 9407ed21fbbd57edeecd888edc32bea6a05d95b3 
   core/src/main/scala/kafka/common/UnknownKeyStoreException.scala 
 PRE-CREATION 
   core/src/main/scala/kafka/consumer/ConsoleConsumer.scala 
 1a16c691683dda0c53f316e3c4797ea38e776574 
   core/src/main/scala/kafka/consumer/ConsumerConfig.scala 
 1cf2f62ba02e4aa66bfa7575865e5d57baf82212 
   core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala 
 b9e2bea7b442a19bcebd1b350d39541a8c9dd068 
   core/src/main/scala/kafka/consumer/SimpleConsumer.scala 
 0e64632210385ef63c2ad3445b55ac4f37a63df2 
   core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala 
 65f518d47c7555c42c4bff39c211814831f4b8b6 
   core/src/main/scala/kafka/controller/ControllerChannelManager.scala 
 8763968fbff697e4c5c98ab1274627c192a4d26a 
   core/src/main/scala/kafka/network/BlockingChannel.scala 
 eb7bb14d94cb3648c06d4de36a3b34aacbde4556 
   core/src/main/scala/kafka/network/SocketServer.scala 
 4976d9c3a66bc965f5870a0736e21c7b32650bab 
   core/src/main/scala/kafka/network/security/AuthConfig.scala PRE-CREATION 
   core/src/main/scala/kafka/network/security/KeyStores.scala PRE-CREATION 
   core/src/main/scala/kafka/network/security/SSLSocketChannel.scala 
 PRE-CREATION 
   core/src/main/scala/kafka/network/security/SecureAuth.scala PRE-CREATION 
   core/src/main/scala/kafka/network/security/store/JKSInitializer.scala 
 PRE-CREATION 
   core/src/main/scala/kafka/producer/ConsoleProducer.scala 
 a2af988d99a94a20291d6a2dc9bec73197f1b756 
   core/src/main/scala/kafka/producer/ProducerConfig.scala 
 3cdf23dce3407f1770b9c6543e3a8ae8ab3ff255 
   core/src/main/scala/kafka/producer/ProducerPool.scala 
 43df70bb461dd3e385e6b20396adef3c4016a3fc 
   core/src/main/scala/kafka/producer/SyncProducer.scala 
 489f0077512d9a69be81649c490274964290fa40 
   core/src/main/scala/kafka/producer/SyncProducerConfig.scala 
 69b2d0c11bb1412ce76d566f285333c806be301a 
   core/src/main/scala/kafka/server/AbstractFetcherThread.scala 
 3b15254f32252cf824d7a292889ac7662d73ada1 
   core/src/main/scala/kafka/server/KafkaConfig.scala 
 ef75b67b67676ae5b8931902cbc8c0c2cc72c0d3 
   core/src/main/scala/kafka/server/KafkaHealthcheck.scala 
 4acdd70fe9c1ee78d6510741006c2ece65450671 
   core/src/main/scala/kafka/server/KafkaServer.scala 
 c22e51e0412843ec993721ad3230824c0aadd2ba 
   core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala 
 19df757d75fdbb3ff0b434b6cb10338ff5cc32da 
   core/src/main/scala/kafka/tools/GetOffsetShell.scala 
 fba652e3716a67b04431fc46790ad255201b639f 
   core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala 
 91f072816418040a396a0cad26bc889f539dadd6 
   core/src/main/scala/kafka/tools/SimpleConsumerShell.scala 
 747e07280cce72d621acbc771337b909a9b2487e 
   core/src/main/scala/kafka/utils/ZkUtils.scala 
 fcbe269b6057b45793ea95f357890d5d6922e8d4 
   core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala 
 fcd5eee09fc1831e7fac4c3f1151e9708dc6f5f1 
   core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala 
 35dc071b1056e775326981573c9618d8046e601d 
   core/src/test/scala/unit/kafka/network/SocketServerTest.scala 
 62fb02cf02d3876b9804d756c4bf8514554cc836 
   core/src/test/scala/unit/kafka/utils/TestUtils.scala

Re: Review Request 22131: Patch for KAFKA-1477

2014-06-02 Thread Joe Stein


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22131/#review44592
---



core/src/main/scala/kafka/network/SocketServer.scala
https://reviews.apache.org/r/22131/#comment79012

lots of changes here.  we need to have the minimal set of changes to 
support the feature.


- Joe Stein


On June 2, 2014, 2:32 p.m., Ivan Lyutov wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/22131/
 ---
 
 (Updated June 2, 2014, 2:32 p.m.)
 
 
 Review request for kafka.
 
 
 Bugs: KAFKA-1477
 https://issues.apache.org/jira/browse/KAFKA-1477
 
 
 Repository: kafka
 
 
 Description
 ---
 
 Reverted gradle version
 
 
 Added SSL for Kafka
 
 Minor fixes, cleanup
 
 Refactoring
 
 Fixed tests compilation error.
 
 
 Diffs
 -
 
   config/client.keystore PRE-CREATION 
   config/client.public-key PRE-CREATION 
   config/client.security.properties PRE-CREATION 
   config/consumer.properties 7343cbc28cf8b8de3f096d09c2be955bea73164f 
   config/producer.properties 39d65d7c6c21f4fccd7af89be6ca12a088d5dd98 
   config/server.keystore PRE-CREATION 
   config/server.properties c9e923aed8551e0797b1ea6f69628b277faf8f48 
   config/server.public-key PRE-CREATION 
   config/server.security.properties PRE-CREATION 
   core/src/main/scala/kafka/api/FetchRequest.scala 
 a8b73acd1a813284744359e8434cb52d22063c99 
   core/src/main/scala/kafka/client/ClientUtils.scala 
 ba5fbdcd9e60f953575e529325caf4c41e22f22d 
   core/src/main/scala/kafka/cluster/Broker.scala 
 9407ed21fbbd57edeecd888edc32bea6a05d95b3 
   core/src/main/scala/kafka/common/UnknownKeyStoreException.scala 
 PRE-CREATION 
   core/src/main/scala/kafka/consumer/ConsoleConsumer.scala 
 1a16c691683dda0c53f316e3c4797ea38e776574 
   core/src/main/scala/kafka/consumer/ConsumerConfig.scala 
 1cf2f62ba02e4aa66bfa7575865e5d57baf82212 
   core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala 
 b9e2bea7b442a19bcebd1b350d39541a8c9dd068 
   core/src/main/scala/kafka/consumer/SimpleConsumer.scala 
 0e64632210385ef63c2ad3445b55ac4f37a63df2 
   core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala 
 65f518d47c7555c42c4bff39c211814831f4b8b6 
   core/src/main/scala/kafka/controller/ControllerChannelManager.scala 
 8763968fbff697e4c5c98ab1274627c192a4d26a 
   core/src/main/scala/kafka/network/BlockingChannel.scala 
 eb7bb14d94cb3648c06d4de36a3b34aacbde4556 
   core/src/main/scala/kafka/network/SocketServer.scala 
 4976d9c3a66bc965f5870a0736e21c7b32650bab 
   core/src/main/scala/kafka/network/security/AuthConfig.scala PRE-CREATION 
   core/src/main/scala/kafka/network/security/KeyStores.scala PRE-CREATION 
   core/src/main/scala/kafka/network/security/SSLSocketChannel.scala 
 PRE-CREATION 
   core/src/main/scala/kafka/network/security/SecureAuth.scala PRE-CREATION 
   core/src/main/scala/kafka/network/security/store/JKSInitializer.scala 
 PRE-CREATION 
   core/src/main/scala/kafka/producer/ConsoleProducer.scala 
 a2af988d99a94a20291d6a2dc9bec73197f1b756 
   core/src/main/scala/kafka/producer/ProducerConfig.scala 
 3cdf23dce3407f1770b9c6543e3a8ae8ab3ff255 
   core/src/main/scala/kafka/producer/ProducerPool.scala 
 43df70bb461dd3e385e6b20396adef3c4016a3fc 
   core/src/main/scala/kafka/producer/SyncProducer.scala 
 489f0077512d9a69be81649c490274964290fa40 
   core/src/main/scala/kafka/producer/SyncProducerConfig.scala 
 69b2d0c11bb1412ce76d566f285333c806be301a 
   core/src/main/scala/kafka/server/AbstractFetcherThread.scala 
 3b15254f32252cf824d7a292889ac7662d73ada1 
   core/src/main/scala/kafka/server/KafkaConfig.scala 
 ef75b67b67676ae5b8931902cbc8c0c2cc72c0d3 
   core/src/main/scala/kafka/server/KafkaHealthcheck.scala 
 4acdd70fe9c1ee78d6510741006c2ece65450671 
   core/src/main/scala/kafka/server/KafkaServer.scala 
 c22e51e0412843ec993721ad3230824c0aadd2ba 
   core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala 
 19df757d75fdbb3ff0b434b6cb10338ff5cc32da 
   core/src/main/scala/kafka/tools/GetOffsetShell.scala 
 fba652e3716a67b04431fc46790ad255201b639f 
   core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala 
 91f072816418040a396a0cad26bc889f539dadd6 
   core/src/main/scala/kafka/tools/SimpleConsumerShell.scala 
 747e07280cce72d621acbc771337b909a9b2487e 
   core/src/main/scala/kafka/utils/ZkUtils.scala 
 fcbe269b6057b45793ea95f357890d5d6922e8d4 
   core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala 
 fcd5eee09fc1831e7fac4c3f1151e9708dc6f5f1 
   core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala 
 35dc071b1056e775326981573c9618d8046e601d 
   core/src/test/scala/unit/kafka/network/SocketServerTest.scala 
 62fb02cf02d3876b9804d756c4bf8514554cc836 
   core/src/test/scala/unit/kafka/utils/TestUtils.scala

Re: Review Request 22131: Patch for KAFKA-1477

Re: Review Request 22131: Patch for KAFKA-1477

Re: Review Request 22131: Patch for KAFKA-1477

Re: Review Request 22131: Patch for KAFKA-1477

Re: Review Request 22131: Patch for KAFKA-1477

Re: Review Request 22131: Patch for KAFKA-1477

Re: Review Request 22131: Patch for KAFKA-1477

Re: Review Request 22131: Patch for KAFKA-1477

Re: Review Request 22131: Patch for KAFKA-1477

Re: Review Request 22131: Patch for KAFKA-1477

Re: Review Request 22131: Patch for KAFKA-1477

Re: Review Request 22131: Patch for KAFKA-1477

Review Request 22131: Patch for KAFKA-1477

Re: Review Request 22131: Patch for KAFKA-1477

Re: Review Request 22131: Patch for KAFKA-1477

Re: Review Request 22131: Patch for KAFKA-1477

Re: Review Request 22131: Patch for KAFKA-1477

Re: Review Request 22131: Patch for KAFKA-1477

Re: Review Request 22131: Patch for KAFKA-1477

Re: Review Request 22131: Patch for KAFKA-1477

Re: Review Request 22131: Patch for KAFKA-1477

Re: Review Request 22131: Patch for KAFKA-1477

Re: Review Request 22131: Patch for KAFKA-1477

23 matches

Site Navigation

Mail list logo

Footer information