Re: Review Request 23692: Patch for KAFKA-1550

2014-07-22 Thread Guozhang Wang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23692/#review48455
---

Ship it!


Ship It!

- Guozhang Wang


On July 22, 2014, 6:41 p.m., Dong Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23692/
> ---
> 
> (Updated July 22, 2014, 6:41 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1550
> https://issues.apache.org/jira/browse/KAFKA-1550
> 
> 
> Repository: kafka
> 
> 
> Description
> ---
> 
> KAFKA-1550 Patch review tool should use git format-patch to generate patch 
> (version 2)
> 
> 
> Diffs
> -
> 
>   kafka-patch-review.py dc45549f886440f1721c60aab9aa0a4af9b4cbef 
> 
> Diff: https://reviews.apache.org/r/23692/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dong Lin
> 
>

Re: Review Request 23692: Patch for KAFKA-1550

2014-07-22 Thread Dong Lin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23692/
---

(Updated July 22, 2014, 6:41 p.m.)


Review request for kafka.


Bugs: KAFKA-1550
https://issues.apache.org/jira/browse/KAFKA-1550


Repository: kafka


Description (updated)
---

KAFKA-1550 Patch review tool should use git format-patch to generate patch 
(version 2)


Diffs (updated)
-

  kafka-patch-review.py dc45549f886440f1721c60aab9aa0a4af9b4cbef 

Diff: https://reviews.apache.org/r/23692/diff/


Testing
---


Thanks,

Dong Lin

Re: Review Request 23692: Patch for KAFKA-1550

2014-07-22 Thread Dong Lin 


> On July 22, 2014, 6:30 p.m., Neha Narkhede wrote:
> > kafka-patch-review.py, line 120
> > 
> >
> > formatted patch is a little misleading and is a git specific command. 
> > diff is easier to understand. So I'd recommend we keep the message as is.

Thanks for the review! I have updated it now.


- Dong


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23692/#review48392
---


On July 22, 2014, 6:41 p.m., Dong Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23692/
> ---
> 
> (Updated July 22, 2014, 6:41 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1550
> https://issues.apache.org/jira/browse/KAFKA-1550
> 
> 
> Repository: kafka
> 
> 
> Description
> ---
> 
> KAFKA-1550 Patch review tool should use git format-patch to generate patch 
> (version 2)
> 
> 
> Diffs
> -
> 
>   kafka-patch-review.py dc45549f886440f1721c60aab9aa0a4af9b4cbef 
> 
> Diff: https://reviews.apache.org/r/23692/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dong Lin
> 
>

Re: Review Request 23692: Patch for KAFKA-1550

2014-07-22 Thread Neha Narkhede 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23692/#review48392
---


Looks good. Thanks for improving our tools. I have a minor comment. 


kafka-patch-review.py


formatted patch is a little misleading and is a git specific command. diff 
is easier to understand. So I'd recommend we keep the message as is.


- Neha Narkhede


On July 18, 2014, 8:58 p.m., Dong Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23692/
> ---
> 
> (Updated July 18, 2014, 8:58 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1550
> https://issues.apache.org/jira/browse/KAFKA-1550
> 
> 
> Repository: kafka
> 
> 
> Description
> ---
> 
> KAFKA-1550 Patch review tool should use git format-patch to generate patch
> 
> 
> Diffs
> -
> 
>   kafka-patch-review.py dc45549f886440f1721c60aab9aa0a4af9b4cbef 
> 
> Diff: https://reviews.apache.org/r/23692/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dong Lin
> 
>

Review Request 23692: Patch for KAFKA-1550

2014-07-18 Thread Dong Lin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23692/
---

Review request for kafka.


Bugs: KAFKA-1550
https://issues.apache.org/jira/browse/KAFKA-1550


Repository: kafka


Description
---

KAFKA-1550 Patch review tool should use git format-patch to generate patch


Diffs
-

  kafka-patch-review.py dc45549f886440f1721c60aab9aa0a4af9b4cbef 

Diff: https://reviews.apache.org/r/23692/diff/


Testing
---


Thanks,

Dong Lin