Review Request 23705: Patch for KAFKA-1192

2014-07-19 Thread Manikumar Reddy O 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23705/
---

Review request for kafka.


Bugs: KAFKA-1192
https://issues.apache.org/jira/browse/KAFKA-1192


Repository: kafka


Description
---

Support given for custom deserialization of messages


Diffs
-

  core/src/main/scala/kafka/tools/DumpLogSegments.scala 
6daf87b25a48a51aafb7dbe8d0c0371e0ea7501f 

Diff: https://reviews.apache.org/r/23705/diff/


Testing
---


Thanks,

Manikumar Reddy O

Re: Review Request 23705: Patch for KAFKA-1192

2014-07-19 Thread Manikumar Reddy O 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23705/
---

(Updated July 19, 2014, 8:28 a.m.)


Review request for kafka.


Bugs: KAFKA-1192
https://issues.apache.org/jira/browse/KAFKA-1192


Repository: kafka


Description
---

Support given for custom deserialization of messages


Diffs (updated)
-

  core/src/main/scala/kafka/tools/DumpLogSegments.scala 
6daf87b25a48a51aafb7dbe8d0c0371e0ea7501f 

Diff: https://reviews.apache.org/r/23705/diff/


Testing
---


Thanks,

Manikumar Reddy O

Re: Review Request 23705: Patch for KAFKA-1192

2014-07-20 Thread Jun Rao 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23705/#review48195
---


Thanks for the patch. A couple of comments below.


core/src/main/scala/kafka/tools/DumpLogSegments.scala


Shouldn't Decoder be kafka.serializer.Decoder?

Also, capitalize custom.



core/src/main/scala/kafka/tools/DumpLogSegments.scala


Could we add a decoder for the key too?


- Jun Rao


On July 19, 2014, 8:28 a.m., Manikumar Reddy O wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23705/
> ---
> 
> (Updated July 19, 2014, 8:28 a.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1192
> https://issues.apache.org/jira/browse/KAFKA-1192
> 
> 
> Repository: kafka
> 
> 
> Description
> ---
> 
> Support given for custom deserialization of messages
> 
> 
> Diffs
> -
> 
>   core/src/main/scala/kafka/tools/DumpLogSegments.scala 
> 6daf87b25a48a51aafb7dbe8d0c0371e0ea7501f 
> 
> Diff: https://reviews.apache.org/r/23705/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Manikumar Reddy O
> 
>