Review Request 23743: Force fsync in OffsetCheckpoint

2014-07-21 Thread Jay Kreps

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23743/
---

Review request for kafka.


Bugs: KAFKA-1539
https://issues.apache.org/jira/browse/KAFKA-1539


Repository: kafka


Description
---

KAFKA-1539 Fsync offset checkpoint file after writing.


Diffs
-

  core/src/main/scala/kafka/server/OffsetCheckpoint.scala 
7af2f430f9f951d4c7df965d330fdcd9b810d2d5 

Diff: https://reviews.apache.org/r/23743/diff/


Testing
---


Thanks,

Jay Kreps



Re: Review Request 23743: Force fsync in OffsetCheckpoint

2014-07-21 Thread Sriram Subramanian

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23743/#review48256
---

Ship it!


Ship It!

- Sriram Subramanian


On July 21, 2014, 5:23 p.m., Jay Kreps wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/23743/
 ---
 
 (Updated July 21, 2014, 5:23 p.m.)
 
 
 Review request for kafka.
 
 
 Bugs: KAFKA-1539
 https://issues.apache.org/jira/browse/KAFKA-1539
 
 
 Repository: kafka
 
 
 Description
 ---
 
 KAFKA-1539 Fsync offset checkpoint file after writing.
 
 
 Diffs
 -
 
   core/src/main/scala/kafka/server/OffsetCheckpoint.scala 
 7af2f430f9f951d4c7df965d330fdcd9b810d2d5 
 
 Diff: https://reviews.apache.org/r/23743/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Jay Kreps