Re: Review Request 25703: Patch for KAFKA-1490
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25703/#review54082 --- Thanks for the patch. Could you update the README to explain any extra step that's needed before using gradlew? - Jun Rao On Sept. 16, 2014, 6:54 p.m., Ivan Lyutov wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25703/ --- (Updated Sept. 16, 2014, 6:54 p.m.) Review request for kafka. Bugs: KAFKA-1490 https://issues.apache.org/jira/browse/KAFKA-1490 Repository: kafka Description --- Removed wrapper generated contents and added default task to generate gradle wrapper binary. remove gradlew initial setup output from source distribution Diffs - build.gradle 74c8c8a9e2f4d9a651181d5337d5a8f07f0cb313 gradle/wrapper/gradle-wrapper.jar a7634b071cb255e91a4572934e55b8cd8877b3e4 gradle/wrapper/gradle-wrapper.properties d238df326fec6d925ccecdecaac0bcedf8e68672 wrapper.gradle PRE-CREATION Diff: https://reviews.apache.org/r/25703/diff/ Testing --- Thanks, Ivan Lyutov
Review Request 25703: Patch for KAFKA-1490
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25703/ --- Review request for kafka. Bugs: KAFKA-1490 https://issues.apache.org/jira/browse/KAFKA-1490 Repository: kafka Description --- Removed wrapper generated contents and added default task to generate gradle wrapper binary. Diffs - build.gradle 74c8c8a9e2f4d9a651181d5337d5a8f07f0cb313 gradle/wrapper/gradle-wrapper.jar a7634b071cb255e91a4572934e55b8cd8877b3e4 gradle/wrapper/gradle-wrapper.properties d238df326fec6d925ccecdecaac0bcedf8e68672 wrapper.gradle PRE-CREATION Diff: https://reviews.apache.org/r/25703/diff/ Testing --- Thanks, Ivan Lyutov
Re: Review Request 25703: Patch for KAFKA-1490
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25703/ --- (Updated Сен. 16, 2014, 6:54 п.п.) Review request for kafka. Bugs: KAFKA-1490 https://issues.apache.org/jira/browse/KAFKA-1490 Repository: kafka Description (updated) --- Removed wrapper generated contents and added default task to generate gradle wrapper binary. remove gradlew initial setup output from source distribution Diffs (updated) - build.gradle 74c8c8a9e2f4d9a651181d5337d5a8f07f0cb313 gradle/wrapper/gradle-wrapper.jar a7634b071cb255e91a4572934e55b8cd8877b3e4 gradle/wrapper/gradle-wrapper.properties d238df326fec6d925ccecdecaac0bcedf8e68672 wrapper.gradle PRE-CREATION Diff: https://reviews.apache.org/r/25703/diff/ Testing --- Thanks, Ivan Lyutov
