Re: Review Request 27535: Patch for KAFKA-1747

2014-11-06 Thread Neha Narkhede

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27535/#review60279
---

Ship it!


Ship It!

- Neha Narkhede


On Nov. 3, 2014, 7:46 p.m., Ewen Cheslack-Postava wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/27535/
 ---
 
 (Updated Nov. 3, 2014, 7:46 p.m.)
 
 
 Review request for kafka.
 
 
 Bugs: KAFKA-1747
 https://issues.apache.org/jira/browse/KAFKA-1747
 
 
 Repository: kafka
 
 
 Description
 ---
 
 KAKFA-1747 Fix TestcaseEnv so state isn't shared between instances.
 
 
 Diffs
 -
 
   system_test/utils/testcase_env.py b3c29105c04348f036efbbdc430e14e099ca8c70 
 
 Diff: https://reviews.apache.org/r/27535/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Ewen Cheslack-Postava
 




Re: Review Request 27535: Patch for KAFKA-1747

2014-11-04 Thread Guozhang Wang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27535/#review59899
---

Ship it!


Thanks for the patch. LGTM.

- Guozhang Wang


On Nov. 3, 2014, 7:46 p.m., Ewen Cheslack-Postava wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/27535/
 ---
 
 (Updated Nov. 3, 2014, 7:46 p.m.)
 
 
 Review request for kafka.
 
 
 Bugs: KAFKA-1747
 https://issues.apache.org/jira/browse/KAFKA-1747
 
 
 Repository: kafka
 
 
 Description
 ---
 
 KAKFA-1747 Fix TestcaseEnv so state isn't shared between instances.
 
 
 Diffs
 -
 
   system_test/utils/testcase_env.py b3c29105c04348f036efbbdc430e14e099ca8c70 
 
 Diff: https://reviews.apache.org/r/27535/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Ewen Cheslack-Postava
 




Review Request 27535: Patch for KAFKA-1747

2014-11-03 Thread Ewen Cheslack-Postava

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27535/
---

Review request for kafka.


Bugs: KAFKA-1747
https://issues.apache.org/jira/browse/KAFKA-1747


Repository: kafka


Description
---

KAKFA-1747 Fix TestcaseEnv so state isn't shared between instances.


Diffs
-

  system_test/utils/testcase_env.py b3c29105c04348f036efbbdc430e14e099ca8c70 

Diff: https://reviews.apache.org/r/27535/diff/


Testing
---


Thanks,

Ewen Cheslack-Postava