Re: Review Request 29738: Patch for kafka-1797

2015-01-09 Thread Neha Narkhede

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29738/#review67458
---

Ship it!


Ship It!

- Neha Narkhede


On Jan. 9, 2015, 1:22 a.m., Jun Rao wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/29738/
 ---
 
 (Updated Jan. 9, 2015, 1:22 a.m.)
 
 
 Review request for kafka.
 
 
 Bugs: kafka-1797
 https://issues.apache.org/jira/browse/kafka-1797
 
 
 Repository: kafka
 
 
 Description
 ---
 
 add null support in string serializer and deserializer
 
 
 Diffs
 -
 
   
 clients/src/main/java/org/apache/kafka/common/serialization/StringDeserializer.java
  a3b3700a1e0716643761d7032bd32bce839d3065 
   
 clients/src/main/java/org/apache/kafka/common/serialization/StringSerializer.java
  02db47f8736988343dd293fc3da03751f78a3b5c 
   
 clients/src/test/java/org/apache/kafka/common/serialization/SerializationTest.java
  d550a3137c066abb5e2984ac6245574832929ff8 
 
 Diff: https://reviews.apache.org/r/29738/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Jun Rao
 




Review Request 29738: Patch for kafka-1797

2015-01-08 Thread Jun Rao

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29738/
---

Review request for kafka.


Bugs: kafka-1797
https://issues.apache.org/jira/browse/kafka-1797


Repository: kafka


Description
---

add null support in string serializer and deserializer


Diffs
-

  
clients/src/main/java/org/apache/kafka/common/serialization/StringDeserializer.java
 a3b3700a1e0716643761d7032bd32bce839d3065 
  
clients/src/main/java/org/apache/kafka/common/serialization/StringSerializer.java
 02db47f8736988343dd293fc3da03751f78a3b5c 
  
clients/src/test/java/org/apache/kafka/common/serialization/SerializationTest.java
 d550a3137c066abb5e2984ac6245574832929ff8 

Diff: https://reviews.apache.org/r/29738/diff/


Testing
---


Thanks,

Jun Rao



Re: Review Request 29738: Patch for kafka-1797

2015-01-08 Thread Manikumar Reddy O

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29738/#review67374
---

Ship it!


Ship It!

- Manikumar Reddy O


On Jan. 9, 2015, 1:22 a.m., Jun Rao wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/29738/
 ---
 
 (Updated Jan. 9, 2015, 1:22 a.m.)
 
 
 Review request for kafka.
 
 
 Bugs: kafka-1797
 https://issues.apache.org/jira/browse/kafka-1797
 
 
 Repository: kafka
 
 
 Description
 ---
 
 add null support in string serializer and deserializer
 
 
 Diffs
 -
 
   
 clients/src/main/java/org/apache/kafka/common/serialization/StringDeserializer.java
  a3b3700a1e0716643761d7032bd32bce839d3065 
   
 clients/src/main/java/org/apache/kafka/common/serialization/StringSerializer.java
  02db47f8736988343dd293fc3da03751f78a3b5c 
   
 clients/src/test/java/org/apache/kafka/common/serialization/SerializationTest.java
  d550a3137c066abb5e2984ac6245574832929ff8 
 
 Diff: https://reviews.apache.org/r/29738/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Jun Rao