Re: Review Request 31168: Patch for KAFKA-1914

2015-02-18 Thread Joel Koshy

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31168/#review73035
---

Ship it!


Ship It!

- Joel Koshy


On Feb. 19, 2015, 12:01 a.m., Aditya Auradkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31168/
> ---
> 
> (Updated Feb. 19, 2015, 12:01 a.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1914
> https://issues.apache.org/jira/browse/KAFKA-1914
> 
> 
> Repository: kafka
> 
> 
> Description
> ---
> 
> Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into 
> trunk
> 
> 
> Fixing failing unit test
> 
> 
> Fixing failing unit test
> 
> 
> Diffs
> -
> 
>   core/src/test/scala/unit/kafka/server/SimpleFetchTest.scala 
> 525c835803b048c952667567cd205b4b06824391 
> 
> Diff: https://reviews.apache.org/r/31168/diff/
> 
> 
> Testing
> ---
> 
> All unit tests now pass.
> 
> BUILD SUCCESSFUL
> Total time: 9 mins 35.296 secs
> 
> 
> Thanks,
> 
> Aditya Auradkar
> 
>



Re: Review Request 31168: Patch for KAFKA-1914

2015-02-18 Thread Aditya Auradkar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31168/
---

(Updated Feb. 19, 2015, 12:01 a.m.)


Review request for kafka.


Bugs: KAFKA-1914
https://issues.apache.org/jira/browse/KAFKA-1914


Repository: kafka


Description
---

Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into trunk


Fixing failing unit test


Fixing failing unit test


Diffs
-

  core/src/test/scala/unit/kafka/server/SimpleFetchTest.scala 
525c835803b048c952667567cd205b4b06824391 

Diff: https://reviews.apache.org/r/31168/diff/


Testing (updated)
---

All unit tests now pass.

BUILD SUCCESSFUL
Total time: 9 mins 35.296 secs


Thanks,

Aditya Auradkar



Re: Review Request 31168: Patch for KAFKA-1914

2015-02-18 Thread Aditya Auradkar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31168/
---

(Updated Feb. 18, 2015, 11:55 p.m.)


Review request for kafka.


Bugs: KAFKA-1914
https://issues.apache.org/jira/browse/KAFKA-1914


Repository: kafka


Description
---

Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into trunk


Fixing failing unit test


Fixing failing unit test


Diffs
-

  core/src/test/scala/unit/kafka/server/SimpleFetchTest.scala 
525c835803b048c952667567cd205b4b06824391 

Diff: https://reviews.apache.org/r/31168/diff/


Testing (updated)
---

All unit tests now pass.


Thanks,

Aditya Auradkar



Review Request 31168: Patch for KAFKA-1914

2015-02-18 Thread Aditya Auradkar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31168/
---

Review request for kafka.


Bugs: KAFKA-1914
https://issues.apache.org/jira/browse/KAFKA-1914


Repository: kafka


Description
---

Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into trunk


Fixing failing unit test


Fixing failing unit test


Diffs
-

  core/src/test/scala/unit/kafka/server/SimpleFetchTest.scala 
525c835803b048c952667567cd205b4b06824391 

Diff: https://reviews.apache.org/r/31168/diff/


Testing
---


Thanks,

Aditya Auradkar