Re: Review Request 31830: Patch for KAFKA-2009
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31830/ --- (Updated March 11, 2015, 6:26 p.m.) Review request for kafka. Bugs: KAFKA-2009 https://issues.apache.org/jira/browse/KAFKA-2009 Repository: kafka Description (updated) --- Because the send callback could be fired in producer.send() as well, so unacked offset needs to be added to unacked offsets list before call producer.send() Diffs (updated) - core/src/main/scala/kafka/tools/MirrorMaker.scala bafa379ff57bc46458ea8409406f5046dc9c973e Diff: https://reviews.apache.org/r/31830/diff/ Testing --- Thanks, Jiangjie Qin
Re: Review Request 31830: Patch for KAFKA-2009
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31830/#review76145 --- Ship it! Ship It! - Onur Karaman On March 11, 2015, 6:26 p.m., Jiangjie Qin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31830/ --- (Updated March 11, 2015, 6:26 p.m.) Review request for kafka. Bugs: KAFKA-2009 https://issues.apache.org/jira/browse/KAFKA-2009 Repository: kafka Description --- Because the send callback could be fired in producer.send() as well, so unacked offset needs to be added to unacked offsets list before call producer.send() Diffs - core/src/main/scala/kafka/tools/MirrorMaker.scala bafa379ff57bc46458ea8409406f5046dc9c973e Diff: https://reviews.apache.org/r/31830/diff/ Testing --- Thanks, Jiangjie Qin
Review Request 31830: Patch for KAFKA-2009
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31830/ --- Review request for kafka. Bugs: KAFKA-2009 https://issues.apache.org/jira/browse/KAFKA-2009 Repository: kafka Description --- Patch for KAFKA-2009, fix mirror maker UnackedOffset.removeOffset synchronization and a trace logging issue. Diffs - core/src/main/scala/kafka/tools/MirrorMaker.scala 5374280dc97dc8e01e9b3ba61fd036dc13ae48cb Diff: https://reviews.apache.org/r/31830/diff/ Testing --- Thanks, Jiangjie Qin
