Re: Review Request 33645: Patch for KAFKA-2153
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33645/#review82406 --- Ship it! Ship It! - Neha Narkhede On April 28, 2015, 11:04 p.m., Ashish Singh wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33645/ --- (Updated April 28, 2015, 11:04 p.m.) Review request for kafka. Bugs: KAFKA-2153 https://issues.apache.org/jira/browse/KAFKA-2153 Repository: kafka Description --- KAFKA-2153: kafka-patch-review tool uploads a patch even if it is empty Diffs - dev-utils/test-patch.py 9d88a6e3926de8a4a62bbb03accfc3928c075b08 kafka-patch-review.py 959268069cd0cba3c70e10a2cf4829ca241b13a5 Diff: https://reviews.apache.org/r/33645/diff/ Testing --- Thanks, Ashish Singh
Re: Review Request 33645: Patch for KAFKA-2153
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33645/#review82076 --- Thanks for fixing the review tool! It looks like some changes to test-patch.py are included. Can you clean them out if they are not an intentional part of this patch? - Gwen Shapira On April 28, 2015, 11:04 p.m., Ashish Singh wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33645/ --- (Updated April 28, 2015, 11:04 p.m.) Review request for kafka. Bugs: KAFKA-2153 https://issues.apache.org/jira/browse/KAFKA-2153 Repository: kafka Description --- KAFKA-2153: kafka-patch-review tool uploads a patch even if it is empty Diffs - dev-utils/test-patch.py 9d88a6e3926de8a4a62bbb03accfc3928c075b08 kafka-patch-review.py 959268069cd0cba3c70e10a2cf4829ca241b13a5 Diff: https://reviews.apache.org/r/33645/diff/ Testing --- Thanks, Ashish Singh
Re: Review Request 33645: Patch for KAFKA-2153
On April 30, 2015, 12:50 a.m., Gwen Shapira wrote: Thanks for fixing the review tool! It looks like some changes to test-patch.py are included. Can you clean them out if they are not an intentional part of this patch? They are intentional :). I am reusing the part of logic already present in test-patch.py. - Ashish --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33645/#review82076 --- On April 28, 2015, 11:04 p.m., Ashish Singh wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33645/ --- (Updated April 28, 2015, 11:04 p.m.) Review request for kafka. Bugs: KAFKA-2153 https://issues.apache.org/jira/browse/KAFKA-2153 Repository: kafka Description --- KAFKA-2153: kafka-patch-review tool uploads a patch even if it is empty Diffs - dev-utils/test-patch.py 9d88a6e3926de8a4a62bbb03accfc3928c075b08 kafka-patch-review.py 959268069cd0cba3c70e10a2cf4829ca241b13a5 Diff: https://reviews.apache.org/r/33645/diff/ Testing --- Thanks, Ashish Singh
Review Request 33645: Patch for KAFKA-2153
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33645/ --- Review request for kafka. Bugs: KAFKA-2153 https://issues.apache.org/jira/browse/KAFKA-2153 Repository: kafka Description --- KAFKA-2153: kafka-patch-review tool uploads a patch even if it is empty Diffs - dev-utils/test-patch.py 9d88a6e3926de8a4a62bbb03accfc3928c075b08 kafka-patch-review.py 959268069cd0cba3c70e10a2cf4829ca241b13a5 Diff: https://reviews.apache.org/r/33645/diff/ Testing --- Thanks, Ashish Singh
