[GitHub] [karaf-minho] jbonofre opened a new issue, #44: Improve message when spring-boot application is not found
jbonofre opened a new issue, #44:
URL: https://github.com/apache/karaf-minho/issues/44
With the `minho-spring-boot` application manager, the user can load several
spring-boot application via the `ConfigService#Applications`. For instance, he
can define spring-boot applications via `minho.json` file:
```json
{
"applications": [
{
"name": "one-app",
"type": "spring-boot",
"url": "file:./app/my-spring-boot-app-1.0-SNAPSHOT.jar",
"properties": {
"args": "--server.port=8181"
}
}
]
}
```
If the `minho-spring-boot` application manager doesn't find the jar on the
provided `url`, the user get this error:
```
INFO: Starting Spring Boot module
file:./app/my-spring-boot-app-1.0-SNAPSHOT.jar
Exception in thread "main" java.lang.IllegalStateException: Can't start
lifecycle service
at
org.apache.karaf.minho.boot.service.LifeCycleService.start(LifeCycleService.java:66)
at
org.apache.karaf.minho.boot.service.ServiceRegistry.lambda$start$2(ServiceRegistry.java:128)
at java.base/java.util.Optional.ifPresent(Optional.java:178)
at
org.apache.karaf.minho.boot.service.ServiceRegistry.start(ServiceRegistry.java:126)
at org.apache.karaf.minho.boot.Minho.start(Minho.java:59)
at org.apache.karaf.minho.boot.Main.main(Main.java:63)
Suppressed: java.lang.RuntimeException: Can't start Spring Boot
module file:./app/my-spring-boot-app-1.0-SNAPSHOT.jar
at
org.apache.karaf.minho.springboot.SpringBootApplicationManagerService.lambda$onRegister$0(SpringBootApplicationManagerService.java:57)
at java.base/java.lang.Iterable.forEach(Iterable.java:75)
at
org.apache.karaf.minho.springboot.SpringBootApplicationManagerService.lambda$onRegister$1(SpringBootApplicationManagerService.java:53)
at
org.apache.karaf.minho.boot.service.LifeCycleService.lambda$start$0(LifeCycleService.java:69)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
at
org.apache.karaf.minho.boot.service.LifeCycleService.start(LifeCycleService.java:67)
... 5 more
Caused by: java.lang.ClassNotFoundException:
org.springframework.boot.loader.JarLauncher
at
java.base/java.net.URLClassLoader.findClass(URLClassLoader.java:445)
at
java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:587)
at
java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:520)
at
org.apache.karaf.minho.springboot.SpringBootApplicationManagerService.start(SpringBootApplicationManagerService.java:106)
at
org.apache.karaf.minho.springboot.SpringBootApplicationManagerService.lambda$onRegister$0(SpringBootApplicationManagerService.java:55)
... 10 more
```
It could be confusing as the problem is not really `ClassNotFoundException:
org.springframework.boot.loader.JarLauncher` but actually the application jar
file is not found.
The `minho-spring-boot` application manager should first check if the jar
exists on the provided URL and throw a clean message if not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [karaf-minho] jbonofre closed issue #42: `minho-spring-boot` application manager should look for `spring-boot` type
jbonofre closed issue #42: `minho-spring-boot` application manager should look for `spring-boot` type URL: https://github.com/apache/karaf-minho/issues/42 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] jbonofre merged pull request #43: [42] Change application type handling in spring-boot application manager
jbonofre merged PR #43: URL: https://github.com/apache/karaf-minho/pull/43 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] jbonofre commented on issue #42: `minho-spring-boot` application manager should look for `spring-boot` type
jbonofre commented on issue #42: URL: https://github.com/apache/karaf-minho/issues/42#issuecomment-1386019577 It would be great to add couple of tests about that, at least loading `minho.json` with applications. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] jbonofre commented on issue #41: Should the `JettyWebContainerService` has a higher priority than the `JerseyRestService` ?
jbonofre commented on issue #41: URL: https://github.com/apache/karaf-minho/issues/41#issuecomment-1384981142 I have a couple of other fixes to do. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] iskey commented on issue #41: Should the `JettyWebContainerService` has a higher priority than the `JerseyRestService` ?
iskey commented on issue #41: URL: https://github.com/apache/karaf-minho/issues/41#issuecomment-1384972190 @jbonofre, thanks, it will be great. ^v^ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] jbonofre commented on issue #41: Should the `JettyWebContainerService` has a higher priority than the `JerseyRestService` ?
jbonofre commented on issue #41: URL: https://github.com/apache/karaf-minho/issues/41#issuecomment-1384966366 Yes I fixed that already for 0.2. I will cut the release soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] iskey closed issue #41: Should the `JettyWebContainerService` has a higher priority than the `JerseyRestService` ?
iskey closed issue #41: Should the `JettyWebContainerService` has a higher priority than the `JerseyRestService` ? URL: https://github.com/apache/karaf-minho/issues/41 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] iskey commented on issue #41: Should the `JettyWebContainerService` has a higher priority than the `JerseyRestService` ?
iskey commented on issue #41: URL: https://github.com/apache/karaf-minho/issues/41#issuecomment-1384956579 The release [minho-0.1](https://github.com/apache/karaf-minho/releases/tag/minho-0.1) is still in the wrong state. The `SNAPSHOT` one works fine for me. I will close this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] iskey commented on issue #41: Should the `JettyWebContainerService` has a higher priority than the `JerseyRestService` ?
iskey commented on issue #41: URL: https://github.com/apache/karaf-minho/issues/41#issuecomment-1384946715 Sorry, I saw it is duplicated with #38, I will try to clear my local maven repo and try again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] iskey opened a new issue, #41: Should the `JerseyRestService` has a higher priority than `JettyWebContainerService`?
iskey opened a new issue, #41: URL: https://github.com/apache/karaf-minho/issues/41 It seems that the `JettyWebContainerService` should have a higher priority than `JerseyRestService`. ``` 2023-01-17 14:56:21 INFO org.apache.karaf.minho.boot.service.ServiceRegistry add Adding minho-rest-service service (1000) Exception in thread "main" java.lang.IllegalStateException: Can't register minho-rest-service at org.apache.karaf.minho.boot.service.ServiceRegistry.add(ServiceRegistry.java:88) at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183) at java.base/java.util.ArrayList.forEach(ArrayList.java:1511) at java.base/java.util.stream.SortedOps$RefSortingSink.end(SortedOps.java:395) at java.base/java.util.stream.Sink$ChainedReference.end(Sink.java:258) at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:510) at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499) at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150) at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173) at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) at java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596) at org.apache.karaf.minho.boot.Minho.start(Minho.java:58) at org.apache.karaf.minho.boot.Main.main(Main.java:63) Caused by: java.lang.IllegalStateException: minho-http-service is not found in the service registry at org.apache.karaf.minho.rest.jersey.JerseyRestService.onRegister(JerseyRestService.java:52) at org.apache.karaf.minho.boot.service.ServiceRegistry.add(ServiceRegistry.java:86) ... 12 more ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-site] wborn opened a new pull request, #70: Fix Deploy header in README.md
wborn opened a new pull request, #70: URL: https://github.com/apache/karaf-site/pull/70 The Deploy header is not properly rendered because it uses a [non-breaking space](https://en.wikipedia.org/wiki/Non-breaking_space) instead of a normal space. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-site] wborn opened a new pull request, #69: Use HTTPS download links
wborn opened a new pull request, #69: URL: https://github.com/apache/karaf-site/pull/69 There is a redirect to HTTPS anyhow. If the redirect stops working one day a MITM attack could occur causing users to install malware. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] jbonofre closed issue #38: `minho-rest` service should have priority higher than `minho-http`
jbonofre closed issue #38: `minho-rest` service should have priority higher than `minho-http` URL: https://github.com/apache/karaf-minho/issues/38 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] jbonofre merged pull request #39: [38] minho-rest service starts afterr minho-http
jbonofre merged PR #39: URL: https://github.com/apache/karaf-minho/pull/39 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] jbonofre closed issue #9: `ConfigService` should look for env variables/system properties automatically
jbonofre closed issue #9: `ConfigService` should look for env variables/system properties automatically URL: https://github.com/apache/karaf-minho/issues/9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] jbonofre commented on issue #9: `ConfigService` should look for env variables/system properties automatically
jbonofre commented on issue #9: URL: https://github.com/apache/karaf-minho/issues/9#issuecomment-1370643170 `Config` is already looking for env variables and system properties (when using `Config#getProperty(key)` method). I'm closing this issue, we will create one dedicated for `ConfigMap` (probably in Apache Sunny). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] jbonofre commented on issue #37: Move to minho namespace and hide karaf one
jbonofre commented on issue #37: URL: https://github.com/apache/karaf-minho/issues/37#issuecomment-1370633210 As we plan to move Minho to Apache Sunny, I'm holding this issue for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-site] jbonofre merged pull request #68: Removed Wizzio story
jbonofre merged PR #68: URL: https://github.com/apache/karaf-site/pull/68 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-site] kyberplayer opened a new pull request, #68: Removed Wizzio story
kyberplayer opened a new pull request, #68: URL: https://github.com/apache/karaf-site/pull/68 No longer promoting the application server for wizzio product. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] jbonofre commented on pull request #34: [#33] Add Minho.getInstance() convenient method to access Minho running instance
jbonofre commented on PR #34: URL: https://github.com/apache/karaf-minho/pull/34#issuecomment-1322042947 @rmannibucau yes, using an user service to retrieve Minho instance from the registry could work too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] rmannibucau commented on pull request #36: Several enhancements
rmannibucau commented on PR #36: URL: https://github.com/apache/karaf-minho/pull/36#issuecomment-1322038700 @jbonofre go ahead, it is mainly a "what I saw and changed" PR, agree it can be split. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] rmannibucau commented on pull request #34: [#33] Add Minho.getInstance() convenient method to access Minho running instance
rmannibucau commented on PR #34: URL: https://github.com/apache/karaf-minho/pull/34#issuecomment-1322037594 @jbonofre think it can be implemented this way - explicit enablement: https://github.com/apache/karaf-minho/pull/36/files#diff-76162c6ce6856187daf0c3c93d0edf7627f5b14cbc6b50a24e346d115124072f That said I think it is never useful - at least we, as dev, should target it. If an user wants that it should also register a JAXRS contextresolver/contextprovider which resolves to minho. In the PR mentionned previously I add `Minho` as a service so any service can access it and make it accessible to its components. Sound safer to me, wdyt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] jbonofre commented on pull request #36: Several enhancements
jbonofre commented on PR #36: URL: https://github.com/apache/karaf-minho/pull/36#issuecomment-1322035696 @rmannibucau do you mind if I split in several PRs ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] jbonofre commented on issue #37: Move to minho namespace and hide karaf one
jbonofre commented on issue #37: URL: https://github.com/apache/karaf-minho/issues/37#issuecomment-1322033460 +1 about that, but the only issue if that I need to ask infra to push SNAPSHOTs artifact on `org.apache.minho` (as we only have permission on `org.apache.karaf`) :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] jbonofre commented on pull request #34: [#33] Add Minho.getInstance() convenient method to access Minho running instance
jbonofre commented on PR #34:
URL: https://github.com/apache/karaf-minho/pull/34#issuecomment-1322031720
Some background about this change.
Imagine an user expose a REST endpoint using `minho-rest` (so Jersey JAXRS)
and doesn't create the Minho instance (it's just use `minho-boot` main.
All jar in a folder, it just launches the runtime with `java -jar
minho-boot.jar`.
So, the user needs a way to retrieve the Minho instance created in the
`minho-boot` `Main`.
Imagine, in the JAXRS class:
```
@Path("/")
public class MyApi {
@Path("/foo")
@GET
public String foo() {
return Minho.getInstance().getServiceRegistry().get(Foo.class).foo();
}
}
```
Thoughts ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [karaf-minho] rmannibucau opened a new issue, #37: Move to minho namespace and hide karaf one
rmannibucau opened a new issue, #37: URL: https://github.com/apache/karaf-minho/issues/37 Goal of this ticket is to use groupId and package `org.apache.minho` and not mention karaf in it since project is quite indenpendent. Will likely help to understand what we run, in particular when we'll run OSGi container (Apache Karaf) inside Apache Karaf Minho. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] rmannibucau commented on pull request #34: [#33] Add Minho.getInstance() convenient method to access Minho running instance
rmannibucau commented on PR #34: URL: https://github.com/apache/karaf-minho/pull/34#issuecomment-1321854471 Hi, Wonder if this shouldn't be reverted since it open doors to a lot of issues like a leak (close hook does not reset the instance), concurrency inconsistency (you can get > 1 minho instance, which one is right?). I propose to move it to a service (GlobalInstanceService) which would be usable with something like `GlobalInstanceService.get().getMinho()`. The service wouldn't be auto-registered but explicitly registered using Minho builder API. Wdyt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] jbonofre commented on issue #35: Add `minho-cdi` service
jbonofre commented on issue #35: URL: https://github.com/apache/karaf-minho/issues/35#issuecomment-1321205911 Yes. That's the plan :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] rmannibucau commented on issue #35: Add `minho-cdi` service
rmannibucau commented on issue #35: URL: https://github.com/apache/karaf-minho/issues/35#issuecomment-1321196904 Can look like https://github.com/apache/openwebbeans/blob/master/webbeans-se/src/main/java/org/apache/openwebbeans/se/CDILauncher.java but using config service instead of args -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] jbonofre opened a new issue, #35: Add `minho-cdi` service
jbonofre opened a new issue, #35: URL: https://github.com/apache/karaf-minho/issues/35 The idea is to provide CDI support thanks to Apache Openwebbeans. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] fpapon commented on issue #9: `ConfigService` should look for env variables/system properties automatically
fpapon commented on issue #9: URL: https://github.com/apache/karaf-minho/issues/9#issuecomment-131872 @mattrpav k8s secrets are generally mapped to the value of env variables in the k8s deployment so I'm not sure what you mean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] fpapon commented on issue #3: Add filtering support on `ServiceRegistry`
fpapon commented on issue #3: URL: https://github.com/apache/karaf-minho/issues/3#issuecomment-1318694328 Do we want to add properties associate to the key to be able to perform some fine search in the service registry? Like we can have with the SCR of OSGi. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] jbonofre merged pull request #34: [#33] Add Minho.getInstance() convenient method to access Minho running instance
jbonofre merged PR #34: URL: https://github.com/apache/karaf-minho/pull/34 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] jbonofre closed issue #33: Add method in `Minho` to retrieve the current instance
jbonofre closed issue #33: Add method in `Minho` to retrieve the current instance URL: https://github.com/apache/karaf-minho/issues/33 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] jbonofre opened a new issue, #33: Add method in `Minho` to retrieve the current instance
jbonofre opened a new issue, #33: URL: https://github.com/apache/karaf-minho/issues/33 For convenience, in order to get especially the `ServiceRegistry`, `Minho` should provide a way to retrieve the current instance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] jbonofre opened a new issue, #32: Improve dependencies resolver
jbonofre opened a new issue, #32: URL: https://github.com/apache/karaf-minho/issues/32 Maven Parser.getDependencies() is not accurate: - it doesn't retrieve all dependencies - it fails to resolve some transitive dependencies It should mimic the maven-dependency-plugin resolve mojo and the result should be the same as dependency:resolve goal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] jbonofre closed issue #21: Upgrade to maven-invoker-plugin 3.3.0
jbonofre closed issue #21: Upgrade to maven-invoker-plugin 3.3.0 URL: https://github.com/apache/karaf-minho/issues/21 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] jbonofre closed issue #20: Upgrade to maven-enforcer-plugin 3.0.0
jbonofre closed issue #20: Upgrade to maven-enforcer-plugin 3.0.0 URL: https://github.com/apache/karaf-minho/issues/20 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] jbonofre merged pull request #31: [#21] Upgrade to maven-invoker-plugin 3.3.0
jbonofre merged PR #31: URL: https://github.com/apache/karaf-minho/pull/31 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] jbonofre merged pull request #30: [#20] Upgrade to maven-enforcer-plugin 3.0.0
jbonofre merged PR #30: URL: https://github.com/apache/karaf-minho/pull/30 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] jbonofre closed issue #19: Upgrade to license-maven-plugin 4.2.rc3
jbonofre closed issue #19: Upgrade to license-maven-plugin 4.2.rc3 URL: https://github.com/apache/karaf-minho/issues/19 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] jbonofre merged pull request #29: [#19] Upgrade to license-maven-plugin 4.2.rc3
jbonofre merged PR #29: URL: https://github.com/apache/karaf-minho/pull/29 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] jbonofre merged pull request #28: [#18] Upgrade to jersey 3.1.0
jbonofre merged PR #28: URL: https://github.com/apache/karaf-minho/pull/28 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] jbonofre closed issue #18: Upgrade to jersey 3.1.0
jbonofre closed issue #18: Upgrade to jersey 3.1.0 URL: https://github.com/apache/karaf-minho/issues/18 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] jbonofre closed issue #17: Upgrade to jetty 11.0.12
jbonofre closed issue #17: Upgrade to jetty 11.0.12 URL: https://github.com/apache/karaf-minho/issues/17 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] jbonofre merged pull request #27: [#17] Upgrade to jetty 11.0.12
jbonofre merged PR #27: URL: https://github.com/apache/karaf-minho/pull/27 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] jbonofre merged pull request #26: [#16] Upgrade to johnzon 1.2.19
jbonofre merged PR #26: URL: https://github.com/apache/karaf-minho/pull/26 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] jbonofre closed issue #16: Upgrade to johnzon 1.2.19
jbonofre closed issue #16: Upgrade to johnzon 1.2.19 URL: https://github.com/apache/karaf-minho/issues/16 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] jbonofre closed issue #15: Upgrade to camel 3.19.0
jbonofre closed issue #15: Upgrade to camel 3.19.0 URL: https://github.com/apache/karaf-minho/issues/15 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] jbonofre merged pull request #25: [#15] Upgrade to camel 3.19.0
jbonofre merged PR #25: URL: https://github.com/apache/karaf-minho/pull/25 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] jbonofre closed issue #14: Upgrade to junit 5.9.1
jbonofre closed issue #14: Upgrade to junit 5.9.1 URL: https://github.com/apache/karaf-minho/issues/14 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] jbonofre merged pull request #24: [#14] Upgrade to junit 5.9.1
jbonofre merged PR #24: URL: https://github.com/apache/karaf-minho/pull/24 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] jbonofre closed issue #13: Upgrade to easymock 5.0.1
jbonofre closed issue #13: Upgrade to easymock 5.0.1 URL: https://github.com/apache/karaf-minho/issues/13 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] jbonofre merged pull request #23: [#13] Upgrade to easymock 5.0.1
jbonofre merged PR #23: URL: https://github.com/apache/karaf-minho/pull/23 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] jbonofre closed issue #12: Upgrade to maven-plugin-annotations 3.7.0
jbonofre closed issue #12: Upgrade to maven-plugin-annotations 3.7.0 URL: https://github.com/apache/karaf-minho/issues/12 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] jbonofre merged pull request #22: [#12] Upgrade to maven-plugin-annotations 3.7.0
jbonofre merged PR #22: URL: https://github.com/apache/karaf-minho/pull/22 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] jbonofre merged pull request #11: Fix the envKey in Config.java
jbonofre merged PR #11: URL: https://github.com/apache/karaf-minho/pull/11 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] jbonofre closed issue #10: There may be a mistake usage of `replaceAll()` for the variable `envKey` .
jbonofre closed issue #10: There may be a mistake usage of `replaceAll()` for the variable `envKey` . URL: https://github.com/apache/karaf-minho/issues/10 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] iskey commented on pull request #11: Fix the envKey in Config.java
iskey commented on PR #11: URL: https://github.com/apache/karaf-minho/pull/11#issuecomment-1311132720 Agree, no mock here. Actually, it is hard to mock without extracting the `getEnv` as another method. Let me make the pattern static. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] fpapon commented on pull request #11: Fix the envKey in Config.java
fpapon commented on PR #11: URL: https://github.com/apache/karaf-minho/pull/11#issuecomment-1310827232 @jbonofre agree, no mock is needed, go for merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] jbonofre commented on pull request #11: Fix the envKey in Config.java
jbonofre commented on PR #11: URL: https://github.com/apache/karaf-minho/pull/11#issuecomment-1310703273 @rmannibucau good point, we can have the Pattern compile as static. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] rmannibucau commented on pull request #11: Fix the envKey in Config.java
rmannibucau commented on PR #11: URL: https://github.com/apache/karaf-minho/pull/11#issuecomment-1310698906 Guess the regex should be extracted if config service is used at runtime instead of recompiled each time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] jbonofre commented on pull request #11: Fix the envKey in Config.java
jbonofre commented on PR #11: URL: https://github.com/apache/karaf-minho/pull/11#issuecomment-1310695667 If no objection, I will merge this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] jbonofre commented on pull request #11: Fix the envKey in Config.java
jbonofre commented on PR #11: URL: https://github.com/apache/karaf-minho/pull/11#issuecomment-1310695263 I think we don't need a mock for the test. We can directly test the `ConfigService` and setting a system property to test. Actually, I think for this kind of "simple" bug, we can just move forward without test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] rmannibucau commented on pull request #11: Fix the envKey in Config.java
rmannibucau commented on PR #11: URL: https://github.com/apache/karaf-minho/pull/11#issuecomment-1310601291 If possible try avoiding a mock please, it is like not testing at all at the end. Using surefire you can force some env var so it is then easy to check it is used or not cases IMHO. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] fpapon commented on pull request #11: Fix the envKey in Config.java
fpapon commented on PR #11: URL: https://github.com/apache/karaf-minho/pull/11#issuecomment-1310295881 > Better to do a mock test. Post two snapshots for contrast for now: > > from  > > to  Sounds good! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] iskey commented on pull request #11: Fix the envKey in Config.java
iskey commented on PR #11: URL: https://github.com/apache/karaf-minho/pull/11#issuecomment-1310239716 Better to do a mock test. Post two snapshots for contrast for now: from  to  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] iskey commented on pull request #11: Fix the envKey in Config.java
iskey commented on PR #11: URL: https://github.com/apache/karaf-minho/pull/11#issuecomment-1310221732 > @iskey can you add a test to validate please? ok, let me do some tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] jbonofre commented on pull request #11: Fix the envKey in Config.java
jbonofre commented on PR #11: URL: https://github.com/apache/karaf-minho/pull/11#issuecomment-1309994422 Thanks, let me take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] fpapon commented on pull request #11: Fix the envKey in Config.java
fpapon commented on PR #11: URL: https://github.com/apache/karaf-minho/pull/11#issuecomment-1309973304 @iskey can you add a test to validate please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] iskey opened a new pull request, #11: Fix the envKey in Config.java
iskey opened a new pull request, #11: URL: https://github.com/apache/karaf-minho/pull/11 fix #10 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] iskey opened a new issue, #10: There may be a mistake usage of `replaceAll()` for the variable `envKey` .
iskey opened a new issue, #10: URL: https://github.com/apache/karaf-minho/issues/10 There may be a mistake usage of `replaceAll()` for the variable `envKey` . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] jbonofre commented on issue #9: `ConfigService` should look for env variables/system properties automatically
jbonofre commented on issue #9: URL: https://github.com/apache/karaf-minho/issues/9#issuecomment-1293642495 Yup -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] mattrpav commented on issue #8: Add `minho-k8s` service
mattrpav commented on issue #8: URL: https://github.com/apache/karaf-minho/issues/8#issuecomment-1293636902 > Yeah the one from Fabric8 is pretty good. +1 It has good multi-version support and using the jdk-based http client would cut out a nice chunk of the transitive deps. ref: https://github.com/fabric8io/kubernetes-client/tree/master/httpclient-jdk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] jbonofre commented on issue #8: Add `minho-k8s` service
jbonofre commented on issue #8: URL: https://github.com/apache/karaf-minho/issues/8#issuecomment-1293629604 Yeah the one from Fabric8 is pretty good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] mattrpav commented on issue #9: `ConfigService` should look for env variables/system properties automatically
mattrpav commented on issue #9: URL: https://github.com/apache/karaf-minho/issues/9#issuecomment-1293627794 In the 'it would be great that': to include Kubernetes Secrets as well! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] mattrpav commented on issue #8: Add `minho-k8s` service
mattrpav commented on issue #8: URL: https://github.com/apache/karaf-minho/issues/8#issuecomment-1293625780 Did you have an existing client library in mind? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] jbonofre opened a new issue, #9: `ConfigService` should look for env variables/system properties automatically
jbonofre opened a new issue, #9: URL: https://github.com/apache/karaf-minho/issues/9 Currently, the ` ConfigService` can only be populated: 1. programmatically 2. json config service 3. properties config service It would be great that: 1. the config properties can look for env variables/system properties 2. populated automatically by k8s `ConfigMap` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] jbonofre opened a new issue, #8: Add `minho-k8s` service
jbonofre opened a new issue, #8: URL: https://github.com/apache/karaf-minho/issues/8 The idea is to create a Kubernetes client as a service in the registry. Then, other services can get the client from the registry and interact with k8s. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] jbonofre merged pull request #1: Bump jetty-server from 11.0.9 to 11.0.10 in /services/minho-http
jbonofre merged PR #1: URL: https://github.com/apache/karaf-minho/pull/1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] jbonofre opened a new issue, #7: Add exploded mode support in spring-boot
jbonofre opened a new issue, #7: URL: https://github.com/apache/karaf-minho/issues/7 Right now, Minho only supports repackaged spring boot application jar, wrapping all jar in uber jar. Then, Minho uses `JarLauncher` to launch the spring boot application. However, this is not the running mode recommended by spring boot. Minho should support running spring boot application in exploded mode (similar to spring-boot:run maven goal). It means that Minho needs: - to scan `@SpringBootApplication` annotation to find the `Main` class - to have a way (using spring boot app pom for instance) to find all dependencies to populate the classloader, leveraging Minho tooling for instance - don't use `JarLauncher` but create classloader and run instead This preparation step should be performed at build time (in Minho tooling), not at build time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] jbonofre opened a new issue, #6: Add `minho-py` service
jbonofre opened a new issue, #6: URL: https://github.com/apache/karaf-minho/issues/6 We can use graalvm for python in the `minho-py`service. Using JSR223, we can eventually abstract the language. The challenge is to handle the env setup (using pipenv or like). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] jbonofre opened a new issue, #5: Add minho-shell service
jbonofre opened a new issue, #5: URL: https://github.com/apache/karaf-minho/issues/5 Provide a `minho-shell` service providing a full shell powered by JLine/JANSI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] jbonofre opened a new issue, #4: Add `ServiceManager` allowing dynamism on the `ServiceRegistry`
jbonofre opened a new issue, #4: URL: https://github.com/apache/karaf-minho/issues/4 We could add a service manager able to dynamically manager service (adding/removing services provided in a new artifacts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] jbonofre opened a new issue, #3: Add filtering support on `ServiceRegistry`
jbonofre opened a new issue, #3:
URL: https://github.com/apache/karaf-minho/issues/3
It's possible to register several services with the same class in the
`ServiceRegistry`.
In that case, it would be great to extend the service registry with a
service key/name, and be able to do `serviceRegistry.get("key",
MyInterface.class)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [karaf-minho] jbonofre opened a new issue, #2: Add OSGi service registry bridge
jbonofre opened a new issue, #2: URL: https://github.com/apache/karaf-minho/issues/2 The purpose of the OSGi bridge service is to register an OSGi service tracker, listening any OSGi service and exposing these services in the Minho `ServiceRegistry`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-minho] dependabot[bot] opened a new pull request, #1: Bump jetty-server from 11.0.9 to 11.0.10 in /services/minho-http
dependabot[bot] opened a new pull request, #1: URL: https://github.com/apache/karaf-minho/pull/1 Bumps [jetty-server](https://github.com/eclipse/jetty.project) from 11.0.9 to 11.0.10. Release notes Sourced from https://github.com/eclipse/jetty.project/releases";>jetty-server's releases. 11.0.10 Fixed Security Advisories (CVE-2022-2047) - https://github.com/eclipse/jetty.project/security/advisories/GHSA-cj7v-27pg-wf7q";>https://github.com/eclipse/jetty.project/security/advisories/GHSA-cj7v-27pg-wf7q - Invalid URI parsing may produce invalid HttpURI.authority (CVE-2022-2048) - https://github.com/eclipse/jetty.project/security/advisories/GHSA-wgmr-mf83-7x4j";>https://github.com/eclipse/jetty.project/security/advisories/GHSA-wgmr-mf83-7x4j - Invalid HTTP/2 requests can lead to denial of service (CVE-2022-2191) - https://github.com/eclipse/jetty.project/security/advisories/GHSA-8mpp-f3f7-xc28";>https://github.com/eclipse/jetty.project/security/advisories/GHSA-8mpp-f3f7-xc28 - SslConnection does not release pooled ByteBuffers in case of errors Special Thanks to the following Eclipse Jetty community members https://github.com/jianglai";>@jianglai (Lai Jiang) https://github.com/markslater";>@markslater (markslater) https://github.com/prenagha";>@prenagha (Padraic Renaghan) Changelog https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8161";>#8161 - Improve SSLConnection buffers handling (Resolves CVE-2022-2191) https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8134";>#8134 - Improve cleanup of deflater/inflater pools for PerMessageDeflateExtension https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8088";>#8088 - Add option to configure exitVm on ShutdownMonitor from System properties https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8067";>#8067 - Wall time usage in DoSFilter RateTracker results in false positive alert https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8057";>#8057 - Support Http Response 103 (Early Hints) https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8014";>#8014 - Review HttpRequest URI construction (Resolves CVE-2022-2047) https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8008";>#8008 - Add compliance mode for LEGACY multipart parser in Jetty https://github-redirect.dependabot.com/eclipse/jetty.project/issues/7994";>#7994 - Ability to construct a detached client Request https://github-redirect.dependabot.com/eclipse/jetty.project/issues/7991";>#7991 - fix bom for jetty-cdi https://github-redirect.dependabot.com/eclipse/jetty.project/issues/7981";>#7981 - Add TRANSFER_ENCODING violation for MultiPart RFC7578 parser. https://github-redirect.dependabot.com/eclipse/jetty.project/issues/7977";>#7977 - UpgradeHttpServletRequest.setAttribute & UpgradeHttpServletRequest.removeAttribute can throw NullPointerException https://github-redirect.dependabot.com/eclipse/jetty.project/issues/7975";>#7975 - ForwardedRequestCustomizer setters do not clear existing handlers https://github-redirect.dependabot.com/eclipse/jetty.project/issues/7953";>#7953 - Fix StatisticsHandler in the case a Handler throws exception. https://github-redirect.dependabot.com/eclipse/jetty.project/issues/7935";>#7935 - Review HTTP/2 error handling (Resolves CVE-2022-2048) https://github-redirect.dependabot.com/eclipse/jetty.project/issues/7929";>#7929 - Correct requestlog formatString commented default (https://github.com/prenagha";>@prenagha) https://github-redirect.dependabot.com/eclipse/jetty.project/issues/7924";>#7924 - Fix a typo in Javadoc (https://github.com/jianglai";>@jianglai) https://github-redirect.dependabot.com/eclipse/jetty.project/issues/7918";>#7918 - PathMappings.asPathSpec does not allow root ServletPathSpec https://github-redirect.dependabot.com/eclipse/jetty.project/issues/7891";>#7891 - Better Servlet PathMappings for Regex https://github-redirect.dependabot.com/eclipse/jetty.project/issues/7880";>#7880 - DefaultServlet should not overwrite programmatically configured precompressed formats with defaults (https://github.com/markslater";>@markslater) https://github-redirect.dependabot.com/eclipse/jetty.project/issues/7863";>#7863 - Default servlet drops first accept-encoding header if there is more than one. (https://github.com/markslater";>@markslater) https://github-redirect.dependabot.com/eclipse/jetty.project/issues/7858";>#7858 - GZipHandler does not play nice with other handlers in HandlerCollection https://github-redirect.dependabot.com/eclipse/jetty.project/issues/7818";>#7818 - Modifying of HTTP headers in HttpChannel.Listener#onResponseBegin is no longer possible with Jetty https://github-redirect.dependabot.com/eclipse/jetty.project/issues/7803";>#7803 - unwrap exception until we get the first non Ser
[GitHub] [karaf-site] jbonofre merged pull request #67: [KARAF-7587] - add GraphQL row to examples on the site
jbonofre merged PR #67: URL: https://github.com/apache/karaf-site/pull/67 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-webconsole] dependabot[bot] opened a new pull request, #1: Bump camel-core from 2.6.0 to 2.24.0
dependabot[bot] opened a new pull request, #1: URL: https://github.com/apache/karaf-webconsole/pull/1 Bumps camel-core from 2.6.0 to 2.24.0. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/karaf-webconsole/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-reactive-components] dependabot[bot] opened a new pull request, #2: Bump kafka-clients from 0.11.0.0 to 0.11.0.2 in /rcomp-examples/kafka-appender
dependabot[bot] opened a new pull request, #2: URL: https://github.com/apache/karaf-reactive-components/pull/2 Bumps kafka-clients from 0.11.0.0 to 0.11.0.2. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/karaf-reactive-components/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-reactive-components] dependabot[bot] opened a new pull request, #1: Bump kafka-clients from 0.11.0.0 to 0.11.0.2 in /rcomp-kafka
dependabot[bot] opened a new pull request, #1: URL: https://github.com/apache/karaf-reactive-components/pull/1 Bumps kafka-clients from 0.11.0.0 to 0.11.0.2. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/karaf-reactive-components/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-site] tiiibs closed pull request #66: Update download.html. Not Active class
tiiibs closed pull request #66: Update download.html. Not Active class URL: https://github.com/apache/karaf-site/pull/66 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-site] tiiibs commented on pull request #66: Update download.html. Not Active class
tiiibs commented on PR #66: URL: https://github.com/apache/karaf-site/pull/66#issuecomment-1108352679 Ok. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-site] jbonofre commented on pull request #66: Update download.html. Not Active class
jbonofre commented on PR #66: URL: https://github.com/apache/karaf-site/pull/66#issuecomment-1108219626 So, let me change 4.2.x back to Active, waiting 4.2.16 to change to "Not Active". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-site] jbonofre commented on pull request #66: Update download.html. Not Active class
jbonofre commented on PR #66: URL: https://github.com/apache/karaf-site/pull/66#issuecomment-1108218835 I would wait a bit as 4.2.16 will be released, and then, it will be one of the 4.2.x series. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-site] tiiibs opened a new pull request, #66: Update download.html. Not Active class
tiiibs opened a new pull request, #66: URL: https://github.com/apache/karaf-site/pull/66 Update download.html set class="text-danger" for the branch 4.2 Note: if no version 4.2.16 is planned, next version and ETA should also be updated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-site] jbonofre merged pull request #65: Update download.html
jbonofre merged pull request #65: URL: https://github.com/apache/karaf-site/pull/65 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-site] jbonofre merged pull request #65: Update download.html
jbonofre merged pull request #65: URL: https://github.com/apache/karaf-site/pull/65 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [karaf-site] tiiibs opened a new pull request #65: Update download.html
tiiibs opened a new pull request #65: URL: https://github.com/apache/karaf-site/pull/65 Correct version from 4.2.14 to 4.2.15 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
