[GitHub] [karaf-minho] rmannibucau commented on pull request #11: Fix the envKey in Config.java

2022-11-10 Thread GitBox 


rmannibucau commented on PR #11:
URL: https://github.com/apache/karaf-minho/pull/11#issuecomment-1310698906

   Guess the regex should be extracted if config service is used at runtime 
instead of recompiled each time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [karaf-minho] rmannibucau commented on pull request #11: Fix the envKey in Config.java

2022-11-10 Thread GitBox 


rmannibucau commented on PR #11:
URL: https://github.com/apache/karaf-minho/pull/11#issuecomment-1310601291

   If possible try avoiding a mock please, it is like not testing at all at the 
end.
   Using surefire you can force some env var so it is then easy to check it is 
used or not cases IMHO.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org