[jira] [Commented] (KNOX-1237) Knox DSL should support HBase Stateless Scanner

2018-12-13 Thread Kevin Risden (JIRA) 


[ 
https://issues.apache.org/jira/browse/KNOX-1237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720655#comment-16720655
 ] 

Kevin Risden commented on KNOX-1237:


This didn't make it into 1.2.0 but reviewing over the next few days.

> Knox DSL should support HBase Stateless Scanner
> ---
>
> Key: KNOX-1237
> URL: https://issues.apache.org/jira/browse/KNOX-1237
> Project: Apache Knox
>  Issue Type: Improvement
>  Components: ClientDSL
>Reporter: Kevin Risden
>Assignee: Dequan Chen
>Priority: Minor
> Fix For: 1.3.0
>
> Attachments: KNOX-1237.patch
>
>
> KNOX-8 added support for HBase REST apis via Knox. The Knox DSL supports 
> stateful scanners as shown in the documentation 
> (https://knox.apache.org/books/knox-1-0-0/user-guide.html#table(String+tableName).scanner().create()+-+Scanner+Creation).
> HBase REST supports stateless scanners 
> ([https://hbase.apache.org/1.2/apidocs/org/apache/hadoop/hbase/rest/package-summary.html#operation_stateless_scanner])
>  which can be easily load balanced. The feature is not well documented in 
> HBase REST.
> Currently if using stateful scanners and Knox or HBase REST is being load 
> balanced, there will be an issue using that scanner. The stateless scanners 
> avoid this since they have all the information necessary.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (KNOX-1595) Support JDK 12

2018-12-13 Thread Kevin Risden (JIRA) 


 [ 
https://issues.apache.org/jira/browse/KNOX-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kevin Risden updated KNOX-1595:
---
Fix Version/s: (was: 1.3.0)
   2.0.0

> Support JDK 12
> --
>
> Key: KNOX-1595
> URL: https://issues.apache.org/jira/browse/KNOX-1595
> Project: Apache Knox
>  Issue Type: Improvement
>  Components: Build
>Reporter: Kevin Risden
>Assignee: Kevin Risden
>Priority: Major
> Fix For: 2.0.0
>
>
> Splitting JDK 12 support out specifically from KNOX-1458



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (KNOX-1677) Use try-with-resources to ensure that resources are closed

2018-12-13 Thread Kevin Risden (JIRA) 


 [ 
https://issues.apache.org/jira/browse/KNOX-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kevin Risden updated KNOX-1677:
---
Resolution: Fixed
Status: Resolved  (was: Patch Available)

> Use try-with-resources to ensure that resources are closed
> --
>
> Key: KNOX-1677
> URL: https://issues.apache.org/jira/browse/KNOX-1677
> Project: Apache Knox
>  Issue Type: Improvement
>Reporter: Kevin Risden
>Assignee: Kevin Risden
>Priority: Major
> Fix For: 1.3.0
>
> Attachments: KNOX-1677.patch
>
>
> There are places where we explicitly close() resources that can instead by 
> try-with-resources. This avoids the finally block or in other cases missing 
> the close() on an exception.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KNOX-1677) Use try-with-resources to ensure that resources are closed

2018-12-13 Thread ASF subversion and git services (JIRA) 


[ 
https://issues.apache.org/jira/browse/KNOX-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720626#comment-16720626
 ] 

ASF subversion and git services commented on KNOX-1677:
---

Commit c00066050bfaa7409f64eb112e8e52f82d66c253 in knox's branch 
refs/heads/master from [~risdenk]
[ https://git-wip-us.apache.org/repos/asf?p=knox.git;h=c000660 ]

KNOX-1677 - Use try-with-resources to ensure that resources are closed

Signed-off-by: Kevin Risden 


> Use try-with-resources to ensure that resources are closed
> --
>
> Key: KNOX-1677
> URL: https://issues.apache.org/jira/browse/KNOX-1677
> Project: Apache Knox
>  Issue Type: Improvement
>Reporter: Kevin Risden
>Assignee: Kevin Risden
>Priority: Major
> Fix For: 1.3.0
>
> Attachments: KNOX-1677.patch
>
>
> There are places where we explicitly close() resources that can instead by 
> try-with-resources. This avoids the finally block or in other cases missing 
> the close() on an exception.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KNOX-1527) Bump apacheds dependency version to 2.0.0.AM25

2018-12-13 Thread ASF subversion and git services (JIRA) 


[ 
https://issues.apache.org/jira/browse/KNOX-1527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720608#comment-16720608
 ] 

ASF subversion and git services commented on KNOX-1527:
---

Commit ecbbbd00a2240b8e25677ec5548916ea189cd87f in knox's branch 
refs/heads/master from [~risdenk]
[ https://git-wip-us.apache.org/repos/asf?p=knox.git;h=ecbbbd0 ]

KNOX-1527 - Bump apacheds dependency version to 2.0.0-AM25

Signed-off-by: Kevin Risden 


> Bump apacheds dependency version to 2.0.0.AM25
> --
>
> Key: KNOX-1527
> URL: https://issues.apache.org/jira/browse/KNOX-1527
> Project: Apache Knox
>  Issue Type: Sub-task
>Reporter: Kevin Risden
>Assignee: Kevin Risden
>Priority: Minor
> Fix For: 1.3.0
>
> Attachments: KNOX-1527.patch
>
>
> This may have to be moved to a later version of Knox since it relies on a 
> future release of Apache DS.
> Apache DS AM25 for apacheds-all is broken due to DIRSERVER-2247. We must wait 
> until AM26 is released before upgrading. KNOX-1474 upgrades to AM24.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (KNOX-1527) Bump apacheds dependency version to 2.0.0.AM25

2018-12-13 Thread Kevin Risden (JIRA) 


 [ 
https://issues.apache.org/jira/browse/KNOX-1527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kevin Risden updated KNOX-1527:
---
Resolution: Fixed
Status: Resolved  (was: Patch Available)

> Bump apacheds dependency version to 2.0.0.AM25
> --
>
> Key: KNOX-1527
> URL: https://issues.apache.org/jira/browse/KNOX-1527
> Project: Apache Knox
>  Issue Type: Sub-task
>Reporter: Kevin Risden
>Assignee: Kevin Risden
>Priority: Minor
> Fix For: 1.3.0
>
> Attachments: KNOX-1527.patch
>
>
> This may have to be moved to a later version of Knox since it relies on a 
> future release of Apache DS.
> Apache DS AM25 for apacheds-all is broken due to DIRSERVER-2247. We must wait 
> until AM26 is released before upgrading. KNOX-1474 upgrades to AM24.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (KNOX-1677) Use try-with-resources to ensure that resources are closed

2018-12-13 Thread Kevin Risden (JIRA) 


 [ 
https://issues.apache.org/jira/browse/KNOX-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kevin Risden updated KNOX-1677:
---
Description: There are places where we explicitly close() resources that 
can instead by try-with-resources. This avoids the finally block or in other 
cases missing the close() on an exception.  (was: There are places where we 
explicitly close() resources that can instead by try-with-resources. This 
avoids the finally block or in other cases missing the .close on an exception.)

> Use try-with-resources to ensure that resources are closed
> --
>
> Key: KNOX-1677
> URL: https://issues.apache.org/jira/browse/KNOX-1677
> Project: Apache Knox
>  Issue Type: Improvement
>Reporter: Kevin Risden
>Assignee: Kevin Risden
>Priority: Major
> Fix For: 1.3.0
>
> Attachments: KNOX-1677.patch
>
>
> There are places where we explicitly close() resources that can instead by 
> try-with-resources. This avoids the finally block or in other cases missing 
> the close() on an exception.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (KNOX-1677) Use try-with-resources to ensure that resources are closed

2018-12-13 Thread Kevin Risden (JIRA) 


 [ 
https://issues.apache.org/jira/browse/KNOX-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kevin Risden updated KNOX-1677:
---
Description: There are places where we explicitly close() resources that 
can instead by try-with-resources. This avoids the finally block or in other 
cases missing the .close on an exception.  (was: THere are places where we 
explicitly close() resources that can instead by try-with-resources. This 
avoids the finally block or in other cases missing the .close on an exception.)

> Use try-with-resources to ensure that resources are closed
> --
>
> Key: KNOX-1677
> URL: https://issues.apache.org/jira/browse/KNOX-1677
> Project: Apache Knox
>  Issue Type: Improvement
>Reporter: Kevin Risden
>Assignee: Kevin Risden
>Priority: Major
> Fix For: 1.3.0
>
> Attachments: KNOX-1677.patch
>
>
> There are places where we explicitly close() resources that can instead by 
> try-with-resources. This avoids the finally block or in other cases missing 
> the .close on an exception.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (KNOX-1527) Bump apacheds dependency version to 2.0.0.AM25

2018-12-13 Thread Kevin Risden (JIRA) 


 [ 
https://issues.apache.org/jira/browse/KNOX-1527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kevin Risden updated KNOX-1527:
---
Summary: Bump apacheds dependency version to 2.0.0.AM25  (was: Bump 
apacheds dependency version to 2.0.0-AM25)

> Bump apacheds dependency version to 2.0.0.AM25
> --
>
> Key: KNOX-1527
> URL: https://issues.apache.org/jira/browse/KNOX-1527
> Project: Apache Knox
>  Issue Type: Sub-task
>Reporter: Kevin Risden
>Assignee: Kevin Risden
>Priority: Minor
> Fix For: 1.3.0
>
> Attachments: KNOX-1527.patch
>
>
> This may have to be moved to a later version of Knox since it relies on a 
> future release of Apache DS.
> Apache DS AM25 for apacheds-all is broken due to DIRSERVER-2247. We must wait 
> until AM26 is released before upgrading. KNOX-1474 upgrades to AM24.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (KNOX-1527) Bump apacheds dependency version to 2.0.0-AM25

2018-12-13 Thread Kevin Risden (JIRA) 


 [ 
https://issues.apache.org/jira/browse/KNOX-1527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kevin Risden updated KNOX-1527:
---
Attachment: (was: KNOX-1527.patch)

> Bump apacheds dependency version to 2.0.0-AM25
> --
>
> Key: KNOX-1527
> URL: https://issues.apache.org/jira/browse/KNOX-1527
> Project: Apache Knox
>  Issue Type: Sub-task
>Reporter: Kevin Risden
>Assignee: Kevin Risden
>Priority: Minor
> Fix For: 1.3.0
>
>
> This may have to be moved to a later version of Knox since it relies on a 
> future release of Apache DS.
> Apache DS AM25 for apacheds-all is broken due to DIRSERVER-2247. We must wait 
> until AM26 is released before upgrading. KNOX-1474 upgrades to AM24.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (KNOX-1527) Bump apacheds dependency version to 2.0.0-AM25

2018-12-13 Thread Kevin Risden (JIRA) 


 [ 
https://issues.apache.org/jira/browse/KNOX-1527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kevin Risden updated KNOX-1527:
---
Attachment: KNOX-1527.patch
Status: Patch Available  (was: In Progress)

> Bump apacheds dependency version to 2.0.0-AM25
> --
>
> Key: KNOX-1527
> URL: https://issues.apache.org/jira/browse/KNOX-1527
> Project: Apache Knox
>  Issue Type: Sub-task
>Reporter: Kevin Risden
>Assignee: Kevin Risden
>Priority: Minor
> Fix For: 1.3.0
>
> Attachments: KNOX-1527.patch
>
>
> This may have to be moved to a later version of Knox since it relies on a 
> future release of Apache DS.
> Apache DS AM25 for apacheds-all is broken due to DIRSERVER-2247. We must wait 
> until AM26 is released before upgrading. KNOX-1474 upgrades to AM24.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KNOX-1527) Bump apacheds dependency version to 2.0.0-AM25

2018-12-13 Thread Kevin Risden (JIRA) 


[ 
https://issues.apache.org/jira/browse/KNOX-1527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720582#comment-16720582
 ] 

Kevin Risden commented on KNOX-1527:


Requires bumping apacheds.directory.api.version to 2.0.0.AM2

> Bump apacheds dependency version to 2.0.0-AM25
> --
>
> Key: KNOX-1527
> URL: https://issues.apache.org/jira/browse/KNOX-1527
> Project: Apache Knox
>  Issue Type: Sub-task
>Reporter: Kevin Risden
>Assignee: Kevin Risden
>Priority: Minor
> Fix For: 1.3.0
>
>
> This may have to be moved to a later version of Knox since it relies on a 
> future release of Apache DS.
> Apache DS AM25 for apacheds-all is broken due to DIRSERVER-2247. We must wait 
> until AM26 is released before upgrading. KNOX-1474 upgrades to AM24.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (KNOX-1677) Use try-with-resources to ensure that resources are closed

2018-12-13 Thread Kevin Risden (JIRA) 


 [ 
https://issues.apache.org/jira/browse/KNOX-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kevin Risden updated KNOX-1677:
---
Attachment: KNOX-1677.patch
Status: Patch Available  (was: In Progress)

> Use try-with-resources to ensure that resources are closed
> --
>
> Key: KNOX-1677
> URL: https://issues.apache.org/jira/browse/KNOX-1677
> Project: Apache Knox
>  Issue Type: Improvement
>Reporter: Kevin Risden
>Assignee: Kevin Risden
>Priority: Major
> Fix For: 1.3.0
>
> Attachments: KNOX-1677.patch
>
>
> THere are places where we explicitly close() resources that can instead by 
> try-with-resources. This avoids the finally block or in other cases missing 
> the .close on an exception.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KNOX-1527) Bump apacheds dependency version to 2.0.0-AM25

2018-12-13 Thread Kevin Risden (JIRA) 


[ 
https://issues.apache.org/jira/browse/KNOX-1527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720581#comment-16720581
 ] 

Kevin Risden commented on KNOX-1527:


KNOX-1638 made it possible to upgrade this since we moved away from 
apacheds-all.

> Bump apacheds dependency version to 2.0.0-AM25
> --
>
> Key: KNOX-1527
> URL: https://issues.apache.org/jira/browse/KNOX-1527
> Project: Apache Knox
>  Issue Type: Sub-task
>Reporter: Kevin Risden
>Priority: Minor
> Fix For: 1.3.0
>
>
> This may have to be moved to a later version of Knox since it relies on a 
> future release of Apache DS.
> Apache DS AM25 for apacheds-all is broken due to DIRSERVER-2247. We must wait 
> until AM26 is released before upgrading. KNOX-1474 upgrades to AM24.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Work started] (KNOX-1527) Bump apacheds dependency version to 2.0.0-AM25

2018-12-13 Thread Kevin Risden (JIRA) 


 [ 
https://issues.apache.org/jira/browse/KNOX-1527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on KNOX-1527 started by Kevin Risden.
--
> Bump apacheds dependency version to 2.0.0-AM25
> --
>
> Key: KNOX-1527
> URL: https://issues.apache.org/jira/browse/KNOX-1527
> Project: Apache Knox
>  Issue Type: Sub-task
>Reporter: Kevin Risden
>Assignee: Kevin Risden
>Priority: Minor
> Fix For: 1.3.0
>
>
> This may have to be moved to a later version of Knox since it relies on a 
> future release of Apache DS.
> Apache DS AM25 for apacheds-all is broken due to DIRSERVER-2247. We must wait 
> until AM26 is released before upgrading. KNOX-1474 upgrades to AM24.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (KNOX-1527) Bump apacheds dependency version to 2.0.0-AM25

2018-12-13 Thread Kevin Risden (JIRA) 


 [ 
https://issues.apache.org/jira/browse/KNOX-1527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kevin Risden reassigned KNOX-1527:
--

Assignee: Kevin Risden

> Bump apacheds dependency version to 2.0.0-AM25
> --
>
> Key: KNOX-1527
> URL: https://issues.apache.org/jira/browse/KNOX-1527
> Project: Apache Knox
>  Issue Type: Sub-task
>Reporter: Kevin Risden
>Assignee: Kevin Risden
>Priority: Minor
> Fix For: 1.3.0
>
>
> This may have to be moved to a later version of Knox since it relies on a 
> future release of Apache DS.
> Apache DS AM25 for apacheds-all is broken due to DIRSERVER-2247. We must wait 
> until AM26 is released before upgrading. KNOX-1474 upgrades to AM24.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (KNOX-1527) Bump apacheds dependency version to 2.0.0-AM25

2018-12-13 Thread Kevin Risden (JIRA) 


 [ 
https://issues.apache.org/jira/browse/KNOX-1527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kevin Risden updated KNOX-1527:
---
Issue Type: Sub-task  (was: Improvement)
Parent: KNOX-1655

> Bump apacheds dependency version to 2.0.0-AM25
> --
>
> Key: KNOX-1527
> URL: https://issues.apache.org/jira/browse/KNOX-1527
> Project: Apache Knox
>  Issue Type: Sub-task
>Reporter: Kevin Risden
>Priority: Minor
> Fix For: 1.3.0
>
>
> This may have to be moved to a later version of Knox since it relies on a 
> future release of Apache DS.
> Apache DS AM25 for apacheds-all is broken due to DIRSERVER-2247. We must wait 
> until AM26 is released before upgrading. KNOX-1474 upgrades to AM24.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (KNOX-1677) Use try-with-resources to ensure that resources are closed

2018-12-13 Thread Kevin Risden (JIRA) 
Kevin Risden created KNOX-1677:
--

 Summary: Use try-with-resources to ensure that resources are closed
 Key: KNOX-1677
 URL: https://issues.apache.org/jira/browse/KNOX-1677
 Project: Apache Knox
  Issue Type: Improvement
Reporter: Kevin Risden
Assignee: Kevin Risden
 Fix For: 1.3.0
 Attachments: KNOX-1677.patch

THere are places where we explicitly close() resources that can instead by 
try-with-resources. This avoids the finally block or in other cases missing the 
.close on an exception.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: [VOTE] Release Apache Knox 1.2.0 RC 4

2018-12-13 Thread Kevin Risden 
Billy - Yea we would target 1.3.0 likely unless it is a regression that we
can't ship with.

Knox 1.2.0 has a lot of fixes for YARN and JobHistoryUI - See
https://issues.apache.org/jira/browse/KNOX-1207

If you have fixes for YARNUIV2, can you see if they fix the items laid out
here - https://issues.apache.org/jira/browse/KNOX-1589

Kevin Risden


On Thu, Dec 13, 2018 at 11:53 AM Watson, Billy 
wrote:

> I have a bunch of fixes for knox yarn, yarnuiv2, jobhistoryui, etc. Is it
> too late to get those into 1.2.0 since you’re at RC stages?
>
>
>
> *Billy Watson*
>
>
>
>
>
>
> *From:*
> *Kevin Risden*
>
>
>
>
> * > Reply-To:
> "u...@knox.apache.org "  > Date: Monday, December 10, 2018 at 3:49 PM To:
> "dev@knox.apache.org "  >, "u...@knox.apache.org "
> > Subject: Re: [VOTE] Release
> Apache Knox 1.2.0 RC 4 *
>
> *   +1   Tested the following: ·  src zip - mvn verify -Ppackage,release
> ·  knoxshell - able to connect to Knox and execute a few examples ·  Ran rc
> against https://github.com/risdenk/knox-performance-tests
> 
>  to
> test unsecure webhdfs, hbase, hive ·  Manual testing of UIs with Kerberos
> ·  Zeppelin UI with websocket enabled ·  Manual testing of Knox against
> Kerberized cluster ·  knoxsso Pac4j backed by Okta ·  hadoopauth provider
> ·  token service and Bearer tokens ·  default topology url ·  topology port
> mapping ·  ambari discovery ·  hadoop group provider ·  metrics ·  ranger
> integration - via /ext loading ·  Knoxsso misconfiguration doesn't result
> in stacktrace Kevin Risden On Mon, Dec 10, 2018 at 3:40 PM Kevin Risden
> > wrote: Release candidate #4 for
> the Apache Knox 1.2.0 release is available at:
> https://dist.apache.org/repos/dist/dev/knox/knox-1.2.0/
> 
>   The release candidate is a zip archive of the sources in:
> https://git-wip-us.apache.org/repos/asf/knox.git
> 
> Branch v1.2.0 (git checkout -b v1.2.0) Tag is v1.2.0-rc4 (git checkout -b
> v1.2.0-rc4)   The KEYS file for signature validation is available
> at: https://dist.apache.org/repos/dist/release/knox/KEYS
> 
>   Please vote on releasing this package as Apache Knox 1.2.0. The vote is
> open for the next 72 hours and passes if a majority of at least three +1
> Apache Knox PMC votes are cast.   [ ] +1 Release this package as Apache
> Knox 1.2.0 [ ] -1 Do not release this package because...   Kevin Risden *
>

[jira] [Resolved] (KNOX-1665) Enable more PMD rulesets

2018-12-13 Thread Kevin Risden (JIRA) 


 [ 
https://issues.apache.org/jira/browse/KNOX-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kevin Risden resolved KNOX-1665.

Resolution: Fixed

> Enable more PMD rulesets
> 
>
> Key: KNOX-1665
> URL: https://issues.apache.org/jira/browse/KNOX-1665
> Project: Apache Knox
>  Issue Type: Improvement
>  Components: Build
>Reporter: Kevin Risden
>Assignee: Kevin Risden
>Priority: Major
> Fix For: 1.3.0
>
>
> KNOX-1615 enabled PMD for static code analysis. Would be good to look at 
> enabling more rules. Currently only performance and security rules are 
> enabled. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (KNOX-1676) Enable PMD for tests

2018-12-13 Thread Kevin Risden (JIRA) 


 [ 
https://issues.apache.org/jira/browse/KNOX-1676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kevin Risden updated KNOX-1676:
---
Resolution: Fixed
Status: Resolved  (was: Patch Available)

> Enable PMD for tests
> 
>
> Key: KNOX-1676
> URL: https://issues.apache.org/jira/browse/KNOX-1676
> Project: Apache Knox
>  Issue Type: Sub-task
>Reporter: Kevin Risden
>Assignee: Kevin Risden
>Priority: Major
> Fix For: 1.3.0
>
> Attachments: KNOX-1676.patch
>
>
> PMD should be enabled for tests as well



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KNOX-1676) Enable PMD for tests

2018-12-13 Thread Kevin Risden (JIRA) 


[ 
https://issues.apache.org/jira/browse/KNOX-1676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720378#comment-16720378
 ] 

Kevin Risden commented on KNOX-1676:


Patch that fixes PMD failures for the previously enabled rules. Biggest change 
was making sure that expected try/catch blocks have an assertion to make sure 
they don't just fall through incorrectly.

> Enable PMD for tests
> 
>
> Key: KNOX-1676
> URL: https://issues.apache.org/jira/browse/KNOX-1676
> Project: Apache Knox
>  Issue Type: Sub-task
>Reporter: Kevin Risden
>Assignee: Kevin Risden
>Priority: Major
> Fix For: 1.3.0
>
> Attachments: KNOX-1676.patch
>
>
> PMD should be enabled for tests as well



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KNOX-1676) Enable PMD for tests

2018-12-13 Thread ASF subversion and git services (JIRA) 


[ 
https://issues.apache.org/jira/browse/KNOX-1676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720380#comment-16720380
 ] 

ASF subversion and git services commented on KNOX-1676:
---

Commit 89caa5feeed706abc8d7ce1407830ae00d97d405 in knox's branch 
refs/heads/master from [~risdenk]
[ https://git-wip-us.apache.org/repos/asf?p=knox.git;h=89caa5f ]

KNOX-1676 - Enable PMD for tests

Signed-off-by: Kevin Risden 


> Enable PMD for tests
> 
>
> Key: KNOX-1676
> URL: https://issues.apache.org/jira/browse/KNOX-1676
> Project: Apache Knox
>  Issue Type: Sub-task
>Reporter: Kevin Risden
>Assignee: Kevin Risden
>Priority: Major
> Fix For: 1.3.0
>
> Attachments: KNOX-1676.patch
>
>
> PMD should be enabled for tests as well



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (KNOX-1676) Enable PMD for tests

2018-12-13 Thread Kevin Risden (JIRA) 


 [ 
https://issues.apache.org/jira/browse/KNOX-1676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kevin Risden updated KNOX-1676:
---
Attachment: KNOX-1676.patch
Status: Patch Available  (was: In Progress)

> Enable PMD for tests
> 
>
> Key: KNOX-1676
> URL: https://issues.apache.org/jira/browse/KNOX-1676
> Project: Apache Knox
>  Issue Type: Sub-task
>Reporter: Kevin Risden
>Assignee: Kevin Risden
>Priority: Major
> Fix For: 1.3.0
>
> Attachments: KNOX-1676.patch
>
>
> PMD should be enabled for tests as well



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Work started] (KNOX-1665) Enable more PMD rulesets

2018-12-13 Thread Kevin Risden (JIRA) 


 [ 
https://issues.apache.org/jira/browse/KNOX-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on KNOX-1665 started by Kevin Risden.
--
> Enable more PMD rulesets
> 
>
> Key: KNOX-1665
> URL: https://issues.apache.org/jira/browse/KNOX-1665
> Project: Apache Knox
>  Issue Type: Improvement
>  Components: Build
>Reporter: Kevin Risden
>Assignee: Kevin Risden
>Priority: Major
> Fix For: 1.3.0
>
>
> KNOX-1615 enabled PMD for static code analysis. Would be good to look at 
> enabling more rules. Currently only performance and security rules are 
> enabled. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Work started] (KNOX-1676) Enable PMD for tests

2018-12-13 Thread Kevin Risden (JIRA) 


 [ 
https://issues.apache.org/jira/browse/KNOX-1676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on KNOX-1676 started by Kevin Risden.
--
> Enable PMD for tests
> 
>
> Key: KNOX-1676
> URL: https://issues.apache.org/jira/browse/KNOX-1676
> Project: Apache Knox
>  Issue Type: Sub-task
>Reporter: Kevin Risden
>Assignee: Kevin Risden
>Priority: Major
> Fix For: 1.3.0
>
>
> PMD should be enabled for tests as well



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (KNOX-1676) Enable PMD for tests

2018-12-13 Thread Kevin Risden (JIRA) 
Kevin Risden created KNOX-1676:
--

 Summary: Enable PMD for tests
 Key: KNOX-1676
 URL: https://issues.apache.org/jira/browse/KNOX-1676
 Project: Apache Knox
  Issue Type: Sub-task
Reporter: Kevin Risden
Assignee: Kevin Risden
 Fix For: 1.3.0


PMD should be enabled for tests as well



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Reopened] (KNOX-1665) Enable more PMD rulesets

2018-12-13 Thread Kevin Risden (JIRA) 


 [ 
https://issues.apache.org/jira/browse/KNOX-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kevin Risden reopened KNOX-1665:


Reopening since PMD doesn't target tests by default.

> Enable more PMD rulesets
> 
>
> Key: KNOX-1665
> URL: https://issues.apache.org/jira/browse/KNOX-1665
> Project: Apache Knox
>  Issue Type: Improvement
>  Components: Build
>Reporter: Kevin Risden
>Assignee: Kevin Risden
>Priority: Major
> Fix For: 1.3.0
>
>
> KNOX-1615 enabled PMD for static code analysis. Would be good to look at 
> enabling more rules. Currently only performance and security rules are 
> enabled. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)