[jira] [Commented] (KNOX-876) Fix FindBugs "Experimental" issues
[ https://issues.apache.org/jira/browse/KNOX-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878379#comment-15878379 ] ASF subversion and git services commented on KNOX-876: -- Commit 2d51810c2b9123a9ff6be1a6d269efecc32ba16f in knox's branch refs/heads/master from [~lmccay] [ https://git-wip-us.apache.org/repos/asf?p=knox.git;h=2d51810 ] KNOX-876 - Fix FindBugs "Experimental" issues (Colm O hEigeartaigh via lmccay) > Fix FindBugs "Experimental" issues > -- > > Key: KNOX-876 > URL: https://issues.apache.org/jira/browse/KNOX-876 > Project: Apache Knox > Issue Type: Improvement >Affects Versions: 0.11.0 >Reporter: Colm O hEigeartaigh >Assignee: Colm O hEigeartaigh > Fix For: 0.12.0 > > Attachments: 0001-KNOX-876-Fix-FindBugs-Experimental-issues.patch > > > This task is to fix the FindBugs "Experimental" issues - namely to use > try-with-resources to ensure that input/output streams are properly closed on > exception. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (KNOX-876) Fix FindBugs "Experimental" issues
[ https://issues.apache.org/jira/browse/KNOX-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878383#comment-15878383 ] Larry McCay commented on KNOX-876: -- [~coheigea] - I've committed this to master and therefore 0.12.0 - thanks for the contribution! > Fix FindBugs "Experimental" issues > -- > > Key: KNOX-876 > URL: https://issues.apache.org/jira/browse/KNOX-876 > Project: Apache Knox > Issue Type: Improvement >Affects Versions: 0.11.0 >Reporter: Colm O hEigeartaigh >Assignee: Colm O hEigeartaigh > Fix For: 0.12.0 > > Attachments: 0001-KNOX-876-Fix-FindBugs-Experimental-issues.patch > > > This task is to fix the FindBugs "Experimental" issues - namely to use > try-with-resources to ensure that input/output streams are properly closed on > exception. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (KNOX-876) Fix FindBugs "Experimental" issues
[ https://issues.apache.org/jira/browse/KNOX-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15877418#comment-15877418 ] Larry McCay commented on KNOX-876: -- [~coheigea] - this no longer applies cleanly. Can you rebase and resubmit a patch? > Fix FindBugs "Experimental" issues > -- > > Key: KNOX-876 > URL: https://issues.apache.org/jira/browse/KNOX-876 > Project: Apache Knox > Issue Type: Improvement >Affects Versions: 0.11.0 >Reporter: Colm O hEigeartaigh >Assignee: Colm O hEigeartaigh > Fix For: 0.12.0 > > Attachments: 0001-KNOX-876-Fix-FindBugs-Experimental-issues.patch > > > This task is to fix the FindBugs "Experimental" issues - namely to use > try-with-resources to ensure that input/output streams are properly closed on > exception. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (KNOX-876) Fix FindBugs "Experimental" issues
[ https://issues.apache.org/jira/browse/KNOX-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15861371#comment-15861371 ] Sandeep More commented on KNOX-876: --- Interesting, thanks [~coheigea] for pointing out issues with Java 1.6. Unfortunately our [quickstart guide | http://knox.apache.org/books/knox-0-11-0/user-guide.html#Quick+Start] states bq. Java 1.6 or later is required for the Knox Gateway runtime I will update it to 1.7 in the docs going forward. > Fix FindBugs "Experimental" issues > -- > > Key: KNOX-876 > URL: https://issues.apache.org/jira/browse/KNOX-876 > Project: Apache Knox > Issue Type: Improvement >Affects Versions: 0.11.0 >Reporter: Colm O hEigeartaigh >Assignee: Colm O hEigeartaigh > Fix For: 0.12.0 > > Attachments: 0001-KNOX-876-Fix-FindBugs-Experimental-issues.patch > > > This task is to fix the FindBugs "Experimental" issues - namely to use > try-with-resources to ensure that input/output streams are properly closed on > exception. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (KNOX-876) Fix FindBugs "Experimental" issues
[ https://issues.apache.org/jira/browse/KNOX-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15861256#comment-15861256 ] Larry McCay commented on KNOX-876: -- [~coheigea] - thanks for trying that out! I wanted to do the same. I will move it back into 0.12.0 but will also consider it lower priority and may move it back out again. It does address one resource leak - it seems. So, it would be good to get that one fixed at least. The other one was fixed in another patch - although it was done with a finally block. :) I'm trying to get to balance getting the release out within our recent cadence while still meeting our stated goal for it. KnoxShell improvements are the stated focus as described in kip-4. > Fix FindBugs "Experimental" issues > -- > > Key: KNOX-876 > URL: https://issues.apache.org/jira/browse/KNOX-876 > Project: Apache Knox > Issue Type: Improvement >Affects Versions: 0.11.0 >Reporter: Colm O hEigeartaigh >Assignee: Colm O hEigeartaigh > Fix For: 0.12.0 > > Attachments: 0001-KNOX-876-Fix-FindBugs-Experimental-issues.patch > > > This task is to fix the FindBugs "Experimental" issues - namely to use > try-with-resources to ensure that input/output streams are properly closed on > exception. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (KNOX-876) Fix FindBugs "Experimental" issues
[ https://issues.apache.org/jira/browse/KNOX-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15860962#comment-15860962 ] Colm O hEigeartaigh commented on KNOX-876: -- Hi [~lmccay], I've no objection to getting this in for 0.13.0 instead - however, the compiler plugin for Knox uses a source + target compiler version of 1.7. When I bumped it down to 1.6 + tried to compile with 1.6 I hit problems straight away with the source. So from my POV Knox 0.12.0 does not support JDK 1.6 at all. Colm. > Fix FindBugs "Experimental" issues > -- > > Key: KNOX-876 > URL: https://issues.apache.org/jira/browse/KNOX-876 > Project: Apache Knox > Issue Type: Improvement >Affects Versions: 0.11.0 >Reporter: Colm O hEigeartaigh >Assignee: Colm O hEigeartaigh > Fix For: 0.13.0 > > Attachments: 0001-KNOX-876-Fix-FindBugs-Experimental-issues.patch > > > This task is to fix the FindBugs "Experimental" issues - namely to use > try-with-resources to ensure that input/output streams are properly closed on > exception. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (KNOX-876) Fix FindBugs "Experimental" issues
[ https://issues.apache.org/jira/browse/KNOX-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15860115#comment-15860115 ] Larry McCay commented on KNOX-876: -- Hi [~coheigea] - I am thinking that we should move this out to 0.13.0. While no one should be using java 6 anymore, I don't want to destabilize the 0.12.0 release with the possibility of breaking folks still on 6. Let's bring it up on a DISCUSS thread for 0.13.0 and set expectations properly. > Fix FindBugs "Experimental" issues > -- > > Key: KNOX-876 > URL: https://issues.apache.org/jira/browse/KNOX-876 > Project: Apache Knox > Issue Type: Improvement >Affects Versions: 0.11.0 >Reporter: Colm O hEigeartaigh >Assignee: Colm O hEigeartaigh > Fix For: 0.13.0 > > Attachments: 0001-KNOX-876-Fix-FindBugs-Experimental-issues.patch > > > This task is to fix the FindBugs "Experimental" issues - namely to use > try-with-resources to ensure that input/output streams are properly closed on > exception. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
