Re: Thinking about renaming TabletPeer

2017-05-04 Thread Mike Percy
FYI the TabletPeer -> TabletReplica rename patch just landed:
https://github.com/apache/kudu/commit/7f72105b79b36480d132e0ed10f4cc
7fbabd6dca

It touched a lot of files so you might want to rebase soon to avoid
conflicts.

Thanks,
Mike

On Thu, May 4, 2017 at 1:48 PM, Mike Percy  wrote:

> I posted a CR to rename TabletPeer to TabletReplica here:
> https://gerrit.cloudera.org/#/c/6794/
>
> On Wed, May 3, 2017 at 1:35 PM, Hao Hao  wrote:
>
>> +1 on TabletReplica.
>>
>> On Wed, May 3, 2017 at 1:27 PM, William Berkeley 
>> wrote:
>>
>> > +1 TabletReplica
>> > On Wed, May 3, 2017 at 13:11 Andrew Wong  wrote:
>> >
>> > > I agree, TabletReplica seems clear.
>> > >
>> > >
>> > > On Wed, May 3, 2017 at 1:05 PM  wrote:
>> > >
>> > > > none seems better than TabletReplica IMO.
>> > > >
>> > >
>> >
>>
>
>


Re: Thinking about renaming TabletPeer

2017-05-03 Thread Todd Lipcon
Sure, I think TabletReplica could be more clear. ReplicatedTablet seems not
quite right, since it's also used for non-replicated (1-replica) cases.

I sort of feel like there's some better name out there, but can't quite
think of one. Anyone else have some ideas to brainstorm?

-Todd

On Tue, May 2, 2017 at 7:42 PM, Mike Percy  wrote:

> It would be nice to rename TabletPeer. What do you guys think? It's kind of
> a confusingly named class.
>
> I think a better class name would be ReplicatedTablet or TabletReplica.
>
> Mike
>



-- 
Todd Lipcon
Software Engineer, Cloudera