Re: Review Request 64060: KYLIN-3058 We should limit the integer type ID for "Kafka Setting" in "Streaming Cluster" page
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64060/
---
(Updated 十一月 28, 2017, 4:49 a.m.)
Review request for kylin, Dayue Gao, Dong Li, hongbin ma, and Wang Xiaoyu.
Changes
---
I have checked the all web pages, and find the other input limition issues.
Then I repaired them, and update the patch, please check it, thanks!
Bugs: KYLIN-3058
https://issues.apache.org/jira/browse/KYLIN-3058
Repository: kylin
Description
---
When you create or edit one streaming table, then set a non-integer type ID for
"Kafka Setting" in "Streaming Cluster" page, at last save it, you will find an
error message page will pop up.
1. Create a streaming table, then set a non-integer type ID to save, such as
"23a", you will get the error message page;
2. Edit a streaming table, then modify a non-integer type ID to save, such as
"23a", you will also get another error message page;
In order to find out the cause of the problem, I analyze the Kylin server log,
then I find the error, as follow:
Kylin server log
2017-11-24 18:46:07,413 ERROR [http-bio-7070-exec-14]
controller.StreamingController:280 : The data KafkaConfig definition is invalid.
com.fasterxml.jackson.databind.exc.InvalidFormatException: Can not construct
instance of int from String value '23a': not a valid Integer value
at [Source:
{"uuid":"261e36cd-599e-4306-93b2-add0291de588","last_modified":1511520352482,"version":"2.3.0.20500","name":"DEFAULT.STREAMING_TABLE","clusters":[{"uuid":null,"last_modified":0,"version":"2.3.0.20500","brokers":[
Unknown macro: {"id"}
],"newBroker":{"id":"23a","host":"1","port":1}}],"topic":"kafka
topic","timeout":6,"parserName":"org.apache.kylin.source.kafka.TimedJsonStreamParser","timestampField":null,"margin":0,"parserProperties":"tsColName=datetime"};
Then I find the server code, it also show the ID must be integer, as follow:
public class BrokerConfig implements Serializable{
@JsonProperty("id")
private int id;
It means the parameter ID isn't allowed for non-integer types, so we should
solve it at the web page.
Diffs (updated)
-
webapp/app/partials/cubeDesigner/advanced_settings.html 5d53075
webapp/app/partials/cubeDesigner/measures.html aa7a096
webapp/app/partials/cubeDesigner/streamingConfig.html 5dc9788
Diff: https://reviews.apache.org/r/64060/diff/3/
Changes: https://reviews.apache.org/r/64060/diff/2-3/
Testing
---
Thanks,
pengjianhua
[jira] [Created] (KYLIN-3065) Add 'First' and 'Last' button in case 'Query History' is too much
peng.jianhua created KYLIN-3065: --- Summary: Add 'First' and 'Last' button in case 'Query History' is too much Key: KYLIN-3065 URL: https://issues.apache.org/jira/browse/KYLIN-3065 Project: Kylin Issue Type: Improvement Components: Web Reporter: peng.jianhua Assignee: peng.jianhua Priority: Minor When the 'Query History' or 'Saved Queries' is too much.Just 'Previous' and 'Next' can not meet the demand. So I add some attributes for the label 'Pagination'. The following 01.png is the comparison picture. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
Review Request 64108: KYLIN-3063 load-hive-conf.sh should not get the commented configuration item
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64108/ --- Review request for kylin, Dayue Gao, Dong Li, hongbin ma, and Wang Xiaoyu. Bugs: KYLIN-3063 https://issues.apache.org/jira/browse/KYLIN-3063 Repository: kylin Description --- load-hive-conf.sh should not get the commented configuration item Diffs - build/bin/load-hive-conf.sh 7639a344f Diff: https://reviews.apache.org/r/64108/diff/1/ Testing --- Thanks, pengjianhua
Re: Oops...failed to load jobs
What's your Kylin version? Line number matters to trace down NPE. On Thu, Nov 23, 2017 at 1:52 PM, 周湘伦 wrote: > Hi,all > I encountered a thorny problem: > Early in the morning，I built a time-consuming cube，then caused memory leak, > and kylin been killed . After i restarted the kylin ,when I click on the > monitor tag on the page, remind me:failed to load jobs. And the log as > below: > 13:36:58.633 [http-bio-7070-exec-3] ERROR > org.apache.kylin.rest.controller.BasicController - > org.apache.kylin.rest.exception.InternalErrorException: > java.lang.NullPointerException > at > org.apache.kylin.rest.controller.JobController.list(JobController.java:76) > ~[kylin-server-base-2.0.0.jar:2.0.0] > at sun.reflect.GeneratedMethodAccessor127.invoke(Unknown Source) ~[?:?] > at > sun.reflect.DelegatingMethodAccessorImpl.invoke( > DelegatingMethodAccessorImpl.java:43) > ~[?:1.8.0_131] > at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_131] > at > org.springframework.web.method.support.InvocableHandlerMethod.doInvoke( > InvocableHandlerMethod.java:221) > ~[spring-web-3.2.17.RELEASE.jar:3.2.17.RELEASE] > at > org.springframework.web.method.support.InvocableHandlerMethod. > invokeForRequest(InvocableHandlerMethod.java:136) > ~[spring-web-3.2.17.RELEASE.jar:3.2.17.RELEASE] > at > org.springframework.web.servlet.mvc.method.annotation. > ServletInvocableHandlerMethod.invokeAndHandle( > ServletInvocableHandlerMethod.java:104) > ~[spring-webmvc-3.2.17.RELEASE.jar:3.2.17.RELEASE] > at > org.springframework.web.servlet.mvc.method.annotation. > RequestMappingHandlerAdapter.invokeHandleMethod( > RequestMappingHandlerAdapter.java:743) > ~[spring-webmvc-3.2.17.RELEASE.jar:3.2.17.RELEASE] > at > org.springframework.web.servlet.mvc.method.annotation. > RequestMappingHandlerAdapter.handleInternal(RequestMappingHandlerAdapter. > java:672) > ~[spring-webmvc-3.2.17.RELEASE.jar:3.2.17.RELEASE] > at > org.springframework.web.servlet.mvc.method.AbstractHandlerMethodAdapter. > handle(AbstractHandlerMethodAdapter.java:82) > ~[spring-webmvc-3.2.17.RELEASE.jar:3.2.17.RELEASE] > > The jobs of other projects is ok.I can see other projects' jobs in web > page. > In addition, I can still query in this project. > First,I thought it was HBase's problem. Then i restart hbase. > But the problem remains unsolved,then i restarted hadoop habse zookeeper > hive kylin , the problem still exists! > > How can i resolve this problem?If any body has idea about this problem , > please help me ,and if anyone need more logs, i also can give more logs. > > Thanks a lot. >
[jira] [Created] (KYLIN-3064) Yarn timeline-service will start jersey client, remove it
yiming.xu created KYLIN-3064: Summary: Yarn timeline-service will start jersey client, remove it Key: KYLIN-3064 URL: https://issues.apache.org/jira/browse/KYLIN-3064 Project: Kylin Issue Type: Bug Reporter: yiming.xu Priority: Minor We not used timeline service, when the yarn.timeline-service.enabled is true, yarn client will start a jersey client, it will use many resources. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (KYLIN-3063) load-hive-conf.sh should not get the commented configuration item
peng.jianhua created KYLIN-3063: --- Summary: load-hive-conf.sh should not get the commented configuration item Key: KYLIN-3063 URL: https://issues.apache.org/jira/browse/KYLIN-3063 Project: Kylin Issue Type: Bug Components: General Affects Versions: v2.2.0 Reporter: peng.jianhua Assignee: peng.jianhua Priority: Minor load-hive-conf.sh should not get the commented configuration item in kylin_hive_conf.xml -- This message was sent by Atlassian JIRA (v6.4.14#64029)
Re: Review Request 63946: KYLIN-3049 Filter the invalid zero value of "Auto Merge Thresholds" parameter when you create or upate a cube.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63946/ --- (Updated 十一月 27, 2017, 9:27 a.m.) Review request for kylin, Dayue Gao, Dong Li, hongbin ma, and Wang Xiaoyu. Changes --- Thanks for your suggestion, I have updated the patch. 1. modify the $scope.prepareCube function 2. add the function 'removeElementInArrayByValue' in utils.js please check it, thanks! Bugs: KYLIN-3049 https://issues.apache.org/jira/browse/KYLIN-3049 Repository: kylin Description --- 1. Open the Model page; 2. Create a new cube, click the "New Thresholds" button in the "Refresh Setting" tab, and don't input any value, then complete the follow steps, at last save it; 3. Choose the cube you just created, go to the "Refresh Setting" tab, you will find the zero hours in "Auto Merge Thresholds" list, which is invalid but saved in the server; 4. Similarly, update a existent cube, do the same steps, you will also find the invalid zero value saved in the server. As we know, the zero value of "Auto Merge Thresholds" parameter is invalid, so we should filter it before sending it to server. Diffs (updated) - webapp/app/js/controllers/cubeEdit.js 5f78b61 webapp/app/js/utils/utils.js 30ad261 Diff: https://reviews.apache.org/r/63946/diff/3/ Changes: https://reviews.apache.org/r/63946/diff/2-3/ Testing --- Thanks, pengjianhua
