[GitHub] shaofengshi commented on issue #285: KYLIN-3597 fix sonar reported issues

2018-10-10 Thread GitBox
shaofengshi commented on issue #285: KYLIN-3597 fix sonar reported issues
URL: https://github.com/apache/kylin/pull/285#issuecomment-428812522
 
 
   Integration test failed, I'm checking.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


LDAP Sync issue - Empty filter; nested exception is javax.naming.directory.InvalidSearchFilterException

2018-10-10 Thread premkumar
Hi - Please help us to solve the below issue to sync with LDAP

Below is the kylin ldap configuration . 

kylin.security.profile=ldap
kylin.security.acl.admin-role=ROLE_KYLIN-ADMIN-GROUP

kylin.security.ldap.connection-server=ldap://:389
kylin.security.ldap.connection-username=*
kylin.security.ldap.connection-password=*

kylin.security.ldap.user-search-base=OU=,OU=Applications,DC=,DC=com

kylin.security.ldap.user-search-pattern=(&(cn={0}))  --tried with many
options but still same issue as below (CN=*,
OU=Applications,OU=Groups,DC=bcbsfl,DC=com) (uid=*)

#kylin.security.ldap.user-search-filter=CN=*,OU=Hadoop,DC=,DC=com

kylin.security.ldap.user-group-search-base=OU=Requested,OU=Groups,DC=*,DC=com


org.springframework.security.authentication.InternalAuthenticationServiceException:
Empty filter; nested exception is
javax.naming.directory.InvalidSearchFilterException: Empty filter; remaining
name '/'
at
org.springframework.security.ldap.authentication.LdapAuthenticationProvider.doAuthentication(LdapAuthenticationProvider.java:206)
at
org.springframework.security.ldap.authentication.AbstractLdapAuthenticationProvider.authenticate(AbstractLdapAuthenticationProvider.java:85)
at
org.apache.kylin.rest.security.KylinAuthenticationProvider.authenticate(KylinAuthenticationProvider.java:94)
at
org.springframework.security.authentication.ProviderManager.authenticate(ProviderManager.java:174)
at
org.springframework.security.authentication.ProviderManager.authenticate(ProviderManager.java:199)
at
org.springframework.security.web.authentication.www.BasicAuthenticationFilter.doFilterInternal(BasicAuthenticationFilter.java:180)
at
org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107)
at
org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:331)
at
org.springframework.security.web.authentication.AbstractAuthenticationProcessingFilter.doFilter(AbstractAuthenticationProcessingFilter.java:200)
at
org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:331)
at
org.springframework.security.web.authentication.logout.LogoutFilter.doFilter(LogoutFilter.java:116)
at
org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:331)
at
org.springframework.security.web.header.HeaderWriterFilter.doFilterInternal(HeaderWriterFilter.java:64)
at
org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107)
at
org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:331)
at
org.springframework.security.web.context.request.async.WebAsyncManagerIntegrationFilter.doFilterInternal(WebAsyncManagerIntegrationFilter.java:56)


--
Sent from: http://apache-kylin.74782.x6.nabble.com/


[GitHub] codecov-io commented on issue #285: KYLIN-3597 fix sonar reported issues

2018-10-10 Thread GitBox
codecov-io commented on issue #285: KYLIN-3597 fix sonar reported issues
URL: https://github.com/apache/kylin/pull/285#issuecomment-428542798
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/285?src=pr=h1) Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@d2a2864`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `36.36%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/kylin/pull/285/graphs/tree.svg?width=650=JawVgbgsVo=150=pr)](https://codecov.io/gh/apache/kylin/pull/285?src=pr=tree)
   
   ```diff
   @@   Coverage Diff@@
   ## master#285   +/-   ##
   
 Coverage  ?   21.3%   
 Complexity?4437   
   
 Files ?1087   
 Lines ?   69912   
 Branches  ?   10100   
   
 Hits  ?   14893   
 Misses?   53618   
 Partials  ?1401
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/kylin/pull/285?src=pr=tree) | Coverage Δ 
| Complexity Δ | |
   |---|---|---|---|
   | 
[...in/storage/hbase/util/GridTableHBaseBenchmark.java](https://codecov.io/gh/apache/kylin/pull/285/diff?src=pr=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS91dGlsL0dyaWRUYWJsZUhCYXNlQmVuY2htYXJrLmphdmE=)
 | `0% <0%> (ø)` | `0 <0> (?)` | |
   | 
[.../apache/kylin/common/persistence/ResourceTool.java](https://codecov.io/gh/apache/kylin/pull/285/diff?src=pr=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9wZXJzaXN0ZW5jZS9SZXNvdXJjZVRvb2wuamF2YQ==)
 | `24.65% <100%> (ø)` | `13 <0> (?)` | |
   | 
[...he/kylin/common/persistence/HDFSResourceStore.java](https://codecov.io/gh/apache/kylin/pull/285/diff?src=pr=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9wZXJzaXN0ZW5jZS9IREZTUmVzb3VyY2VTdG9yZS5qYXZh)
 | `23% <33.33%> (ø)` | `5 <0> (?)` | |
   | 
[...apache/kylin/common/persistence/ResourceStore.java](https://codecov.io/gh/apache/kylin/pull/285/diff?src=pr=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9wZXJzaXN0ZW5jZS9SZXNvdXJjZVN0b3JlLmphdmE=)
 | `62% <75%> (ø)` | `29 <0> (?)` | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/kylin/pull/285?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/kylin/pull/285?src=pr=footer). Last 
update 
[d2a2864...e30622d](https://codecov.io/gh/apache/kylin/pull/285?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] shaofengshi opened a new pull request #285: KYLIN-3597 fix sonar reported issues

2018-10-10 Thread GitBox
shaofengshi opened a new pull request #285: KYLIN-3597 fix sonar reported issues
URL: https://github.com/apache/kylin/pull/285
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] asfgit commented on issue #285: KYLIN-3597 fix sonar reported issues

2018-10-10 Thread GitBox
asfgit commented on issue #285: KYLIN-3597 fix sonar reported issues
URL: https://github.com/apache/kylin/pull/285#issuecomment-428535706
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] shaofengshi closed pull request #284: KYLIN-3272 Upgrade Spark to 2.3.2

2018-10-10 Thread GitBox
shaofengshi closed pull request #284: KYLIN-3272 Upgrade Spark to 2.3.2
URL: https://github.com/apache/kylin/pull/284
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/build/script/download-spark.sh b/build/script/download-spark.sh
index ed904b54d4..1b61145180 100755
--- a/build/script/download-spark.sh
+++ b/build/script/download-spark.sh
@@ -27,8 +27,8 @@ if [[ `uname -a` =~ "Darwin" ]]; then
 alias md5cmd="md5 -q"
 fi
 
-spark_version="2.1.2"
-spark_pkg_md5="b47cf199bf78042a0471b9a5ae0ceeac"
+spark_version="2.3.2"
+spark_pkg_md5="01b3e6aef0ef574e066d15e035b9b2dd"
 
 if [ ! -f "build/spark-${spark_version}-bin-hadoop2.7.tgz" ]
 then
diff --git 
a/engine-spark/src/main/java/org/apache/kylin/engine/spark/KylinKryoRegistrator.java
 
b/engine-spark/src/main/java/org/apache/kylin/engine/spark/KylinKryoRegistrator.java
index a13f96ae4b..ed623d7bc7 100644
--- 
a/engine-spark/src/main/java/org/apache/kylin/engine/spark/KylinKryoRegistrator.java
+++ 
b/engine-spark/src/main/java/org/apache/kylin/engine/spark/KylinKryoRegistrator.java
@@ -111,6 +111,9 @@ public void registerClasses(Kryo kryo) {
 addClassQuitely(kyroClasses, 
"org.apache.spark.sql.catalyst.expressions.GenericInternalRow");
 addClassQuitely(kyroClasses, 
"org.apache.spark.unsafe.types.UTF8String");
 
+addClassQuitely(kyroClasses, 
"org.apache.spark.internal.io.FileCommitProtocol$TaskCommitMessage");
+addClassQuitely(kyroClasses, 
"scala.collection.immutable.Set$EmptySet$");
+
 for (Class kyroClass : kyroClasses) {
 kryo.register(kyroClass);
 }
diff --git a/pom.xml b/pom.xml
index c973d1abce..264583d048 100644
--- a/pom.xml
+++ b/pom.xml
@@ -60,7 +60,7 @@
 1.0.0
 
 
-2.1.2
+2.3.2
 4.0.0
 
 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services