[jira] [Updated] (LENS-885) Cleanup of Cube test cases

[Rajat Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-885:
--
Attachment: LENS-885.03.patch

> Cleanup of Cube test cases
> --
>
> Key: LENS-885
> URL: https://issues.apache.org/jira/browse/LENS-885
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: build
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-885.03.patch
>
>
> * Some functions are wrongly placed. e.g. DateUtil.getCeilDate(date, 
> updatePeriod) can be better expressed as updatePeriod.getCeilDate(date).
> * Date parsing from query can be cached
> * There is a bloat of Date variables in CubeTestSetup, organize them and only 
> keep named variables for the most used ones
> * Unify time range clause creation across test cases. Right now, tests create 
> time ranges as and when needed. Remove repetition and redundancies. 
> * Correct names to variables



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-885) Cleanup of Cube test cases

[Rajat Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-885:
--
Status: Patch Available  (was: In Progress)

> Cleanup of Cube test cases
> --
>
> Key: LENS-885
> URL: https://issues.apache.org/jira/browse/LENS-885
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: build
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-885.03.patch
>
>
> * Some functions are wrongly placed. e.g. DateUtil.getCeilDate(date, 
> updatePeriod) can be better expressed as updatePeriod.getCeilDate(date).
> * Date parsing from query can be cached
> * There is a bloat of Date variables in CubeTestSetup, organize them and only 
> keep named variables for the most used ones
> * Unify time range clause creation across test cases. Right now, tests create 
> time ranges as and when needed. Remove repetition and redundancies. 
> * Correct names to variables



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-885) Cleanup of Cube test cases

[Rajat Khandelwal (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15052352#comment-15052352
 ] 

Rajat Khandelwal commented on LENS-885:
---

Taking patch from reviewboard and attaching

> Cleanup of Cube test cases
> --
>
> Key: LENS-885
> URL: https://issues.apache.org/jira/browse/LENS-885
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: build
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-885.03.patch
>
>
> * Some functions are wrongly placed. e.g. DateUtil.getCeilDate(date, 
> updatePeriod) can be better expressed as updatePeriod.getCeilDate(date).
> * Date parsing from query can be cached
> * There is a bloat of Date variables in CubeTestSetup, organize them and only 
> keep named variables for the most used ones
> * Unify time range clause creation across test cases. Right now, tests create 
> time ranges as and when needed. Remove repetition and redundancies. 
> * Correct names to variables



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 40739: LENS-885: Cleanup of Cube test cases

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40739/
---

(Updated Dec. 11, 2015, 1:09 p.m.)


Review request for lens.


Bugs: LENS-885
https://issues.apache.org/jira/browse/LENS-885


Repository: lens


Description
---

* Some functions are wrongly placed. e.g. DateUtil.getCeilDate(date, 
updatePeriod) can be better expressed as updatePeriod.getCeilDate(date).
* Date parsing from query can be cached
* There is a bloat of Date variables in CubeTestSetup, organize them and only 
keep named variables for the most used ones
* Unify time range clause creation across test cases. Right now, tests create 
time ranges as and when needed. Remove repetition and redundancies. 
* Correct names to variables


Diffs (updated)
-

  lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeColumn.java 
a2a00d2c60077a41eb9576901f1702fd94473cc7 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 
d6bfb795373674f77705a2df14a9f24695a76a1a 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/DateUtil.java 
PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRange.java 
01069a587c77230bddbae543eba799c2ce495a19 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/TimeRange.java 
PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/UpdatePeriod.java 
4c76a69d0e2986d450d81b8cbed877995696ba0d 
  
lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/EndsAndHolesPartitionTimeline.java
 9d5e264b725ba57ced7618dc2be9de9bcc7983f8 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 
7f8146158c1e2d883ee9327c4bf847883d0e1004 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
 9c8b5b9fece146bcf0fa7d5048b93b236cd3d557 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java 
cd05c68647e44c1fa96302840330dfd774952e73 
  lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 
200a48cd67e6a5a381ef3723a3adb686d8347efb 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java 
60b2dde8a7e088d8712879c68cd98193bb72de03 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 
cc8e68c5ad60edeb9638216a6cc9240750e3091e 
  lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRange.java 
7be7ace884bb843604934f650c656e326767b7e3 
  lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 
f772279712c3d1fc5da2325ec2e6a3c1402b550a 
  lens-cube/src/test/java/org/apache/lens/cube/metadata/CubeFactTableTest.java 
2abc6d0b3d9d025543f09ca129bf9d351a188f25 
  lens-cube/src/test/java/org/apache/lens/cube/metadata/DateFactory.java 
PRE-CREATION 
  
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java
 e5dbde7af58f74db4ae2a86d9eda602def25d9fe 
  lens-cube/src/test/java/org/apache/lens/cube/metadata/TestDateUtil.java 
PRE-CREATION 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 
1357035c8dfc6a5115c02d8fdc7cd8bb341eb6dd 
  
lens-cube/src/test/java/org/apache/lens/cube/parse/FieldsCannotBeQueriedTogetherTest.java
 0fea9f1bb4a266b680a252786ebd9e931d1b0c09 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java 
753ca331d28ad594555663d7f03374b75e5760f1 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 
ee84a4cdd5f0a54d90603c1ef96282e8068f4d32 
  
lens-cube/src/test/java/org/apache/lens/cube/parse/TestBetweenTimeRangeWriter.java
 9a2493c306938a0823d4b7d2bd264f915143ea64 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
fea70b72cbde190d69d46f68d163fd9e541c53f8 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestDateUtil.java 
ff9a96d2fe4dd8865e1c2a422334ff7f0624420e 
  
lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java
 d16ea4c56a792f1ac100e398bfdc6c8d1eab4490 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionContext.java 
0d1f9fe878aeec1161329d1ad4e8686fc6d65cd9 
  
lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java 
1e21fb0664d7d0153789cd47d14b4989b39bc5bb 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java 
ea561b6bd7bba05ebdd33bbe5f9785597459d732 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestORTimeRangeWriter.java 
4a23818313482d420721d62f908af4cc52f8311d 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryMetrics.java 
255aade5e8b9c4d18ba20e4d263dcce0d497ce76 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestRewriterPlan.java 
4d3a3dc67ef0f18ef2354ac552fbc4e017022f17 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestStorageUtil.java 
73c3338f2b44f4d9e878a4de3d424f7184b9f9f0 
  
lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java 
a4317173f9544ebcab05e290c312

Re: Review Request 40899: LENS-851: Replace columns with aliases in where clause of the inner query

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40899/
---

(Updated Dec. 11, 2015, 1:05 p.m.)


Review request for lens.


Bugs: LENS-851
https://issues.apache.org/jira/browse/LENS-851


Repository: lens


Description
---


Diffs (updated)
-

  lens-api/src/main/resources/lens-errors.conf 
ca8562f14fe9f45889ea59b055cdd1b001f02810 
  lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 
6c5dc2f7fb2e2c3e53ed5a25adf464d734eca793 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java 
b4185174c7ca7365bf9de7e2a0a0f75bdde6ba4b 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 
4ec049c103bdae662fc7f869aa32199e768a4b64 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 
7f8146158c1e2d883ee9327c4bf847883d0e1004 
  lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java 
97088a146729d4d2fb6ed6c55c2d16bfa8c75339 
  lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 
9a9d1348cce1b90fa9d558cc6399d441cca9fca1 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java 
60b2dde8a7e088d8712879c68cd98193bb72de03 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java
 418ef5a7b64f717618c3b16fe3755141c07beb76 
  lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java 
c9ba561bc8da1abb59898619620bbd47ec43028c 
  
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java
 e5dbde7af58f74db4ae2a86d9eda602def25d9fe 
  lens-cube/src/test/java/org/apache/lens/cube/metadata/TestExprColumn.java 
8770f1a76572cca36978df6ecb077b425d140c34 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 
1357035c8dfc6a5115c02d8fdc7cd8bb341eb6dd 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
fea70b72cbde190d69d46f68d163fd9e541c53f8 
  lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 
a5883f7b852f1d2a104d46e234546508422be172 

Diff: https://reviews.apache.org/r/40899/diff/


Testing
---

[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules . SUCCESS [1.873s]
[INFO] Lens .. SUCCESS [2.927s]
[INFO] Lens API .. SUCCESS [24.639s]
[INFO] Lens API for server and extensions  SUCCESS [23.716s]
[INFO] Lens Cube . SUCCESS [12:18.390s]
[INFO] Lens DB storage ... SUCCESS [24.670s]
[INFO] Lens Query Library  SUCCESS [19.728s]
[INFO] Lens Hive Driver .. SUCCESS [3:10.599s]
[INFO] Lens Driver for JDBC .. SUCCESS [35.097s]
[INFO] Lens Elastic Search Driver  SUCCESS [17.525s]
[INFO] Lens Server ... SUCCESS [9:47.931s]
[INFO] Lens client ... SUCCESS [37.521s]
[INFO] Lens CLI .. SUCCESS [55.112s]
[INFO] Lens Examples . SUCCESS [10.632s]
[INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [0.758s]
[INFO] Lens Distribution . SUCCESS [9.045s]
[INFO] Lens ML Lib ... SUCCESS [1:23.648s]
[INFO] Lens ML Ext Distribution .. SUCCESS [1.935s]
[INFO] Lens Regression ... SUCCESS [14.437s]
[INFO] Lens UI ... SUCCESS [28.745s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 31:49.869s
[INFO] Finished at: Thu Dec 10 11:25:18 UTC 2015
[INFO] Final Memory: 204M/2104M
[INFO] 


Thanks,

Rajat Khandelwal

Re: Review Request 39911: LENS-760 : Session close should not result in running query failures

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39911/#review109927
---


Deepak, can you mark the review issues as fixed/dropped accordingly ?


lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 
(line 1284)


Should we not persist opHandleToSessionHandle map as well? Otherwise, 
orphaned sessions will be still orphaned upon lens server restart.


- Amareshwari Sriramadasu


On Dec. 10, 2015, 10:19 a.m., Deepak Barr wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39911/
> ---
> 
> (Updated Dec. 10, 2015, 10:19 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> OperationHandle-HiveSession mapping is maintained for all active operations. 
> Now, hive session will only be closed when there are no active operations 
> running on that session.
> 
> 
> Diffs
> -
> 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 
> a84c679 
>   
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java
>  ab5ada9 
>   
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 
> f6693aa 
> 
> Diff: https://reviews.apache.org/r/39911/diff/
> 
> 
> Testing
> ---
> 
> Yes.
> 
> 1. Created session.
> 2. Fired a query.
> 3. Deleted the session before query finishes. 
> 4. Query keeps running and finishes eventually.
> 
> 
> Thanks,
> 
> Deepak Barr
> 
>

Re: 2.5 release planning

[amareshwarisr .]

Great!
Deepak, to get started follow the doc at
https://cwiki.apache.org/confluence/display/LENS/How+to+release+Apapche+Lens

Thanks

On Fri, Dec 11, 2015 at 12:06 PM, Deepak Kumar Barr (Tech_BLR) <
deepak.b...@flipkart.com> wrote:

> I will volunteer.
>
> Regards,
> Deepak Kumar Barr
> Bigfoot-Apps
>
> On Fri, Dec 11, 2015 at 9:46 AM, amareshwarisr . 
> wrote:
>
> > Any volunteers please?
> >
> > On Thu, Dec 10, 2015 at 11:57 AM, amareshwarisr .  >
> > wrote:
> >
> > > Hi all,
> > >
> > > We should plan for 2.5 release, as 2.4 was frozen two months back. We
> > have
> > > interesting features coming up in 2.5 :
> > >
> > > - Multiple driver support
> > > - Scheduler framework
> > > - Query submission throttling stabilized and more constraints getting
> > added
> > > - Error codes and responses getting fixed.
> > >
> > > Volunteers are welcome for release manager for 2.5, anyone please?
> > >
> > > Thanks
> > > Amareshwari
> > >
> >
>

Re: Review Request 41035: LENS-791: CLI format json strips away all commas, including useful ones

[Rajat Khandelwal]

> On Dec. 11, 2015, 11:24 a.m., Amareshwari Sriramadasu wrote:
> > lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java, 
> > line 145
> > 
> >
> > I did not like the fact that we need to put off pretty printing to see 
> > correct values from json. 
> > 
> > Is there a way to fix pretty printing not to eat up values, instead of 
> > putting it off?

My thought was that let's not disturb the normal output, experiment with the 
new output and when it feels right, switch to that permanently. I was 
originally going to change the normal output, but then I decided to go with 
this approach. Let me know your thoughts.


- Rajat


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41035/#review109920
---


On Dec. 7, 2015, 6:57 p.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41035/
> ---
> 
> (Updated Dec. 7, 2015, 6:57 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-791
> https://issues.apache.org/jira/browse/LENS-791
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/LensConf.java 
> ff965d6aabf052371e0b3b4644a5f60d1210be3d 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java 
> 643772596c472425c0688a93ed621b4dba45 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 
> a0c05b41650cd8303879c6c370d892c544adf6ca 
>   
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java
>  0aa51a8eeea2ad3e0b43d7f011c50b83b0ba30e4 
>   
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java
>  dc8349e322adcb031ef503850e012603f5865088 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 
> fe9b84dd5574b922c6b8a16a1b8c5b7518aa400a 
>   
> lens-cli/src/main/java/org/apache/lens/cli/commands/LogicalTableCrudCommand.java
>  a04d5c836a31b625e0efcd5509d999d6e483cbb6 
>   lens-client/src/main/java/org/apache/lens/client/LensClient.java 
> 5fd04c4591264ac2e5082f1a60281b15fac9 
> 
> Diff: https://reviews.apache.org/r/41035/diff/
> 
> 
> Testing
> ---
> 
> lens-shell>describe dimtable dim_table
> 
> columns :
> column :
>name : id  type : int  comment : ID
>name : name  type : string  comment : name
>name : detail  type : string  comment : more details
>name : d2id  type : int  comment : d2 ID
> 
> 
> properties :
> property :
>name : cube.table.type  value : DIM_TABLE
>name : dimtble.dim_table.local.dumpperiod  value : HOURLY
>name : dim1.prop  value : d1
>name : cube.table.dim_table.weight  value : 100.0
>name : dimtble.dim_table.storages  value : local
>name : transient_lastDdlTime  value : 1449487545
>name : dimtble.dim_table.dim.name  value : sample_dim
> 
> 
> storageTables :
> storageTable :
>updatePeriods :   updatePeriod :  HOURLY
> storageName : local  tableDesc :   partCols :   column :
>name : dt  type : string  comment : Time column
> tableParameters :   property :
>name : EXTERNAL  value : TRUE name : cube.storagetable.time.partcols  
> value : dt name : transient_lastDdlTime  value : 1449487545
> serdeParameters :   property :
>name : serialization.format  value :  name : field.delim  value :
> timePartCols :  dt
>   external : true  tableLocation : file:/tmp/examples/dim1  inputFormat : 
> org.apache.hadoop.mapred.TextInputFormat  outputFormat : 
> org.apache.hadoop.hive.ql.io.HiveIgnoreKeyTextOutputFormat  fieldDelimiter :  
>  serdeClassName : org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe  
> storageHandlerName :   numBuckets : 0  compressed : false
> 
> 
> dimensionName : sample_dim
> tableName : dim_table
> weight : 100.0
> 
> lens-shell>set lens.cli.json.pretty=true
> Client side Set lens.cli.json.pretty=true
> lens-shell>describe dimtable dim_table
> {
> "columns" : {
> "column" : [ {  "name" : "id",  "type" : "int",  "comment" : "ID"
> }, {  "name" : "name",  "type" : "string",  "comment" : "name"
> }, {  "name" : "detail",  "type" : "string",  "comment" : "more details"
> }, {  "name" : "d2id",  "type" : "int",  "comment" : "d2 ID"
> } ]
> },
> "properties" : {
> "property" : [ {  "name" : "cube.table.type",  "value" : "DIM_TABLE"
> }, {  "name" : "dimtble.dim_table.local.dumpperiod",  "value" : "HOURLY"
> }, {  "name" : "dim1.prop",  "value" : "d1"
> }, {  "name" : "cube.table.dim_table.weight",  "value" : "100.0"
> }, {  "name" : "dimtble.dim_table.storages",  "value" : "local"
> }, {  "name" : "transient_lastDdlTime",  "value" : "1449487545"

Re: 2.5 release planning

[Deepak Kumar Barr (Tech_BLR)]

I will volunteer.

Regards,
Deepak Kumar Barr
Bigfoot-Apps

On Fri, Dec 11, 2015 at 9:46 AM, amareshwarisr . 
wrote:

> Any volunteers please?
>
> On Thu, Dec 10, 2015 at 11:57 AM, amareshwarisr . 
> wrote:
>
> > Hi all,
> >
> > We should plan for 2.5 release, as 2.4 was frozen two months back. We
> have
> > interesting features coming up in 2.5 :
> >
> > - Multiple driver support
> > - Scheduler framework
> > - Query submission throttling stabilized and more constraints getting
> added
> > - Error codes and responses getting fixed.
> >
> > Volunteers are welcome for release manager for 2.5, anyone please?
> >
> > Thanks
> > Amareshwari
> >
>

Re: Review Request 41039: LENS-890: Allow per-queue driver max launched queries constraints

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41039/
---

(Updated Dec. 11, 2015, 12:02 p.m.)


Review request for lens.


Bugs: LENS-890
https://issues.apache.org/jira/browse/LENS-890


Repository: lens


Description
---


Diffs (updated)
-

  lens-api/src/main/java/org/apache/lens/api/util/CommonUtils.java 
38d58c710a2b917c34cda5de96a36dc49b6f15f0 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 
a84c6792e7b0570c216d30b53066e762a47a4204 
  
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 
11efd3c411a10b6506677986609e03f24160b9eb 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java
 55f1535191cd0423c850a1309747f81d5490ca12 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 
c2208846ddd53adf414bd4bae6898e26ac425c56 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java
 2f20113a1a30f902a1db4b25d5a78da0126a1b0c 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
 b637665e79c46014a7ab8770e0da38d4a9768bd6 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraint.java
 bae2e6490aafbfd55c9983c94d9cc892af384f7b 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraintFactory.java
 b6e6c2f1bd2e4f3c0acdcdaae57dcd812e6bb435 
  
lens-server-api/src/test/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraintTest.java
 55a2eea110f9001c962faede01cef396e8c91b6c 
  
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
 ffd2d422fd126d7f8acd50014fc4ee9bb3bf5ede 
  
lens-server/src/test/java/org/apache/lens/server/query/constraint/ThreadSafeEstimatedQueryCollectionTest.java
 9138f8ea2bb0b87bfcd2c9a4770bc732856fa680 

Diff: https://reviews.apache.org/r/41039/diff/


Testing
---


Thanks,

Rajat Khandelwal

Re: Review Request 41193: LENS-270 : The exception thrown for no candidate fact should contain only brief error

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41193/#review109923
---



lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFactAvailableException.java
 (line 49)


can we use getMaxCause().compareTo(other.getMaxCause()) instead of raw 
subtraction.



lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java (line 
849)


can we check whether the callers of this function are also logging the 
exception? If yes, this log is not needed. If no, can we convert it to 
log.error?



lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 
(line 93)


Instead of repeated casting by callers, extractPruneCause can return ``, and return `(T) retVal`



lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java (line 
203)


did not understand why we are changing `extractPruneCause` to 
`getJsonMessage`.


- Rajat Khandelwal


On Dec. 10, 2015, 9:06 p.m., Sushil Mohanty wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41193/
> ---
> 
> (Updated Dec. 10, 2015, 9:06 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-270
> https://issues.apache.org/jira/browse/LENS-270
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> After this change NO_CANDIDATE_FACT_AVAILABLE exception throws only brief 
> error also it compares errors across drivers to show the appropriate one.
> 
> 
> Diffs
> -
> 
>   
> lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFactAvailableException.java
>  PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 
> cf114c9 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/PruneCauses.java 7a92b3b 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 
> ee84a4c 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
> fea70b7 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java
>  d16ea4c 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java 
> 1fc8bc8 
> 
> Diff: https://reviews.apache.org/r/41193/diff/
> 
> 
> Testing
> ---
> 
> Fixed test cases. mvn clean install is running fine.
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules . SUCCESS [1.857s]
> [INFO] Lens .. SUCCESS [3.609s]
> [INFO] Lens API .. SUCCESS [24.695s]
> [INFO] Lens API for server and extensions  SUCCESS [21.389s]
> [INFO] Lens Cube . SUCCESS 
> [11:16.979s]
> [INFO] Lens DB storage ... SUCCESS [20.342s]
> [INFO] Lens Query Library  SUCCESS [17.663s]
> [INFO] Lens Hive Driver .. SUCCESS [2:49.242s]
> [INFO] Lens Driver for JDBC .. SUCCESS [36.354s]
> [INFO] Lens Elastic Search Driver  SUCCESS [15.701s]
> [INFO] Lens Server ... SUCCESS [9:46.856s]
> [INFO] Lens client ... SUCCESS [32.908s]
> [INFO] Lens CLI .. SUCCESS [50.828s]
> [INFO] Lens Examples . SUCCESS [8.110s]
> [INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [0.703s]
> [INFO] Lens Distribution . SUCCESS [8.565s]
> [INFO] Lens ML Lib ... SUCCESS [1:24.915s]
> [INFO] Lens ML Ext Distribution .. SUCCESS [2.194s]
> [INFO] Lens Regression ... SUCCESS [13.202s]
> [INFO] Lens UI ... SUCCESS [33.676s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 30:10.728s
> [INFO] Finished at: Thu Dec 10 06:47:36 UTC 2015
> [INFO] Final Memory: 200M/2134M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Sushil Mohanty
> 
>

[jira] [Comment Edited] (LENS-743) Query failure retries for transient errors

[Puneet Gupta (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15052190#comment-15052190
 ] 

Puneet Gupta edited comment on LENS-743 at 12/11/15 6:13 AM:
-

Configurations 
* Retry attempts (driver specific/ Error specific or common?)
* Wait duration between retries (can have a default value and also based on 
error type)

How will the APIs respond ?
* query details : show details for all attempts
* query status : show status of latest attempt 
* show logs : shows logs for all attempts 

 



was (Author: puneet884):
Configurations 
*Retry attempts (driver specific/ Error specific or common?)
*Wait duration between retries (can have a default value and also based on 
error type)

How will the APIs respond ?
* query details : show details for all attempts
* query status : show status of latest attempt 
* show logs : shows logs for all attempts 

 


> Query failure retries for transient errors
> --
>
> Key: LENS-743
> URL: https://issues.apache.org/jira/browse/LENS-743
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>Reporter: Amareshwari Sriramadasu
>Assignee: Rajat Khandelwal
>
> There have to be retries for query failures for transient errors like network 
> errors (Hive server not reachable/ Metastore not reachable/ DB not 
> reachable). Retries should be available for each phase - submission, 
> execution, updating status, fetching results and formatting.
> Right now, any such failure results in marking query as failed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 41035: LENS-791: CLI format json strips away all commas, including useful ones

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41035/#review109920
---



lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java (line 
144)


I did not like the fact that we need to put off pretty printing to see 
correct values from json. 

Is there a way to fix pretty printing not to eat up values, instead of 
putting it off?


- Amareshwari Sriramadasu


On Dec. 7, 2015, 1:27 p.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41035/
> ---
> 
> (Updated Dec. 7, 2015, 1:27 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-791
> https://issues.apache.org/jira/browse/LENS-791
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/LensConf.java 
> ff965d6aabf052371e0b3b4644a5f60d1210be3d 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java 
> 643772596c472425c0688a93ed621b4dba45 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 
> a0c05b41650cd8303879c6c370d892c544adf6ca 
>   
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java
>  0aa51a8eeea2ad3e0b43d7f011c50b83b0ba30e4 
>   
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java
>  dc8349e322adcb031ef503850e012603f5865088 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 
> fe9b84dd5574b922c6b8a16a1b8c5b7518aa400a 
>   
> lens-cli/src/main/java/org/apache/lens/cli/commands/LogicalTableCrudCommand.java
>  a04d5c836a31b625e0efcd5509d999d6e483cbb6 
>   lens-client/src/main/java/org/apache/lens/client/LensClient.java 
> 5fd04c4591264ac2e5082f1a60281b15fac9 
> 
> Diff: https://reviews.apache.org/r/41035/diff/
> 
> 
> Testing
> ---
> 
> lens-shell>describe dimtable dim_table
> 
> columns :
> column :
>name : id  type : int  comment : ID
>name : name  type : string  comment : name
>name : detail  type : string  comment : more details
>name : d2id  type : int  comment : d2 ID
> 
> 
> properties :
> property :
>name : cube.table.type  value : DIM_TABLE
>name : dimtble.dim_table.local.dumpperiod  value : HOURLY
>name : dim1.prop  value : d1
>name : cube.table.dim_table.weight  value : 100.0
>name : dimtble.dim_table.storages  value : local
>name : transient_lastDdlTime  value : 1449487545
>name : dimtble.dim_table.dim.name  value : sample_dim
> 
> 
> storageTables :
> storageTable :
>updatePeriods :   updatePeriod :  HOURLY
> storageName : local  tableDesc :   partCols :   column :
>name : dt  type : string  comment : Time column
> tableParameters :   property :
>name : EXTERNAL  value : TRUE name : cube.storagetable.time.partcols  
> value : dt name : transient_lastDdlTime  value : 1449487545
> serdeParameters :   property :
>name : serialization.format  value :  name : field.delim  value :
> timePartCols :  dt
>   external : true  tableLocation : file:/tmp/examples/dim1  inputFormat : 
> org.apache.hadoop.mapred.TextInputFormat  outputFormat : 
> org.apache.hadoop.hive.ql.io.HiveIgnoreKeyTextOutputFormat  fieldDelimiter :  
>  serdeClassName : org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe  
> storageHandlerName :   numBuckets : 0  compressed : false
> 
> 
> dimensionName : sample_dim
> tableName : dim_table
> weight : 100.0
> 
> lens-shell>set lens.cli.json.pretty=true
> Client side Set lens.cli.json.pretty=true
> lens-shell>describe dimtable dim_table
> {
> "columns" : {
> "column" : [ {  "name" : "id",  "type" : "int",  "comment" : "ID"
> }, {  "name" : "name",  "type" : "string",  "comment" : "name"
> }, {  "name" : "detail",  "type" : "string",  "comment" : "more details"
> }, {  "name" : "d2id",  "type" : "int",  "comment" : "d2 ID"
> } ]
> },
> "properties" : {
> "property" : [ {  "name" : "cube.table.type",  "value" : "DIM_TABLE"
> }, {  "name" : "dimtble.dim_table.local.dumpperiod",  "value" : "HOURLY"
> }, {  "name" : "dim1.prop",  "value" : "d1"
> }, {  "name" : "cube.table.dim_table.weight",  "value" : "100.0"
> }, {  "name" : "dimtble.dim_table.storages",  "value" : "local"
> }, {  "name" : "transient_lastDdlTime",  "value" : "1449487545"
> }, {  "name" : "dimtble.dim_table.dim.name",  "value" : "sample_dim"
> } ]
> },
> "storageTables" : {
> "storageTable" : [ {  "updatePeriods" : {  "updatePeriod" : [ "HOURLY" ]  },  
> "storageName" : "local",  "tableDesc" : {  "partCols" : {  "column" : [ {  
> "name" : "dt",  "type" : "string",  "comment" : "Time column"  } ]  },  
> "tableParameters" : {  "property"

Re: Review Request 41193: LENS-270 : The exception thrown for no candidate fact should contain only brief error

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41193/#review109919
---



lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFactAvailableException.java
 (line 48)


Can you add comments about what comparision we are doing here?



lens-cube/src/main/java/org/apache/lens/cube/parse/PruneCauses.java (line 84)


Can you convert this to a lazy Getter method and use it in below method 
also ?


- Amareshwari Sriramadasu


On Dec. 10, 2015, 3:36 p.m., Sushil Mohanty wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41193/
> ---
> 
> (Updated Dec. 10, 2015, 3:36 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-270
> https://issues.apache.org/jira/browse/LENS-270
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> After this change NO_CANDIDATE_FACT_AVAILABLE exception throws only brief 
> error also it compares errors across drivers to show the appropriate one.
> 
> 
> Diffs
> -
> 
>   
> lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFactAvailableException.java
>  PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 
> cf114c9 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/PruneCauses.java 7a92b3b 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 
> ee84a4c 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
> fea70b7 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java
>  d16ea4c 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java 
> 1fc8bc8 
> 
> Diff: https://reviews.apache.org/r/41193/diff/
> 
> 
> Testing
> ---
> 
> Fixed test cases. mvn clean install is running fine.
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules . SUCCESS [1.857s]
> [INFO] Lens .. SUCCESS [3.609s]
> [INFO] Lens API .. SUCCESS [24.695s]
> [INFO] Lens API for server and extensions  SUCCESS [21.389s]
> [INFO] Lens Cube . SUCCESS 
> [11:16.979s]
> [INFO] Lens DB storage ... SUCCESS [20.342s]
> [INFO] Lens Query Library  SUCCESS [17.663s]
> [INFO] Lens Hive Driver .. SUCCESS [2:49.242s]
> [INFO] Lens Driver for JDBC .. SUCCESS [36.354s]
> [INFO] Lens Elastic Search Driver  SUCCESS [15.701s]
> [INFO] Lens Server ... SUCCESS [9:46.856s]
> [INFO] Lens client ... SUCCESS [32.908s]
> [INFO] Lens CLI .. SUCCESS [50.828s]
> [INFO] Lens Examples . SUCCESS [8.110s]
> [INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [0.703s]
> [INFO] Lens Distribution . SUCCESS [8.565s]
> [INFO] Lens ML Lib ... SUCCESS [1:24.915s]
> [INFO] Lens ML Ext Distribution .. SUCCESS [2.194s]
> [INFO] Lens Regression ... SUCCESS [13.202s]
> [INFO] Lens UI ... SUCCESS [33.676s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 30:10.728s
> [INFO] Finished at: Thu Dec 10 06:47:36 UTC 2015
> [INFO] Final Memory: 200M/2134M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Sushil Mohanty
> 
>

[jira] [Updated] (LENS-836) Query commands in CLI should take default value for query handle as the last executed query

[Amareshwari Sriramadasu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-836:
-
Component/s: client

> Query commands in CLI should take default value for query handle as the last 
> executed query
> ---
>
> Key: LENS-836
> URL: https://issues.apache.org/jira/browse/LENS-836
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: client
>Reporter: Rajat Khandelwal
>  Labels: newbie
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-880) Organise utility classes in different modules

[Amareshwari Sriramadasu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-880:
-
Component/s: build

> Organise utility classes in different modules
> -
>
> Key: LENS-880
> URL: https://issues.apache.org/jira/browse/LENS-880
> Project: Apache Lens
>  Issue Type: Wish
>  Components: build
>Reporter: Rajat Khandelwal
>
> We have multiple utility classes scattered around, this task is to look at 
> those and try to reduce/regroup those. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-830) Checkstyle version should be picked from project version

[Amareshwari Sriramadasu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-830:
-
Component/s: build

> Checkstyle version should be picked from project version
> 
>
> Key: LENS-830
> URL: https://issues.apache.org/jira/browse/LENS-830
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: build
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-867) Do Query Comparison through individual ASTs

[Amareshwari Sriramadasu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-867:
-
Component/s: cube

> Do Query Comparison through individual ASTs
> ---
>
> Key: LENS-867
> URL: https://issues.apache.org/jira/browse/LENS-867
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: cube
>Reporter: Rajat Khandelwal
>
> Two queries should be equivalent if their select asts, from asts, where asts, 
> group by asts, having asts etc all are equivalent. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-743) Query failure retries for transient errors

[Puneet Gupta (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15052190#comment-15052190
 ] 

Puneet Gupta commented on LENS-743:
---

Configurations 
*Retry attempts (driver specific/ Error specific or common?)
*Wait duration between retries (can have a default value and also based on 
error type)

How will the APIs respond ?
* query details : show details for all attempts
* query status : show status of latest attempt 
* show logs : shows logs for all attempts 

 


> Query failure retries for transient errors
> --
>
> Key: LENS-743
> URL: https://issues.apache.org/jira/browse/LENS-743
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>Reporter: Amareshwari Sriramadasu
>Assignee: Rajat Khandelwal
>
> There have to be retries for query failures for transient errors like network 
> errors (Hive server not reachable/ Metastore not reachable/ DB not 
> reachable). Retries should be available for each phase - submission, 
> execution, updating status, fetching results and formatting.
> Right now, any such failure results in marking query as failed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 41033: LENS-836: Query commands in CLI should take default value for query handle as the last executed query

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41033/#review109913
---



lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 
(line 143)


Can you add a unit test?


- Amareshwari Sriramadasu


On Dec. 9, 2015, 10:05 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41033/
> ---
> 
> (Updated Dec. 9, 2015, 10:05 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-836
> https://issues.apache.org/jira/browse/LENS-836
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 
> fe9b84dd5574b922c6b8a16a1b8c5b7518aa400a 
>   lens-client/src/main/java/org/apache/lens/client/LensClient.java 
> 5fd04c4591264ac2e5082f1a60281b15fac9 
>   lens-client/src/main/java/org/apache/lens/client/LensStatement.java 
> 40e6d76d20dbb1359d4d6dc64ff7c41f324c7662 
> 
> Diff: https://reviews.apache.org/r/41033/diff/
> 
> 
> Testing
> ---
> 
> http://showterm.io/2bbd961fd3bcc859adbc8
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: 2.5 release planning

[amareshwarisr .]

Any volunteers please?

On Thu, Dec 10, 2015 at 11:57 AM, amareshwarisr . 
wrote:

> Hi all,
>
> We should plan for 2.5 release, as 2.4 was frozen two months back. We have
> interesting features coming up in 2.5 :
>
> - Multiple driver support
> - Scheduler framework
> - Query submission throttling stabilized and more constraints getting added
> - Error codes and responses getting fixed.
>
> Volunteers are welcome for release manager for 2.5, anyone please?
>
> Thanks
> Amareshwari
>

Re: Review Request 41193: LENS-270 : The exception thrown for no candidate fact should contain only brief error

[Sushil Mohanty]

> On Dec. 10, 2015, 10:48 a.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java, 
> > line 850
> > 
> >
> > Can you add NoCandidateDimAvailableException as well for dimtables ?

Sure. Will create a separate ticket to track this.


- Sushil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41193/#review109731
---


On Dec. 10, 2015, 3:36 p.m., Sushil Mohanty wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41193/
> ---
> 
> (Updated Dec. 10, 2015, 3:36 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-270
> https://issues.apache.org/jira/browse/LENS-270
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> After this change NO_CANDIDATE_FACT_AVAILABLE exception throws only brief 
> error also it compares errors across drivers to show the appropriate one.
> 
> 
> Diffs
> -
> 
>   
> lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFactAvailableException.java
>  PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 
> cf114c9 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/PruneCauses.java 7a92b3b 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 
> ee84a4c 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
> fea70b7 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java
>  d16ea4c 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java 
> 1fc8bc8 
> 
> Diff: https://reviews.apache.org/r/41193/diff/
> 
> 
> Testing
> ---
> 
> Fixed test cases. mvn clean install is running fine.
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules . SUCCESS [1.857s]
> [INFO] Lens .. SUCCESS [3.609s]
> [INFO] Lens API .. SUCCESS [24.695s]
> [INFO] Lens API for server and extensions  SUCCESS [21.389s]
> [INFO] Lens Cube . SUCCESS 
> [11:16.979s]
> [INFO] Lens DB storage ... SUCCESS [20.342s]
> [INFO] Lens Query Library  SUCCESS [17.663s]
> [INFO] Lens Hive Driver .. SUCCESS [2:49.242s]
> [INFO] Lens Driver for JDBC .. SUCCESS [36.354s]
> [INFO] Lens Elastic Search Driver  SUCCESS [15.701s]
> [INFO] Lens Server ... SUCCESS [9:46.856s]
> [INFO] Lens client ... SUCCESS [32.908s]
> [INFO] Lens CLI .. SUCCESS [50.828s]
> [INFO] Lens Examples . SUCCESS [8.110s]
> [INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [0.703s]
> [INFO] Lens Distribution . SUCCESS [8.565s]
> [INFO] Lens ML Lib ... SUCCESS [1:24.915s]
> [INFO] Lens ML Ext Distribution .. SUCCESS [2.194s]
> [INFO] Lens Regression ... SUCCESS [13.202s]
> [INFO] Lens UI ... SUCCESS [33.676s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 30:10.728s
> [INFO] Finished at: Thu Dec 10 06:47:36 UTC 2015
> [INFO] Final Memory: 200M/2134M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Sushil Mohanty
> 
>

Re: Review Request 41193: LENS-270 : The exception thrown for no candidate fact should contain only brief error

[Sushil Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41193/
---

(Updated Dec. 10, 2015, 3:36 p.m.)


Review request for lens.


Changes
---

Addressed review commnets. All unit tests are running fine.


Bugs: LENS-270
https://issues.apache.org/jira/browse/LENS-270


Repository: lens


Description
---

After this change NO_CANDIDATE_FACT_AVAILABLE exception throws only brief error 
also it compares errors across drivers to show the appropriate one.


Diffs (updated)
-

  
lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFactAvailableException.java
 PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 
cf114c9 
  lens-cube/src/main/java/org/apache/lens/cube/parse/PruneCauses.java 7a92b3b 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 
ee84a4c 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
fea70b7 
  
lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java
 d16ea4c 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java 
1fc8bc8 

Diff: https://reviews.apache.org/r/41193/diff/


Testing
---

Fixed test cases. mvn clean install is running fine.

[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules . SUCCESS [1.857s]
[INFO] Lens .. SUCCESS [3.609s]
[INFO] Lens API .. SUCCESS [24.695s]
[INFO] Lens API for server and extensions  SUCCESS [21.389s]
[INFO] Lens Cube . SUCCESS [11:16.979s]
[INFO] Lens DB storage ... SUCCESS [20.342s]
[INFO] Lens Query Library  SUCCESS [17.663s]
[INFO] Lens Hive Driver .. SUCCESS [2:49.242s]
[INFO] Lens Driver for JDBC .. SUCCESS [36.354s]
[INFO] Lens Elastic Search Driver  SUCCESS [15.701s]
[INFO] Lens Server ... SUCCESS [9:46.856s]
[INFO] Lens client ... SUCCESS [32.908s]
[INFO] Lens CLI .. SUCCESS [50.828s]
[INFO] Lens Examples . SUCCESS [8.110s]
[INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [0.703s]
[INFO] Lens Distribution . SUCCESS [8.565s]
[INFO] Lens ML Lib ... SUCCESS [1:24.915s]
[INFO] Lens ML Ext Distribution .. SUCCESS [2.194s]
[INFO] Lens Regression ... SUCCESS [13.202s]
[INFO] Lens UI ... SUCCESS [33.676s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 30:10.728s
[INFO] Finished at: Thu Dec 10 06:47:36 UTC 2015
[INFO] Final Memory: 200M/2134M
[INFO] 


Thanks,

Sushil Mohanty

[jira] [Commented] (LENS-879) Base framework for Scheduler.

[Rajat Khandelwal (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15050953#comment-15050953
 ] 

Rajat Khandelwal commented on LENS-879:
---

We might have to move away from PreCommit-Admin job which does the bookkeeping 
of jira-attachment-job. It can add comments on reviewboard, as it will be 
contextual. But triggering mechanism still needs to be changed. 

> Base framework for Scheduler.
> -
>
> Key: LENS-879
> URL: https://issues.apache.org/jira/browse/LENS-879
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: server
>Reporter: Ajay Yadava
>Assignee: Ajay Yadava
> Fix For: 2.5
>
> Attachments: LENS-879-v1.patch, LENS-879-v2.patch, LENS-879-v3.patch, 
> LENS-879-v4.patch, LENS-879-v5.patch, LENS-879.patch
>
>
> Add interfaces for scheduler service and xsd for job.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 40739: LENS-885: Cleanup of Cube test cases

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40739/#review109751
---

Ship it!


Ship It!

- Amareshwari Sriramadasu


On Nov. 30, 2015, 10:05 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40739/
> ---
> 
> (Updated Nov. 30, 2015, 10:05 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-885
> https://issues.apache.org/jira/browse/LENS-885
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> * Some functions are wrongly placed. e.g. DateUtil.getCeilDate(date, 
> updatePeriod) can be better expressed as updatePeriod.getCeilDate(date).
> * Date parsing from query can be cached
> * There is a bloat of Date variables in CubeTestSetup, organize them and only 
> keep named variables for the most used ones
> * Unify time range clause creation across test cases. Right now, tests create 
> time ranges as and when needed. Remove repetition and redundancies. 
> * Correct names to variables
> 
> 
> Diffs
> -
> 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeColumn.java 
> a2a00d2c60077a41eb9576901f1702fd94473cc7 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 
> d6bfb795373674f77705a2df14a9f24695a76a1a 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/DateUtil.java 
> PRE-CREATION 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRange.java 
> 01069a587c77230bddbae543eba799c2ce495a19 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/TimeRange.java 
> PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/UpdatePeriod.java 
> 4c76a69d0e2986d450d81b8cbed877995696ba0d 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/EndsAndHolesPartitionTimeline.java
>  9d5e264b725ba57ced7618dc2be9de9bcc7983f8 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 
> 7f8146158c1e2d883ee9327c4bf847883d0e1004 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
>  9c8b5b9fece146bcf0fa7d5048b93b236cd3d557 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java 
> 5e17eac62a6b12ef04d1d4e3254efbda54402eb6 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 
> 200a48cd67e6a5a381ef3723a3adb686d8347efb 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java 
> 60b2dde8a7e088d8712879c68cd98193bb72de03 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 
> cc8e68c5ad60edeb9638216a6cc9240750e3091e 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRange.java 
> 7be7ace884bb843604934f650c656e326767b7e3 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 
> f772279712c3d1fc5da2325ec2e6a3c1402b550a 
>   
> lens-cube/src/test/java/org/apache/lens/cube/metadata/CubeFactTableTest.java 
> 2abc6d0b3d9d025543f09ca129bf9d351a188f25 
>   lens-cube/src/test/java/org/apache/lens/cube/metadata/DateFactory.java 
> PRE-CREATION 
>   
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java
>  e415a5adeb5a8af16bad56c96b9f9a32cb7afcbb 
>   lens-cube/src/test/java/org/apache/lens/cube/metadata/TestDateUtil.java 
> PRE-CREATION 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 
> 1357035c8dfc6a5115c02d8fdc7cd8bb341eb6dd 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/FieldsCannotBeQueriedTogetherTest.java
>  0fea9f1bb4a266b680a252786ebd9e931d1b0c09 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java 
> 753ca331d28ad594555663d7f03374b75e5760f1 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 
> ee84a4cdd5f0a54d90603c1ef96282e8068f4d32 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestBetweenTimeRangeWriter.java
>  9a2493c306938a0823d4b7d2bd264f915143ea64 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
> fea70b72cbde190d69d46f68d163fd9e541c53f8 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestDateUtil.java 
> ab88fbe067fadc839676f0013dc4885e3fbc5546 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java
>  d16ea4c56a792f1ac100e398bfdc6c8d1eab4490 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionContext.java 
> 0d1f9fe878aeec1161329d1ad4e8686fc6d65cd9 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java
>  1e21fb0664d7d0153789cd47d14b4989b39bc5bb 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java 
> ea561b6bd7bba05ebdd33bbe5f9785597459d732 
>   
> lens-cube/src/test/java/org/apach

[jira] [Commented] (LENS-879) Base framework for Scheduler.

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15050917#comment-15050917
 ] 

Hudson commented on LENS-879:
-

UNSTABLE: Integrated in Lens-Commit #1149 (See 
[https://builds.apache.org/job/Lens-Commit/1149/])
LENS-879 : Adds Base framework for scheduler (amareshwari: rev 
7e9e47ea66109470327607fafb26045080fc969d)
* lens-server/src/main/resources/lensserver-default.xml
* lens-examples/src/main/resources/example-job.xml
* 
lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java
* 
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
* 
lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java
* lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java
* 
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobStats.java
* src/site/apt/admin/config.apt
* 
lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java
* pom.xml
* 
lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java
* 
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java
* lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java
* lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInfo.java
* lens-api/src/main/resources/scheduler-job-0.1.xsd
* 
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java


> Base framework for Scheduler.
> -
>
> Key: LENS-879
> URL: https://issues.apache.org/jira/browse/LENS-879
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: server
>Reporter: Ajay Yadava
>Assignee: Ajay Yadava
> Fix For: 2.5
>
> Attachments: LENS-879-v1.patch, LENS-879-v2.patch, LENS-879-v3.patch, 
> LENS-879-v4.patch, LENS-879-v5.patch, LENS-879.patch
>
>
> Add interfaces for scheduler service and xsd for job.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-879) Base framework for Scheduler.

[Amareshwari Sriramadasu (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15050913#comment-15050913
 ] 

Amareshwari Sriramadasu commented on LENS-879:
--

I feel adding comments on jira is no harm for patches on review board. 
Otherwise, it can add comments on review board it self, if that can be done. 
But isn't precommit build triggered with making jira "Patch Available"? Will 
that introduce an additional step of raising request and making jira PA ?

> Base framework for Scheduler.
> -
>
> Key: LENS-879
> URL: https://issues.apache.org/jira/browse/LENS-879
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: server
>Reporter: Ajay Yadava
>Assignee: Ajay Yadava
> Fix For: 2.5
>
> Attachments: LENS-879-v1.patch, LENS-879-v2.patch, LENS-879-v3.patch, 
> LENS-879-v4.patch, LENS-879-v5.patch, LENS-879.patch
>
>
> Add interfaces for scheduler service and xsd for job.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 40899: LENS-851: Replace columns with aliases in where clause of the inner query

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40899/#review109746
---



lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 
(lines 57 - 58)


I think weights of these error codes should be more than 1400. can you 
change?


- Amareshwari Sriramadasu


On Dec. 10, 2015, 11:31 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40899/
> ---
> 
> (Updated Dec. 10, 2015, 11:31 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-851
> https://issues.apache.org/jira/browse/LENS-851
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/resources/lens-errors.conf 
> ca8562f14fe9f45889ea59b055cdd1b001f02810 
>   lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 
> 6c5dc2f7fb2e2c3e53ed5a25adf464d734eca793 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java 
> b4185174c7ca7365bf9de7e2a0a0f75bdde6ba4b 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 
> 4ec049c103bdae662fc7f869aa32199e768a4b64 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 
> 7f8146158c1e2d883ee9327c4bf847883d0e1004 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java 
> 97088a146729d4d2fb6ed6c55c2d16bfa8c75339 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 
> 9a9d1348cce1b90fa9d558cc6399d441cca9fca1 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java 
> 60b2dde8a7e088d8712879c68cd98193bb72de03 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java
>  418ef5a7b64f717618c3b16fe3755141c07beb76 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java 
> c9ba561bc8da1abb59898619620bbd47ec43028c 
>   
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java
>  e5dbde7af58f74db4ae2a86d9eda602def25d9fe 
>   lens-cube/src/test/java/org/apache/lens/cube/metadata/TestExprColumn.java 
> 8770f1a76572cca36978df6ecb077b425d140c34 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 
> 1357035c8dfc6a5115c02d8fdc7cd8bb341eb6dd 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
> fea70b72cbde190d69d46f68d163fd9e541c53f8 
>   lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 
> a5883f7b852f1d2a104d46e234546508422be172 
> 
> Diff: https://reviews.apache.org/r/40899/diff/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules . SUCCESS [1.873s]
> [INFO] Lens .. SUCCESS [2.927s]
> [INFO] Lens API .. SUCCESS [24.639s]
> [INFO] Lens API for server and extensions  SUCCESS [23.716s]
> [INFO] Lens Cube . SUCCESS 
> [12:18.390s]
> [INFO] Lens DB storage ... SUCCESS [24.670s]
> [INFO] Lens Query Library  SUCCESS [19.728s]
> [INFO] Lens Hive Driver .. SUCCESS [3:10.599s]
> [INFO] Lens Driver for JDBC .. SUCCESS [35.097s]
> [INFO] Lens Elastic Search Driver  SUCCESS [17.525s]
> [INFO] Lens Server ... SUCCESS [9:47.931s]
> [INFO] Lens client ... SUCCESS [37.521s]
> [INFO] Lens CLI .. SUCCESS [55.112s]
> [INFO] Lens Examples . SUCCESS [10.632s]
> [INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [0.758s]
> [INFO] Lens Distribution . SUCCESS [9.045s]
> [INFO] Lens ML Lib ... SUCCESS [1:23.648s]
> [INFO] Lens ML Ext Distribution .. SUCCESS [1.935s]
> [INFO] Lens Regression ... SUCCESS [14.437s]
> [INFO] Lens UI ... SUCCESS [28.745s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 31:49.869s
> [INFO] Finished at: Thu Dec 10 11:25:18 UTC 2015
> [INFO] Final Memory: 204M/2104M
> [INFO] 
> 

[jira] [Commented] (LENS-879) Base framework for Scheduler.

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15050894#comment-15050894
 ] 

Hudson commented on LENS-879:
-

SUCCESS: Integrated in Lens-Commit-Java8 #64 (See 
[https://builds.apache.org/job/Lens-Commit-Java8/64/])
LENS-879 : Adds Base framework for scheduler (amareshwari: rev 
7e9e47ea66109470327607fafb26045080fc969d)
* lens-server/src/main/resources/lensserver-default.xml
* 
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
* pom.xml
* src/site/apt/admin/config.apt
* 
lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java
* 
lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java
* 
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobStats.java
* lens-api/src/main/resources/scheduler-job-0.1.xsd
* 
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java
* 
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java
* lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java
* 
lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java
* lens-examples/src/main/resources/example-job.xml
* 
lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java
* lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java
* lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInfo.java


> Base framework for Scheduler.
> -
>
> Key: LENS-879
> URL: https://issues.apache.org/jira/browse/LENS-879
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: server
>Reporter: Ajay Yadava
>Assignee: Ajay Yadava
> Fix For: 2.5
>
> Attachments: LENS-879-v1.patch, LENS-879-v2.patch, LENS-879-v3.patch, 
> LENS-879-v4.patch, LENS-879-v5.patch, LENS-879.patch
>
>
> Add interfaces for scheduler service and xsd for job.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-743) Query failure retries for transient errors

[Rajat Khandelwal (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15050634#comment-15050634
 ] 

Rajat Khandelwal commented on LENS-743:
---

After some offline discussions, I'm inclined towards this approach:

Define a concept of Attempt for queries. LensQuery is the user-facing class for 
a query. Right now it contains fields for one attempt:

{noformat}
  private QueryStatus status;

  private String driverOpHandle;

  private long driverStartTime;
 
  private long driverFinishTime;

{noformat}

These will be extracted out in a class `Attempt` and LensQuery will not contain 
a list of attempts. 

>From lens database side:
There will be a separate table for attempts, where all attempts of queries will 
be stored. The query ultimately finishes when the last attempt finishes, and 
finished_query table already have fields belonging to attempt, so I'm thinking 
last attempt details can go to that table. Though we'll need to add a column 
"number of attempts" in finished_queries. 

Similar changes will be done in QueryContext. 


On query execution side, updateFinishedQuery will check FAILURE and make a 
decision on whether to retry or not. A retry will consist of launching the 
query again on the driver and creating another attempt. In this process, the 
previous retry will be saved to db.  
If a decision is made to not-retry the query, it'll follow the normal code 
path. 

[~amareshwari] [~Puneetkgupta] Please add if I missed anything. I'll do the 
same. 

> Query failure retries for transient errors
> --
>
> Key: LENS-743
> URL: https://issues.apache.org/jira/browse/LENS-743
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>Reporter: Amareshwari Sriramadasu
>Assignee: Rajat Khandelwal
>
> There have to be retries for query failures for transient errors like network 
> errors (Hive server not reachable/ Metastore not reachable/ DB not 
> reachable). Retries should be available for each phase - submission, 
> execution, updating status, fetching results and formatting.
> Right now, any such failure results in marking query as failed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 40899: LENS-851: Replace columns with aliases in where clause of the inner query

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40899/
---

(Updated Dec. 10, 2015, 5:01 p.m.)


Review request for lens.


Bugs: LENS-851
https://issues.apache.org/jira/browse/LENS-851


Repository: lens


Description
---


Diffs (updated)
-

  lens-api/src/main/resources/lens-errors.conf 
ca8562f14fe9f45889ea59b055cdd1b001f02810 
  lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 
6c5dc2f7fb2e2c3e53ed5a25adf464d734eca793 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java 
b4185174c7ca7365bf9de7e2a0a0f75bdde6ba4b 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 
4ec049c103bdae662fc7f869aa32199e768a4b64 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 
7f8146158c1e2d883ee9327c4bf847883d0e1004 
  lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java 
97088a146729d4d2fb6ed6c55c2d16bfa8c75339 
  lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 
9a9d1348cce1b90fa9d558cc6399d441cca9fca1 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java 
60b2dde8a7e088d8712879c68cd98193bb72de03 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java
 418ef5a7b64f717618c3b16fe3755141c07beb76 
  lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java 
c9ba561bc8da1abb59898619620bbd47ec43028c 
  
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java
 e5dbde7af58f74db4ae2a86d9eda602def25d9fe 
  lens-cube/src/test/java/org/apache/lens/cube/metadata/TestExprColumn.java 
8770f1a76572cca36978df6ecb077b425d140c34 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 
1357035c8dfc6a5115c02d8fdc7cd8bb341eb6dd 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
fea70b72cbde190d69d46f68d163fd9e541c53f8 
  lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 
a5883f7b852f1d2a104d46e234546508422be172 

Diff: https://reviews.apache.org/r/40899/diff/


Testing (updated)
---

[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules . SUCCESS [1.873s]
[INFO] Lens .. SUCCESS [2.927s]
[INFO] Lens API .. SUCCESS [24.639s]
[INFO] Lens API for server and extensions  SUCCESS [23.716s]
[INFO] Lens Cube . SUCCESS [12:18.390s]
[INFO] Lens DB storage ... SUCCESS [24.670s]
[INFO] Lens Query Library  SUCCESS [19.728s]
[INFO] Lens Hive Driver .. SUCCESS [3:10.599s]
[INFO] Lens Driver for JDBC .. SUCCESS [35.097s]
[INFO] Lens Elastic Search Driver  SUCCESS [17.525s]
[INFO] Lens Server ... SUCCESS [9:47.931s]
[INFO] Lens client ... SUCCESS [37.521s]
[INFO] Lens CLI .. SUCCESS [55.112s]
[INFO] Lens Examples . SUCCESS [10.632s]
[INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [0.758s]
[INFO] Lens Distribution . SUCCESS [9.045s]
[INFO] Lens ML Lib ... SUCCESS [1:23.648s]
[INFO] Lens ML Ext Distribution .. SUCCESS [1.935s]
[INFO] Lens Regression ... SUCCESS [14.437s]
[INFO] Lens UI ... SUCCESS [28.745s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 31:49.869s
[INFO] Finished at: Thu Dec 10 11:25:18 UTC 2015
[INFO] Final Memory: 204M/2104M
[INFO] 


Thanks,

Rajat Khandelwal

[jira] [Resolved] (LENS-872) Download link is not correct for 2.4.0-beta in "release-history.html"

[Raju Bairishetti (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Raju Bairishetti resolved LENS-872.
---
Resolution: Invalid

Not sure when the archival was happened for this release. Artifacts for 2.4 
release is present in the archived dist repo. 

Closing this as invalid as I have created this jira immediately after the 
release. 

> Download link is not correct for 2.4.0-beta in "release-history.html"
> -
>
> Key: LENS-872
> URL: https://issues.apache.org/jira/browse/LENS-872
> Project: Apache Lens
>  Issue Type: Task
>  Components: docs
>Reporter: Raju Bairishetti
>Assignee: Raju Bairishetti
>Priority: Critical
>  Labels: release
> Fix For: 2.5
>
>
> [Release history page|http://lens.apache.org/releases/release-history.htm]  
> contains all the information about the previous releases and current 
> releases. Download link for latest release is pointing to archived dist repo. 
> It can be always archived repo.
> It should point to archived dist repo 
> link(http://archive.apache.org/dist/lens/2.4-beta/) for 2.4. 
> [Download page|http://lens.apache.org/releases/download.html] is having the 
> link to mirrors for latest release. Users can download from there.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (LENS-872) Download link is not correct for 2.4.0-beta in "release-history.html"

[Raju Bairishetti (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Raju Bairishetti closed LENS-872.
-

> Download link is not correct for 2.4.0-beta in "release-history.html"
> -
>
> Key: LENS-872
> URL: https://issues.apache.org/jira/browse/LENS-872
> Project: Apache Lens
>  Issue Type: Task
>  Components: docs
>Reporter: Raju Bairishetti
>Assignee: Raju Bairishetti
>Priority: Critical
>  Labels: release
> Fix For: 2.5
>
>
> [Release history page|http://lens.apache.org/releases/release-history.htm]  
> contains all the information about the previous releases and current 
> releases. Download link for latest release is pointing to archived dist repo. 
> It can be always archived repo.
> It should point to archived dist repo 
> link(http://archive.apache.org/dist/lens/2.4-beta/) for 2.4. 
> [Download page|http://lens.apache.org/releases/download.html] is having the 
> link to mirrors for latest release. Users can download from there.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-879) Base framework for Scheduler.

[Rajat Khandelwal (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15050590#comment-15050590
 ] 

Rajat Khandelwal commented on LENS-879:
---

bq. We should check if there is a way to download patch from reviewboard and 
run tests on that. Uploading in two places should not be required.

I believe that can be done for our pre-commit job at least. Only thing is, I 
don't want it to add comments on jira whenever one patch is updated on 
reviewboard. If some alternatives can be explored, I can make the changes. 

> Base framework for Scheduler.
> -
>
> Key: LENS-879
> URL: https://issues.apache.org/jira/browse/LENS-879
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: server
>Reporter: Ajay Yadava
>Assignee: Ajay Yadava
> Fix For: 2.5
>
> Attachments: LENS-879-v1.patch, LENS-879-v2.patch, LENS-879-v3.patch, 
> LENS-879-v4.patch, LENS-879-v5.patch, LENS-879.patch
>
>
> Add interfaces for scheduler service and xsd for job.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-879) Base framework for Scheduler.

[Amareshwari Sriramadasu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-879:
-
   Resolution: Fixed
Fix Version/s: 2.5
   Status: Resolved  (was: Patch Available)

Committed. Thanks [~ajayyadava] !

Hope will push scheduler service in 2.5

> Base framework for Scheduler.
> -
>
> Key: LENS-879
> URL: https://issues.apache.org/jira/browse/LENS-879
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: server
>Reporter: Ajay Yadava
>Assignee: Ajay Yadava
> Fix For: 2.5
>
> Attachments: LENS-879-v1.patch, LENS-879-v2.patch, LENS-879-v3.patch, 
> LENS-879-v4.patch, LENS-879-v5.patch, LENS-879.patch
>
>
> Add interfaces for scheduler service and xsd for job.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-872) Download link is not correct for 2.4.0-beta in "release-history.html"

[Raju Bairishetti (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15050575#comment-15050575
 ] 

Raju Bairishetti commented on LENS-872:
---

[~amareshwari] http://archive.apache.org/dist/lens/2.4-beta/  link is exist now 
and it has all the release artifacts.

> Download link is not correct for 2.4.0-beta in "release-history.html"
> -
>
> Key: LENS-872
> URL: https://issues.apache.org/jira/browse/LENS-872
> Project: Apache Lens
>  Issue Type: Task
>  Components: docs
>Reporter: Raju Bairishetti
>Assignee: Raju Bairishetti
>Priority: Critical
>  Labels: release
> Fix For: 2.5
>
>
> [Release history page|http://lens.apache.org/releases/release-history.htm]  
> contains all the information about the previous releases and current 
> releases. Download link for latest release is pointing to archived dist repo. 
> It can be always archived repo.
> It should point to archived dist repo 
> link(http://archive.apache.org/dist/lens/2.4-beta/) for 2.4. 
> [Download page|http://lens.apache.org/releases/download.html] is having the 
> link to mirrors for latest release. Users can download from there.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 41193: LENS-270 : The exception thrown for no candidate fact should contain only brief error

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41193/#review109731
---



lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFactAvailableException.java
 (line 51)


Can you add unit tests for comparision?



lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFactAvailableException.java
 (lines 52 - 55)


Seems you are doing much comparison here. If e instanceof 
NoCandidateFactAvailableException, then we should compare max causes of both 
exceptions



lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java (line 
849)


Lets use slf4j style for logging



lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java (line 
850)


Can you add NoCandidateDimAvailableException as well for dimtables ?


- Amareshwari Sriramadasu


On Dec. 10, 2015, 6:49 a.m., Sushil Mohanty wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41193/
> ---
> 
> (Updated Dec. 10, 2015, 6:49 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-270
> https://issues.apache.org/jira/browse/LENS-270
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> After this change NO_CANDIDATE_FACT_AVAILABLE exception throws only brief 
> error also it compares errors across drivers to show the appropriate one.
> 
> 
> Diffs
> -
> 
>   
> lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFactAvailableException.java
>  PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 
> cf114c9 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 
> ee84a4c 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
> fea70b7 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java
>  d16ea4c 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java 
> 1fc8bc8 
> 
> Diff: https://reviews.apache.org/r/41193/diff/
> 
> 
> Testing
> ---
> 
> Fixed test cases. mvn clean install is running fine.
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules . SUCCESS [1.857s]
> [INFO] Lens .. SUCCESS [3.609s]
> [INFO] Lens API .. SUCCESS [24.695s]
> [INFO] Lens API for server and extensions  SUCCESS [21.389s]
> [INFO] Lens Cube . SUCCESS 
> [11:16.979s]
> [INFO] Lens DB storage ... SUCCESS [20.342s]
> [INFO] Lens Query Library  SUCCESS [17.663s]
> [INFO] Lens Hive Driver .. SUCCESS [2:49.242s]
> [INFO] Lens Driver for JDBC .. SUCCESS [36.354s]
> [INFO] Lens Elastic Search Driver  SUCCESS [15.701s]
> [INFO] Lens Server ... SUCCESS [9:46.856s]
> [INFO] Lens client ... SUCCESS [32.908s]
> [INFO] Lens CLI .. SUCCESS [50.828s]
> [INFO] Lens Examples . SUCCESS [8.110s]
> [INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [0.703s]
> [INFO] Lens Distribution . SUCCESS [8.565s]
> [INFO] Lens ML Lib ... SUCCESS [1:24.915s]
> [INFO] Lens ML Ext Distribution .. SUCCESS [2.194s]
> [INFO] Lens Regression ... SUCCESS [13.202s]
> [INFO] Lens UI ... SUCCESS [33.676s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 30:10.728s
> [INFO] Finished at: Thu Dec 10 06:47:36 UTC 2015
> [INFO] Final Memory: 200M/2134M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Sushil Mohanty
> 
>

[jira] [Commented] (LENS-270) The exception thrown for no candidate fact should contain only brief error

[Sushil Mohanty (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15050559#comment-15050559
 ] 

Sushil Mohanty commented on LENS-270:
-

Below are some sample error message from columns present in only one of the 
storage.
{CODE} 
lens-shell>query explain cube select  column_from_hive from test_cube where 
time_range_in(time_part_col, '2015-12-01-00', '2015-12-09-00')
Request Id: 2260c331-1333-4815-9266-6057fafc9dd2
Error Code: 3028
Error Message: No candidate fact table available to answer the query, because 
Missing partitions for the cube table: [[it:[2015-12-01-00-00-00, 
2015-12-09-00-00-00)]]

lens-shell>query explain cube select  column_from_jdbc from test_cube where 
time_range_in(time_part_col, '2015-12-01-00', '2015-12-09-00')
Request Id: 2260c331-1333-4815-9266-6057fafc9dd2
Error Code: 3028
Error Message: No candidate fact table available to answer the query, because 
Missing partitions for the cube table: [[it:[2015-12-01-00-00-00, 
2015-12-09-00-00-00)]]
{CODE}

> The exception thrown for no candidate fact should contain only brief error
> --
>
> Key: LENS-270
> URL: https://issues.apache.org/jira/browse/LENS-270
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Amareshwari Sriramadasu
>Assignee: Sushil Mohanty
> Fix For: 2.5
>
>
> The exception thrown for no candidate fact table can answer should contain 
> only brief error and detail error should be part of query status details.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-879) Base framework for Scheduler.

[Ajay Yadava (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15050542#comment-15050542
 ] 

Ajay Yadava commented on LENS-879:
--

I was curious about the metadata like git commits(in case multiple commits are 
there), commit message etc. I tested it by downloading from reviewboard and it 
retains all the metadata. Thanks!

> Base framework for Scheduler.
> -
>
> Key: LENS-879
> URL: https://issues.apache.org/jira/browse/LENS-879
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: server
>Reporter: Ajay Yadava
>Assignee: Ajay Yadava
> Attachments: LENS-879-v1.patch, LENS-879-v2.patch, LENS-879-v3.patch, 
> LENS-879-v4.patch, LENS-879-v5.patch, LENS-879.patch
>
>
> Add interfaces for scheduler service and xsd for job.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-879) Base framework for Scheduler.

[Amareshwari Sriramadasu (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15050538#comment-15050538
 ] 

Amareshwari Sriramadasu commented on LENS-879:
--

bq. I think instead of making the build a committer's prerogative, opening it 
for contributors will be much helpful.

Agreed. We should check if there is a way to download patch from reviewboard 
and run tests on that. Uploading in two places should not be required.

I'm not sure about whats the git metadata you are talking about here, but the 
patch downloaded from review board will be same as what you attach here, so we 
should not lose any information.

> Base framework for Scheduler.
> -
>
> Key: LENS-879
> URL: https://issues.apache.org/jira/browse/LENS-879
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: server
>Reporter: Ajay Yadava
>Assignee: Ajay Yadava
> Attachments: LENS-879-v1.patch, LENS-879-v2.patch, LENS-879-v3.patch, 
> LENS-879-v4.patch, LENS-879-v5.patch, LENS-879.patch
>
>
> Add interfaces for scheduler service and xsd for job.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-879) Base framework for Scheduler.

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15050536#comment-15050536
 ] 

Hadoop QA commented on LENS-879:


Applied patch: 
[LENS-879-v5.patch|https://issues.apache.org/jira/secure/attachment/12776762/LENS-879-v5.patch]
 and ran command: mvn clean install -fae. Result: Success. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/212/

> Base framework for Scheduler.
> -
>
> Key: LENS-879
> URL: https://issues.apache.org/jira/browse/LENS-879
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: server
>Reporter: Ajay Yadava
>Assignee: Ajay Yadava
> Attachments: LENS-879-v1.patch, LENS-879-v2.patch, LENS-879-v3.patch, 
> LENS-879-v4.patch, LENS-879-v5.patch, LENS-879.patch
>
>
> Add interfaces for scheduler service and xsd for job.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 39911: LENS-760 : Session close should not result in running query failures

[Deepak Barr]

> On Dec. 10, 2015, 4:41 a.m., Puneet Gupta wrote:
> > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java, 
> > lines 803-804
> > 
> >
> > Please log the closing of session .

Not required in latest diff. Session close on driver close is removed.


- Deepak


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39911/#review109474
---


On Dec. 10, 2015, 10:19 a.m., Deepak Barr wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39911/
> ---
> 
> (Updated Dec. 10, 2015, 10:19 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> OperationHandle-HiveSession mapping is maintained for all active operations. 
> Now, hive session will only be closed when there are no active operations 
> running on that session.
> 
> 
> Diffs
> -
> 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 
> a84c679 
>   
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java
>  ab5ada9 
>   
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 
> f6693aa 
> 
> Diff: https://reviews.apache.org/r/39911/diff/
> 
> 
> Testing
> ---
> 
> Yes.
> 
> 1. Created session.
> 2. Fired a query.
> 3. Deleted the session before query finishes. 
> 4. Query keeps running and finishes eventually.
> 
> 
> Thanks,
> 
> Deepak Barr
> 
>

Re: Review Request 39911: LENS-760 : Session close should not result in running query failures

[Deepak Barr]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39911/
---

(Updated Dec. 10, 2015, 10:19 a.m.)


Review request for lens.


Changes
---

removed session close logic from driver.close().


Repository: lens


Description
---

OperationHandle-HiveSession mapping is maintained for all active operations. 
Now, hive session will only be closed when there are no active operations 
running on that session.


Diffs (updated)
-

  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 
a84c679 
  
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java
 ab5ada9 
  lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 
f6693aa 

Diff: https://reviews.apache.org/r/39911/diff/


Testing
---

Yes.

1. Created session.
2. Fired a query.
3. Deleted the session before query finishes. 
4. Query keeps running and finishes eventually.


Thanks,

Deepak Barr

[jira] [Commented] (LENS-879) Base framework for Scheduler.

[Ajay Yadava (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15050498#comment-15050498
 ] 

Ajay Yadava commented on LENS-879:
--

Thanks for the detailed response, appreciate it. My intention was not to 
propose a change in the workflow but just to get some clarifications. Just for 
a fresh perspective I will put my views here:

I think instead of making the build a committer's prerogative, opening it for 
contributors will be much helpful. I think same is reflected when most Apache 
Projects run it on Patch Available queue and not on JIRAs which have "Ship It" 
or "+1". 

It is also not about contributor's confidence in patch, uploading your work in 
open for criticism from everyone requires more confidence. 

1. It also provides a sandbox environment for contributors to test their 
changes with the latest of the trunk. It might be the case that the patch 
passed on my machine, but fails on Jenkins because of some timing issues in 
tests. Discovering that issue early is very useful as it might require non 
trivial changes in design and will cause another round of review from scratch 
for my patch. 


2. It is also not useless as it provides a history of changes over time. If 
duplication is the concern then probably switching to github workflow for 
apache is a much better model.

3. It forces some idiosyncratic workflows for LENS e.g. the issues for which 
the patch is available doesn't have status as "Patch Available". It can also 
eliminate the need to copy paste the build status and also allow committers to 
be doubly sure about the quality of patch. 

All that said, these are just my personal views. As I said earlier also, 
intention was to just get some clarifications on build/metadata and not propose 
a new workflow. I am happy to stop posting my patches on JIRA and save some 
clicks :)


> Base framework for Scheduler.
> -
>
> Key: LENS-879
> URL: https://issues.apache.org/jira/browse/LENS-879
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: server
>Reporter: Ajay Yadava
>Assignee: Ajay Yadava
> Attachments: LENS-879-v1.patch, LENS-879-v2.patch, LENS-879-v3.patch, 
> LENS-879-v4.patch, LENS-879-v5.patch, LENS-879.patch
>
>
> Add interfaces for scheduler service and xsd for job.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 39911: LENS-760 : Session close should not result in running query failures

[Deepak Barr]

> On Dec. 10, 2015, 4:41 a.m., Puneet Gupta wrote:
> > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java, 
> > line 535
> > 
> >
> > If closeQuery() is not called before this, which happens for (result == 
> > null || !(result instanceof HiveInMemoryResultSet),  how will the oprphan 
> > session be closed? 
> > As of now closeQuery() is doing that also.

Looking at the execute method and its comment[assuming this is only called for 
executing explain/insert/set/delete/etc... queries which don't ask to fetch 
data.),I think this method is only called for queries that do not return 
result,so I assumed closeQuery() will be called.Looking at the code, I can see 
this method is called for  "add jar" and "explain" queries.


- Deepak


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39911/#review109474
---


On Dec. 2, 2015, 10:40 a.m., Deepak Barr wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39911/
> ---
> 
> (Updated Dec. 2, 2015, 10:40 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> OperationHandle-HiveSession mapping is maintained for all active operations. 
> Now, hive session will only be closed when there are no active operations 
> running on that session.
> 
> 
> Diffs
> -
> 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 
> a84c679 
>   
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java
>  ab5ada9 
>   
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 
> f6693aa 
> 
> Diff: https://reviews.apache.org/r/39911/diff/
> 
> 
> Testing
> ---
> 
> Yes.
> 
> 1. Created session.
> 2. Fired a query.
> 3. Deleted the session before query finishes. 
> 4. Query keeps running and finishes eventually.
> 
> 
> Thanks,
> 
> Deepak Barr
> 
>

Re: Review Request 41039: LENS-890: Allow per-queue driver max launched queries constraints

[Rajat Khandelwal]

> On Dec. 10, 2015, 2:58 p.m., Amareshwari Sriramadasu wrote:
> > Ship It!

I was thinking I'll add per-priority constraints too.


- Rajat


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41039/#review109724
---


On Dec. 7, 2015, 8:28 p.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41039/
> ---
> 
> (Updated Dec. 7, 2015, 8:28 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-890
> https://issues.apache.org/jira/browse/LENS-890
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/util/CommonUtils.java 
> 38d58c710a2b917c34cda5de96a36dc49b6f15f0 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java
>  2f20113a1a30f902a1db4b25d5a78da0126a1b0c 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraint.java
>  bae2e6490aafbfd55c9983c94d9cc892af384f7b 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraintFactory.java
>  b6e6c2f1bd2e4f3c0acdcdaae57dcd812e6bb435 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraintTest.java
>  55a2eea110f9001c962faede01cef396e8c91b6c 
>   
> lens-server/src/test/java/org/apache/lens/server/query/constraint/ThreadSafeEstimatedQueryCollectionTest.java
>  9138f8ea2bb0b87bfcd2c9a4770bc732856fa680 
> 
> Diff: https://reviews.apache.org/r/41039/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 41039: LENS-890: Allow per-queue driver max launched queries constraints

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41039/#review109724
---

Ship it!


Ship It!

- Amareshwari Sriramadasu


On Dec. 7, 2015, 2:58 p.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41039/
> ---
> 
> (Updated Dec. 7, 2015, 2:58 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-890
> https://issues.apache.org/jira/browse/LENS-890
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/util/CommonUtils.java 
> 38d58c710a2b917c34cda5de96a36dc49b6f15f0 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java
>  2f20113a1a30f902a1db4b25d5a78da0126a1b0c 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraint.java
>  bae2e6490aafbfd55c9983c94d9cc892af384f7b 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraintFactory.java
>  b6e6c2f1bd2e4f3c0acdcdaae57dcd812e6bb435 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraintTest.java
>  55a2eea110f9001c962faede01cef396e8c91b6c 
>   
> lens-server/src/test/java/org/apache/lens/server/query/constraint/ThreadSafeEstimatedQueryCollectionTest.java
>  9138f8ea2bb0b87bfcd2c9a4770bc732856fa680 
> 
> Diff: https://reviews.apache.org/r/41039/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

[jira] [Commented] (LENS-879) Base framework for Scheduler.

[Rajat Khandelwal (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15050425#comment-15050425
 ] 

Rajat Khandelwal commented on LENS-879:
---

I believe that attaching patch just for the reason of checking pre-commit 
results is not a good idea. That would be a misuse of pre-commit job. As a 
contributor you should be confident about the validity of your patch. I believe 
the Pre-commit job is to help the committers. The committers have to be sure 
that the patch is valid and is not breaking anything before committing. 
Pre-commit job is automating that manual effort. 

We don't attach patches with every revision posted in reviewboard because 

* too much noise in email
* It's anyway duplicate of something present somewhere else. Whatever be the 
use of the patch file, can be obtained from reviewboard.
* Once committed, earlier patches are useless. I'd say even the committed patch 
is useless, but the "degree of uselessness" is more :P. The patch that is 
uploaded on jira is supposed to be a snapshot of the approved patch on 
reviewboard in case more patches are added on reviewboard later. 
 ** It's a previous version
 ** Of a useless file
 ** While being present somewhere else too



> Base framework for Scheduler.
> -
>
> Key: LENS-879
> URL: https://issues.apache.org/jira/browse/LENS-879
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: server
>Reporter: Ajay Yadava
>Assignee: Ajay Yadava
> Attachments: LENS-879-v1.patch, LENS-879-v2.patch, LENS-879-v3.patch, 
> LENS-879-v4.patch, LENS-879-v5.patch, LENS-879.patch
>
>
> Add interfaces for scheduler service and xsd for job.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 40899: LENS-851: Replace columns with aliases in where clause of the inner query

[Amareshwari Sriramadasu]

> On Dec. 10, 2015, 8:14 a.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java, line 
> > 152
> > 
> >
> > Can it throw LensException out instead of catching  and throwing 
> > IllegalArgumentException?
> 
> Rajat Khandelwal wrote:
> * There will be signature changes for other functions. 
> * this function is used in `hashCode()`. There we can't throw so will 
> have to add try-catch there. Converting to RTE is okay I guess.

The error wont get propagated to client with RTE. Can we do that only in 
hashCode() ?


- Amareshwari


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40899/#review109705
---


On Dec. 10, 2015, 9:05 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40899/
> ---
> 
> (Updated Dec. 10, 2015, 9:05 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-851
> https://issues.apache.org/jira/browse/LENS-851
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/resources/lens-errors.conf 
> ca8562f14fe9f45889ea59b055cdd1b001f02810 
>   lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 
> 6c5dc2f7fb2e2c3e53ed5a25adf464d734eca793 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java 
> b4185174c7ca7365bf9de7e2a0a0f75bdde6ba4b 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 
> 4ec049c103bdae662fc7f869aa32199e768a4b64 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 
> 7f8146158c1e2d883ee9327c4bf847883d0e1004 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java 
> 97088a146729d4d2fb6ed6c55c2d16bfa8c75339 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 
> 9a9d1348cce1b90fa9d558cc6399d441cca9fca1 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java 
> 60b2dde8a7e088d8712879c68cd98193bb72de03 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java
>  418ef5a7b64f717618c3b16fe3755141c07beb76 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java 
> c9ba561bc8da1abb59898619620bbd47ec43028c 
>   
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java
>  e5dbde7af58f74db4ae2a86d9eda602def25d9fe 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
> fea70b72cbde190d69d46f68d163fd9e541c53f8 
> 
> Diff: https://reviews.apache.org/r/40899/diff/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules . SUCCESS [2.226s]
> [INFO] Lens .. SUCCESS [1.371s]
> [INFO] Lens API .. SUCCESS [7.419s]
> [INFO] Lens API for server and extensions  SUCCESS [9.282s]
> [INFO] Lens Cube . SUCCESS [5:14.939s]
> [INFO] Lens DB storage ... SUCCESS [11.174s]
> [INFO] Lens Query Library  SUCCESS [5.068s]
> [INFO] Lens Hive Driver .. SUCCESS [2:37.060s]
> [INFO] Lens Driver for JDBC .. SUCCESS [23.202s]
> [INFO] Lens Elastic Search Driver  SUCCESS [5.523s]
> [INFO] Lens Server ... SUCCESS 
> [10:04.272s]
> [INFO] Lens client ... SUCCESS [23.400s]
> [INFO] Lens CLI .. SUCCESS [40.574s]
> [INFO] Lens Examples . SUCCESS [0.455s]
> [INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [0.338s]
> [INFO] Lens Distribution . SUCCESS [8.315s]
> [INFO] Lens ML Lib ... SUCCESS [1:05.857s]
> [INFO] Lens ML Ext Distribution .. SUCCESS [1.877s]
> [INFO] Lens Regression ... SUCCESS [2.549s]
> [INFO] Lens UI ... SUCCESS [26.262s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 21:52.090s
> [INFO] Finished at: Thu Dec 03 08:36:40 UTC 2015
> [INFO] Final Memory: 170M/922M
> [INFO] 
> 

[jira] [Commented] (LENS-879) Base framework for Scheduler.

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15050399#comment-15050399
 ] 

Hadoop QA commented on LENS-879:


Applied patch: 
[LENS-879-v4.patch|https://issues.apache.org/jira/secure/attachment/12776752/LENS-879-v4.patch]
 and ran command: mvn clean install -fae. Result: Success. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/211/

> Base framework for Scheduler.
> -
>
> Key: LENS-879
> URL: https://issues.apache.org/jira/browse/LENS-879
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: server
>Reporter: Ajay Yadava
>Assignee: Ajay Yadava
> Attachments: LENS-879-v1.patch, LENS-879-v2.patch, LENS-879-v3.patch, 
> LENS-879-v4.patch, LENS-879-v5.patch, LENS-879.patch
>
>
> Add interfaces for scheduler service and xsd for job.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 40899: LENS-851: Replace columns with aliases in where clause of the inner query

[Rajat Khandelwal]

> On Dec. 10, 2015, 1:44 p.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java, line 
> > 152
> > 
> >
> > Can it throw LensException out instead of catching  and throwing 
> > IllegalArgumentException?

* There will be signature changes for other functions. 
* this function is used in `hashCode()`. There we can't throw so will have to 
add try-catch there. Converting to RTE is okay I guess.


- Rajat


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40899/#review109705
---


On Dec. 10, 2015, 2:35 p.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40899/
> ---
> 
> (Updated Dec. 10, 2015, 2:35 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-851
> https://issues.apache.org/jira/browse/LENS-851
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/resources/lens-errors.conf 
> ca8562f14fe9f45889ea59b055cdd1b001f02810 
>   lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 
> 6c5dc2f7fb2e2c3e53ed5a25adf464d734eca793 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java 
> b4185174c7ca7365bf9de7e2a0a0f75bdde6ba4b 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 
> 4ec049c103bdae662fc7f869aa32199e768a4b64 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 
> 7f8146158c1e2d883ee9327c4bf847883d0e1004 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java 
> 97088a146729d4d2fb6ed6c55c2d16bfa8c75339 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 
> 9a9d1348cce1b90fa9d558cc6399d441cca9fca1 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java 
> 60b2dde8a7e088d8712879c68cd98193bb72de03 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java
>  418ef5a7b64f717618c3b16fe3755141c07beb76 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java 
> c9ba561bc8da1abb59898619620bbd47ec43028c 
>   
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java
>  e5dbde7af58f74db4ae2a86d9eda602def25d9fe 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
> fea70b72cbde190d69d46f68d163fd9e541c53f8 
> 
> Diff: https://reviews.apache.org/r/40899/diff/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules . SUCCESS [2.226s]
> [INFO] Lens .. SUCCESS [1.371s]
> [INFO] Lens API .. SUCCESS [7.419s]
> [INFO] Lens API for server and extensions  SUCCESS [9.282s]
> [INFO] Lens Cube . SUCCESS [5:14.939s]
> [INFO] Lens DB storage ... SUCCESS [11.174s]
> [INFO] Lens Query Library  SUCCESS [5.068s]
> [INFO] Lens Hive Driver .. SUCCESS [2:37.060s]
> [INFO] Lens Driver for JDBC .. SUCCESS [23.202s]
> [INFO] Lens Elastic Search Driver  SUCCESS [5.523s]
> [INFO] Lens Server ... SUCCESS 
> [10:04.272s]
> [INFO] Lens client ... SUCCESS [23.400s]
> [INFO] Lens CLI .. SUCCESS [40.574s]
> [INFO] Lens Examples . SUCCESS [0.455s]
> [INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [0.338s]
> [INFO] Lens Distribution . SUCCESS [8.315s]
> [INFO] Lens ML Lib ... SUCCESS [1:05.857s]
> [INFO] Lens ML Ext Distribution .. SUCCESS [1.877s]
> [INFO] Lens Regression ... SUCCESS [2.549s]
> [INFO] Lens UI ... SUCCESS [26.262s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 21:52.090s
> [INFO] Finished at: Thu Dec 03 08:36:40 UTC 2015
> [INFO] Final Memory: 170M/922M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 40899: LENS-851: Replace columns with aliases in where clause of the inner query

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40899/
---

(Updated Dec. 10, 2015, 2:35 p.m.)


Review request for lens.


Bugs: LENS-851
https://issues.apache.org/jira/browse/LENS-851


Repository: lens


Description
---


Diffs (updated)
-

  lens-api/src/main/resources/lens-errors.conf 
ca8562f14fe9f45889ea59b055cdd1b001f02810 
  lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 
6c5dc2f7fb2e2c3e53ed5a25adf464d734eca793 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java 
b4185174c7ca7365bf9de7e2a0a0f75bdde6ba4b 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 
4ec049c103bdae662fc7f869aa32199e768a4b64 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 
7f8146158c1e2d883ee9327c4bf847883d0e1004 
  lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java 
97088a146729d4d2fb6ed6c55c2d16bfa8c75339 
  lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 
9a9d1348cce1b90fa9d558cc6399d441cca9fca1 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java 
60b2dde8a7e088d8712879c68cd98193bb72de03 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java
 418ef5a7b64f717618c3b16fe3755141c07beb76 
  lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java 
c9ba561bc8da1abb59898619620bbd47ec43028c 
  
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java
 e5dbde7af58f74db4ae2a86d9eda602def25d9fe 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
fea70b72cbde190d69d46f68d163fd9e541c53f8 

Diff: https://reviews.apache.org/r/40899/diff/


Testing
---

[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules . SUCCESS [2.226s]
[INFO] Lens .. SUCCESS [1.371s]
[INFO] Lens API .. SUCCESS [7.419s]
[INFO] Lens API for server and extensions  SUCCESS [9.282s]
[INFO] Lens Cube . SUCCESS [5:14.939s]
[INFO] Lens DB storage ... SUCCESS [11.174s]
[INFO] Lens Query Library  SUCCESS [5.068s]
[INFO] Lens Hive Driver .. SUCCESS [2:37.060s]
[INFO] Lens Driver for JDBC .. SUCCESS [23.202s]
[INFO] Lens Elastic Search Driver  SUCCESS [5.523s]
[INFO] Lens Server ... SUCCESS [10:04.272s]
[INFO] Lens client ... SUCCESS [23.400s]
[INFO] Lens CLI .. SUCCESS [40.574s]
[INFO] Lens Examples . SUCCESS [0.455s]
[INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [0.338s]
[INFO] Lens Distribution . SUCCESS [8.315s]
[INFO] Lens ML Lib ... SUCCESS [1:05.857s]
[INFO] Lens ML Ext Distribution .. SUCCESS [1.877s]
[INFO] Lens Regression ... SUCCESS [2.549s]
[INFO] Lens UI ... SUCCESS [26.262s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 21:52.090s
[INFO] Finished at: Thu Dec 03 08:36:40 UTC 2015
[INFO] Final Memory: 170M/922M
[INFO] 


Thanks,

Rajat Khandelwal

[jira] [Commented] (LENS-879) Base framework for Scheduler.

[Ajay Yadava (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15050366#comment-15050366
 ] 

Ajay Yadava commented on LENS-879:
--

I was not sure about the git metadata information getting saved in the patch 
once it's uploaded to the reviewboard. Sometimes for large features it's useful 
for me to revert back to a particular commit id inside the patch. 

Another reason was to leverage the precommit build to see if I am making some 
mistakes and fix them early. Does Hadoop QA also pull the diff from reviewboard 
and run or is it run only at the end after Ship It?

I can skip it if it is producing too much noise on the mailing lists.

> Base framework for Scheduler.
> -
>
> Key: LENS-879
> URL: https://issues.apache.org/jira/browse/LENS-879
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: server
>Reporter: Ajay Yadava
>Assignee: Ajay Yadava
> Attachments: LENS-879-v1.patch, LENS-879-v2.patch, LENS-879-v3.patch, 
> LENS-879-v4.patch, LENS-879-v5.patch, LENS-879.patch
>
>
> Add interfaces for scheduler service and xsd for job.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-879) Base framework for Scheduler.

[Ajay Yadava (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ajay Yadava updated LENS-879:
-
Attachment: LENS-879-v5.patch

Changed the return type to void for scheduleJob method.

> Base framework for Scheduler.
> -
>
> Key: LENS-879
> URL: https://issues.apache.org/jira/browse/LENS-879
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: server
>Reporter: Ajay Yadava
>Assignee: Ajay Yadava
> Attachments: LENS-879-v1.patch, LENS-879-v2.patch, LENS-879-v3.patch, 
> LENS-879-v4.patch, LENS-879-v5.patch, LENS-879.patch
>
>
> Add interfaces for scheduler service and xsd for job.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 40638: Base framework for scheduler.

[Ajay Yadava]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/
---

(Updated Dec. 10, 2015, 8:47 a.m.)


Review request for lens.


Changes
---

Changed the return type to void for scheduleJob method.


Bugs: LENS-879
https://issues.apache.org/jira/browse/LENS-879


Repository: lens


Description
---

Base framework for lens scheduler service and job definition.


Diffs (updated)
-

  lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java 
PRE-CREATION 
  lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInfo.java 
PRE-CREATION 
  
lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java
 PRE-CREATION 
  
lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java 
PRE-CREATION 
  lens-api/src/main/resources/scheduler-job-0.1.xsd PRE-CREATION 
  lens-examples/src/main/resources/example-job.xml PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java
 9f48d27 
  
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobStats.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java
 PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java
 3389aba 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java
 24949bd 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
 PRE-CREATION 
  lens-server/src/main/resources/lensserver-default.xml 39b72dc 
  
lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java
 e11413e 
  pom.xml 732b3bb 
  src/site/apt/admin/config.apt bcf4b7d 

Diff: https://reviews.apache.org/r/40638/diff/


Testing
---


Thanks,

Ajay Yadava

[jira] [Commented] (LENS-882) provide option from CLI as well to list queries by driver

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15050344#comment-15050344
 ] 

Hudson commented on LENS-882:
-

SUCCESS: Integrated in Lens-Commit #1148 (See 
[https://builds.apache.org/job/Lens-Commit/1148/])
LENS-882: Provide option from CLI to list queries by driver (rajatgupta59: rev 
0e4c18cb917015b469ca43d30d7e2196d8f64789)
* lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java
* lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java
* lens-client/src/main/java/org/apache/lens/client/LensStatement.java
* src/site/apt/user/cli.apt
* lens-client/src/main/java/org/apache/lens/client/LensClient.java


> provide option from CLI as well to list queries by driver
> -
>
> Key: LENS-882
> URL: https://issues.apache.org/jira/browse/LENS-882
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: client
>Reporter: Archana H
>Assignee: Deepak Barr
> Fix For: 2.5
>
> Attachments: LENS-882.4.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 40638: Base framework for scheduler.

[Ajay Yadava]

> On Dec. 10, 2015, 8:29 a.m., Amareshwari Sriramadasu wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java,
> >  line 57
> > 
> >
> > return would be void.

It's just to be consistent with SubmitAndSchedule. If you want I can change it.


- Ajay


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/#review109707
---


On Dec. 10, 2015, 8:01 a.m., Ajay Yadava wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40638/
> ---
> 
> (Updated Dec. 10, 2015, 8:01 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-879
> https://issues.apache.org/jira/browse/LENS-879
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Base framework for lens scheduler service and job definition.
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java 
> PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInfo.java 
> PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java
>  PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java
>  PRE-CREATION 
>   lens-api/src/main/resources/scheduler-job-0.1.xsd PRE-CREATION 
>   lens-examples/src/main/resources/example-job.xml PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java
>  9f48d27 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobStats.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java
>  3389aba 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java
>  24949bd 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
>  PRE-CREATION 
>   lens-server/src/main/resources/lensserver-default.xml 39b72dc 
>   
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java
>  e11413e 
>   pom.xml 732b3bb 
>   src/site/apt/admin/config.apt bcf4b7d 
> 
> Diff: https://reviews.apache.org/r/40638/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ajay Yadava
> 
>

[jira] [Commented] (LENS-879) Base framework for Scheduler.

[Amareshwari Sriramadasu (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15050329#comment-15050329
 ] 

Amareshwari Sriramadasu commented on LENS-879:
--

[~ajayyadava], Thanks for taking this up. As per 
http://lens.apache.org/developer/contribute.html#Submit_patch, we are only 
attaching the patches to jira once the review gets a ship it, sothat developer 
can save time in uploading in multiple places. You can go through other 
guidelines in contributor doc as well for your upcoming patches. 

> Base framework for Scheduler.
> -
>
> Key: LENS-879
> URL: https://issues.apache.org/jira/browse/LENS-879
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: server
>Reporter: Ajay Yadava
>Assignee: Ajay Yadava
> Attachments: LENS-879-v1.patch, LENS-879-v2.patch, LENS-879-v3.patch, 
> LENS-879-v4.patch, LENS-879.patch
>
>
> Add interfaces for scheduler service and xsd for job.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 40638: Base framework for scheduler.

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/#review109707
---

Ship it!



lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java
 (line 57)


return would be void.


- Amareshwari Sriramadasu


On Dec. 10, 2015, 8:01 a.m., Ajay Yadava wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40638/
> ---
> 
> (Updated Dec. 10, 2015, 8:01 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-879
> https://issues.apache.org/jira/browse/LENS-879
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Base framework for lens scheduler service and job definition.
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java 
> PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInfo.java 
> PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java
>  PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java
>  PRE-CREATION 
>   lens-api/src/main/resources/scheduler-job-0.1.xsd PRE-CREATION 
>   lens-examples/src/main/resources/example-job.xml PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java
>  9f48d27 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobStats.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java
>  3389aba 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java
>  24949bd 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
>  PRE-CREATION 
>   lens-server/src/main/resources/lensserver-default.xml 39b72dc 
>   
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java
>  e11413e 
>   pom.xml 732b3bb 
>   src/site/apt/admin/config.apt bcf4b7d 
> 
> Diff: https://reviews.apache.org/r/40638/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ajay Yadava
> 
>

[jira] [Commented] (LENS-882) provide option from CLI as well to list queries by driver

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15050304#comment-15050304
 ] 

Hudson commented on LENS-882:
-

UNSTABLE: Integrated in Lens-Commit-Java8 #63 (See 
[https://builds.apache.org/job/Lens-Commit-Java8/63/])
LENS-882: Provide option from CLI to list queries by driver (rajatgupta59: rev 
0e4c18cb917015b469ca43d30d7e2196d8f64789)
* lens-client/src/main/java/org/apache/lens/client/LensClient.java
* src/site/apt/user/cli.apt
* lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java
* lens-client/src/main/java/org/apache/lens/client/LensStatement.java
* lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java


> provide option from CLI as well to list queries by driver
> -
>
> Key: LENS-882
> URL: https://issues.apache.org/jira/browse/LENS-882
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: client
>Reporter: Archana H
>Assignee: Deepak Barr
> Fix For: 2.5
>
> Attachments: LENS-882.4.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 40899: LENS-851: Replace columns with aliases in where clause of the inner query

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40899/#review109705
---



lens-api/src/main/resources/lens-errors.conf (lines 294 - 295)


Should be INTERNAL_SERVER_ERROR here.



lens-api/src/main/resources/lens-errors.conf (line 314)


Should be BAD_REQUEST here



lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java (line 151)


Can it throw LensException out instead of catching  and throwing 
IllegalArgumentException?



lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java (line 
22)


Should be using error code > 3100



lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java (line 179)


Should be changed to new error code.


- Amareshwari Sriramadasu


On Dec. 10, 2015, 7:46 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40899/
> ---
> 
> (Updated Dec. 10, 2015, 7:46 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-851
> https://issues.apache.org/jira/browse/LENS-851
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/resources/lens-errors.conf 
> ca8562f14fe9f45889ea59b055cdd1b001f02810 
>   lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 
> 6c5dc2f7fb2e2c3e53ed5a25adf464d734eca793 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java 
> b4185174c7ca7365bf9de7e2a0a0f75bdde6ba4b 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 
> 4ec049c103bdae662fc7f869aa32199e768a4b64 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 
> 7f8146158c1e2d883ee9327c4bf847883d0e1004 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java 
> 97088a146729d4d2fb6ed6c55c2d16bfa8c75339 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 
> 9a9d1348cce1b90fa9d558cc6399d441cca9fca1 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java 
> 60b2dde8a7e088d8712879c68cd98193bb72de03 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java
>  418ef5a7b64f717618c3b16fe3755141c07beb76 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java 
> c9ba561bc8da1abb59898619620bbd47ec43028c 
>   
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java
>  e5dbde7af58f74db4ae2a86d9eda602def25d9fe 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
> fea70b72cbde190d69d46f68d163fd9e541c53f8 
> 
> Diff: https://reviews.apache.org/r/40899/diff/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules . SUCCESS [2.226s]
> [INFO] Lens .. SUCCESS [1.371s]
> [INFO] Lens API .. SUCCESS [7.419s]
> [INFO] Lens API for server and extensions  SUCCESS [9.282s]
> [INFO] Lens Cube . SUCCESS [5:14.939s]
> [INFO] Lens DB storage ... SUCCESS [11.174s]
> [INFO] Lens Query Library  SUCCESS [5.068s]
> [INFO] Lens Hive Driver .. SUCCESS [2:37.060s]
> [INFO] Lens Driver for JDBC .. SUCCESS [23.202s]
> [INFO] Lens Elastic Search Driver  SUCCESS [5.523s]
> [INFO] Lens Server ... SUCCESS 
> [10:04.272s]
> [INFO] Lens client ... SUCCESS [23.400s]
> [INFO] Lens CLI .. SUCCESS [40.574s]
> [INFO] Lens Examples . SUCCESS [0.455s]
> [INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [0.338s]
> [INFO] Lens Distribution . SUCCESS [8.315s]
> [INFO] Lens ML Lib ... SUCCESS [1:05.857s]
> [INFO] Lens ML Ext Distribution .. SUCCESS [1.877s]
> [INFO] Lens Regression ... SUCCESS [2.549s]
> [INFO] Lens UI ... SUCCESS [26.262s]
> [INFO] 
> 
> [INFO] BUI

[jira] [Updated] (LENS-879) Base framework for Scheduler.

[Ajay Yadava (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ajay Yadava updated LENS-879:
-
Attachment: LENS-879-v4.patch

Latest patch with all review comments addressed.

> Base framework for Scheduler.
> -
>
> Key: LENS-879
> URL: https://issues.apache.org/jira/browse/LENS-879
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: server
>Reporter: Ajay Yadava
>Assignee: Ajay Yadava
> Attachments: LENS-879-v1.patch, LENS-879-v2.patch, LENS-879-v3.patch, 
> LENS-879-v4.patch, LENS-879.patch
>
>
> Add interfaces for scheduler service and xsd for job.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 40638: Base framework for scheduler.

[Ajay Yadava]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/
---

(Updated Dec. 10, 2015, 8:01 a.m.)


Review request for lens.


Changes
---

Addressed the review comments.


Bugs: LENS-879
https://issues.apache.org/jira/browse/LENS-879


Repository: lens


Description
---

Base framework for lens scheduler service and job definition.


Diffs (updated)
-

  lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java 
PRE-CREATION 
  lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInfo.java 
PRE-CREATION 
  
lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java
 PRE-CREATION 
  
lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java 
PRE-CREATION 
  lens-api/src/main/resources/scheduler-job-0.1.xsd PRE-CREATION 
  lens-examples/src/main/resources/example-job.xml PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java
 9f48d27 
  
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobStats.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java
 PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java
 3389aba 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java
 24949bd 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
 PRE-CREATION 
  lens-server/src/main/resources/lensserver-default.xml 39b72dc 
  
lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java
 e11413e 
  pom.xml 732b3bb 
  src/site/apt/admin/config.apt bcf4b7d 

Diff: https://reviews.apache.org/r/40638/diff/


Testing
---


Thanks,

Ajay Yadava