[jira] [Commented] (LENS-270) The exception thrown for no candidate fact should contain only brief error

2015-12-14 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/LENS-270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15055609#comment-15055609
 ] 

Hudson commented on LENS-270:
-

SUCCESS: Integrated in Lens-Commit #1153 (See 
[https://builds.apache.org/job/Lens-Commit/1153/])
LENS-270 : The exception thrown for no candidate fact should contain 
(amareshwari: rev 36166a2e58a2a89bd97dc8595cb7920fbf4253d8)
* lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java
* 
lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java
* lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java
* lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java
* lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java
* lens-cube/src/main/java/org/apache/lens/cube/parse/PruneCauses.java
* 
lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFactAvailableException.java


> The exception thrown for no candidate fact should contain only brief error
> --
>
> Key: LENS-270
> URL: https://issues.apache.org/jira/browse/LENS-270
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Amareshwari Sriramadasu
>Assignee: Sushil Mohanty
> Fix For: 2.5
>
> Attachments: LENS-270_2.patch, LENS-270_3.patch, LENS-270_4.patch
>
>
> The exception thrown for no candidate fact table can answer should contain 
> only brief error and detail error should be part of query status details.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Review Request 41039: LENS-890: Allow per-queue driver max launched queries constraints

2015-12-14 Thread Rajat Khandelwal

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41039/
---

(Updated Dec. 14, 2015, 2:13 p.m.)


Review request for lens.


Bugs: LENS-890
https://issues.apache.org/jira/browse/LENS-890


Repository: lens


Description
---


Diffs (updated)
-

  lens-api/src/main/java/org/apache/lens/api/util/CommonUtils.java 
38d58c710a2b917c34cda5de96a36dc49b6f15f0 
  
lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java
 d56e1c7e68ecc741f776db7224877994bcc4489a 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 
253cfc4470ae25734d0cc6b05c8382cf69e74773 
  
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 
11efd3c411a10b6506677986609e03f24160b9eb 
  lens-driver-hive/src/test/resources/priority_tests.data 
98b82ef96068d2cc8d5fd07b4fe7538194cdbcac 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java
 55f1535191cd0423c850a1309747f81d5490ca12 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 
c2208846ddd53adf414bd4bae6898e26ac425c56 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java
 2f20113a1a30f902a1db4b25d5a78da0126a1b0c 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
 b637665e79c46014a7ab8770e0da38d4a9768bd6 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraint.java
 bae2e6490aafbfd55c9983c94d9cc892af384f7b 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraintFactory.java
 b6e6c2f1bd2e4f3c0acdcdaae57dcd812e6bb435 
  
lens-server-api/src/test/java/org/apache/lens/server/api/query/TestAbstractQueryContext.java
 a37a4c85cf918e62201d6a6dbf4e8b03fa565637 
  
lens-server-api/src/test/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraintTest.java
 55a2eea110f9001c962faede01cef396e8c91b6c 
  
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
 ffd2d422fd126d7f8acd50014fc4ee9bb3bf5ede 
  
lens-server/src/test/java/org/apache/lens/server/query/constraint/ThreadSafeEstimatedQueryCollectionTest.java
 9138f8ea2bb0b87bfcd2c9a4770bc732856fa680 

Diff: https://reviews.apache.org/r/41039/diff/


Testing
---


Thanks,

Rajat Khandelwal



[jira] [Work started] (LENS-890) Allow per-queue driver max launched queries constraints

2015-12-14 Thread Rajat Khandelwal (JIRA)

 [ 
https://issues.apache.org/jira/browse/LENS-890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on LENS-890 started by Rajat Khandelwal.
-
> Allow per-queue driver max launched queries constraints
> ---
>
> Key: LENS-890
> URL: https://issues.apache.org/jira/browse/LENS-890
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-890.03.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Review Request 41039: LENS-890: Allow per-queue driver max launched queries constraints

2015-12-14 Thread Rajat Khandelwal

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41039/
---

(Updated Dec. 14, 2015, 3:48 p.m.)


Review request for lens.


Bugs: LENS-890
https://issues.apache.org/jira/browse/LENS-890


Repository: lens


Description
---


Diffs (updated)
-

  lens-api/src/main/java/org/apache/lens/api/util/CommonUtils.java 
38d58c710a2b917c34cda5de96a36dc49b6f15f0 
  
lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java
 d56e1c7e68ecc741f776db7224877994bcc4489a 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 
253cfc4470ae25734d0cc6b05c8382cf69e74773 
  
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 
11efd3c411a10b6506677986609e03f24160b9eb 
  lens-driver-hive/src/test/resources/priority_tests.data 
98b82ef96068d2cc8d5fd07b4fe7538194cdbcac 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java
 55f1535191cd0423c850a1309747f81d5490ca12 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 
c2208846ddd53adf414bd4bae6898e26ac425c56 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java
 2f20113a1a30f902a1db4b25d5a78da0126a1b0c 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
 b637665e79c46014a7ab8770e0da38d4a9768bd6 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraint.java
 bae2e6490aafbfd55c9983c94d9cc892af384f7b 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraintFactory.java
 b6e6c2f1bd2e4f3c0acdcdaae57dcd812e6bb435 
  
lens-server-api/src/test/java/org/apache/lens/server/api/query/TestAbstractQueryContext.java
 a37a4c85cf918e62201d6a6dbf4e8b03fa565637 
  
lens-server-api/src/test/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraintTest.java
 55a2eea110f9001c962faede01cef396e8c91b6c 
  
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
 ffd2d422fd126d7f8acd50014fc4ee9bb3bf5ede 
  
lens-server/src/test/java/org/apache/lens/server/query/constraint/ThreadSafeEstimatedQueryCollectionTest.java
 9138f8ea2bb0b87bfcd2c9a4770bc732856fa680 

Diff: https://reviews.apache.org/r/41039/diff/


Testing
---


Thanks,

Rajat Khandelwal



Re: Review Request 40761: Query Completion email missing for some queries

2015-12-14 Thread Puneet Gupta

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40761/
---

(Updated Dec. 14, 2015, 11:50 a.m.)


Review request for lens.


Changes
---

updated comments


Bugs: LENS-887
https://issues.apache.org/jira/browse/LENS-887


Repository: lens


Description
---

Initial Changes (as discussed in JIRA) 
+ disabled core pool timeout for AsyncEventListeners (since pool had only 
single thread)


Diffs (updated)
-

  
lens-server-api/src/main/java/org/apache/lens/server/api/events/AsyncEventListener.java
 547c008 
  lens-server/src/main/java/org/apache/lens/server/EventServiceImpl.java 
a276828 
  lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java 
110624a 
  lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java 
f568b17 
  lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java 
702a529 

Diff: https://reviews.apache.org/r/40761/diff/


Testing
---

> Verified Build .
> Verified new Thread Names while debugging.

[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules . SUCCESS [2.085s]
[INFO] Lens .. SUCCESS [2.889s]
[INFO] Lens API .. SUCCESS [25.083s]
[INFO] Lens API for server and extensions  SUCCESS [23.336s]
[INFO] Lens Cube . SUCCESS [5:57.544s]
[INFO] Lens DB storage ... SUCCESS [20.762s]
[INFO] Lens Query Library  SUCCESS [15.393s]
[INFO] Lens Hive Driver .. SUCCESS [2:50.461s]
[INFO] Lens Driver for JDBC .. SUCCESS [35.760s]
[INFO] Lens Elastic Search Driver  SUCCESS [17.248s]
[INFO] Lens Server ... SUCCESS [9:50.223s]
[INFO] Lens client ... SUCCESS [36.590s]
[INFO] Lens CLI .. SUCCESS [51.185s]
[INFO] Lens Examples . SUCCESS [9.779s]
[INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [1.037s]
[INFO] Lens Distribution . SUCCESS [8.573s]
[INFO] Lens ML Lib ... SUCCESS [1:20.846s]
[INFO] Lens ML Ext Distribution .. SUCCESS [2.013s]
[INFO] Lens Regression ... SUCCESS [12.349s]
[INFO] Lens UI ... SUCCESS [27.294s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 24:51.394s
[INFO] Finished at: Sat Nov 28 04:07:51 UTC 2015
[INFO] Final Memory: 199M/2040M
[INFO] 


Thanks,

Puneet Gupta



Re: Review Request 41039: LENS-890: Allow per-queue driver max launched queries constraints

2015-12-14 Thread Amareshwari Sriramadasu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41039/#review110202
---



lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 
(line 560)


Remove commented code?



lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 
(line 418)


Add the assert back ?


- Amareshwari Sriramadasu


On Dec. 14, 2015, 10:18 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41039/
> ---
> 
> (Updated Dec. 14, 2015, 10:18 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-890
> https://issues.apache.org/jira/browse/LENS-890
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/util/CommonUtils.java 
> 38d58c710a2b917c34cda5de96a36dc49b6f15f0 
>   
> lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java
>  d56e1c7e68ecc741f776db7224877994bcc4489a 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 
> 253cfc4470ae25734d0cc6b05c8382cf69e74773 
>   
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java
>  11efd3c411a10b6506677986609e03f24160b9eb 
>   lens-driver-hive/src/test/resources/priority_tests.data 
> 98b82ef96068d2cc8d5fd07b4fe7538194cdbcac 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java
>  55f1535191cd0423c850a1309747f81d5490ca12 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java
>  c2208846ddd53adf414bd4bae6898e26ac425c56 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java
>  2f20113a1a30f902a1db4b25d5a78da0126a1b0c 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
>  b637665e79c46014a7ab8770e0da38d4a9768bd6 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraint.java
>  bae2e6490aafbfd55c9983c94d9cc892af384f7b 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraintFactory.java
>  b6e6c2f1bd2e4f3c0acdcdaae57dcd812e6bb435 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/TestAbstractQueryContext.java
>  a37a4c85cf918e62201d6a6dbf4e8b03fa565637 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraintTest.java
>  55a2eea110f9001c962faede01cef396e8c91b6c 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
>  ffd2d422fd126d7f8acd50014fc4ee9bb3bf5ede 
>   
> lens-server/src/test/java/org/apache/lens/server/query/constraint/ThreadSafeEstimatedQueryCollectionTest.java
>  9138f8ea2bb0b87bfcd2c9a4770bc732856fa680 
> 
> Diff: https://reviews.apache.org/r/41039/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>



Re: Review Request 41039: LENS-890: Allow per-queue driver max launched queries constraints

2015-12-14 Thread Amareshwari Sriramadasu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41039/#review110221
---



lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
 (line 430)


Is cost not calculated at estimate already?


- Amareshwari Sriramadasu


On Dec. 14, 2015, 10:18 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41039/
> ---
> 
> (Updated Dec. 14, 2015, 10:18 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-890
> https://issues.apache.org/jira/browse/LENS-890
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/util/CommonUtils.java 
> 38d58c710a2b917c34cda5de96a36dc49b6f15f0 
>   
> lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java
>  d56e1c7e68ecc741f776db7224877994bcc4489a 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 
> 253cfc4470ae25734d0cc6b05c8382cf69e74773 
>   
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java
>  11efd3c411a10b6506677986609e03f24160b9eb 
>   lens-driver-hive/src/test/resources/priority_tests.data 
> 98b82ef96068d2cc8d5fd07b4fe7538194cdbcac 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java
>  55f1535191cd0423c850a1309747f81d5490ca12 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java
>  c2208846ddd53adf414bd4bae6898e26ac425c56 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java
>  2f20113a1a30f902a1db4b25d5a78da0126a1b0c 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
>  b637665e79c46014a7ab8770e0da38d4a9768bd6 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraint.java
>  bae2e6490aafbfd55c9983c94d9cc892af384f7b 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraintFactory.java
>  b6e6c2f1bd2e4f3c0acdcdaae57dcd812e6bb435 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/TestAbstractQueryContext.java
>  a37a4c85cf918e62201d6a6dbf4e8b03fa565637 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraintTest.java
>  55a2eea110f9001c962faede01cef396e8c91b6c 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
>  ffd2d422fd126d7f8acd50014fc4ee9bb3bf5ede 
>   
> lens-server/src/test/java/org/apache/lens/server/query/constraint/ThreadSafeEstimatedQueryCollectionTest.java
>  9138f8ea2bb0b87bfcd2c9a4770bc732856fa680 
> 
> Diff: https://reviews.apache.org/r/41039/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>



Re: Review Request 40863: LENS-552: Union support across storage tables in multi fact query

2015-12-14 Thread Amareshwari Sriramadasu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40863/#review110226
---



lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java (line 164)


TODO about?


- Amareshwari Sriramadasu


On Dec. 13, 2015, 10:06 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40863/
> ---
> 
> (Updated Dec. 13, 2015, 10:06 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-552
> https://issues.apache.org/jira/browse/LENS-552
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> includes LENS-851 changes, since I expect this to be merged after LENS-851
> 
> 
> Diffs
> -
> 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java 
> b544a670a27f65b65a66affde55c7276438d4daa 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java 
> 0656049dafc0b974104ff1c2f79a98fac934901d 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AutoJoinContext.java 
> 94725063c0f9f64682bc0741c409bcefdf0be8ec 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 
> 2338ba70bbdeae90c7a0270f63f5d2c1255b5529 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java 
> b95595ade6120c0073c286e073715800b6cdd915 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 
> cf114c91f103d40c1f0fe9886b15820bb7ef7614 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 
> e0759b0b8894ec1d0cca41fa6f897576f8090070 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DefaultQueryAST.java 
> PRE-CREATION 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java
>  a576f3a6720e5e4454faf0188a43091191b0c787 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java 
> bcfc1f6202da5c4377cf6710525c9655a08ce4cc 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 
> 0c43d9800d27b6c343af2b200ebeff9cf20fa816 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 
> 776021d94cfb3c724970bc81a5d03c58459c7911 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java 
> 6c442333fb42beafac1839907159d775b6f97dce 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java 
> da74713e5656a10144a6298a2a6fea266a11e156 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 
> 7cea7d5a4491d1185cae845415d90d46cfd825c0 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java 
> 1385584e033abe904279a8fd6dfa299f4e48665c 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/MultiFactHQLContext.java 
> 113d8deb8284443ae45151aa27852ab97570591e 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/QueryAST.java 
> PRE-CREATION 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java 
> de52b0a50b8cec580eb7807669d652a85b71e5f9 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java
>  96b1d054a3c444960c69298d878784a819defd53 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactSingleStorageHQLContext.java
>  PRE-CREATION 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 
> 62cc071237b84c46d69d78eea694eb9b8e9b2fd4 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 
> 3f01dbeb1e27248071ecd78c48daea8b77c87459 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 
> 97c6d08a6d4ab53a49d9e205d1b4013b08da3658 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
> 0f05556decc24cd5101e75b0851d1f9ff14d4b95 
> 
> Diff: https://reviews.apache.org/r/40863/diff/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules . SUCCESS [2.211s]
> [INFO] Lens .. SUCCESS [4.133s]
> [INFO] Lens API .. SUCCESS [26.669s]
> [INFO] Lens API for server and extensions  SUCCESS [24.038s]
> [INFO] Lens Cube . SUCCESS [6:30.318s]
> [INFO] Lens DB storage ... SUCCESS [19.100s]
> [INFO] Lens Query Library  SUCCESS [14.772s]
> [INFO] Lens Hive Driver .. SUCCESS [3:00.020s]
> [INFO] Lens Driver for JDBC .. SUCCESS [40.555s]
> [INFO] Lens Elastic Search Driver  SUCCESS [18.922s]

Re: Review Request 40761: Query Completion email missing for some queries

2015-12-14 Thread Rajat Khandelwal

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40761/#review110227
---



lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java 
(line 140)


Missing space here too.


- Rajat Khandelwal


On Dec. 14, 2015, 5:20 p.m., Puneet Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40761/
> ---
> 
> (Updated Dec. 14, 2015, 5:20 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-887
> https://issues.apache.org/jira/browse/LENS-887
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Initial Changes (as discussed in JIRA) 
> + disabled core pool timeout for AsyncEventListeners (since pool had only 
> single thread)
> 
> 
> Diffs
> -
> 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/events/AsyncEventListener.java
>  547c008 
>   lens-server/src/main/java/org/apache/lens/server/EventServiceImpl.java 
> a276828 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java 
> 110624a 
>   lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java 
> f568b17 
>   
> lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java 
> 702a529 
> 
> Diff: https://reviews.apache.org/r/40761/diff/
> 
> 
> Testing
> ---
> 
> > Verified Build .
> > Verified new Thread Names while debugging.
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules . SUCCESS [2.085s]
> [INFO] Lens .. SUCCESS [2.889s]
> [INFO] Lens API .. SUCCESS [25.083s]
> [INFO] Lens API for server and extensions  SUCCESS [23.336s]
> [INFO] Lens Cube . SUCCESS [5:57.544s]
> [INFO] Lens DB storage ... SUCCESS [20.762s]
> [INFO] Lens Query Library  SUCCESS [15.393s]
> [INFO] Lens Hive Driver .. SUCCESS [2:50.461s]
> [INFO] Lens Driver for JDBC .. SUCCESS [35.760s]
> [INFO] Lens Elastic Search Driver  SUCCESS [17.248s]
> [INFO] Lens Server ... SUCCESS [9:50.223s]
> [INFO] Lens client ... SUCCESS [36.590s]
> [INFO] Lens CLI .. SUCCESS [51.185s]
> [INFO] Lens Examples . SUCCESS [9.779s]
> [INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [1.037s]
> [INFO] Lens Distribution . SUCCESS [8.573s]
> [INFO] Lens ML Lib ... SUCCESS [1:20.846s]
> [INFO] Lens ML Ext Distribution .. SUCCESS [2.013s]
> [INFO] Lens Regression ... SUCCESS [12.349s]
> [INFO] Lens UI ... SUCCESS [27.294s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 24:51.394s
> [INFO] Finished at: Sat Nov 28 04:07:51 UTC 2015
> [INFO] Final Memory: 199M/2040M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Puneet Gupta
> 
>



[jira] [Created] (LENS-895) Add data availability based triggers in scheduler

2015-12-14 Thread Rajat Khandelwal (JIRA)
Rajat Khandelwal created LENS-895:
-

 Summary: Add data availability based triggers in scheduler
 Key: LENS-895
 URL: https://issues.apache.org/jira/browse/LENS-895
 Project: Apache Lens
  Issue Type: New Feature
Reporter: Rajat Khandelwal
Assignee: Ajay Yadava






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (LENS-895) Add data availability based triggers in scheduler

2015-12-14 Thread Rajat Khandelwal (JIRA)

 [ 
https://issues.apache.org/jira/browse/LENS-895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-895:
--
Component/s: server

> Add data availability based triggers in scheduler
> -
>
> Key: LENS-895
> URL: https://issues.apache.org/jira/browse/LENS-895
> Project: Apache Lens
>  Issue Type: New Feature
>  Components: server
>Reporter: Rajat Khandelwal
>Assignee: Ajay Yadava
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Review Request 40863: LENS-552: Union support across storage tables in multi fact query

2015-12-14 Thread Rajat Khandelwal

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40863/
---

(Updated Dec. 14, 2015, 8:12 p.m.)


Review request for lens.


Bugs: LENS-552
https://issues.apache.org/jira/browse/LENS-552


Repository: lens


Description
---

includes LENS-851 changes, since I expect this to be merged after LENS-851


Diffs (updated)
-

  lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java 
b544a670a27f65b65a66affde55c7276438d4daa 
  lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java 
0656049dafc0b974104ff1c2f79a98fac934901d 
  lens-cube/src/main/java/org/apache/lens/cube/parse/AutoJoinContext.java 
94725063c0f9f64682bc0741c409bcefdf0be8ec 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 
2338ba70bbdeae90c7a0270f63f5d2c1255b5529 
  lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java 
b95595ade6120c0073c286e073715800b6cdd915 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 
f75a6b9b79ee9330de05c24d8f290b2cd27fcc4a 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 
e0759b0b8894ec1d0cca41fa6f897576f8090070 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DefaultQueryAST.java 
PRE-CREATION 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 
a576f3a6720e5e4454faf0188a43091191b0c787 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java 
bcfc1f6202da5c4377cf6710525c9655a08ce4cc 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 
0c43d9800d27b6c343af2b200ebeff9cf20fa816 
  lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 
776021d94cfb3c724970bc81a5d03c58459c7911 
  lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java 
6c442333fb42beafac1839907159d775b6f97dce 
  lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java 
da74713e5656a10144a6298a2a6fea266a11e156 
  lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 
7cea7d5a4491d1185cae845415d90d46cfd825c0 
  lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java 
1385584e033abe904279a8fd6dfa299f4e48665c 
  lens-cube/src/main/java/org/apache/lens/cube/parse/MultiFactHQLContext.java 
113d8deb8284443ae45151aa27852ab97570591e 
  lens-cube/src/main/java/org/apache/lens/cube/parse/QueryAST.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java 
de52b0a50b8cec580eb7807669d652a85b71e5f9 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java
 96b1d054a3c444960c69298d878784a819defd53 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactSingleStorageHQLContext.java
 PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 
62cc071237b84c46d69d78eea694eb9b8e9b2fd4 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 
3f01dbeb1e27248071ecd78c48daea8b77c87459 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 
a5886dc1420a38dee88b8798da3fa386bf713436 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
802ff42cf44e2a51ac984220d57d961f68dec442 

Diff: https://reviews.apache.org/r/40863/diff/


Testing
---

[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules . SUCCESS [2.211s]
[INFO] Lens .. SUCCESS [4.133s]
[INFO] Lens API .. SUCCESS [26.669s]
[INFO] Lens API for server and extensions  SUCCESS [24.038s]
[INFO] Lens Cube . SUCCESS [6:30.318s]
[INFO] Lens DB storage ... SUCCESS [19.100s]
[INFO] Lens Query Library  SUCCESS [14.772s]
[INFO] Lens Hive Driver .. SUCCESS [3:00.020s]
[INFO] Lens Driver for JDBC .. SUCCESS [40.555s]
[INFO] Lens Elastic Search Driver  SUCCESS [18.922s]
[INFO] Lens Server ... SUCCESS [10:23.992s]
[INFO] Lens client ... SUCCESS [40.087s]
[INFO] Lens CLI .. SUCCESS [54.969s]
[INFO] Lens Examples . SUCCESS [11.468s]
[INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [0.983s]
[INFO] Lens Distribution . SUCCESS [9.764s]
[INFO] Lens ML Lib ... SUCCESS [1:31.190s]
[INFO] Lens ML Ext Distribution .. SUCCESS [2.913s]
[INFO] Lens Regression 

Re: Review Request 41039: LENS-890: Allow per-queue driver max launched queries constraints

2015-12-14 Thread Rajat Khandelwal


> On Dec. 14, 2015, 6:48 p.m., Amareshwari Sriramadasu wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java,
> >  line 432
> > 
> >
> > Is cost not calculated at estimate already?

It should be, but in test cases we're bypassing the cost computations. The 
QueryContext created there is a mock one. Estimate call doesn't happen.


- Rajat


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41039/#review110221
---


On Dec. 14, 2015, 3:48 p.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41039/
> ---
> 
> (Updated Dec. 14, 2015, 3:48 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-890
> https://issues.apache.org/jira/browse/LENS-890
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/util/CommonUtils.java 
> 38d58c710a2b917c34cda5de96a36dc49b6f15f0 
>   
> lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java
>  d56e1c7e68ecc741f776db7224877994bcc4489a 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 
> 253cfc4470ae25734d0cc6b05c8382cf69e74773 
>   
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java
>  11efd3c411a10b6506677986609e03f24160b9eb 
>   lens-driver-hive/src/test/resources/priority_tests.data 
> 98b82ef96068d2cc8d5fd07b4fe7538194cdbcac 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java
>  55f1535191cd0423c850a1309747f81d5490ca12 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java
>  c2208846ddd53adf414bd4bae6898e26ac425c56 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java
>  2f20113a1a30f902a1db4b25d5a78da0126a1b0c 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
>  b637665e79c46014a7ab8770e0da38d4a9768bd6 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraint.java
>  bae2e6490aafbfd55c9983c94d9cc892af384f7b 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraintFactory.java
>  b6e6c2f1bd2e4f3c0acdcdaae57dcd812e6bb435 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/TestAbstractQueryContext.java
>  a37a4c85cf918e62201d6a6dbf4e8b03fa565637 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraintTest.java
>  55a2eea110f9001c962faede01cef396e8c91b6c 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
>  ffd2d422fd126d7f8acd50014fc4ee9bb3bf5ede 
>   
> lens-server/src/test/java/org/apache/lens/server/query/constraint/ThreadSafeEstimatedQueryCollectionTest.java
>  9138f8ea2bb0b87bfcd2c9a4770bc732856fa680 
> 
> Diff: https://reviews.apache.org/r/41039/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>



Re: Review Request 41039: LENS-890: Allow per-queue driver max launched queries constraints

2015-12-14 Thread Rajat Khandelwal


> On Dec. 14, 2015, 6:34 p.m., Amareshwari Sriramadasu wrote:
> > lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java,
> >  line 418
> > 
> >
> > Add the assert back ?

Added.


> On Dec. 14, 2015, 6:34 p.m., Amareshwari Sriramadasu wrote:
> > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java, 
> > line 562
> > 
> >
> > Remove commented code?

Uncommenting it. The function contains protection against repeat-calls. Test 
code skips estimate, hence estimate is happening through this path.


- Rajat


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41039/#review110202
---


On Dec. 14, 2015, 3:48 p.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41039/
> ---
> 
> (Updated Dec. 14, 2015, 3:48 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-890
> https://issues.apache.org/jira/browse/LENS-890
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/util/CommonUtils.java 
> 38d58c710a2b917c34cda5de96a36dc49b6f15f0 
>   
> lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java
>  d56e1c7e68ecc741f776db7224877994bcc4489a 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 
> 253cfc4470ae25734d0cc6b05c8382cf69e74773 
>   
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java
>  11efd3c411a10b6506677986609e03f24160b9eb 
>   lens-driver-hive/src/test/resources/priority_tests.data 
> 98b82ef96068d2cc8d5fd07b4fe7538194cdbcac 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java
>  55f1535191cd0423c850a1309747f81d5490ca12 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java
>  c2208846ddd53adf414bd4bae6898e26ac425c56 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java
>  2f20113a1a30f902a1db4b25d5a78da0126a1b0c 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
>  b637665e79c46014a7ab8770e0da38d4a9768bd6 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraint.java
>  bae2e6490aafbfd55c9983c94d9cc892af384f7b 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraintFactory.java
>  b6e6c2f1bd2e4f3c0acdcdaae57dcd812e6bb435 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/TestAbstractQueryContext.java
>  a37a4c85cf918e62201d6a6dbf4e8b03fa565637 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraintTest.java
>  55a2eea110f9001c962faede01cef396e8c91b6c 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
>  ffd2d422fd126d7f8acd50014fc4ee9bb3bf5ede 
>   
> lens-server/src/test/java/org/apache/lens/server/query/constraint/ThreadSafeEstimatedQueryCollectionTest.java
>  9138f8ea2bb0b87bfcd2c9a4770bc732856fa680 
> 
> Diff: https://reviews.apache.org/r/41039/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>



Re: Review Request 41039: LENS-890: Allow per-queue driver max launched queries constraints

2015-12-14 Thread Rajat Khandelwal

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41039/
---

(Updated Dec. 14, 2015, 8:32 p.m.)


Review request for lens.


Bugs: LENS-890
https://issues.apache.org/jira/browse/LENS-890


Repository: lens


Description
---


Diffs (updated)
-

  lens-api/src/main/java/org/apache/lens/api/util/CommonUtils.java 
38d58c710a2b917c34cda5de96a36dc49b6f15f0 
  
lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java
 d56e1c7e68ecc741f776db7224877994bcc4489a 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 
253cfc4470ae25734d0cc6b05c8382cf69e74773 
  
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 
11efd3c411a10b6506677986609e03f24160b9eb 
  lens-driver-hive/src/test/resources/priority_tests.data 
98b82ef96068d2cc8d5fd07b4fe7538194cdbcac 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java
 55f1535191cd0423c850a1309747f81d5490ca12 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 
c2208846ddd53adf414bd4bae6898e26ac425c56 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java
 2f20113a1a30f902a1db4b25d5a78da0126a1b0c 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
 b637665e79c46014a7ab8770e0da38d4a9768bd6 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraint.java
 bae2e6490aafbfd55c9983c94d9cc892af384f7b 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraintFactory.java
 b6e6c2f1bd2e4f3c0acdcdaae57dcd812e6bb435 
  
lens-server-api/src/test/java/org/apache/lens/server/api/query/TestAbstractQueryContext.java
 a37a4c85cf918e62201d6a6dbf4e8b03fa565637 
  
lens-server-api/src/test/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraintTest.java
 55a2eea110f9001c962faede01cef396e8c91b6c 
  
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
 ffd2d422fd126d7f8acd50014fc4ee9bb3bf5ede 
  
lens-server/src/test/java/org/apache/lens/server/query/constraint/ThreadSafeEstimatedQueryCollectionTest.java
 9138f8ea2bb0b87bfcd2c9a4770bc732856fa680 

Diff: https://reviews.apache.org/r/41039/diff/


Testing
---


Thanks,

Rajat Khandelwal



Re: Review Request 39131: LENS -750 : Handle SemanticException from HiveDriver instead of throwing 500 Internal Server Error

2015-12-14 Thread Deepak Barr


> On Oct. 9, 2015, 12:27 p.m., Amareshwari Sriramadasu wrote:
> > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java, 
> > line 517
> > 
> >
> > Can you do the same changes for explain, estimate, executeAsync?
> > 
> > Shall we have handleHiveSQLException method throws proper LensException?

Hey amareshwari,

   Not sure if that would be necessary. explain and estimate methods call 
execute() method. Also, when running an async query, explain() is called first 
before executeAsync(). So the error will be captured when submitting the query 
itself. So, it should suffice to handle for execute() method. What do you think 
?


- Deepak


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39131/#review102050
---


On Oct. 8, 2015, 1:45 p.m., Deepak Barr wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39131/
> ---
> 
> (Updated Oct. 8, 2015, 1:45 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Added a Hive Error code for handling semantic exceptions
> 
> 
> Earlier, if someone queries a native table that does not exist -
> 
> 
> 
> d482699c-f3cd-49d7-a8a5-dd8437ec4ee3
> 
> 1001
> Internal Server Error.
> org.apache.lens.server.api.error.LensException: Error executing 
> query
> .
> .
> .
> 
> ---
> 
> After the fix- 
> 
> 
> 
> 81753012-99e8-4695-ac60-33ee1e9db289
> 
> 4001
> Semantic Error : Error while compiling statement: FAILED: 
> SemanticException [Error 10001]: Line 1:31 Table not found 
> 'test_data44'
> org.apache.lens.server.api.error.LensException: 
> SEMANTIC_ERROR[Error while compiling statement: FAILED: SemanticException 
> [Error 10001]: Line 1:31 Table not found 'test_data44']
> .
> .
> .
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/resources/lens-errors.conf a582dc2 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 
> 4561ccf 
>   
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/LensHiveErrorCode.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39131/diff/
> 
> 
> Testing
> ---
> 
> Yes.
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .. SUCCESS [  2.394 
> s]
> [INFO] Lens ... SUCCESS [  4.437 
> s]
> [INFO] Lens API ... SUCCESS [ 29.879 
> s]
> [INFO] Lens API for server and extensions . SUCCESS [ 26.698 
> s]
> [INFO] Lens Cube .. SUCCESS [07:06 
> min]
> [INFO] Lens DB storage  SUCCESS [ 26.526 
> s]
> [INFO] Lens Query Library . SUCCESS [ 21.488 
> s]
> [INFO] Lens Hive Driver ... SUCCESS [04:14 
> min]
> [INFO] Lens Driver for JDBC ... SUCCESS [ 54.033 
> s]
> [INFO] Lens Elastic Search Driver . SUCCESS [ 21.722 
> s]
> [INFO] Lens Server  SUCCESS [11:19 
> min]
> [INFO] Lens client  SUCCESS [ 46.726 
> s]
> [INFO] Lens CLI ... SUCCESS [03:45 
> min]
> [INFO] Lens Examples .. SUCCESS [ 11.543 
> s]
> [INFO] Lens Distribution .. SUCCESS [ 12.677 
> s]
> [INFO] Lens ML Lib  SUCCESS [02:05 
> min]
> [INFO] Lens ML Ext Distribution ... SUCCESS [  2.966 
> s]
> [INFO] Lens Regression  SUCCESS [ 16.229 
> s]
> [INFO] Lens UI  SUCCESS [ 42.657 
> s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 33:51 min
> [INFO] Finished at: 2015-10-06T23:01:26+05:30
> [INFO] Final Memory: 216M/3028M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Deepak Barr
> 
>



Re: Review Request 39131: LENS -750 : Handle SemanticException from HiveDriver instead of throwing 500 Internal Server Error

2015-12-14 Thread Deepak Barr

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39131/
---

(Updated Dec. 14, 2015, 3:07 p.m.)


Review request for lens.


Changes
---

Added test case + other refactoring


Repository: lens


Description
---

Added a Hive Error code for handling semantic exceptions


Earlier, if someone queries a native table that does not exist -



d482699c-f3cd-49d7-a8a5-dd8437ec4ee3

1001
Internal Server Error.
org.apache.lens.server.api.error.LensException: Error executing 
query
.
.
.

---

After the fix- 



81753012-99e8-4695-ac60-33ee1e9db289

4001
Semantic Error : Error while compiling statement: FAILED: 
SemanticException [Error 10001]: Line 1:31 Table not found 
'test_data44'
org.apache.lens.server.api.error.LensException: 
SEMANTIC_ERROR[Error while compiling statement: FAILED: SemanticException 
[Error 10001]: Line 1:31 Table not found 'test_data44']
.
.
.


Diffs (updated)
-

  lens-api/src/main/resources/lens-errors.conf c880543 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 
253cfc4 
  
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/LensHiveErrorCode.java
 PRE-CREATION 
  lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 
efef358 

Diff: https://reviews.apache.org/r/39131/diff/


Testing
---

Yes.

[INFO] 
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .. SUCCESS [  2.394 s]
[INFO] Lens ... SUCCESS [  4.437 s]
[INFO] Lens API ... SUCCESS [ 29.879 s]
[INFO] Lens API for server and extensions . SUCCESS [ 26.698 s]
[INFO] Lens Cube .. SUCCESS [07:06 min]
[INFO] Lens DB storage  SUCCESS [ 26.526 s]
[INFO] Lens Query Library . SUCCESS [ 21.488 s]
[INFO] Lens Hive Driver ... SUCCESS [04:14 min]
[INFO] Lens Driver for JDBC ... SUCCESS [ 54.033 s]
[INFO] Lens Elastic Search Driver . SUCCESS [ 21.722 s]
[INFO] Lens Server  SUCCESS [11:19 min]
[INFO] Lens client  SUCCESS [ 46.726 s]
[INFO] Lens CLI ... SUCCESS [03:45 min]
[INFO] Lens Examples .. SUCCESS [ 11.543 s]
[INFO] Lens Distribution .. SUCCESS [ 12.677 s]
[INFO] Lens ML Lib  SUCCESS [02:05 min]
[INFO] Lens ML Ext Distribution ... SUCCESS [  2.966 s]
[INFO] Lens Regression  SUCCESS [ 16.229 s]
[INFO] Lens UI  SUCCESS [ 42.657 s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 33:51 min
[INFO] Finished at: 2015-10-06T23:01:26+05:30
[INFO] Final Memory: 216M/3028M
[INFO] 


Thanks,

Deepak Barr



Re: Review Request 40863: LENS-552: Union support across storage tables in multi fact query

2015-12-14 Thread Rajat Khandelwal

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40863/
---

(Updated Dec. 14, 2015, 8:45 p.m.)


Review request for lens.


Bugs: LENS-552
https://issues.apache.org/jira/browse/LENS-552


Repository: lens


Description
---

includes LENS-851 changes, since I expect this to be merged after LENS-851


Diffs (updated)
-

  lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java 
b544a670a27f65b65a66affde55c7276438d4daa 
  lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java 
0656049dafc0b974104ff1c2f79a98fac934901d 
  lens-cube/src/main/java/org/apache/lens/cube/parse/AutoJoinContext.java 
94725063c0f9f64682bc0741c409bcefdf0be8ec 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 
2338ba70bbdeae90c7a0270f63f5d2c1255b5529 
  lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java 
b95595ade6120c0073c286e073715800b6cdd915 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 
f75a6b9b79ee9330de05c24d8f290b2cd27fcc4a 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 
e0759b0b8894ec1d0cca41fa6f897576f8090070 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DefaultQueryAST.java 
PRE-CREATION 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 
a576f3a6720e5e4454faf0188a43091191b0c787 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java 
bcfc1f6202da5c4377cf6710525c9655a08ce4cc 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 
0c43d9800d27b6c343af2b200ebeff9cf20fa816 
  lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 
776021d94cfb3c724970bc81a5d03c58459c7911 
  lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java 
6c442333fb42beafac1839907159d775b6f97dce 
  lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java 
da74713e5656a10144a6298a2a6fea266a11e156 
  lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 
7cea7d5a4491d1185cae845415d90d46cfd825c0 
  lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java 
1385584e033abe904279a8fd6dfa299f4e48665c 
  lens-cube/src/main/java/org/apache/lens/cube/parse/MultiFactHQLContext.java 
113d8deb8284443ae45151aa27852ab97570591e 
  lens-cube/src/main/java/org/apache/lens/cube/parse/QueryAST.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java 
de52b0a50b8cec580eb7807669d652a85b71e5f9 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java
 96b1d054a3c444960c69298d878784a819defd53 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactSingleStorageHQLContext.java
 PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 
62cc071237b84c46d69d78eea694eb9b8e9b2fd4 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 
3f01dbeb1e27248071ecd78c48daea8b77c87459 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 
a5886dc1420a38dee88b8798da3fa386bf713436 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
802ff42cf44e2a51ac984220d57d961f68dec442 

Diff: https://reviews.apache.org/r/40863/diff/


Testing
---

[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules . SUCCESS [2.211s]
[INFO] Lens .. SUCCESS [4.133s]
[INFO] Lens API .. SUCCESS [26.669s]
[INFO] Lens API for server and extensions  SUCCESS [24.038s]
[INFO] Lens Cube . SUCCESS [6:30.318s]
[INFO] Lens DB storage ... SUCCESS [19.100s]
[INFO] Lens Query Library  SUCCESS [14.772s]
[INFO] Lens Hive Driver .. SUCCESS [3:00.020s]
[INFO] Lens Driver for JDBC .. SUCCESS [40.555s]
[INFO] Lens Elastic Search Driver  SUCCESS [18.922s]
[INFO] Lens Server ... SUCCESS [10:23.992s]
[INFO] Lens client ... SUCCESS [40.087s]
[INFO] Lens CLI .. SUCCESS [54.969s]
[INFO] Lens Examples . SUCCESS [11.468s]
[INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [0.983s]
[INFO] Lens Distribution . SUCCESS [9.764s]
[INFO] Lens ML Lib ... SUCCESS [1:31.190s]
[INFO] Lens ML Ext Distribution .. SUCCESS [2.913s]
[INFO] Lens Regression 

[jira] [Updated] (LENS-896) base url is not set in lens jdbc client.

2015-12-14 Thread piyush (JIRA)

 [ 
https://issues.apache.org/jira/browse/LENS-896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

piyush updated LENS-896:

Summary: base url is not set in lens jdbc client.  (was: base url is not 
set by lens jdbc client.)

> base url is not set in lens jdbc client.
> 
>
> Key: LENS-896
> URL: https://issues.apache.org/jira/browse/LENS-896
> Project: Apache Lens
>  Issue Type: Bug
>  Components: client
>Reporter: piyush
>
> Inside  method "JDBCUtils.parseUrl". we are not setting base url. due to 
> which lens jdbc connection to server is failing. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (LENS-896) base url is not set by lens jdbc client.

2015-12-14 Thread piyush (JIRA)
piyush created LENS-896:
---

 Summary: base url is not set by lens jdbc client.
 Key: LENS-896
 URL: https://issues.apache.org/jira/browse/LENS-896
 Project: Apache Lens
  Issue Type: Bug
  Components: client
Reporter: piyush


Inside  method "JDBCUtils.parseUrl". we are not setting base url. due to which 
lens jdbc connection to server is failing. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Review Request 40761: Query Completion email missing for some queries

2015-12-14 Thread Puneet Gupta


> On Dec. 14, 2015, 1:44 p.m., Rajat Khandelwal wrote:
> > lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java,
> >  line 140
> > 
> >
> > Missing space here too.

Checkstyle runs as part of "mvn clean install -DskipTests". Should it not catch 
such instances by itself ?
http://checkstyle.sourceforge.net/config_whitespace.html#WhitespaceAround


- Puneet


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40761/#review110227
---


On Dec. 14, 2015, 11:50 a.m., Puneet Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40761/
> ---
> 
> (Updated Dec. 14, 2015, 11:50 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-887
> https://issues.apache.org/jira/browse/LENS-887
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Initial Changes (as discussed in JIRA) 
> + disabled core pool timeout for AsyncEventListeners (since pool had only 
> single thread)
> 
> 
> Diffs
> -
> 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/events/AsyncEventListener.java
>  547c008 
>   lens-server/src/main/java/org/apache/lens/server/EventServiceImpl.java 
> a276828 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java 
> 110624a 
>   lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java 
> f568b17 
>   
> lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java 
> 702a529 
> 
> Diff: https://reviews.apache.org/r/40761/diff/
> 
> 
> Testing
> ---
> 
> > Verified Build .
> > Verified new Thread Names while debugging.
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules . SUCCESS [2.085s]
> [INFO] Lens .. SUCCESS [2.889s]
> [INFO] Lens API .. SUCCESS [25.083s]
> [INFO] Lens API for server and extensions  SUCCESS [23.336s]
> [INFO] Lens Cube . SUCCESS [5:57.544s]
> [INFO] Lens DB storage ... SUCCESS [20.762s]
> [INFO] Lens Query Library  SUCCESS [15.393s]
> [INFO] Lens Hive Driver .. SUCCESS [2:50.461s]
> [INFO] Lens Driver for JDBC .. SUCCESS [35.760s]
> [INFO] Lens Elastic Search Driver  SUCCESS [17.248s]
> [INFO] Lens Server ... SUCCESS [9:50.223s]
> [INFO] Lens client ... SUCCESS [36.590s]
> [INFO] Lens CLI .. SUCCESS [51.185s]
> [INFO] Lens Examples . SUCCESS [9.779s]
> [INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [1.037s]
> [INFO] Lens Distribution . SUCCESS [8.573s]
> [INFO] Lens ML Lib ... SUCCESS [1:20.846s]
> [INFO] Lens ML Ext Distribution .. SUCCESS [2.013s]
> [INFO] Lens Regression ... SUCCESS [12.349s]
> [INFO] Lens UI ... SUCCESS [27.294s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 24:51.394s
> [INFO] Finished at: Sat Nov 28 04:07:51 UTC 2015
> [INFO] Final Memory: 199M/2040M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Puneet Gupta
> 
>



Re: Review Request 40761: Query Completion email missing for some queries

2015-12-14 Thread Puneet Gupta

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40761/
---

(Updated Dec. 15, 2015, 2:59 a.m.)


Review request for lens.


Changes
---

checkstyle - space added to try catch


Bugs: LENS-887
https://issues.apache.org/jira/browse/LENS-887


Repository: lens


Description
---

Initial Changes (as discussed in JIRA) 
+ disabled core pool timeout for AsyncEventListeners (since pool had only 
single thread)


Diffs (updated)
-

  
lens-server-api/src/main/java/org/apache/lens/server/api/events/AsyncEventListener.java
 547c008 
  lens-server/src/main/java/org/apache/lens/server/EventServiceImpl.java 
a276828 
  lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java 
110624a 
  lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java 
f568b17 
  lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java 
702a529 

Diff: https://reviews.apache.org/r/40761/diff/


Testing
---

> Verified Build .
> Verified new Thread Names while debugging.

[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules . SUCCESS [2.085s]
[INFO] Lens .. SUCCESS [2.889s]
[INFO] Lens API .. SUCCESS [25.083s]
[INFO] Lens API for server and extensions  SUCCESS [23.336s]
[INFO] Lens Cube . SUCCESS [5:57.544s]
[INFO] Lens DB storage ... SUCCESS [20.762s]
[INFO] Lens Query Library  SUCCESS [15.393s]
[INFO] Lens Hive Driver .. SUCCESS [2:50.461s]
[INFO] Lens Driver for JDBC .. SUCCESS [35.760s]
[INFO] Lens Elastic Search Driver  SUCCESS [17.248s]
[INFO] Lens Server ... SUCCESS [9:50.223s]
[INFO] Lens client ... SUCCESS [36.590s]
[INFO] Lens CLI .. SUCCESS [51.185s]
[INFO] Lens Examples . SUCCESS [9.779s]
[INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [1.037s]
[INFO] Lens Distribution . SUCCESS [8.573s]
[INFO] Lens ML Lib ... SUCCESS [1:20.846s]
[INFO] Lens ML Ext Distribution .. SUCCESS [2.013s]
[INFO] Lens Regression ... SUCCESS [12.349s]
[INFO] Lens UI ... SUCCESS [27.294s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 24:51.394s
[INFO] Finished at: Sat Nov 28 04:07:51 UTC 2015
[INFO] Final Memory: 199M/2040M
[INFO] 


Thanks,

Puneet Gupta



Re: Review Request 40761: Query Completion email missing for some queries

2015-12-14 Thread Rajat Khandelwal

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40761/#review110442
---

Ship it!


Ship It!

- Rajat Khandelwal


On Dec. 15, 2015, 8:29 a.m., Puneet Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40761/
> ---
> 
> (Updated Dec. 15, 2015, 8:29 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-887
> https://issues.apache.org/jira/browse/LENS-887
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Initial Changes (as discussed in JIRA) 
> + disabled core pool timeout for AsyncEventListeners (since pool had only 
> single thread)
> 
> 
> Diffs
> -
> 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/events/AsyncEventListener.java
>  547c008 
>   lens-server/src/main/java/org/apache/lens/server/EventServiceImpl.java 
> a276828 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java 
> 110624a 
>   lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java 
> f568b17 
>   
> lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java 
> 702a529 
> 
> Diff: https://reviews.apache.org/r/40761/diff/
> 
> 
> Testing
> ---
> 
> > Verified Build .
> > Verified new Thread Names while debugging.
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules . SUCCESS [2.085s]
> [INFO] Lens .. SUCCESS [2.889s]
> [INFO] Lens API .. SUCCESS [25.083s]
> [INFO] Lens API for server and extensions  SUCCESS [23.336s]
> [INFO] Lens Cube . SUCCESS [5:57.544s]
> [INFO] Lens DB storage ... SUCCESS [20.762s]
> [INFO] Lens Query Library  SUCCESS [15.393s]
> [INFO] Lens Hive Driver .. SUCCESS [2:50.461s]
> [INFO] Lens Driver for JDBC .. SUCCESS [35.760s]
> [INFO] Lens Elastic Search Driver  SUCCESS [17.248s]
> [INFO] Lens Server ... SUCCESS [9:50.223s]
> [INFO] Lens client ... SUCCESS [36.590s]
> [INFO] Lens CLI .. SUCCESS [51.185s]
> [INFO] Lens Examples . SUCCESS [9.779s]
> [INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [1.037s]
> [INFO] Lens Distribution . SUCCESS [8.573s]
> [INFO] Lens ML Lib ... SUCCESS [1:20.846s]
> [INFO] Lens ML Ext Distribution .. SUCCESS [2.013s]
> [INFO] Lens Regression ... SUCCESS [12.349s]
> [INFO] Lens UI ... SUCCESS [27.294s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 24:51.394s
> [INFO] Finished at: Sat Nov 28 04:07:51 UTC 2015
> [INFO] Final Memory: 199M/2040M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Puneet Gupta
> 
>