Re: Review Request 41671: LENS-735 : Remove accepting TableReferences for ReferenceDimAttribute

[Amareshwari Sriramadasu]

> On Jan. 7, 2016, 6:48 a.m., Rajat Khandelwal wrote:
> > lens-examples/src/main/resources/cube-queries.sql, line 70
> > 
> >
> > `left outer join` now always requires explicit specification of the 
> > join path?

Yes. Partial join resolution is remvoed. Either user should give full join 
himself or use chains defined and user can pass join type configuration if left 
outer join is required.


- Amareshwari


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41671/#review113203
---


On Jan. 7, 2016, 6:11 a.m., Amareshwari Sriramadasu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41671/
> ---
> 
> (Updated Jan. 7, 2016, 6:11 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-735
> https://issues.apache.org/jira/browse/LENS-735
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Changes include the following :
> 
> - Remove the option to specify TableReferences for reference in xsd. Now we 
> accept only chain ref columns
> - Updated the same in all corresponding classes
> - Removed unnecessary code from JoinResolver. Also did some refactoring for 
> join related classes
> - Updated existing tests to use chain ref columns
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/resources/cube-0.1.xsd 4092133 
>   lens-api/src/main/resources/lens-errors.conf c7ccea1 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java 
> 42c6bae 
>   lens-cli/src/test/resources/cube_with_no_weight_facts.xml 263ca88 
>   lens-cli/src/test/resources/sample-cube.xml d72d279 
>   lens-cli/src/test/resources/test-dimension.xml 6eb3d31 
>   lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 
> 68cd80b 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractBaseTable.java 
> 88c9ee8 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java 
> da3a7e5 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/Cube.java f09da37 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeColumn.java 
> b04532f 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeDimensionTable.java 
> cd80d64 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 
> dd0adb7 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java
>  e7550ca 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/DerivedCube.java 
> 681aa7b 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/Dimension.java 
> 27cbc30 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/JoinChain.java 
> 6250905 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/ReferencedDimAtrribute.java
>  c51b489 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/ReferencedDimAttribute.java
>  PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java 
> fa230ef 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/join/JoinPath.java 
> PRE-CREATION 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/join/TableRelationship.java
>  PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AutoJoinContext.java 
> 7f13c6c 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateDim.java 
> 64dff16 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 
> 1fd1d17 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java
>  5c8bd84 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java 
> b253b94 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java 
> ab7a6d8 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 6c3d4c3 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/JoinClause.java d9a8249 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java 
> de3a16e 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/JoinTree.java 5a294af 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageUtil.java 67b3f40 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 
> 1a83d09 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/join/AutoJoinContext.java 
> PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/join/JoinClause.java 
> PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/join/JoinTree.java 
> PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/join/JoinUtils.java 
> PRE-CREATION 
>   
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java
>  0fef13f 
>   lens-cube/src/test/java/

Re: Review Request 41671: LENS-735 : Remove accepting TableReferences for ReferenceDimAttribute

[Amareshwari Sriramadasu]

> On Jan. 7, 2016, 6:43 a.m., Rajat Khandelwal wrote:
> > lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java,
> >  line 328
> > 
> >
> > Why has the error code changed? Does he new code make more sense than 
> > the old one?

Change looks fine. Validated the test once again.


- Amareshwari


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41671/#review113199
---


On Jan. 7, 2016, 6:11 a.m., Amareshwari Sriramadasu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41671/
> ---
> 
> (Updated Jan. 7, 2016, 6:11 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-735
> https://issues.apache.org/jira/browse/LENS-735
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Changes include the following :
> 
> - Remove the option to specify TableReferences for reference in xsd. Now we 
> accept only chain ref columns
> - Updated the same in all corresponding classes
> - Removed unnecessary code from JoinResolver. Also did some refactoring for 
> join related classes
> - Updated existing tests to use chain ref columns
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/resources/cube-0.1.xsd 4092133 
>   lens-api/src/main/resources/lens-errors.conf c7ccea1 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java 
> 42c6bae 
>   lens-cli/src/test/resources/cube_with_no_weight_facts.xml 263ca88 
>   lens-cli/src/test/resources/sample-cube.xml d72d279 
>   lens-cli/src/test/resources/test-dimension.xml 6eb3d31 
>   lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 
> 68cd80b 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractBaseTable.java 
> 88c9ee8 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java 
> da3a7e5 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/Cube.java f09da37 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeColumn.java 
> b04532f 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeDimensionTable.java 
> cd80d64 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 
> dd0adb7 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java
>  e7550ca 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/DerivedCube.java 
> 681aa7b 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/Dimension.java 
> 27cbc30 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/JoinChain.java 
> 6250905 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/ReferencedDimAtrribute.java
>  c51b489 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/ReferencedDimAttribute.java
>  PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java 
> fa230ef 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/join/JoinPath.java 
> PRE-CREATION 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/join/TableRelationship.java
>  PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AutoJoinContext.java 
> 7f13c6c 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateDim.java 
> 64dff16 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 
> 1fd1d17 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java
>  5c8bd84 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java 
> b253b94 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java 
> ab7a6d8 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 6c3d4c3 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/JoinClause.java d9a8249 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java 
> de3a16e 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/JoinTree.java 5a294af 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageUtil.java 67b3f40 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 
> 1a83d09 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/join/AutoJoinContext.java 
> PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/join/JoinClause.java 
> PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/join/JoinTree.java 
> PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/join/JoinUtils.java 
> PRE-CREATION 
>   
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java
>  0fef13f 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 
> ad20ae1 
>   
> lens-cube/src/test/java/

[jira] [Work started] (LENS-912) Make `cube` keyword optional in queries

[Rajat Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on LENS-912 started by Rajat Khandelwal.
-
> Make `cube` keyword optional in queries
> ---
>
> Key: LENS-912
> URL: https://issues.apache.org/jira/browse/LENS-912
> Project: Apache Lens
>  Issue Type: Improvement
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Reopened] (LENS-719) Allow fact start time to be specified for a storage and a update period

[Sushil Mohanty (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sushil Mohanty reopened LENS-719:
-

Storage start time not honored when query from date is less than this.
[~prongs] Can you please check. 

> Allow fact start time to be specified for a storage and a update period
> ---
>
> Key: LENS-719
> URL: https://issues.apache.org/jira/browse/LENS-719
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: cube
>Reporter: Amareshwari Sriramadasu
>Assignee: Rajat Khandelwal
> Fix For: 2.5
>
> Attachments: LENS-719.05.patch
>
>
> We can specify absolute and relative start time for a fact. This improvement 
> request is to add the ability to override the start time of a fact on a 
> storage and a update period.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Review Request 42023: LENS-719: Allow fact start time to be specified for a storage and a update period

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42023/
---

Review request for lens.


Bugs: LENS-719
https://issues.apache.org/jira/browse/LENS-719


Repository: lens


Description
---

We can specify absolute and relative start time for a fact. This improvement 
request is to add the ability to override the start time of a fact on a storage 
and a update period.


Diffs
-

  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 
14def15ec842d1d2cf8d3079ecc457a147cd41af 

Diff: https://reviews.apache.org/r/42023/diff/


Testing
---


Thanks,

Rajat Khandelwal

[jira] [Commented] (LENS-719) Allow fact start time to be specified for a storage and a update period

[Rajat Khandelwal (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15087151#comment-15087151
 ] 

Rajat Khandelwal commented on LENS-719:
---

Created https://reviews.apache.org/r/42023/

> Allow fact start time to be specified for a storage and a update period
> ---
>
> Key: LENS-719
> URL: https://issues.apache.org/jira/browse/LENS-719
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: cube
>Reporter: Amareshwari Sriramadasu
>Assignee: Rajat Khandelwal
> Fix For: 2.5
>
> Attachments: LENS-719.05.patch
>
>
> We can specify absolute and relative start time for a fact. This improvement 
> request is to add the ability to override the start time of a fact on a 
> storage and a update period.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 41671: LENS-735 : Remove accepting TableReferences for ReferenceDimAttribute

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41671/#review113225
---



lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java 
(lines 115 - 144)


Should we add nonnull annotation here?


- Rajat Khandelwal


On Jan. 7, 2016, 3:25 p.m., Amareshwari Sriramadasu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41671/
> ---
> 
> (Updated Jan. 7, 2016, 3:25 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-735
> https://issues.apache.org/jira/browse/LENS-735
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Changes include the following :
> 
> - Remove the option to specify TableReferences for reference in xsd. Now we 
> accept only chain ref columns
> - Updated the same in all corresponding classes
> - Removed unnecessary code from JoinResolver. Also did some refactoring for 
> join related classes
> - Updated existing tests to use chain ref columns
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/resources/cube-0.1.xsd 4092133 
>   lens-api/src/main/resources/lens-errors.conf c7ccea1 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java 
> 42c6bae 
>   lens-cli/src/test/resources/cube_with_no_weight_facts.xml 263ca88 
>   lens-cli/src/test/resources/sample-cube.xml d72d279 
>   lens-cli/src/test/resources/test-dimension.xml 6eb3d31 
>   lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 
> 68cd80b 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractBaseTable.java 
> 88c9ee8 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java 
> da3a7e5 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/Cube.java f09da37 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeColumn.java 
> b04532f 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeDimensionTable.java 
> cd80d64 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 
> dd0adb7 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java
>  e7550ca 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/DerivedCube.java 
> 681aa7b 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/Dimension.java 
> 27cbc30 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/JoinChain.java 
> 6250905 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/ReferencedDimAtrribute.java
>  c51b489 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/ReferencedDimAttribute.java
>  PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java 
> fa230ef 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/join/JoinPath.java 
> PRE-CREATION 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/join/TableRelationship.java
>  PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AutoJoinContext.java 
> 7f13c6c 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateDim.java 
> 64dff16 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 
> 1fd1d17 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java
>  5c8bd84 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java 
> b253b94 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java 
> ab7a6d8 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 6c3d4c3 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/JoinClause.java d9a8249 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java 
> de3a16e 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/JoinTree.java 5a294af 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageUtil.java 67b3f40 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 
> 1a83d09 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/join/AutoJoinContext.java 
> PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/join/JoinClause.java 
> PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/join/JoinTree.java 
> PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/join/JoinUtils.java 
> PRE-CREATION 
>   
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java
>  0fef13f 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 
> ad20ae1 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/FieldsCannotBeQueriedTogetherTest.java
>  ff7c15f 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 
> 5b44f95 
>   lens-cube/src/t

Review Request 42024: LENS-851: queries where results of two storage tables of same fact are unioned, the rows should be aggregated

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42024/
---

Review request for lens.


Bugs: LENS-851
https://issues.apache.org/jira/browse/LENS-851


Repository: lens


Description
---


Diffs
-

  lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 
6c3d4c3b0235f88c16aad148cbbbc30eca89eb7f 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java
 e531e6b0bcfb6c0d565cd0cfeb4e9b4b45b4534e 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
f02cdb05cb9e3707b59eb62fd068c31be9e4c69f 

Diff: https://reviews.apache.org/r/42024/diff/


Testing
---


Thanks,

Rajat Khandelwal

[jira] [Commented] (LENS-851) queries where results of two storage tables of same fact are unioned, the rows should be aggregated

[Rajat Khandelwal (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15087250#comment-15087250
 ] 

Rajat Khandelwal commented on LENS-851:
---

Created https://reviews.apache.org/r/42024/

> queries where results of two storage tables of same fact are unioned, the 
> rows should be aggregated
> ---
>
> Key: LENS-851
> URL: https://issues.apache.org/jira/browse/LENS-851
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Fix For: 2.5
>
> Attachments: LENS-851.01.patch, LENS-851.02.patch, LENS-851.03.patch, 
> LENS-851.08.patch, LENS-851.08.patch, LENS-851.local.1.patch, 
> LENS-851.local.patch, rb40475.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work started] (LENS-851) queries where results of two storage tables of same fact are unioned, the rows should be aggregated

[Rajat Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on LENS-851 started by Rajat Khandelwal.
-
> queries where results of two storage tables of same fact are unioned, the 
> rows should be aggregated
> ---
>
> Key: LENS-851
> URL: https://issues.apache.org/jira/browse/LENS-851
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Fix For: 2.5
>
> Attachments: LENS-851.01.patch, LENS-851.02.patch, LENS-851.03.patch, 
> LENS-851.08.patch, LENS-851.08.patch, LENS-851.local.1.patch, 
> LENS-851.local.patch, rb40475.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-851) queries where results of two storage tables of same fact are unioned, the rows should be aggregated

[Rajat Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-851:
--
Attachment: LENS-851.01.patch

> queries where results of two storage tables of same fact are unioned, the 
> rows should be aggregated
> ---
>
> Key: LENS-851
> URL: https://issues.apache.org/jira/browse/LENS-851
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Fix For: 2.5
>
> Attachments: LENS-851.01.patch, LENS-851.01.patch, LENS-851.02.patch, 
> LENS-851.03.patch, LENS-851.08.patch, LENS-851.08.patch, 
> LENS-851.local.1.patch, LENS-851.local.patch, rb40475.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 42023: LENS-719: Allow fact start time to be specified for a storage and a update period

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42023/
---

(Updated Jan. 7, 2016, 6:39 p.m.)


Review request for lens.


Bugs: LENS-719
https://issues.apache.org/jira/browse/LENS-719


Repository: lens


Description
---

We can specify absolute and relative start time for a fact. This improvement 
request is to add the ability to override the start time of a fact on a storage 
and a update period.


Diffs (updated)
-

  
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 
e7550ca2c8307cba086e848e8b476a670366f7a5 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 
14def15ec842d1d2cf8d3079ecc457a147cd41af 
  
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java
 0fef13f30662755c7f3da953c411e6715539ac7e 

Diff: https://reviews.apache.org/r/42023/diff/


Testing
---


Thanks,

Rajat Khandelwal

[jira] [Commented] (LENS-851) queries where results of two storage tables of same fact are unioned, the rows should be aggregated

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15087336#comment-15087336
 ] 

Hadoop QA commented on LENS-851:


Applied patch: 
[LENS-851.01.patch|https://issues.apache.org/jira/secure/attachment/12780959/LENS-851.01.patch]
 and ran command: mvn clean install -fae. Result: Success. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/238/

> queries where results of two storage tables of same fact are unioned, the 
> rows should be aggregated
> ---
>
> Key: LENS-851
> URL: https://issues.apache.org/jira/browse/LENS-851
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Fix For: 2.5
>
> Attachments: LENS-851.01.patch, LENS-851.01.patch, LENS-851.02.patch, 
> LENS-851.03.patch, LENS-851.08.patch, LENS-851.08.patch, 
> LENS-851.local.1.patch, LENS-851.local.patch, rb40475.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-124) Add scheduler service on lens

[Amareshwari Sriramadasu (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15088685#comment-15088685
 ] 

Amareshwari Sriramadasu commented on LENS-124:
--

[~ajayyadava], Hope you will be able to contribute the follow up patches. Any 
update?

> Add scheduler service on lens
> -
>
> Key: LENS-124
> URL: https://issues.apache.org/jira/browse/LENS-124
> Project: Apache Lens
>  Issue Type: New Feature
>  Components: server
>Reporter: Amareshwari Sriramadasu
>Assignee: Ajay Yadava
>  Labels: Hackathon-July
> Attachments: Lens Scheduler API.pdf
>
>
> Query scheduler service should provide following services
>  * Schedule a query
>  ** Periodically
>  ** On data availability, for ex: whenever a day's data is available
>  * Look at status of scheduled query
>  ** Mostly the current run status
>  * Look at the output of scheduled query - through email?
>  * Update scheduled query
>  ** Update the query
>  ** Update the frequency
>  ** Update the configuration
>   * Look at stats of scheduled query
>   **  number of failures
>   **  number of reruns
>   **  Get handles for completed queries
>  * Cancel a scheduled query
>  * Pause and resume a scheduled query
>  *  Look at all scheduled queries



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: 2.5 release planning

[amareshwarisr .]

Deepak,

Can you put up a plan for 2.5 release and share?

Thanks

On Sat, Dec 12, 2015 at 12:25 AM, Deepak Kumar Barr (Tech_BLR) <
deepak.b...@flipkart.com> wrote:

> Sure.
>
> Regards,
> Deepak Kumar Barr
> Bigfoot-Apps
>
> On Fri, Dec 11, 2015 at 12:17 PM, amareshwarisr . 
> wrote:
>
> > Great!
> > Deepak, to get started follow the doc at
> >
> >
> https://cwiki.apache.org/confluence/display/LENS/How+to+release+Apapche+Lens
> >
> > Thanks
> >
> > On Fri, Dec 11, 2015 at 12:06 PM, Deepak Kumar Barr (Tech_BLR) <
> > deepak.b...@flipkart.com> wrote:
> >
> > > I will volunteer.
> > >
> > > Regards,
> > > Deepak Kumar Barr
> > > Bigfoot-Apps
> > >
> > > On Fri, Dec 11, 2015 at 9:46 AM, amareshwarisr . <
> amareshw...@gmail.com>
> > > wrote:
> > >
> > > > Any volunteers please?
> > > >
> > > > On Thu, Dec 10, 2015 at 11:57 AM, amareshwarisr . <
> > amareshw...@gmail.com
> > > >
> > > > wrote:
> > > >
> > > > > Hi all,
> > > > >
> > > > > We should plan for 2.5 release, as 2.4 was frozen two months back.
> We
> > > > have
> > > > > interesting features coming up in 2.5 :
> > > > >
> > > > > - Multiple driver support
> > > > > - Scheduler framework
> > > > > - Query submission throttling stabilized and more constraints
> getting
> > > > added
> > > > > - Error codes and responses getting fixed.
> > > > >
> > > > > Volunteers are welcome for release manager for 2.5, anyone please?
> > > > >
> > > > > Thanks
> > > > > Amareshwari
> > > > >
> > > >
> > >
> >
>

Re: Review Request 42023: LENS-719: Allow fact start time to be specified for a storage and a update period

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42023/#review113407
---

Ship it!


Ship It!

- Amareshwari Sriramadasu


On Jan. 7, 2016, 1:09 p.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42023/
> ---
> 
> (Updated Jan. 7, 2016, 1:09 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-719
> https://issues.apache.org/jira/browse/LENS-719
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> We can specify absolute and relative start time for a fact. This improvement 
> request is to add the ability to override the start time of a fact on a 
> storage and a update period.
> 
> 
> Diffs
> -
> 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java
>  e7550ca2c8307cba086e848e8b476a670366f7a5 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 
> 14def15ec842d1d2cf8d3079ecc457a147cd41af 
>   
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java
>  0fef13f30662755c7f3da953c411e6715539ac7e 
> 
> Diff: https://reviews.apache.org/r/42023/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

[jira] [Commented] (LENS-124) Add scheduler service on lens

[Ajay Yadava (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15088709#comment-15088709
 ] 

Ajay Yadava commented on LENS-124:
--

[~amareshwari] Yes I am committed to see this feature through. Apologies for 
the delay, I was a bit occupied with falcon's next release so couldn't get back 
to it. I will start again on it this weekend.

> Add scheduler service on lens
> -
>
> Key: LENS-124
> URL: https://issues.apache.org/jira/browse/LENS-124
> Project: Apache Lens
>  Issue Type: New Feature
>  Components: server
>Reporter: Amareshwari Sriramadasu
>Assignee: Ajay Yadava
>  Labels: Hackathon-July
> Attachments: Lens Scheduler API.pdf
>
>
> Query scheduler service should provide following services
>  * Schedule a query
>  ** Periodically
>  ** On data availability, for ex: whenever a day's data is available
>  * Look at status of scheduled query
>  ** Mostly the current run status
>  * Look at the output of scheduled query - through email?
>  * Update scheduled query
>  ** Update the query
>  ** Update the frequency
>  ** Update the configuration
>   * Look at stats of scheduled query
>   **  number of failures
>   **  number of reruns
>   **  Get handles for completed queries
>  * Cancel a scheduled query
>  * Pause and resume a scheduled query
>  *  Look at all scheduled queries



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-719) Allow fact start time to be specified for a storage and a update period

[Rajat Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-719:
--
Status: Patch Available  (was: In Progress)

> Allow fact start time to be specified for a storage and a update period
> ---
>
> Key: LENS-719
> URL: https://issues.apache.org/jira/browse/LENS-719
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: cube
>Reporter: Amareshwari Sriramadasu
>Assignee: Rajat Khandelwal
> Fix For: 2.5
>
> Attachments: LENS-719.02.patch, LENS-719.05.patch
>
>
> We can specify absolute and relative start time for a fact. This improvement 
> request is to add the ability to override the start time of a fact on a 
> storage and a update period.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-719) Allow fact start time to be specified for a storage and a update period

[Rajat Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-719:
--
Attachment: LENS-719.02.patch

> Allow fact start time to be specified for a storage and a update period
> ---
>
> Key: LENS-719
> URL: https://issues.apache.org/jira/browse/LENS-719
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: cube
>Reporter: Amareshwari Sriramadasu
>Assignee: Rajat Khandelwal
> Fix For: 2.5
>
> Attachments: LENS-719.02.patch, LENS-719.05.patch
>
>
> We can specify absolute and relative start time for a fact. This improvement 
> request is to add the ability to override the start time of a fact on a 
> storage and a update period.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-719) Allow fact start time to be specified for a storage and a update period

[Rajat Khandelwal (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15088758#comment-15088758
 ] 

Rajat Khandelwal commented on LENS-719:
---

Taking patch from reviewboard and attaching

> Allow fact start time to be specified for a storage and a update period
> ---
>
> Key: LENS-719
> URL: https://issues.apache.org/jira/browse/LENS-719
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: cube
>Reporter: Amareshwari Sriramadasu
>Assignee: Rajat Khandelwal
> Fix For: 2.5
>
> Attachments: LENS-719.02.patch, LENS-719.05.patch
>
>
> We can specify absolute and relative start time for a fact. This improvement 
> request is to add the ability to override the start time of a fact on a 
> storage and a update period.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Review Request 42062: LENS-913: Seeing DateUtil exception in all cube tests

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42062/
---

Review request for lens.


Bugs: LENS-913
https://issues.apache.org/jira/browse/LENS-913


Repository: lens


Description
---

Seeing following exception when any cube.parse test is run, all the logs are 
filled with this.

{noformat}
05 Jan 2016 10:52:40 [main] ERROR org.apache.lens.cube.metadata.DateUtil 164 - 
Invalid date format. expected only -MM-dd-HH:mm:ss,SSS date provided:null
java.lang.NullPointerException: null
at 
com.google.common.base.Preconditions.checkNotNull(Preconditions.java:187) 
~[hive-exec-0.13.3-inm.jar:0.13.3-inm]
at com.google.common.cache.LocalCache.get(LocalCache.java:3964) 
~[hive-exec-0.13.3-inm.jar:0.13.3-inm]
at 
com.google.common.cache.LocalCache$LocalManualCache.get(LocalCache.java:4764) 
~[hive-exec-0.13.3-inm.jar:0.13.3-inm]
at 
org.apache.lens.cube.metadata.DateUtil.resolveAbsoluteDate(DateUtil.java:157) 
~[classes/:na]
at 
org.apache.lens.cube.metadata.CubeFactTable.getAbsoluteStartTime(CubeFactTable.java:327)
 [classes/:na]
at 
org.apache.lens.cube.metadata.CubeFactTable.getStartTime(CubeFactTable.java:342)
 [classes/:na]
at 
org.apache.lens.cube.parse.CandidateFact.isValidForTimeRange(CandidateFact.java:103)
 [classes/:na]
at 
org.apache.lens.cube.parse.TimerangeResolver.doFactRangeValidation(TimerangeResolver.java:249)
 [classes/:na]
at 
org.apache.lens.cube.parse.TimerangeResolver.rewriteContext(TimerangeResolver.java:59)
 [classes/:na]
at 
org.apache.lens.cube.parse.CubeQueryRewriter.rewrite(CubeQueryRewriter.java:229)
 [classes/:na]
at 
org.apache.lens.cube.parse.CubeQueryRewriter.rewrite(CubeQueryRewriter.java:199)
 [classes/:na]
at 
org.apache.lens.cube.parse.CubeQueryRewriter.rewrite(CubeQueryRewriter.java:215)
 [classes/:na]
at 
org.apache.lens.cube.parse.TestQueryRewrite.rewriteCtx(TestQueryRewrite.java:92)
 [test-classes/:na]
at 
org.apache.lens.cube.parse.TestQueryRewrite.rewrite(TestQueryRewrite.java:83) 
[test-classes/:na]
{noformat}


Diffs
-

  lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 
dd0adb7c669fa7f286676ee4d7133109e25c942b 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/DateUtil.java 
b76c567d44727c68f6009a7336df234a251b8bc3 
  lens-cube/src/test/java/org/apache/lens/cube/metadata/CubeFactTableTest.java 
25eaaef67404a9d1a43daf915c61d127ede36012 

Diff: https://reviews.apache.org/r/42062/diff/


Testing
---


Thanks,

Rajat Khandelwal

[jira] [Commented] (LENS-913) Seeing DateUtil exception in all cube tests

[Rajat Khandelwal (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15088781#comment-15088781
 ] 

Rajat Khandelwal commented on LENS-913:
---

Created https://reviews.apache.org/r/42062/

> Seeing DateUtil exception in all cube tests
> ---
>
> Key: LENS-913
> URL: https://issues.apache.org/jira/browse/LENS-913
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Affects Versions: 2.5
>Reporter: Amareshwari Sriramadasu
>Assignee: Rajat Khandelwal
>Priority: Minor
> Fix For: 2.5
>
>
> Seeing following exception when any cube.parse test is run, all the logs are 
> filled with this.
> {noformat}
> 05 Jan 2016 10:52:40 [main] ERROR org.apache.lens.cube.metadata.DateUtil 164 
> - Invalid date format. expected only -MM-dd-HH:mm:ss,SSS date 
> provided:null
> java.lang.NullPointerException: null
> at 
> com.google.common.base.Preconditions.checkNotNull(Preconditions.java:187) 
> ~[hive-exec-0.13.3-inm.jar:0.13.3-inm]
> at com.google.common.cache.LocalCache.get(LocalCache.java:3964) 
> ~[hive-exec-0.13.3-inm.jar:0.13.3-inm]
> at 
> com.google.common.cache.LocalCache$LocalManualCache.get(LocalCache.java:4764) 
> ~[hive-exec-0.13.3-inm.jar:0.13.3-inm]
> at 
> org.apache.lens.cube.metadata.DateUtil.resolveAbsoluteDate(DateUtil.java:157) 
> ~[classes/:na]
> at 
> org.apache.lens.cube.metadata.CubeFactTable.getAbsoluteStartTime(CubeFactTable.java:327)
>  [classes/:na]
> at 
> org.apache.lens.cube.metadata.CubeFactTable.getStartTime(CubeFactTable.java:342)
>  [classes/:na]
> at 
> org.apache.lens.cube.parse.CandidateFact.isValidForTimeRange(CandidateFact.java:103)
>  [classes/:na]
> at 
> org.apache.lens.cube.parse.TimerangeResolver.doFactRangeValidation(TimerangeResolver.java:249)
>  [classes/:na]
> at 
> org.apache.lens.cube.parse.TimerangeResolver.rewriteContext(TimerangeResolver.java:59)
>  [classes/:na]
> at 
> org.apache.lens.cube.parse.CubeQueryRewriter.rewrite(CubeQueryRewriter.java:229)
>  [classes/:na]
> at 
> org.apache.lens.cube.parse.CubeQueryRewriter.rewrite(CubeQueryRewriter.java:199)
>  [classes/:na]
> at 
> org.apache.lens.cube.parse.CubeQueryRewriter.rewrite(CubeQueryRewriter.java:215)
>  [classes/:na]
> at 
> org.apache.lens.cube.parse.TestQueryRewrite.rewriteCtx(TestQueryRewrite.java:92)
>  [test-classes/:na]
> at 
> org.apache.lens.cube.parse.TestQueryRewrite.rewrite(TestQueryRewrite.java:83) 
> [test-classes/:na]
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work started] (LENS-913) Seeing DateUtil exception in all cube tests

[Rajat Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on LENS-913 started by Rajat Khandelwal.
-
> Seeing DateUtil exception in all cube tests
> ---
>
> Key: LENS-913
> URL: https://issues.apache.org/jira/browse/LENS-913
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Affects Versions: 2.5
>Reporter: Amareshwari Sriramadasu
>Assignee: Rajat Khandelwal
>Priority: Minor
> Fix For: 2.5
>
>
> Seeing following exception when any cube.parse test is run, all the logs are 
> filled with this.
> {noformat}
> 05 Jan 2016 10:52:40 [main] ERROR org.apache.lens.cube.metadata.DateUtil 164 
> - Invalid date format. expected only -MM-dd-HH:mm:ss,SSS date 
> provided:null
> java.lang.NullPointerException: null
> at 
> com.google.common.base.Preconditions.checkNotNull(Preconditions.java:187) 
> ~[hive-exec-0.13.3-inm.jar:0.13.3-inm]
> at com.google.common.cache.LocalCache.get(LocalCache.java:3964) 
> ~[hive-exec-0.13.3-inm.jar:0.13.3-inm]
> at 
> com.google.common.cache.LocalCache$LocalManualCache.get(LocalCache.java:4764) 
> ~[hive-exec-0.13.3-inm.jar:0.13.3-inm]
> at 
> org.apache.lens.cube.metadata.DateUtil.resolveAbsoluteDate(DateUtil.java:157) 
> ~[classes/:na]
> at 
> org.apache.lens.cube.metadata.CubeFactTable.getAbsoluteStartTime(CubeFactTable.java:327)
>  [classes/:na]
> at 
> org.apache.lens.cube.metadata.CubeFactTable.getStartTime(CubeFactTable.java:342)
>  [classes/:na]
> at 
> org.apache.lens.cube.parse.CandidateFact.isValidForTimeRange(CandidateFact.java:103)
>  [classes/:na]
> at 
> org.apache.lens.cube.parse.TimerangeResolver.doFactRangeValidation(TimerangeResolver.java:249)
>  [classes/:na]
> at 
> org.apache.lens.cube.parse.TimerangeResolver.rewriteContext(TimerangeResolver.java:59)
>  [classes/:na]
> at 
> org.apache.lens.cube.parse.CubeQueryRewriter.rewrite(CubeQueryRewriter.java:229)
>  [classes/:na]
> at 
> org.apache.lens.cube.parse.CubeQueryRewriter.rewrite(CubeQueryRewriter.java:199)
>  [classes/:na]
> at 
> org.apache.lens.cube.parse.CubeQueryRewriter.rewrite(CubeQueryRewriter.java:215)
>  [classes/:na]
> at 
> org.apache.lens.cube.parse.TestQueryRewrite.rewriteCtx(TestQueryRewrite.java:92)
>  [test-classes/:na]
> at 
> org.apache.lens.cube.parse.TestQueryRewrite.rewrite(TestQueryRewrite.java:83) 
> [test-classes/:na]
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 42062: LENS-913: Seeing DateUtil exception in all cube tests

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42062/#review113425
---

Ship it!


Ship It!

- Amareshwari Sriramadasu


On Jan. 8, 2016, 6:31 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42062/
> ---
> 
> (Updated Jan. 8, 2016, 6:31 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-913
> https://issues.apache.org/jira/browse/LENS-913
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Seeing following exception when any cube.parse test is run, all the logs are 
> filled with this.
> 
> {noformat}
> 05 Jan 2016 10:52:40 [main] ERROR org.apache.lens.cube.metadata.DateUtil 164 
> - Invalid date format. expected only -MM-dd-HH:mm:ss,SSS date 
> provided:null
> java.lang.NullPointerException: null
> at 
> com.google.common.base.Preconditions.checkNotNull(Preconditions.java:187) 
> ~[hive-exec-0.13.3-inm.jar:0.13.3-inm]
> at com.google.common.cache.LocalCache.get(LocalCache.java:3964) 
> ~[hive-exec-0.13.3-inm.jar:0.13.3-inm]
> at 
> com.google.common.cache.LocalCache$LocalManualCache.get(LocalCache.java:4764) 
> ~[hive-exec-0.13.3-inm.jar:0.13.3-inm]
> at 
> org.apache.lens.cube.metadata.DateUtil.resolveAbsoluteDate(DateUtil.java:157) 
> ~[classes/:na]
> at 
> org.apache.lens.cube.metadata.CubeFactTable.getAbsoluteStartTime(CubeFactTable.java:327)
>  [classes/:na]
> at 
> org.apache.lens.cube.metadata.CubeFactTable.getStartTime(CubeFactTable.java:342)
>  [classes/:na]
> at 
> org.apache.lens.cube.parse.CandidateFact.isValidForTimeRange(CandidateFact.java:103)
>  [classes/:na]
> at 
> org.apache.lens.cube.parse.TimerangeResolver.doFactRangeValidation(TimerangeResolver.java:249)
>  [classes/:na]
> at 
> org.apache.lens.cube.parse.TimerangeResolver.rewriteContext(TimerangeResolver.java:59)
>  [classes/:na]
> at 
> org.apache.lens.cube.parse.CubeQueryRewriter.rewrite(CubeQueryRewriter.java:229)
>  [classes/:na]
> at 
> org.apache.lens.cube.parse.CubeQueryRewriter.rewrite(CubeQueryRewriter.java:199)
>  [classes/:na]
> at 
> org.apache.lens.cube.parse.CubeQueryRewriter.rewrite(CubeQueryRewriter.java:215)
>  [classes/:na]
> at 
> org.apache.lens.cube.parse.TestQueryRewrite.rewriteCtx(TestQueryRewrite.java:92)
>  [test-classes/:na]
> at 
> org.apache.lens.cube.parse.TestQueryRewrite.rewrite(TestQueryRewrite.java:83) 
> [test-classes/:na]
> {noformat}
> 
> 
> Diffs
> -
> 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 
> dd0adb7c669fa7f286676ee4d7133109e25c942b 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/DateUtil.java 
> b76c567d44727c68f6009a7336df234a251b8bc3 
>   
> lens-cube/src/test/java/org/apache/lens/cube/metadata/CubeFactTableTest.java 
> 25eaaef67404a9d1a43daf915c61d127ede36012 
> 
> Diff: https://reviews.apache.org/r/42062/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

[jira] [Commented] (LENS-719) Allow fact start time to be specified for a storage and a update period

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15088803#comment-15088803
 ] 

Hadoop QA commented on LENS-719:


Applied patch: 
[LENS-719.02.patch|https://issues.apache.org/jira/secure/attachment/12781147/LENS-719.02.patch]
 and ran command: mvn clean install -fae. Result: Success. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/239/

> Allow fact start time to be specified for a storage and a update period
> ---
>
> Key: LENS-719
> URL: https://issues.apache.org/jira/browse/LENS-719
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: cube
>Reporter: Amareshwari Sriramadasu
>Assignee: Rajat Khandelwal
> Fix For: 2.5
>
> Attachments: LENS-719.02.patch, LENS-719.05.patch
>
>
> We can specify absolute and relative start time for a fact. This improvement 
> request is to add the ability to override the start time of a fact on a 
> storage and a update period.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-813) For multifact queries, having clauses are getting added to both sub queries.

[Rajat Khandelwal (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15088806#comment-15088806
 ] 

Rajat Khandelwal commented on LENS-813:
---

Posting the thought process here:

* Having clause has a boolean expression
* Hence, having AST is the AST of a boolean expression
* For multi-fact queries, the AST is copied to both facts and then both facts 
independently resolve expression in the AST recursively.
  ** If a fact is unable to resolve an expression, it just leaves it as it is.
* Multi-fact queries are by-design queries involving measures not present in a 
single fact. 
* The measures in multi-fact queries are split over the facts. 
* Having clause only involves conditions over measures and expressions over 
them. 
* For a multi-fact query, the whole having clause makes sense only after all 
the measures are in context, which is in the outer query. 
* Special cases of having clause can be pushed down. Necessary conditions:
  ** The boolean expression should be *and* over multiple boolean expressions. 
  ** Each single boolean expression should be evaluable by a single fact. 


For the sake of correctness, I'm planning to implement the easier version 
first, which is to have *having* at the outer query level and the ingredients 
at inner query level.

> For multifact queries, having clauses are getting added to both sub queries. 
> -
>
> Key: LENS-813
> URL: https://issues.apache.org/jira/browse/LENS-813
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Rajat Khandelwal
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-813) For multifact queries, having clauses are getting added to both sub queries.

[Rajat Khandelwal (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15088812#comment-15088812
 ] 

Rajat Khandelwal commented on LENS-813:
---

I'll take the push-down feature once the basic version is complete. 

> For multifact queries, having clauses are getting added to both sub queries. 
> -
>
> Key: LENS-813
> URL: https://issues.apache.org/jira/browse/LENS-813
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Rajat Khandelwal
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-913) Seeing DateUtil exception in all cube tests

[Rajat Khandelwal (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15088810#comment-15088810
 ] 

Rajat Khandelwal commented on LENS-913:
---

Taking patch from reviewboard and attaching

> Seeing DateUtil exception in all cube tests
> ---
>
> Key: LENS-913
> URL: https://issues.apache.org/jira/browse/LENS-913
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Affects Versions: 2.5
>Reporter: Amareshwari Sriramadasu
>Assignee: Rajat Khandelwal
>Priority: Minor
> Fix For: 2.5
>
> Attachments: LENS-913.01.patch
>
>
> Seeing following exception when any cube.parse test is run, all the logs are 
> filled with this.
> {noformat}
> 05 Jan 2016 10:52:40 [main] ERROR org.apache.lens.cube.metadata.DateUtil 164 
> - Invalid date format. expected only -MM-dd-HH:mm:ss,SSS date 
> provided:null
> java.lang.NullPointerException: null
> at 
> com.google.common.base.Preconditions.checkNotNull(Preconditions.java:187) 
> ~[hive-exec-0.13.3-inm.jar:0.13.3-inm]
> at com.google.common.cache.LocalCache.get(LocalCache.java:3964) 
> ~[hive-exec-0.13.3-inm.jar:0.13.3-inm]
> at 
> com.google.common.cache.LocalCache$LocalManualCache.get(LocalCache.java:4764) 
> ~[hive-exec-0.13.3-inm.jar:0.13.3-inm]
> at 
> org.apache.lens.cube.metadata.DateUtil.resolveAbsoluteDate(DateUtil.java:157) 
> ~[classes/:na]
> at 
> org.apache.lens.cube.metadata.CubeFactTable.getAbsoluteStartTime(CubeFactTable.java:327)
>  [classes/:na]
> at 
> org.apache.lens.cube.metadata.CubeFactTable.getStartTime(CubeFactTable.java:342)
>  [classes/:na]
> at 
> org.apache.lens.cube.parse.CandidateFact.isValidForTimeRange(CandidateFact.java:103)
>  [classes/:na]
> at 
> org.apache.lens.cube.parse.TimerangeResolver.doFactRangeValidation(TimerangeResolver.java:249)
>  [classes/:na]
> at 
> org.apache.lens.cube.parse.TimerangeResolver.rewriteContext(TimerangeResolver.java:59)
>  [classes/:na]
> at 
> org.apache.lens.cube.parse.CubeQueryRewriter.rewrite(CubeQueryRewriter.java:229)
>  [classes/:na]
> at 
> org.apache.lens.cube.parse.CubeQueryRewriter.rewrite(CubeQueryRewriter.java:199)
>  [classes/:na]
> at 
> org.apache.lens.cube.parse.CubeQueryRewriter.rewrite(CubeQueryRewriter.java:215)
>  [classes/:na]
> at 
> org.apache.lens.cube.parse.TestQueryRewrite.rewriteCtx(TestQueryRewrite.java:92)
>  [test-classes/:na]
> at 
> org.apache.lens.cube.parse.TestQueryRewrite.rewrite(TestQueryRewrite.java:83) 
> [test-classes/:na]
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-913) Seeing DateUtil exception in all cube tests

[Rajat Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-913:
--
Status: Patch Available  (was: In Progress)

> Seeing DateUtil exception in all cube tests
> ---
>
> Key: LENS-913
> URL: https://issues.apache.org/jira/browse/LENS-913
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Affects Versions: 2.5
>Reporter: Amareshwari Sriramadasu
>Assignee: Rajat Khandelwal
>Priority: Minor
> Fix For: 2.5
>
> Attachments: LENS-913.01.patch
>
>
> Seeing following exception when any cube.parse test is run, all the logs are 
> filled with this.
> {noformat}
> 05 Jan 2016 10:52:40 [main] ERROR org.apache.lens.cube.metadata.DateUtil 164 
> - Invalid date format. expected only -MM-dd-HH:mm:ss,SSS date 
> provided:null
> java.lang.NullPointerException: null
> at 
> com.google.common.base.Preconditions.checkNotNull(Preconditions.java:187) 
> ~[hive-exec-0.13.3-inm.jar:0.13.3-inm]
> at com.google.common.cache.LocalCache.get(LocalCache.java:3964) 
> ~[hive-exec-0.13.3-inm.jar:0.13.3-inm]
> at 
> com.google.common.cache.LocalCache$LocalManualCache.get(LocalCache.java:4764) 
> ~[hive-exec-0.13.3-inm.jar:0.13.3-inm]
> at 
> org.apache.lens.cube.metadata.DateUtil.resolveAbsoluteDate(DateUtil.java:157) 
> ~[classes/:na]
> at 
> org.apache.lens.cube.metadata.CubeFactTable.getAbsoluteStartTime(CubeFactTable.java:327)
>  [classes/:na]
> at 
> org.apache.lens.cube.metadata.CubeFactTable.getStartTime(CubeFactTable.java:342)
>  [classes/:na]
> at 
> org.apache.lens.cube.parse.CandidateFact.isValidForTimeRange(CandidateFact.java:103)
>  [classes/:na]
> at 
> org.apache.lens.cube.parse.TimerangeResolver.doFactRangeValidation(TimerangeResolver.java:249)
>  [classes/:na]
> at 
> org.apache.lens.cube.parse.TimerangeResolver.rewriteContext(TimerangeResolver.java:59)
>  [classes/:na]
> at 
> org.apache.lens.cube.parse.CubeQueryRewriter.rewrite(CubeQueryRewriter.java:229)
>  [classes/:na]
> at 
> org.apache.lens.cube.parse.CubeQueryRewriter.rewrite(CubeQueryRewriter.java:199)
>  [classes/:na]
> at 
> org.apache.lens.cube.parse.CubeQueryRewriter.rewrite(CubeQueryRewriter.java:215)
>  [classes/:na]
> at 
> org.apache.lens.cube.parse.TestQueryRewrite.rewriteCtx(TestQueryRewrite.java:92)
>  [test-classes/:na]
> at 
> org.apache.lens.cube.parse.TestQueryRewrite.rewrite(TestQueryRewrite.java:83) 
> [test-classes/:na]
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-913) Seeing DateUtil exception in all cube tests

[Rajat Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-913:
--
Attachment: LENS-913.01.patch

> Seeing DateUtil exception in all cube tests
> ---
>
> Key: LENS-913
> URL: https://issues.apache.org/jira/browse/LENS-913
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Affects Versions: 2.5
>Reporter: Amareshwari Sriramadasu
>Assignee: Rajat Khandelwal
>Priority: Minor
> Fix For: 2.5
>
> Attachments: LENS-913.01.patch
>
>
> Seeing following exception when any cube.parse test is run, all the logs are 
> filled with this.
> {noformat}
> 05 Jan 2016 10:52:40 [main] ERROR org.apache.lens.cube.metadata.DateUtil 164 
> - Invalid date format. expected only -MM-dd-HH:mm:ss,SSS date 
> provided:null
> java.lang.NullPointerException: null
> at 
> com.google.common.base.Preconditions.checkNotNull(Preconditions.java:187) 
> ~[hive-exec-0.13.3-inm.jar:0.13.3-inm]
> at com.google.common.cache.LocalCache.get(LocalCache.java:3964) 
> ~[hive-exec-0.13.3-inm.jar:0.13.3-inm]
> at 
> com.google.common.cache.LocalCache$LocalManualCache.get(LocalCache.java:4764) 
> ~[hive-exec-0.13.3-inm.jar:0.13.3-inm]
> at 
> org.apache.lens.cube.metadata.DateUtil.resolveAbsoluteDate(DateUtil.java:157) 
> ~[classes/:na]
> at 
> org.apache.lens.cube.metadata.CubeFactTable.getAbsoluteStartTime(CubeFactTable.java:327)
>  [classes/:na]
> at 
> org.apache.lens.cube.metadata.CubeFactTable.getStartTime(CubeFactTable.java:342)
>  [classes/:na]
> at 
> org.apache.lens.cube.parse.CandidateFact.isValidForTimeRange(CandidateFact.java:103)
>  [classes/:na]
> at 
> org.apache.lens.cube.parse.TimerangeResolver.doFactRangeValidation(TimerangeResolver.java:249)
>  [classes/:na]
> at 
> org.apache.lens.cube.parse.TimerangeResolver.rewriteContext(TimerangeResolver.java:59)
>  [classes/:na]
> at 
> org.apache.lens.cube.parse.CubeQueryRewriter.rewrite(CubeQueryRewriter.java:229)
>  [classes/:na]
> at 
> org.apache.lens.cube.parse.CubeQueryRewriter.rewrite(CubeQueryRewriter.java:199)
>  [classes/:na]
> at 
> org.apache.lens.cube.parse.CubeQueryRewriter.rewrite(CubeQueryRewriter.java:215)
>  [classes/:na]
> at 
> org.apache.lens.cube.parse.TestQueryRewrite.rewriteCtx(TestQueryRewrite.java:92)
>  [test-classes/:na]
> at 
> org.apache.lens.cube.parse.TestQueryRewrite.rewrite(TestQueryRewrite.java:83) 
> [test-classes/:na]
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)