[jira] [Commented] (LENS-1355) Lens unable to parse "date" in queries
[ https://issues.apache.org/jira/browse/LENS-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15562323#comment-15562323 ] Hadoop QA commented on LENS-1355: - Applied patch: [LENS-1355.01.patch|https://issues.apache.org/jira/secure/attachment/12832471/LENS-1355.01.patch] and ran command: mvn clean install -fae. Result: Failure. Build Job: https://builds.apache.org/job/PreCommit-Lens-Build/1044/ > Lens unable to parse "date" in queries > -- > > Key: LENS-1355 > URL: https://issues.apache.org/jira/browse/LENS-1355 > Project: Apache Lens > Issue Type: Bug >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Attachments: LENS-1355.01.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1354) Timeout and test failures in lens-cube module
[ https://issues.apache.org/jira/browse/LENS-1354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15562242#comment-15562242 ] Hadoop QA commented on LENS-1354: - Applied patch: [LENS-1354.01.patch|https://issues.apache.org/jira/secure/attachment/12832462/LENS-1354.01.patch] and ran command: mvn clean install -fae. Result: Failure. Build Job: https://builds.apache.org/job/PreCommit-Lens-Build/1043/ > Timeout and test failures in lens-cube module > - > > Key: LENS-1354 > URL: https://issues.apache.org/jira/browse/LENS-1354 > Project: Apache Lens > Issue Type: Bug > Components: cube >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Attachments: LENS-1354.01.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1355) Lens unable to parse "date" in queries
[ https://issues.apache.org/jira/browse/LENS-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajat Khandelwal updated LENS-1355: --- Status: Patch Available (was: In Progress) > Lens unable to parse "date" in queries > -- > > Key: LENS-1355 > URL: https://issues.apache.org/jira/browse/LENS-1355 > Project: Apache Lens > Issue Type: Bug >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Attachments: LENS-1355.01.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1355) Lens unable to parse "date" in queries
[ https://issues.apache.org/jira/browse/LENS-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15562220#comment-15562220 ] Rajat Khandelwal commented on LENS-1355: Taking patch from reviewboard and attaching > Lens unable to parse "date" in queries > -- > > Key: LENS-1355 > URL: https://issues.apache.org/jira/browse/LENS-1355 > Project: Apache Lens > Issue Type: Bug >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Attachments: LENS-1355.01.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1355) Lens unable to parse "date" in queries
[ https://issues.apache.org/jira/browse/LENS-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajat Khandelwal updated LENS-1355: --- Attachment: LENS-1355.01.patch > Lens unable to parse "date" in queries > -- > > Key: LENS-1355 > URL: https://issues.apache.org/jira/browse/LENS-1355 > Project: Apache Lens > Issue Type: Bug >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Attachments: LENS-1355.01.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work started] (LENS-1355) Lens unable to parse "date" in queries
[ https://issues.apache.org/jira/browse/LENS-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on LENS-1355 started by Rajat Khandelwal. -- > Lens unable to parse "date" in queries > -- > > Key: LENS-1355 > URL: https://issues.apache.org/jira/browse/LENS-1355 > Project: Apache Lens > Issue Type: Bug >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1355) Lens unable to parse "date" in queries
[ https://issues.apache.org/jira/browse/LENS-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15562216#comment-15562216 ] Rajat Khandelwal commented on LENS-1355: Created https://reviews.apache.org/r/52687/ > Lens unable to parse "date" in queries > -- > > Key: LENS-1355 > URL: https://issues.apache.org/jira/browse/LENS-1355 > Project: Apache Lens > Issue Type: Bug >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Review Request 52687: LENS-1355: Lens unable to parse "date" in queries
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52687/ --- Review request for lens. Bugs: LENS-1355 https://issues.apache.org/jira/browse/LENS-1355 Repository: lens Description --- Diffs - lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java c522061f3428c62dbf5a2ed8ec6b192d480f3fa6 lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 6d53d00f43c149a010c2f49aef44ace2a89c9348 lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java 26ae1e72ce3a8d04d4a9b5cd1cdf8dc237eae712 lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 1976248c066b518bb8de517631050878cf96c5e5 lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java 2619cb0800f5d22ac1bce52cb50136c879789de2 Diff: https://reviews.apache.org/r/52687/diff/ Testing --- Thanks, Rajat Khandelwal
[jira] [Commented] (LENS-1343) expression not being propagated to error message in COULD_NOT_PARSE_EXPRESSION error
[ https://issues.apache.org/jira/browse/LENS-1343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15562213#comment-15562213 ] Rajat Khandelwal commented on LENS-1343: On second thought, will leave this as resolved. Opened https://issues.apache.org/jira/browse/LENS-1355 for fixing the parsing of "date" > expression not being propagated to error message in > COULD_NOT_PARSE_EXPRESSION error > > > Key: LENS-1343 > URL: https://issues.apache.org/jira/browse/LENS-1343 > Project: Apache Lens > Issue Type: Bug > Components: cube >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Fix For: 2.7 > > Attachments: LENS-1343.01.patch, LENS-1343.02.patch, > LENS-1343.03.patch, LENS-1343.2016-10-03_12:58:34.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (LENS-1355) Lens unable to parse "date" in queries
Rajat Khandelwal created LENS-1355: -- Summary: Lens unable to parse "date" in queries Key: LENS-1355 URL: https://issues.apache.org/jira/browse/LENS-1355 Project: Apache Lens Issue Type: Bug Reporter: Rajat Khandelwal Assignee: Rajat Khandelwal -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1343) expression not being propagated to error message in COULD_NOT_PARSE_EXPRESSION error
[ https://issues.apache.org/jira/browse/LENS-1343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajat Khandelwal updated LENS-1343: --- Attachment: LENS-1343.02.patch > expression not being propagated to error message in > COULD_NOT_PARSE_EXPRESSION error > > > Key: LENS-1343 > URL: https://issues.apache.org/jira/browse/LENS-1343 > Project: Apache Lens > Issue Type: Bug > Components: cube >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Fix For: 2.7 > > Attachments: LENS-1343.01.patch, LENS-1343.02.patch, > LENS-1343.03.patch, LENS-1343.2016-10-03_12:58:34.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1343) expression not being propagated to error message in COULD_NOT_PARSE_EXPRESSION error
[ https://issues.apache.org/jira/browse/LENS-1343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15562174#comment-15562174 ] Rajat Khandelwal commented on LENS-1343: Taking patch from reviewboard and attaching > expression not being propagated to error message in > COULD_NOT_PARSE_EXPRESSION error > > > Key: LENS-1343 > URL: https://issues.apache.org/jira/browse/LENS-1343 > Project: Apache Lens > Issue Type: Bug > Components: cube >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Fix For: 2.7 > > Attachments: LENS-1343.01.patch, LENS-1343.02.patch, > LENS-1343.03.patch, LENS-1343.2016-10-03_12:58:34.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1287) Create command in cli to create schema taking parent directory where schema is stored
[ https://issues.apache.org/jira/browse/LENS-1287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15562169#comment-15562169 ] Hudson commented on LENS-1287: -- UNSTABLE: Integrated in Jenkins build Lens-Commit #1357 (See [https://builds.apache.org/job/Lens-Commit/1357/]) LENS-1287: Create command in cli to create schema taking parent (rajatgupta59: rev d9884ec6dcc59825f7f771b4d0c3cf7f187686f8) * (edit) lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java * (add) lens-cli/src/test/resources/schema/dimtables/dim_table.xml * (add) lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java * (delete) lens-cli/src/test/resources/cube_with_no_weight_facts.xml * (edit) lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java * (edit) lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java * (edit) lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java * (edit) lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java * (add) lens-cli/src/test/resources/schema/facts/fact_without_weight.xml * (edit) lens-cli/src/test/java/org/apache/lens/cli/doc/TestGenerateCLIUserDoc.java * (add) lens-cli/src/test/resources/schema/segmentations/seg1.xml * (delete) lens-cli/src/test/resources/seg1.xml * (delete) lens-cli/src/test/resources/dim_table2.xml * (edit) lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java * (add) lens-cli/src/test/resources/schema/dimensions/test-dimension.xml * (add) lens-cli/src/test/resources/schema/dimtables/dim_table2.xml * (edit) src/site/apt/user/cli.apt * (delete) lens-cli/src/test/resources/fact_without_weight.xml * (edit) lens-cli/src/main/java/org/apache/lens/cli/commands/LensDatabaseCommands.java * (delete) lens-cli/src/test/resources/local-storage.xml * (edit) lens-cli/src/test/java/org/apache/lens/cli/TestLensSegmentationCommands.java * (add) lens-cli/src/test/resources/schema/cubes/base/sample-cube.xml * (delete) lens-cli/src/test/resources/test-dimension.xml * (add) lens-cli/src/test/resources/schema/facts/fact1.xml * (delete) lens-cli/src/test/resources/sample-cube.xml * (delete) lens-cli/src/test/resources/fact1.xml * (edit) lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java * (edit) lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java * (edit) lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java * (add) lens-cli/src/test/resources/schema/cubes/base/cube_with_no_weight_facts.xml * (add) lens-cli/src/test/resources/schema/dimensions/test-detail.xml * (edit) lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java * (add) lens-cli/src/test/java/org/apache/lens/cli/LensCLITest.java * (add) lens-cli/src/test/java/org/apache/lens/cli/TestLensSchemaCommands.java * (add) lens-cli/src/test/resources/schema/storages/local-storage.xml * (delete) lens-cli/src/test/resources/test-detail.xml * (delete) lens-cli/src/test/resources/dim_table.xml > Create command in cli to create schema taking parent directory where schema > is stored > - > > Key: LENS-1287 > URL: https://issues.apache.org/jira/browse/LENS-1287 > Project: Apache Lens > Issue Type: New Feature >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Fix For: 2.7 > > Attachments: LENS-1287.07.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Review Request 52686: LENS-1343: expression not being propagated to error message in COULD_NOT_PARSE_EXPRESSION error
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52686/ --- (Updated Oct. 10, 2016, 5:59 p.m.) Review request for lens. Bugs: LENS-1343 https://issues.apache.org/jira/browse/LENS-1343 Repository: lens Description --- Diffs (updated) - lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java c522061f3428c62dbf5a2ed8ec6b192d480f3fa6 lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 6d53d00f43c149a010c2f49aef44ace2a89c9348 lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java 26ae1e72ce3a8d04d4a9b5cd1cdf8dc237eae712 lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 1976248c066b518bb8de517631050878cf96c5e5 lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java 2619cb0800f5d22ac1bce52cb50136c879789de2 Diff: https://reviews.apache.org/r/52686/diff/ Testing --- Thanks, Rajat Khandelwal
[jira] [Commented] (LENS-1273) Resolve issues with case when aggregate expressions with dim-attributes conditions
[ https://issues.apache.org/jira/browse/LENS-1273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15562170#comment-15562170 ] Hudson commented on LENS-1273: -- UNSTABLE: Integrated in Jenkins build Lens-Commit #1357 (See [https://builds.apache.org/job/Lens-Commit/1357/]) LENS-1273 : Resolve issues with case when aggregate expressions with (rajatgupta59: rev 2cfb7b097c5367f21779f3c27bc347a9ff536de1) * (add) lens-cube/src/main/java/org/apache/lens/cube/parse/QueriedPhraseContext.java * (add) lens-cube/src/main/java/org/apache/lens/cube/parse/TracksQueriedColumns.java * (edit) lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java * (edit) lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRangeChecker.java * (edit) lens-cube/src/main/java/org/apache/lens/cube/parse/TrackQueriedColumns.java * (edit) lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java * (edit) lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java * (edit) lens-cube/src/main/java/org/apache/lens/cube/parse/MultiFactHQLContext.java * (edit) lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java * (edit) lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java * (add) lens-cube/src/main/java/org/apache/lens/cube/parse/TrackQueriedCubeFields.java * (edit) lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java * (edit) lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java * (edit) lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java * (edit) lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java * (add) lens-cube/src/main/java/org/apache/lens/cube/parse/SelectPhraseContext.java * (edit) lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java * (edit) lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java * (edit) lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java > Resolve issues with case when aggregate expressions with dim-attributes > conditions > --- > > Key: LENS-1273 > URL: https://issues.apache.org/jira/browse/LENS-1273 > Project: Apache Lens > Issue Type: Improvement > Components: cube >Reporter: Amareshwari Sriramadasu >Assignee: Amareshwari Sriramadasu > Fix For: 2.7 > > Attachments: LENS-1273.2.patch, LENS-1273.3.patch, LENS-1273.patch > > > Right now, users write query like the following : > select sum(case when dim1=x then msr1 else 0 end), msr2 from cube where > time_range_in(...) > And if dim1 and msr2 are not queryable, query fails saying Fields cannot be > queried together. > but the query should be accepted. > The same works fine if the above is created as cube expression. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1343) expression not being propagated to error message in COULD_NOT_PARSE_EXPRESSION error
[ https://issues.apache.org/jira/browse/LENS-1343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajat Khandelwal updated LENS-1343: --- Attachment: LENS-1343.01.patch > expression not being propagated to error message in > COULD_NOT_PARSE_EXPRESSION error > > > Key: LENS-1343 > URL: https://issues.apache.org/jira/browse/LENS-1343 > Project: Apache Lens > Issue Type: Bug > Components: cube >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Fix For: 2.7 > > Attachments: LENS-1343.01.patch, LENS-1343.03.patch, > LENS-1343.2016-10-03_12:58:34.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1343) expression not being propagated to error message in COULD_NOT_PARSE_EXPRESSION error
[ https://issues.apache.org/jira/browse/LENS-1343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15562167#comment-15562167 ] Rajat Khandelwal commented on LENS-1343: Taking patch from reviewboard and attaching > expression not being propagated to error message in > COULD_NOT_PARSE_EXPRESSION error > > > Key: LENS-1343 > URL: https://issues.apache.org/jira/browse/LENS-1343 > Project: Apache Lens > Issue Type: Bug > Components: cube >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Fix For: 2.7 > > Attachments: LENS-1343.01.patch, LENS-1343.03.patch, > LENS-1343.2016-10-03_12:58:34.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1343) expression not being propagated to error message in COULD_NOT_PARSE_EXPRESSION error
[ https://issues.apache.org/jira/browse/LENS-1343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15562163#comment-15562163 ] Rajat Khandelwal commented on LENS-1343: Created https://reviews.apache.org/r/52686/ > expression not being propagated to error message in > COULD_NOT_PARSE_EXPRESSION error > > > Key: LENS-1343 > URL: https://issues.apache.org/jira/browse/LENS-1343 > Project: Apache Lens > Issue Type: Bug > Components: cube >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Fix For: 2.7 > > Attachments: LENS-1343.03.patch, LENS-1343.2016-10-03_12:58:34.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1343) expression not being propagated to error message in COULD_NOT_PARSE_EXPRESSION error
[ https://issues.apache.org/jira/browse/LENS-1343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15562158#comment-15562158 ] Rajat Khandelwal commented on LENS-1343: I think we should be able to parse "date" field. Will open a review request for the capability of parsing "date" field. > expression not being propagated to error message in > COULD_NOT_PARSE_EXPRESSION error > > > Key: LENS-1343 > URL: https://issues.apache.org/jira/browse/LENS-1343 > Project: Apache Lens > Issue Type: Bug > Components: cube >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Fix For: 2.7 > > Attachments: LENS-1343.03.patch, LENS-1343.2016-10-03_12:58:34.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1354) Timeout and test failures in lens-cube module
[ https://issues.apache.org/jira/browse/LENS-1354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajat Khandelwal updated LENS-1354: --- Status: Patch Available (was: In Progress) > Timeout and test failures in lens-cube module > - > > Key: LENS-1354 > URL: https://issues.apache.org/jira/browse/LENS-1354 > Project: Apache Lens > Issue Type: Bug > Components: cube >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Attachments: LENS-1354.01.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1354) Timeout and test failures in lens-cube module
[ https://issues.apache.org/jira/browse/LENS-1354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15562094#comment-15562094 ] Rajat Khandelwal commented on LENS-1354: Taking patch from reviewboard and attaching > Timeout and test failures in lens-cube module > - > > Key: LENS-1354 > URL: https://issues.apache.org/jira/browse/LENS-1354 > Project: Apache Lens > Issue Type: Bug > Components: cube >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Attachments: LENS-1354.01.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1354) Timeout and test failures in lens-cube module
[ https://issues.apache.org/jira/browse/LENS-1354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajat Khandelwal updated LENS-1354: --- Attachment: LENS-1354.01.patch > Timeout and test failures in lens-cube module > - > > Key: LENS-1354 > URL: https://issues.apache.org/jira/browse/LENS-1354 > Project: Apache Lens > Issue Type: Bug > Components: cube >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Attachments: LENS-1354.01.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1354) Timeout and test failures in lens-cube module
[ https://issues.apache.org/jira/browse/LENS-1354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15562089#comment-15562089 ] Rajat Khandelwal commented on LENS-1354: Created https://reviews.apache.org/r/52683/ > Timeout and test failures in lens-cube module > - > > Key: LENS-1354 > URL: https://issues.apache.org/jira/browse/LENS-1354 > Project: Apache Lens > Issue Type: Bug > Components: cube >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work started] (LENS-1354) Timeout and test failures in lens-cube module
[ https://issues.apache.org/jira/browse/LENS-1354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on LENS-1354 started by Rajat Khandelwal. -- > Timeout and test failures in lens-cube module > - > > Key: LENS-1354 > URL: https://issues.apache.org/jira/browse/LENS-1354 > Project: Apache Lens > Issue Type: Bug > Components: cube >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Review Request 52683: LENS-1354: Timeout and test failures in lens-cube module
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52683/ --- Review request for lens. Bugs: LENS-1354 https://issues.apache.org/jira/browse/LENS-1354 Repository: lens Description --- Diffs - lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java e21dc2ac187318cbc52bd0e49cc8e7065236c4e0 lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java f7f8af22dd07c4798b0856e6ddc0b0fc16d4177a Diff: https://reviews.apache.org/r/52683/diff/ Testing --- Thanks, Rajat Khandelwal
[jira] [Commented] (LENS-1273) Resolve issues with case when aggregate expressions with dim-attributes conditions
[ https://issues.apache.org/jira/browse/LENS-1273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15562014#comment-15562014 ] Hudson commented on LENS-1273: -- UNSTABLE: Integrated in Jenkins build Lens-Commit-Java8 #274 (See [https://builds.apache.org/job/Lens-Commit-Java8/274/]) LENS-1273 : Resolve issues with case when aggregate expressions with (rajatgupta59: rev 2cfb7b097c5367f21779f3c27bc347a9ff536de1) * (edit) lens-cube/src/main/java/org/apache/lens/cube/parse/MultiFactHQLContext.java * (edit) lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java * (edit) lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java * (add) lens-cube/src/main/java/org/apache/lens/cube/parse/SelectPhraseContext.java * (edit) lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java * (add) lens-cube/src/main/java/org/apache/lens/cube/parse/TrackQueriedCubeFields.java * (edit) lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java * (edit) lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java * (add) lens-cube/src/main/java/org/apache/lens/cube/parse/QueriedPhraseContext.java * (edit) lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java * (add) lens-cube/src/main/java/org/apache/lens/cube/parse/TracksQueriedColumns.java * (edit) lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java * (edit) lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java * (edit) lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java * (edit) lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java * (edit) lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java * (edit) lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java * (edit) lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRangeChecker.java * (edit) lens-cube/src/main/java/org/apache/lens/cube/parse/TrackQueriedColumns.java > Resolve issues with case when aggregate expressions with dim-attributes > conditions > --- > > Key: LENS-1273 > URL: https://issues.apache.org/jira/browse/LENS-1273 > Project: Apache Lens > Issue Type: Improvement > Components: cube >Reporter: Amareshwari Sriramadasu >Assignee: Amareshwari Sriramadasu > Fix For: 2.7 > > Attachments: LENS-1273.2.patch, LENS-1273.3.patch, LENS-1273.patch > > > Right now, users write query like the following : > select sum(case when dim1=x then msr1 else 0 end), msr2 from cube where > time_range_in(...) > And if dim1 and msr2 are not queryable, query fails saying Fields cannot be > queried together. > but the query should be accepted. > The same works fine if the above is created as cube expression. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1287) Create command in cli to create schema taking parent directory where schema is stored
[ https://issues.apache.org/jira/browse/LENS-1287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15562013#comment-15562013 ] Hudson commented on LENS-1287: -- UNSTABLE: Integrated in Jenkins build Lens-Commit-Java8 #274 (See [https://builds.apache.org/job/Lens-Commit-Java8/274/]) LENS-1287: Create command in cli to create schema taking parent (rajatgupta59: rev d9884ec6dcc59825f7f771b4d0c3cf7f187686f8) * (add) lens-cli/src/test/resources/schema/facts/fact_without_weight.xml * (delete) lens-cli/src/test/resources/local-storage.xml * (edit) lens-cli/src/test/java/org/apache/lens/cli/TestLensSegmentationCommands.java * (add) lens-cli/src/test/resources/schema/cubes/base/cube_with_no_weight_facts.xml * (add) lens-cli/src/test/java/org/apache/lens/cli/TestLensSchemaCommands.java * (edit) src/site/apt/user/cli.apt * (edit) lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java * (delete) lens-cli/src/test/resources/dim_table.xml * (edit) lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java * (delete) lens-cli/src/test/resources/test-dimension.xml * (add) lens-cli/src/test/resources/schema/facts/fact1.xml * (add) lens-cli/src/test/resources/schema/segmentations/seg1.xml * (add) lens-cli/src/test/resources/schema/dimensions/test-dimension.xml * (delete) lens-cli/src/test/resources/fact1.xml * (edit) lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java * (delete) lens-cli/src/test/resources/cube_with_no_weight_facts.xml * (edit) lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java * (edit) lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java * (delete) lens-cli/src/test/resources/sample-cube.xml * (add) lens-cli/src/test/resources/schema/dimtables/dim_table.xml * (delete) lens-cli/src/test/resources/fact_without_weight.xml * (edit) lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java * (add) lens-cli/src/test/resources/schema/dimensions/test-detail.xml * (add) lens-cli/src/test/resources/schema/dimtables/dim_table2.xml * (delete) lens-cli/src/test/resources/seg1.xml * (add) lens-cli/src/test/resources/schema/cubes/base/sample-cube.xml * (add) lens-cli/src/test/resources/schema/storages/local-storage.xml * (delete) lens-cli/src/test/resources/test-detail.xml * (delete) lens-cli/src/test/resources/dim_table2.xml * (add) lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java * (edit) lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java * (add) lens-cli/src/test/java/org/apache/lens/cli/LensCLITest.java * (edit) lens-cli/src/main/java/org/apache/lens/cli/commands/LensDatabaseCommands.java * (edit) lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java * (edit) lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java * (edit) lens-cli/src/test/java/org/apache/lens/cli/doc/TestGenerateCLIUserDoc.java * (edit) lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java > Create command in cli to create schema taking parent directory where schema > is stored > - > > Key: LENS-1287 > URL: https://issues.apache.org/jira/browse/LENS-1287 > Project: Apache Lens > Issue Type: New Feature >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Fix For: 2.7 > > Attachments: LENS-1287.07.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (LENS-1354) Timeout and test failures in lens-cube module
Rajat Khandelwal created LENS-1354: -- Summary: Timeout and test failures in lens-cube module Key: LENS-1354 URL: https://issues.apache.org/jira/browse/LENS-1354 Project: Apache Lens Issue Type: Bug Components: cube Reporter: Rajat Khandelwal Assignee: Rajat Khandelwal -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1345) Deadlock in jdbc query status update
[ https://issues.apache.org/jira/browse/LENS-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15561975#comment-15561975 ] Hudson commented on LENS-1345: -- SUCCESS: Integrated in Jenkins build Lens-Commit #1356 (See [https://builds.apache.org/job/Lens-Commit/1356/]) LENS-1345: Fixing deadlock in jdbc query status update flow (rajatgupta59: rev 9ef7ce73693d039ab5a197b4227c5c09c2efcaa4) * (edit) lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java * (edit) lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java * (edit) lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java * (edit) lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java * (edit) lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java * (edit) lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java * (edit) lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java * (edit) lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java > Deadlock in jdbc query status update > > > Key: LENS-1345 > URL: https://issues.apache.org/jira/browse/LENS-1345 > Project: Apache Lens > Issue Type: Bug >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Fix For: 2.7 > > Attachments: LENS-1345.02.patch, LENS-1345.04.patch, > LENS-1345.05.patch, LENS-1345.06.patch, LENS-1345.07.patch > > > JDBC query is launched in a thread. On query finish, the thread calls back > the query service to update status, which creates a FinishedQuery instance. > In the constructor, FinishedQuery is fetching result from the jdbc driver, > which waits on the original thread to complete. Basically the thread is > waiting for itself. > In the callback, query context is acquired by the thread, and can't be > acquired again. Which means that get calls for this query won't return and > will stay blocked. This can end up blocking all the grizzly threads. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1345) Deadlock in jdbc query status update
[ https://issues.apache.org/jira/browse/LENS-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15561908#comment-15561908 ] Hudson commented on LENS-1345: -- UNSTABLE: Integrated in Jenkins build Lens-Commit-Java8 #273 (See [https://builds.apache.org/job/Lens-Commit-Java8/273/]) LENS-1345: Fixing deadlock in jdbc query status update flow (rajatgupta59: rev 9ef7ce73693d039ab5a197b4227c5c09c2efcaa4) * (edit) lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java * (edit) lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java * (edit) lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java * (edit) lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java * (edit) lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java * (edit) lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java * (edit) lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java * (edit) lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java > Deadlock in jdbc query status update > > > Key: LENS-1345 > URL: https://issues.apache.org/jira/browse/LENS-1345 > Project: Apache Lens > Issue Type: Bug >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Fix For: 2.7 > > Attachments: LENS-1345.02.patch, LENS-1345.04.patch, > LENS-1345.05.patch, LENS-1345.06.patch, LENS-1345.07.patch > > > JDBC query is launched in a thread. On query finish, the thread calls back > the query service to update status, which creates a FinishedQuery instance. > In the constructor, FinishedQuery is fetching result from the jdbc driver, > which waits on the original thread to complete. Basically the thread is > waiting for itself. > In the callback, query context is acquired by the thread, and can't be > acquired again. Which means that get calls for this query won't return and > will stay blocked. This can end up blocking all the grizzly threads. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1287) Create command in cli to create schema taking parent directory where schema is stored
[ https://issues.apache.org/jira/browse/LENS-1287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajat Khandelwal updated LENS-1287: --- Resolution: Fixed Status: Resolved (was: Patch Available) > Create command in cli to create schema taking parent directory where schema > is stored > - > > Key: LENS-1287 > URL: https://issues.apache.org/jira/browse/LENS-1287 > Project: Apache Lens > Issue Type: New Feature >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Fix For: 2.7 > > Attachments: LENS-1287.07.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1287) Create command in cli to create schema taking parent directory where schema is stored
[ https://issues.apache.org/jira/browse/LENS-1287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15561812#comment-15561812 ] Rajat Khandelwal commented on LENS-1287: Committed myself. > Create command in cli to create schema taking parent directory where schema > is stored > - > > Key: LENS-1287 > URL: https://issues.apache.org/jira/browse/LENS-1287 > Project: Apache Lens > Issue Type: New Feature >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Fix For: 2.7 > > Attachments: LENS-1287.07.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1287) Create command in cli to create schema taking parent directory where schema is stored
[ https://issues.apache.org/jira/browse/LENS-1287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajat Khandelwal updated LENS-1287: --- Fix Version/s: 2.7 > Create command in cli to create schema taking parent directory where schema > is stored > - > > Key: LENS-1287 > URL: https://issues.apache.org/jira/browse/LENS-1287 > Project: Apache Lens > Issue Type: New Feature >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Fix For: 2.7 > > Attachments: LENS-1287.07.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1273) Resolve issues with case when aggregate expressions with dim-attributes conditions
[ https://issues.apache.org/jira/browse/LENS-1273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15561809#comment-15561809 ] Rajat Khandelwal commented on LENS-1273: Committed. Thanks [~amareshwari] > Resolve issues with case when aggregate expressions with dim-attributes > conditions > --- > > Key: LENS-1273 > URL: https://issues.apache.org/jira/browse/LENS-1273 > Project: Apache Lens > Issue Type: Improvement > Components: cube >Reporter: Amareshwari Sriramadasu >Assignee: Amareshwari Sriramadasu > Fix For: 2.7 > > Attachments: LENS-1273.2.patch, LENS-1273.3.patch, LENS-1273.patch > > > Right now, users write query like the following : > select sum(case when dim1=x then msr1 else 0 end), msr2 from cube where > time_range_in(...) > And if dim1 and msr2 are not queryable, query fails saying Fields cannot be > queried together. > but the query should be accepted. > The same works fine if the above is created as cube expression. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1273) Resolve issues with case when aggregate expressions with dim-attributes conditions
[ https://issues.apache.org/jira/browse/LENS-1273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajat Khandelwal updated LENS-1273: --- Resolution: Fixed Status: Resolved (was: Patch Available) > Resolve issues with case when aggregate expressions with dim-attributes > conditions > --- > > Key: LENS-1273 > URL: https://issues.apache.org/jira/browse/LENS-1273 > Project: Apache Lens > Issue Type: Improvement > Components: cube >Reporter: Amareshwari Sriramadasu >Assignee: Amareshwari Sriramadasu > Fix For: 2.7 > > Attachments: LENS-1273.2.patch, LENS-1273.3.patch, LENS-1273.patch > > > Right now, users write query like the following : > select sum(case when dim1=x then msr1 else 0 end), msr2 from cube where > time_range_in(...) > And if dim1 and msr2 are not queryable, query fails saying Fields cannot be > queried together. > but the query should be accepted. > The same works fine if the above is created as cube expression. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1340) Adding API for data completeness checker
[ https://issues.apache.org/jira/browse/LENS-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15561788#comment-15561788 ] Hudson commented on LENS-1340: -- UNSTABLE: Integrated in Jenkins build Lens-Commit #1355 (See [https://builds.apache.org/job/Lens-Commit/1355/]) LENS-1340: Adding API for data completeness checker (rajatgupta59: rev 61ee6bfc8f7c66d2b5fc7274cf893e259460b7a9) * (add) lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java > Adding API for data completeness checker > > > Key: LENS-1340 > URL: https://issues.apache.org/jira/browse/LENS-1340 > Project: Apache Lens > Issue Type: Sub-task > Components: cube >Reporter: Narayan Periwal >Assignee: Narayan Periwal > Fix For: 2.7 > > Attachments: LENS-1340-v2.patch, LENS-1340.patch > > > The data completeness API will take the factTag, startDate, endDate and > measure's list as input. > It will return the completeness percentage for each of the measures for the > given factTag and time range. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1340) Adding API for data completeness checker
[ https://issues.apache.org/jira/browse/LENS-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15561752#comment-15561752 ] Hudson commented on LENS-1340: -- UNSTABLE: Integrated in Jenkins build Lens-Commit-Java8 #272 (See [https://builds.apache.org/job/Lens-Commit-Java8/272/]) LENS-1340: Adding API for data completeness checker (rajatgupta59: rev 61ee6bfc8f7c66d2b5fc7274cf893e259460b7a9) * (add) lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java > Adding API for data completeness checker > > > Key: LENS-1340 > URL: https://issues.apache.org/jira/browse/LENS-1340 > Project: Apache Lens > Issue Type: Sub-task > Components: cube >Reporter: Narayan Periwal >Assignee: Narayan Periwal > Fix For: 2.7 > > Attachments: LENS-1340-v2.patch, LENS-1340.patch > > > The data completeness API will take the factTag, startDate, endDate and > measure's list as input. > It will return the completeness percentage for each of the measures for the > given factTag and time range. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1345) Deadlock in jdbc query status update
[ https://issues.apache.org/jira/browse/LENS-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15561688#comment-15561688 ] Rajat Khandelwal commented on LENS-1345: Committed myself. > Deadlock in jdbc query status update > > > Key: LENS-1345 > URL: https://issues.apache.org/jira/browse/LENS-1345 > Project: Apache Lens > Issue Type: Bug >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Fix For: 2.7 > > Attachments: LENS-1345.02.patch, LENS-1345.04.patch, > LENS-1345.05.patch, LENS-1345.06.patch, LENS-1345.07.patch > > > JDBC query is launched in a thread. On query finish, the thread calls back > the query service to update status, which creates a FinishedQuery instance. > In the constructor, FinishedQuery is fetching result from the jdbc driver, > which waits on the original thread to complete. Basically the thread is > waiting for itself. > In the callback, query context is acquired by the thread, and can't be > acquired again. Which means that get calls for this query won't return and > will stay blocked. This can end up blocking all the grizzly threads. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1345) Deadlock in jdbc query status update
[ https://issues.apache.org/jira/browse/LENS-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajat Khandelwal updated LENS-1345: --- Resolution: Fixed Status: Resolved (was: Patch Available) > Deadlock in jdbc query status update > > > Key: LENS-1345 > URL: https://issues.apache.org/jira/browse/LENS-1345 > Project: Apache Lens > Issue Type: Bug >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Fix For: 2.7 > > Attachments: LENS-1345.02.patch, LENS-1345.04.patch, > LENS-1345.05.patch, LENS-1345.06.patch, LENS-1345.07.patch > > > JDBC query is launched in a thread. On query finish, the thread calls back > the query service to update status, which creates a FinishedQuery instance. > In the constructor, FinishedQuery is fetching result from the jdbc driver, > which waits on the original thread to complete. Basically the thread is > waiting for itself. > In the callback, query context is acquired by the thread, and can't be > acquired again. Which means that get calls for this query won't return and > will stay blocked. This can end up blocking all the grizzly threads. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1333) Add data completeness checker
[ https://issues.apache.org/jira/browse/LENS-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15561686#comment-15561686 ] Hadoop QA commented on LENS-1333: - Applied patch: [LENS-1333-v2.patch|https://issues.apache.org/jira/secure/attachment/12832429/LENS-1333-v2.patch] and ran command: mvn clean install -fae. Result: Failure. Build Job: https://builds.apache.org/job/PreCommit-Lens-Build/1042/ > Add data completeness checker > - > > Key: LENS-1333 > URL: https://issues.apache.org/jira/browse/LENS-1333 > Project: Apache Lens > Issue Type: New Feature > Components: cube >Reporter: Amareshwari Sriramadasu >Assignee: Narayan Periwal > Attachments: LENS-1333-v1.patch, LENS-1333-v2.patch > > > Though lens has partition registration being done whenever data is available, > there is no guarantee the partition registered is complete. There can be > different ways to know if the data is complete for partition. One option > could be to have a partition property saying whether it is complete or not. > Other could be to do a http call to another hosted service and more. > Proposal here is to add an interface for DataCompletenessChecker and do the > check while resolving partitions. > Here are some of the capabilities we would like to add in Lens : > # Lens will check partition existence first, if it exists, then check the > completeness percentage. If the completeness percentage is less than a > configured threshold (default should be 98, 99 or even 100), Lens will fail > the query. > # Lens's accept query on partial data will accept on incomplete data as well. > # Lens will also option to override the completeness percentage threshold > value at query level > # Lens will still have look ahead capability of daily being incomplete, then > it will union with hourly. > # If same measure is there in two different facts , Lens will we pick the one > with higher availability. > # In case of completeness percentage threshold missed, Lens will respond back > with available percentage. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1345) Deadlock in jdbc query status update
[ https://issues.apache.org/jira/browse/LENS-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15561657#comment-15561657 ] Hadoop QA commented on LENS-1345: - Applied patch: [LENS-1345.07.patch|https://issues.apache.org/jira/secure/attachment/12832317/LENS-1345.07.patch] and ran command: mvn clean install -fae. Result: Failure. Build Job: https://builds.apache.org/job/PreCommit-Lens-Build/1039/ > Deadlock in jdbc query status update > > > Key: LENS-1345 > URL: https://issues.apache.org/jira/browse/LENS-1345 > Project: Apache Lens > Issue Type: Bug >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Attachments: LENS-1345.02.patch, LENS-1345.04.patch, > LENS-1345.05.patch, LENS-1345.06.patch, LENS-1345.07.patch > > > JDBC query is launched in a thread. On query finish, the thread calls back > the query service to update status, which creates a FinishedQuery instance. > In the constructor, FinishedQuery is fetching result from the jdbc driver, > which waits on the original thread to complete. Basically the thread is > waiting for itself. > In the callback, query context is acquired by the thread, and can't be > acquired again. Which means that get calls for this query won't return and > will stay blocked. This can end up blocking all the grizzly threads. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1345) Deadlock in jdbc query status update
[ https://issues.apache.org/jira/browse/LENS-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15561626#comment-15561626 ] Hadoop QA commented on LENS-1345: - Applied patch: [LENS-1345.07.patch|https://issues.apache.org/jira/secure/attachment/12832317/LENS-1345.07.patch] and ran command: mvn clean install -fae. Result: Failure. Build Job: https://builds.apache.org/job/PreCommit-Lens-Build/1040/ > Deadlock in jdbc query status update > > > Key: LENS-1345 > URL: https://issues.apache.org/jira/browse/LENS-1345 > Project: Apache Lens > Issue Type: Bug >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Attachments: LENS-1345.02.patch, LENS-1345.04.patch, > LENS-1345.05.patch, LENS-1345.06.patch, LENS-1345.07.patch > > > JDBC query is launched in a thread. On query finish, the thread calls back > the query service to update status, which creates a FinishedQuery instance. > In the constructor, FinishedQuery is fetching result from the jdbc driver, > which waits on the original thread to complete. Basically the thread is > waiting for itself. > In the callback, query context is acquired by the thread, and can't be > acquired again. Which means that get calls for this query won't return and > will stay blocked. This can end up blocking all the grizzly threads. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1345) Deadlock in jdbc query status update
[ https://issues.apache.org/jira/browse/LENS-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15561624#comment-15561624 ] Hadoop QA commented on LENS-1345: - Applied patch: [LENS-1345.07.patch|https://issues.apache.org/jira/secure/attachment/12832317/LENS-1345.07.patch] and ran command: mvn clean install -fae. Result: Failure. Build Job: https://builds.apache.org/job/PreCommit-Lens-Build/1038/ > Deadlock in jdbc query status update > > > Key: LENS-1345 > URL: https://issues.apache.org/jira/browse/LENS-1345 > Project: Apache Lens > Issue Type: Bug >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Attachments: LENS-1345.02.patch, LENS-1345.04.patch, > LENS-1345.05.patch, LENS-1345.06.patch, LENS-1345.07.patch > > > JDBC query is launched in a thread. On query finish, the thread calls back > the query service to update status, which creates a FinishedQuery instance. > In the constructor, FinishedQuery is fetching result from the jdbc driver, > which waits on the original thread to complete. Basically the thread is > waiting for itself. > In the callback, query context is acquired by the thread, and can't be > acquired again. Which means that get calls for this query won't return and > will stay blocked. This can end up blocking all the grizzly threads. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1333) Add data completeness checker
[ https://issues.apache.org/jira/browse/LENS-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Narayan Periwal updated LENS-1333: -- Status: Patch Available (was: In Progress) > Add data completeness checker > - > > Key: LENS-1333 > URL: https://issues.apache.org/jira/browse/LENS-1333 > Project: Apache Lens > Issue Type: New Feature > Components: cube >Reporter: Amareshwari Sriramadasu >Assignee: Narayan Periwal > Attachments: LENS-1333-v1.patch, LENS-1333-v2.patch > > > Though lens has partition registration being done whenever data is available, > there is no guarantee the partition registered is complete. There can be > different ways to know if the data is complete for partition. One option > could be to have a partition property saying whether it is complete or not. > Other could be to do a http call to another hosted service and more. > Proposal here is to add an interface for DataCompletenessChecker and do the > check while resolving partitions. > Here are some of the capabilities we would like to add in Lens : > # Lens will check partition existence first, if it exists, then check the > completeness percentage. If the completeness percentage is less than a > configured threshold (default should be 98, 99 or even 100), Lens will fail > the query. > # Lens's accept query on partial data will accept on incomplete data as well. > # Lens will also option to override the completeness percentage threshold > value at query level > # Lens will still have look ahead capability of daily being incomplete, then > it will union with hourly. > # If same measure is there in two different facts , Lens will we pick the one > with higher availability. > # In case of completeness percentage threshold missed, Lens will respond back > with available percentage. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1333) Add data completeness checker
[ https://issues.apache.org/jira/browse/LENS-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Narayan Periwal updated LENS-1333: -- Status: Patch Available (was: In Progress) > Add data completeness checker > - > > Key: LENS-1333 > URL: https://issues.apache.org/jira/browse/LENS-1333 > Project: Apache Lens > Issue Type: New Feature > Components: cube >Reporter: Amareshwari Sriramadasu >Assignee: Narayan Periwal > Attachments: LENS-1333-v1.patch, LENS-1333-v2.patch > > > Though lens has partition registration being done whenever data is available, > there is no guarantee the partition registered is complete. There can be > different ways to know if the data is complete for partition. One option > could be to have a partition property saying whether it is complete or not. > Other could be to do a http call to another hosted service and more. > Proposal here is to add an interface for DataCompletenessChecker and do the > check while resolving partitions. > Here are some of the capabilities we would like to add in Lens : > # Lens will check partition existence first, if it exists, then check the > completeness percentage. If the completeness percentage is less than a > configured threshold (default should be 98, 99 or even 100), Lens will fail > the query. > # Lens's accept query on partial data will accept on incomplete data as well. > # Lens will also option to override the completeness percentage threshold > value at query level > # Lens will still have look ahead capability of daily being incomplete, then > it will union with hourly. > # If same measure is there in two different facts , Lens will we pick the one > with higher availability. > # In case of completeness percentage threshold missed, Lens will respond back > with available percentage. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1333) Add data completeness checker
[ https://issues.apache.org/jira/browse/LENS-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Narayan Periwal updated LENS-1333: -- Status: In Progress (was: Patch Available) > Add data completeness checker > - > > Key: LENS-1333 > URL: https://issues.apache.org/jira/browse/LENS-1333 > Project: Apache Lens > Issue Type: New Feature > Components: cube >Reporter: Amareshwari Sriramadasu >Assignee: Narayan Periwal > Attachments: LENS-1333-v1.patch, LENS-1333-v2.patch > > > Though lens has partition registration being done whenever data is available, > there is no guarantee the partition registered is complete. There can be > different ways to know if the data is complete for partition. One option > could be to have a partition property saying whether it is complete or not. > Other could be to do a http call to another hosted service and more. > Proposal here is to add an interface for DataCompletenessChecker and do the > check while resolving partitions. > Here are some of the capabilities we would like to add in Lens : > # Lens will check partition existence first, if it exists, then check the > completeness percentage. If the completeness percentage is less than a > configured threshold (default should be 98, 99 or even 100), Lens will fail > the query. > # Lens's accept query on partial data will accept on incomplete data as well. > # Lens will also option to override the completeness percentage threshold > value at query level > # Lens will still have look ahead capability of daily being incomplete, then > it will union with hourly. > # If same measure is there in two different facts , Lens will we pick the one > with higher availability. > # In case of completeness percentage threshold missed, Lens will respond back > with available percentage. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1333) Add data completeness checker
[ https://issues.apache.org/jira/browse/LENS-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Narayan Periwal updated LENS-1333: -- Attachment: LENS-1333-v2.patch > Add data completeness checker > - > > Key: LENS-1333 > URL: https://issues.apache.org/jira/browse/LENS-1333 > Project: Apache Lens > Issue Type: New Feature > Components: cube >Reporter: Amareshwari Sriramadasu >Assignee: Narayan Periwal > Attachments: LENS-1333-v1.patch, LENS-1333-v2.patch > > > Though lens has partition registration being done whenever data is available, > there is no guarantee the partition registered is complete. There can be > different ways to know if the data is complete for partition. One option > could be to have a partition property saying whether it is complete or not. > Other could be to do a http call to another hosted service and more. > Proposal here is to add an interface for DataCompletenessChecker and do the > check while resolving partitions. > Here are some of the capabilities we would like to add in Lens : > # Lens will check partition existence first, if it exists, then check the > completeness percentage. If the completeness percentage is less than a > configured threshold (default should be 98, 99 or even 100), Lens will fail > the query. > # Lens's accept query on partial data will accept on incomplete data as well. > # Lens will also option to override the completeness percentage threshold > value at query level > # Lens will still have look ahead capability of daily being incomplete, then > it will union with hourly. > # If same measure is there in two different facts , Lens will we pick the one > with higher availability. > # In case of completeness percentage threshold missed, Lens will respond back > with available percentage. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1340) Adding API for data completeness checker
[ https://issues.apache.org/jira/browse/LENS-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15561591#comment-15561591 ] Narayan Periwal commented on LENS-1340: --- Thanks [~prongs] > Adding API for data completeness checker > > > Key: LENS-1340 > URL: https://issues.apache.org/jira/browse/LENS-1340 > Project: Apache Lens > Issue Type: Sub-task > Components: cube >Reporter: Narayan Periwal >Assignee: Narayan Periwal > Fix For: 2.7 > > Attachments: LENS-1340-v2.patch, LENS-1340.patch > > > The data completeness API will take the factTag, startDate, endDate and > measure's list as input. > It will return the completeness percentage for each of the measures for the > given factTag and time range. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1340) Adding API for data completeness checker
[ https://issues.apache.org/jira/browse/LENS-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajat Khandelwal updated LENS-1340: --- Resolution: Fixed Status: Resolved (was: Patch Available) > Adding API for data completeness checker > > > Key: LENS-1340 > URL: https://issues.apache.org/jira/browse/LENS-1340 > Project: Apache Lens > Issue Type: Sub-task > Components: cube >Reporter: Narayan Periwal >Assignee: Narayan Periwal > Fix For: 2.7 > > Attachments: LENS-1340-v2.patch, LENS-1340.patch > > > The data completeness API will take the factTag, startDate, endDate and > measure's list as input. > It will return the completeness percentage for each of the measures for the > given factTag and time range. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1340) Adding API for data completeness checker
[ https://issues.apache.org/jira/browse/LENS-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15561586#comment-15561586 ] Rajat Khandelwal commented on LENS-1340: Committed. Thanks [~nperiwal] > Adding API for data completeness checker > > > Key: LENS-1340 > URL: https://issues.apache.org/jira/browse/LENS-1340 > Project: Apache Lens > Issue Type: Sub-task > Components: cube >Reporter: Narayan Periwal >Assignee: Narayan Periwal > Fix For: 2.7 > > Attachments: LENS-1340-v2.patch, LENS-1340.patch > > > The data completeness API will take the factTag, startDate, endDate and > measure's list as input. > It will return the completeness percentage for each of the measures for the > given factTag and time range. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (LENS-1353) Write HiveDriver retry policy to recover queries lost due to hive server restart
Rajat Khandelwal created LENS-1353: -- Summary: Write HiveDriver retry policy to recover queries lost due to hive server restart Key: LENS-1353 URL: https://issues.apache.org/jira/browse/LENS-1353 Project: Apache Lens Issue Type: Task Reporter: Rajat Khandelwal Assignee: Lavkesh Lahngir -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (LENS-1352) Write JDBC driver Retry policy to recover queries lost after lens restart
Rajat Khandelwal created LENS-1352: -- Summary: Write JDBC driver Retry policy to recover queries lost after lens restart Key: LENS-1352 URL: https://issues.apache.org/jira/browse/LENS-1352 Project: Apache Lens Issue Type: Task Reporter: Rajat Khandelwal Assignee: Lavkesh Lahngir -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (LENS-1351) Refactor QueryExecutionServiceImpl class to make file size smaller.
Rajat Khandelwal created LENS-1351: -- Summary: Refactor QueryExecutionServiceImpl class to make file size smaller. Key: LENS-1351 URL: https://issues.apache.org/jira/browse/LENS-1351 Project: Apache Lens Issue Type: Task Components: server Reporter: Rajat Khandelwal Post this, also reduce the max file size number at https://github.com/apache/lens/blob/master/checkstyle/src/main/resources/checkstyle.xml#L65 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Review Request 52514: Add data completeness checker
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52514/ --- (Updated Oct. 10, 2016, 7:45 a.m.) Review request for lens. Bugs: LENS-1333 https://issues.apache.org/jira/browse/LENS-1333 Repository: lens Description --- Though lens has partition registration being done whenever data is available, there is no guarantee the partition registered is complete. There can be different ways to know if the data is complete for partition. One option could be to have a partition property saying whether it is complete or not. Other could be to do a http call to another hosted service and more. Proposal here is to add an interface for DataCompletenessChecker and do the check while resolving partitions. Here are some of the capabilities we would like to add in Lens : # Lens will check partition existence first, if it exists, then check the completeness percentage. If the completeness percentage is less than a configured threshold (default should be 98, 99 or even 100), Lens will fail the query. # Lens's accept query on partial data will accept on incomplete data as well. # Lens will also option to override the completeness percentage threshold value at query level # Lens will still have look ahead capability of daily being incomplete, then it will union with hourly. # If same measure is there in two different facts , Lens will we pick the one with higher availability. # In case of completeness percentage threshold missed, Lens will respond back with available percentage. Diffs (updated) - lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java fb958c3 lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 4585ef7 lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 01265a5 lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java 78fb21d lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java 49ed5ef lens-cube/src/main/java/org/apache/lens/cube/parse/DefaultChecker.java PRE-CREATION lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java 13f1aa4 lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java db26718 lens-cube/src/main/resources/olap-query-conf.xml 0c888ca lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java f7f8af2 lens-cube/src/test/java/org/apache/lens/cube/parse/DefaultCompletenessChecker.java PRE-CREATION lens-cube/src/test/java/org/apache/lens/cube/parse/FieldsCannotBeQueriedTogetherTest.java 7afa32e lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 6fb027a lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java b90d4d3 lens-server/src/main/resources/lenssession-default.xml b6bfa2e src/site/apt/admin/session-config.apt c4b3c04 src/site/apt/user/olap-query-conf.apt ce35ec4 Diff: https://reviews.apache.org/r/52514/diff/ Testing --- Thanks, Narayan Periwal
[jira] [Commented] (LENS-743) Query failure retries for transient errors
[ https://issues.apache.org/jira/browse/LENS-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15561557#comment-15561557 ] Rajat Khandelwal commented on LENS-743: --- About time! :) > Query failure retries for transient errors > -- > > Key: LENS-743 > URL: https://issues.apache.org/jira/browse/LENS-743 > Project: Apache Lens > Issue Type: Improvement > Components: server >Reporter: Amareshwari Sriramadasu >Assignee: Rajat Khandelwal > Labels: gsoc2016, java > Attachments: LENS-743.09.patch, LENS-743.11.patch, LENS-743.12.patch, > LENS-743.13.patch, LENS-743.14.patch, LENS-743.15.patch > > > There have to be retries for query failures for transient errors like network > errors (Hive server not reachable/ Metastore not reachable/ DB not > reachable). Retries should be available for each phase - submission, > execution, updating status, fetching results and formatting. > Right now, any such failure results in marking query as failed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-743) Query failure retries for transient errors
[ https://issues.apache.org/jira/browse/LENS-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15561547#comment-15561547 ] Hadoop QA commented on LENS-743: Applied patch: [LENS-743.15.patch|https://issues.apache.org/jira/secure/attachment/12832415/LENS-743.15.patch] and ran command: mvn clean install -fae. Result: Success. Build Job: https://builds.apache.org/job/PreCommit-Lens-Build/1035/ > Query failure retries for transient errors > -- > > Key: LENS-743 > URL: https://issues.apache.org/jira/browse/LENS-743 > Project: Apache Lens > Issue Type: Improvement > Components: server >Reporter: Amareshwari Sriramadasu >Assignee: Rajat Khandelwal > Labels: gsoc2016, java > Attachments: LENS-743.09.patch, LENS-743.11.patch, LENS-743.12.patch, > LENS-743.13.patch, LENS-743.14.patch, LENS-743.15.patch > > > There have to be retries for query failures for transient errors like network > errors (Hive server not reachable/ Metastore not reachable/ DB not > reachable). Retries should be available for each phase - submission, > execution, updating status, fetching results and formatting. > Right now, any such failure results in marking query as failed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1345) Deadlock in jdbc query status update
[ https://issues.apache.org/jira/browse/LENS-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15561530#comment-15561530 ] Hadoop QA commented on LENS-1345: - Applied patch: [LENS-1345.07.patch|https://issues.apache.org/jira/secure/attachment/12832317/LENS-1345.07.patch] and ran command: mvn clean install -fae. Result: Failure. Build Job: https://builds.apache.org/job/PreCommit-Lens-Build/1033/ > Deadlock in jdbc query status update > > > Key: LENS-1345 > URL: https://issues.apache.org/jira/browse/LENS-1345 > Project: Apache Lens > Issue Type: Bug >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Attachments: LENS-1345.02.patch, LENS-1345.04.patch, > LENS-1345.05.patch, LENS-1345.06.patch, LENS-1345.07.patch > > > JDBC query is launched in a thread. On query finish, the thread calls back > the query service to update status, which creates a FinishedQuery instance. > In the constructor, FinishedQuery is fetching result from the jdbc driver, > which waits on the original thread to complete. Basically the thread is > waiting for itself. > In the callback, query context is acquired by the thread, and can't be > acquired again. Which means that get calls for this query won't return and > will stay blocked. This can end up blocking all the grizzly threads. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1345) Deadlock in jdbc query status update
[ https://issues.apache.org/jira/browse/LENS-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15561525#comment-15561525 ] Hadoop QA commented on LENS-1345: - Applied patch: [LENS-1345.07.patch|https://issues.apache.org/jira/secure/attachment/12832317/LENS-1345.07.patch] and ran command: mvn clean install -fae. Result: Failure. Build Job: https://builds.apache.org/job/PreCommit-Lens-Build/1031/ > Deadlock in jdbc query status update > > > Key: LENS-1345 > URL: https://issues.apache.org/jira/browse/LENS-1345 > Project: Apache Lens > Issue Type: Bug >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Attachments: LENS-1345.02.patch, LENS-1345.04.patch, > LENS-1345.05.patch, LENS-1345.06.patch, LENS-1345.07.patch > > > JDBC query is launched in a thread. On query finish, the thread calls back > the query service to update status, which creates a FinishedQuery instance. > In the constructor, FinishedQuery is fetching result from the jdbc driver, > which waits on the original thread to complete. Basically the thread is > waiting for itself. > In the callback, query context is acquired by the thread, and can't be > acquired again. Which means that get calls for this query won't return and > will stay blocked. This can end up blocking all the grizzly threads. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1345) Deadlock in jdbc query status update
[ https://issues.apache.org/jira/browse/LENS-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15561522#comment-15561522 ] Hadoop QA commented on LENS-1345: - Applied patch: [LENS-1345.07.patch|https://issues.apache.org/jira/secure/attachment/12832317/LENS-1345.07.patch] and ran command: mvn clean install -fae. Result: Failure. Build Job: https://builds.apache.org/job/PreCommit-Lens-Build/1032/ > Deadlock in jdbc query status update > > > Key: LENS-1345 > URL: https://issues.apache.org/jira/browse/LENS-1345 > Project: Apache Lens > Issue Type: Bug >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Attachments: LENS-1345.02.patch, LENS-1345.04.patch, > LENS-1345.05.patch, LENS-1345.06.patch, LENS-1345.07.patch > > > JDBC query is launched in a thread. On query finish, the thread calls back > the query service to update status, which creates a FinishedQuery instance. > In the constructor, FinishedQuery is fetching result from the jdbc driver, > which waits on the original thread to complete. Basically the thread is > waiting for itself. > In the callback, query context is acquired by the thread, and can't be > acquired again. Which means that get calls for this query won't return and > will stay blocked. This can end up blocking all the grizzly threads. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-743) Query failure retries for transient errors
[ https://issues.apache.org/jira/browse/LENS-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15561515#comment-15561515 ] Hadoop QA commented on LENS-743: Applied patch: [LENS-743.15.patch|https://issues.apache.org/jira/secure/attachment/12832415/LENS-743.15.patch] and ran command: mvn clean install -fae. Result: Failure. Build Job: https://builds.apache.org/job/PreCommit-Lens-Build/1036/ > Query failure retries for transient errors > -- > > Key: LENS-743 > URL: https://issues.apache.org/jira/browse/LENS-743 > Project: Apache Lens > Issue Type: Improvement > Components: server >Reporter: Amareshwari Sriramadasu >Assignee: Rajat Khandelwal > Labels: gsoc2016, java > Attachments: LENS-743.09.patch, LENS-743.11.patch, LENS-743.12.patch, > LENS-743.13.patch, LENS-743.14.patch, LENS-743.15.patch > > > There have to be retries for query failures for transient errors like network > errors (Hive server not reachable/ Metastore not reachable/ DB not > reachable). Retries should be available for each phase - submission, > execution, updating status, fetching results and formatting. > Right now, any such failure results in marking query as failed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1345) Deadlock in jdbc query status update
[ https://issues.apache.org/jira/browse/LENS-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15561505#comment-15561505 ] Hadoop QA commented on LENS-1345: - Applied patch: [LENS-1345.07.patch|https://issues.apache.org/jira/secure/attachment/12832317/LENS-1345.07.patch] and ran command: mvn clean install -fae. Result: Failure. Build Job: https://builds.apache.org/job/PreCommit-Lens-Build/1030/ > Deadlock in jdbc query status update > > > Key: LENS-1345 > URL: https://issues.apache.org/jira/browse/LENS-1345 > Project: Apache Lens > Issue Type: Bug >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Attachments: LENS-1345.02.patch, LENS-1345.04.patch, > LENS-1345.05.patch, LENS-1345.06.patch, LENS-1345.07.patch > > > JDBC query is launched in a thread. On query finish, the thread calls back > the query service to update status, which creates a FinishedQuery instance. > In the constructor, FinishedQuery is fetching result from the jdbc driver, > which waits on the original thread to complete. Basically the thread is > waiting for itself. > In the callback, query context is acquired by the thread, and can't be > acquired again. Which means that get calls for this query won't return and > will stay blocked. This can end up blocking all the grizzly threads. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-743) Query failure retries for transient errors
[ https://issues.apache.org/jira/browse/LENS-743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajat Khandelwal updated LENS-743: -- Attachment: LENS-743.15.patch > Query failure retries for transient errors > -- > > Key: LENS-743 > URL: https://issues.apache.org/jira/browse/LENS-743 > Project: Apache Lens > Issue Type: Improvement > Components: server >Reporter: Amareshwari Sriramadasu >Assignee: Rajat Khandelwal > Labels: gsoc2016, java > Attachments: LENS-743.09.patch, LENS-743.11.patch, LENS-743.12.patch, > LENS-743.13.patch, LENS-743.14.patch, LENS-743.15.patch > > > There have to be retries for query failures for transient errors like network > errors (Hive server not reachable/ Metastore not reachable/ DB not > reachable). Retries should be available for each phase - submission, > execution, updating status, fetching results and formatting. > Right now, any such failure results in marking query as failed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-743) Query failure retries for transient errors
[ https://issues.apache.org/jira/browse/LENS-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15561471#comment-15561471 ] Rajat Khandelwal commented on LENS-743: --- Taking patch from reviewboard and attaching > Query failure retries for transient errors > -- > > Key: LENS-743 > URL: https://issues.apache.org/jira/browse/LENS-743 > Project: Apache Lens > Issue Type: Improvement > Components: server >Reporter: Amareshwari Sriramadasu >Assignee: Rajat Khandelwal > Labels: gsoc2016, java > Attachments: LENS-743.09.patch, LENS-743.11.patch, LENS-743.12.patch, > LENS-743.13.patch, LENS-743.14.patch, LENS-743.15.patch > > > There have to be retries for query failures for transient errors like network > errors (Hive server not reachable/ Metastore not reachable/ DB not > reachable). Retries should be available for each phase - submission, > execution, updating status, fetching results and formatting. > Right now, any such failure results in marking query as failed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Review Request 52088: LENS-743: Query failure retries for transient errors
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52088/ --- (Updated Oct. 10, 2016, 12:14 p.m.) Review request for lens. Bugs: LENS-743 https://issues.apache.org/jira/browse/LENS-743 Repository: lens Description --- There have to be retries for query failures for transient errors like network errors (Hive server not reachable/ Metastore not reachable/ DB not reachable). Retries should be available for each phase - submission, execution, updating status, fetching results and formatting. Right now, any such failure results in marking query as failed. Diffs (updated) - checkstyle/src/main/resources/checkstyle.xml 17e55ea1071c06c73e8bf387cd69acca83bc lens-api/src/main/java/org/apache/lens/api/query/FailedAttempt.java PRE-CREATION lens-api/src/main/java/org/apache/lens/api/query/LensQuery.java 7d079a9ed99e3d4940d5f26370547683a6bba465 lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java daedbf9ea387cbde3ef39363c2beef3f96725223 lens-api/src/test/java/org/apache/lens/api/jaxb/YAMLToStringStrategyTest.java 04d9ad6dee942c705b0cdf071f49f1305696da65 lens-api/src/test/resources/toString/org.apache.lens.api.query.LensQuery.xml a681bca7fd6e46fe992901e04e025a8a3106 lens-api/src/test/resources/toString/org.apache.lens.api.query.QueryStatus.xml 70f9c932efc090095273566eaa52d380a2f23842 lens-driver-es/src/main/java/org/apache/lens/driver/es/ESDriver.java fceabeae9217676774a6978212cbc9ee9ca120f7 lens-driver-es/src/test/resources/hive-site.xml e49c876289d5352203d2523ddb9134d745c197e5 lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 0d8810f6b7dfd9fb0173a4be6966f1a561107066 lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java daf01ac64616da72ee55c00f71c2c0aa33651ee4 lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 1acbb13c3a24c0e7b41d799db0d307c5acfa8c6b lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java f805ec6ebccd18de3bfcd0f1ab8626f7330dd6f1 lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java 3c34eb191966dff3ac3032eb79282336b5c6789b lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/MaxJDBCConnectionCheckConstraint.java 82b56470e2de09f7c41d1226ea59cffdd8d26a26 lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java 6e9086f9e8dc302ad2171d7f5636a24cb79dcb50 lens-regression/src/main/java/org/apache/lens/regression/core/constants/DriverConfig.java d80fba9aee91130b69a2a511d7f157c01a261ac4 lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 8cf617b7181b9a305ea2c68f68c610f823ee75d7 lens-server-api/src/main/java/org/apache/lens/server/api/common/BackOffRetryHandler.java 17bfba02244bca7141268ed12e4a41400e2bec82 lens-server-api/src/main/java/org/apache/lens/server/api/common/FailureContext.java 70a34b0c0517ed3b7af46120906fb77ae57870ac lens-server-api/src/main/java/org/apache/lens/server/api/common/FibonacciExponentialBackOffRetryHandler.java e7fb8ce0194803317aaa0e1c5f4e3e0fb6bbca8c lens-server-api/src/main/java/org/apache/lens/server/api/common/OperationRetryHandlerFactory.java 88fbe43318315394873cabb9f5dd39f09f6c47f4 lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java e4984798751d012f0a9d01980df833c206155546 lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverConfiguration.java PRE-CREATION lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java 033f6777b4be7a1b6d6cdc350e42a94ade1acbca lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java e472de0a452ffbbcb217503c260aa26fe7f6ed99 lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java e160f58bfb45cffb05b9f6be19db3bc7605dde57 lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 5ff59bd0da713651a7cc5261dbd18cd88e91fc76 lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java b58fcf964cedb8dc302099ae9c806b06acafa2d3 lens-server-api/src/main/java/org/apache/lens/server/api/query/PriorityChange.java eaf3fee953e1efbcf151fc844a9441b74b84cc3e lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryAccepted.java 8980b619c9feb86be326bf799fecc35c1579c763 lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryCancelled.java a473a47606df84e2b5b204478ad63e63e69b0c23 lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryClosed.java 3837087db6e51c1606573511bfc02b6108d1ef3d lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
[jira] [Commented] (LENS-743) Query failure retries for transient errors
[ https://issues.apache.org/jira/browse/LENS-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15561455#comment-15561455 ] Hadoop QA commented on LENS-743: Applied patch: [LENS-743.14.patch|https://issues.apache.org/jira/secure/attachment/12832411/LENS-743.14.patch] and ran command: mvn clean install -fae. Result: Failure. Build Job: https://builds.apache.org/job/PreCommit-Lens-Build/1029/ > Query failure retries for transient errors > -- > > Key: LENS-743 > URL: https://issues.apache.org/jira/browse/LENS-743 > Project: Apache Lens > Issue Type: Improvement > Components: server >Reporter: Amareshwari Sriramadasu >Assignee: Rajat Khandelwal > Labels: gsoc2016, java > Attachments: LENS-743.09.patch, LENS-743.11.patch, LENS-743.12.patch, > LENS-743.13.patch, LENS-743.14.patch > > > There have to be retries for query failures for transient errors like network > errors (Hive server not reachable/ Metastore not reachable/ DB not > reachable). Retries should be available for each phase - submission, > execution, updating status, fetching results and formatting. > Right now, any such failure results in marking query as failed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1285) Adding unit tests for scheduler API
[ https://issues.apache.org/jira/browse/LENS-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15561444#comment-15561444 ] Rajat Khandelwal commented on LENS-1285: In the last 3 test failures, I see that org.apache.lens.server.healthcheck.TestHealthChecks.testCubeMetastoreServiceHealth is common. Can you check whether it's caused by your patch? > Adding unit tests for scheduler API > --- > > Key: LENS-1285 > URL: https://issues.apache.org/jira/browse/LENS-1285 > Project: Apache Lens > Issue Type: Test >Reporter: Lavkesh Lahngir >Assignee: Lavkesh Lahngir > Attachments: 0001-Api-tests.patch, 0001-Resource-tests.patch, > Scheduler-API-tests.patch, Scheduler-API-tests.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
