Re: Review Request 51964: LENS-317: Server side calls for updating database jars

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51964/#review152818
---




lens-cli/src/main/java/org/apache/lens/cli/commands/LensDatabaseCommands.java 
(line 134)


How are we handling HDFS path ? are we downloading this jar to local 
machine (hosting the cli) and then uploading to server ?



lens-client/src/main/java/org/apache/lens/client/LensConnection.java (lines 393 
- 396)


How do we handle non jar type resources both on client and on server ?



lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java
 (line 738)


Should we have logs statements at the start and end of this method as its 
syncronized so that we know why the other addjar call is waiting (if that 
situation ever arises)



lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java
 (line 760)


Do we need to update 
org.apache.lens.server.session.DatabaseResourceService#dbResEntryMap with entry 
in this case?



lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java
 (lines 762 - 764)


How is addJar updating 
org.apache.lens.server.session.DatabaseResourceService#classLoaderCache  with 
calssloader pointing to the newly uploaded jar? Will the new jar be refletced 
in exsitin session calss loader as well ?



lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java
 (lines 792 - 795)


Should we fail in this case or create the directory and add the jar? I 
feel, the use case where a user creates a new DB from lens CLI and then uploads 
a jar should work without admin intervention.



lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java
 (line 801)


Should we show a different message to user which says 
"This database {dbname} does not support jar upload"

The warning message can still have details that jar_oder file is present 
and hence upload is not allowed



lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java
 (lines 808 - 812)


Theoratically this case should not arive since the method is syncronized. 
If this does occur, it can be because server was resttarted while a jar was 
still uploading or rename opertaion failed. In this case(s) we should overwrite 
the jar with a warning message. 
Please check once.



lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java
 (lines 815 - 827)


should we move this logic to a utility and use it for both 
DatabaseResourceService and CubeMetastoreServiceImpl ?



lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java
 (line 829)


This seems same as "uploadingPath"



lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java
 (line 834)


Can we resuse "dbDir" in all paces where DB path is required



lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java
 (lines 840 - 845)


Should we club the two exceptions (catch with multiple exceptions) and just 
say "Execption while uploading jar". The stack trace will have the exception 
type and details anyway. 
Or we can even have smaller try blocks and print the exact execption 
message (Say a try block around IOUtils.copy(is, fos) and the catch says 
execption wile copying jar)



lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java
 (line 1397)


Are two commands required for Hive ?



lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java
 (lines 1566 - 1567)


fileDetail needs to me added too ?



lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java
 (line 1576)


can only JARs be added as resources ? If yes then should we rename the 
method to include jar



lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java
 (line 1581)


This file size is passed 

Re: Review Request 52924: LENS-1359: Add driver hooks for user based filtering of queries

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52924/#review152869
---




lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/PriorityBasedQueryHook.java
 (line 42)


This needs to be done based on cost in post estimate.


- Puneet Gupta


On Oct. 17, 2016, 12:08 p.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52924/
> ---
> 
> (Updated Oct. 17, 2016, 12:08 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1359
> https://issues.apache.org/jira/browse/LENS-1359
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   lens-driver-hive/src/main/resources/hivedriver-default.xml 
> f5fd3bb20b9d6b82292c4483d860ea14c8104c5c 
>   
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java
>  43b33f331f4d9017d76bccbe0f6936aaeb184f8f 
>   
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java
>  961ec4ec781d3d7fd0f28edc4f23e9b39549592f 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  3ae59c6ca126f0a3535974352adf97e7a495838f 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java
>  8f30aa06ab234cedb53acb17544210ba4190ab53 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverConfiguration.java
>  69a1a0b7ce57c24602a17ea7c97c0664a77c6568 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryHook.java
>  f8a9ee07d8c8b737a41de339ab44ca7752c90748 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java
>  146223942d05cfd952599297144e2a6bc02df273 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/NoOpDriverQueryHook.java
>  4f1f2eb99ed0bec8e6e471a9723a6b002a092202 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/ChainedDriverQueryHook.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/DriverQueryHook.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/NoOpDriverQueryHook.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/PriorityBasedQueryHook.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHook.java
>  PRE-CREATION 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/DriverConfigurationTest.java
>  PRE-CREATION 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/ChainedDriverQueryHookTest.java
>  PRE-CREATION 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/PriorityBasedQueryHookTest.java
>  PRE-CREATION 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHookTest.java
>  PRE-CREATION 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/user/MockDriverQueryHook.java
>  f70979abf7c44d3b4ed3588628de5a7517adfa81 
>   src/site/apt/admin/hivedriver-config.apt 
> b1a25c3b5bb58fc2d0773dc168c110ee5e60c635 
> 
> Diff: https://reviews.apache.org/r/52924/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

[jira] [Commented] (LENS-1359) Add driver hooks for user based filtering of queries

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15582188#comment-15582188
 ] 

Hadoop QA commented on LENS-1359:
-

Applied patch: 
[LENS-1359.05.patch|https://issues.apache.org/jira/secure/attachment/12833722/LENS-1359.05.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1091/

> Add driver hooks for user based filtering of queries
> 
>
> Key: LENS-1359
> URL: https://issues.apache.org/jira/browse/LENS-1359
> Project: Apache Lens
>  Issue Type: Task
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1359.01.patch, LENS-1359.02.patch, 
> LENS-1359.03.patch, LENS-1359.04.patch, LENS-1359.05.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1360) org.apache.lens.driver.jdbc.TestJdbcDriver#testCancelQuery failing in pre-commit

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15582042#comment-15582042
 ] 

Hadoop QA commented on LENS-1360:
-

Applied patch: 
[LENS-1360.02.patch|https://issues.apache.org/jira/secure/attachment/12833716/LENS-1360.02.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1089/

> org.apache.lens.driver.jdbc.TestJdbcDriver#testCancelQuery failing in 
> pre-commit 
> -
>
> Key: LENS-1360
> URL: https://issues.apache.org/jira/browse/LENS-1360
> Project: Apache Lens
>  Issue Type: Task
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1360.02.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1359) Add driver hooks for user based filtering of queries

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15582061#comment-15582061
 ] 

Hadoop QA commented on LENS-1359:
-

Applied patch: 
[LENS-1359.03.patch|https://issues.apache.org/jira/secure/attachment/12833714/LENS-1359.03.patch]
 and ran command: mvn clean install -fae. Result: Success. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1088/

> Add driver hooks for user based filtering of queries
> 
>
> Key: LENS-1359
> URL: https://issues.apache.org/jira/browse/LENS-1359
> Project: Apache Lens
>  Issue Type: Task
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1359.01.patch, LENS-1359.02.patch, 
> LENS-1359.03.patch, LENS-1359.04.patch, LENS-1359.05.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1359) Add driver hooks for user based filtering of queries

[Rajat Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-1359:
---
Attachment: LENS-1359.05.patch

> Add driver hooks for user based filtering of queries
> 
>
> Key: LENS-1359
> URL: https://issues.apache.org/jira/browse/LENS-1359
> Project: Apache Lens
>  Issue Type: Task
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1359.01.patch, LENS-1359.02.patch, 
> LENS-1359.03.patch, LENS-1359.04.patch, LENS-1359.05.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1359) Add driver hooks for user based filtering of queries

[Rajat Khandelwal (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15582057#comment-15582057
 ] 

Rajat Khandelwal commented on LENS-1359:


Taking patch from reviewboard and attaching

> Add driver hooks for user based filtering of queries
> 
>
> Key: LENS-1359
> URL: https://issues.apache.org/jira/browse/LENS-1359
> Project: Apache Lens
>  Issue Type: Task
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1359.01.patch, LENS-1359.02.patch, 
> LENS-1359.03.patch, LENS-1359.04.patch, LENS-1359.05.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 52924: LENS-1359: Add driver hooks for user based filtering of queries

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52924/
---

(Updated Oct. 17, 2016, 5:38 p.m.)


Review request for lens.


Bugs: LENS-1359
https://issues.apache.org/jira/browse/LENS-1359


Repository: lens


Description
---


Diffs (updated)
-

  lens-driver-hive/src/main/resources/hivedriver-default.xml 
f5fd3bb20b9d6b82292c4483d860ea14c8104c5c 
  
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 
43b33f331f4d9017d76bccbe0f6936aaeb184f8f 
  
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java
 961ec4ec781d3d7fd0f28edc4f23e9b39549592f 
  
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 
3ae59c6ca126f0a3535974352adf97e7a495838f 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java
 8f30aa06ab234cedb53acb17544210ba4190ab53 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverConfiguration.java
 69a1a0b7ce57c24602a17ea7c97c0664a77c6568 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryHook.java
 f8a9ee07d8c8b737a41de339ab44ca7752c90748 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 
146223942d05cfd952599297144e2a6bc02df273 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/NoOpDriverQueryHook.java
 4f1f2eb99ed0bec8e6e471a9723a6b002a092202 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/ChainedDriverQueryHook.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/DriverQueryHook.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/NoOpDriverQueryHook.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/PriorityBasedQueryHook.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHook.java
 PRE-CREATION 
  
lens-server-api/src/test/java/org/apache/lens/server/api/driver/DriverConfigurationTest.java
 PRE-CREATION 
  
lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/ChainedDriverQueryHookTest.java
 PRE-CREATION 
  
lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/PriorityBasedQueryHookTest.java
 PRE-CREATION 
  
lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHookTest.java
 PRE-CREATION 
  
lens-server-api/src/test/java/org/apache/lens/server/api/user/MockDriverQueryHook.java
 f70979abf7c44d3b4ed3588628de5a7517adfa81 
  src/site/apt/admin/hivedriver-config.apt 
b1a25c3b5bb58fc2d0773dc168c110ee5e60c635 

Diff: https://reviews.apache.org/r/52924/diff/


Testing
---


Thanks,

Rajat Khandelwal

[jira] [Commented] (LENS-1359) Add driver hooks for user based filtering of queries

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15582030#comment-15582030
 ] 

Hadoop QA commented on LENS-1359:
-

Applied patch: 
[LENS-1359.04.patch|https://issues.apache.org/jira/secure/attachment/12833720/LENS-1359.04.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1090/

> Add driver hooks for user based filtering of queries
> 
>
> Key: LENS-1359
> URL: https://issues.apache.org/jira/browse/LENS-1359
> Project: Apache Lens
>  Issue Type: Task
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1359.01.patch, LENS-1359.02.patch, 
> LENS-1359.03.patch, LENS-1359.04.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1360) org.apache.lens.driver.jdbc.TestJdbcDriver#testCancelQuery failing in pre-commit

[Rajat Khandelwal (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15582012#comment-15582012
 ] 

Rajat Khandelwal commented on LENS-1360:


Review at https://reviews.apache.org/r/52926/

> org.apache.lens.driver.jdbc.TestJdbcDriver#testCancelQuery failing in 
> pre-commit 
> -
>
> Key: LENS-1360
> URL: https://issues.apache.org/jira/browse/LENS-1360
> Project: Apache Lens
>  Issue Type: Task
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1360.02.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1359) Add driver hooks for user based filtering of queries

[Rajat Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-1359:
---
Attachment: LENS-1359.04.patch

> Add driver hooks for user based filtering of queries
> 
>
> Key: LENS-1359
> URL: https://issues.apache.org/jira/browse/LENS-1359
> Project: Apache Lens
>  Issue Type: Task
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1359.01.patch, LENS-1359.02.patch, 
> LENS-1359.03.patch, LENS-1359.04.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1359) Add driver hooks for user based filtering of queries

[Rajat Khandelwal (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15582015#comment-15582015
 ] 

Rajat Khandelwal commented on LENS-1359:


Taking patch from reviewboard and attaching

> Add driver hooks for user based filtering of queries
> 
>
> Key: LENS-1359
> URL: https://issues.apache.org/jira/browse/LENS-1359
> Project: Apache Lens
>  Issue Type: Task
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1359.01.patch, LENS-1359.02.patch, 
> LENS-1359.03.patch, LENS-1359.04.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 52924: LENS-1359: Add driver hooks for user based filtering of queries

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52924/
---

(Updated Oct. 17, 2016, 5:23 p.m.)


Review request for lens.


Bugs: LENS-1359
https://issues.apache.org/jira/browse/LENS-1359


Repository: lens


Description
---


Diffs (updated)
-

  lens-driver-hive/src/main/resources/hivedriver-default.xml 
f5fd3bb20b9d6b82292c4483d860ea14c8104c5c 
  
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 
43b33f331f4d9017d76bccbe0f6936aaeb184f8f 
  
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java
 961ec4ec781d3d7fd0f28edc4f23e9b39549592f 
  
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 
3ae59c6ca126f0a3535974352adf97e7a495838f 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java
 8f30aa06ab234cedb53acb17544210ba4190ab53 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverConfiguration.java
 69a1a0b7ce57c24602a17ea7c97c0664a77c6568 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryHook.java
 f8a9ee07d8c8b737a41de339ab44ca7752c90748 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 
146223942d05cfd952599297144e2a6bc02df273 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/NoOpDriverQueryHook.java
 4f1f2eb99ed0bec8e6e471a9723a6b002a092202 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/ChainedDriverQueryHook.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/DriverQueryHook.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/NoOpDriverQueryHook.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/PriorityBasedQueryHook.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHook.java
 PRE-CREATION 
  
lens-server-api/src/test/java/org/apache/lens/server/api/driver/DriverConfigurationTest.java
 PRE-CREATION 
  
lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/ChainedDriverQueryHookTest.java
 PRE-CREATION 
  
lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/PriorityBasedQueryHookTest.java
 PRE-CREATION 
  
lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHookTest.java
 PRE-CREATION 
  
lens-server-api/src/test/java/org/apache/lens/server/api/user/MockDriverQueryHook.java
 f70979abf7c44d3b4ed3588628de5a7517adfa81 
  src/site/apt/admin/hivedriver-config.apt 
b1a25c3b5bb58fc2d0773dc168c110ee5e60c635 

Diff: https://reviews.apache.org/r/52924/diff/


Testing
---


Thanks,

Rajat Khandelwal

[jira] [Commented] (LENS-1360) org.apache.lens.driver.jdbc.TestJdbcDriver#testCancelQuery failing in pre-commit

[Rajat Khandelwal (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15581923#comment-15581923
 ] 

Rajat Khandelwal commented on LENS-1360:


Taking patch from reviewboard and attaching

> org.apache.lens.driver.jdbc.TestJdbcDriver#testCancelQuery failing in 
> pre-commit 
> -
>
> Key: LENS-1360
> URL: https://issues.apache.org/jira/browse/LENS-1360
> Project: Apache Lens
>  Issue Type: Task
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1360.02.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1360) org.apache.lens.driver.jdbc.TestJdbcDriver#testCancelQuery failing in pre-commit

[Rajat Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-1360:
---
Status: Patch Available  (was: In Progress)

> org.apache.lens.driver.jdbc.TestJdbcDriver#testCancelQuery failing in 
> pre-commit 
> -
>
> Key: LENS-1360
> URL: https://issues.apache.org/jira/browse/LENS-1360
> Project: Apache Lens
>  Issue Type: Task
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1360.02.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1360) org.apache.lens.driver.jdbc.TestJdbcDriver#testCancelQuery failing in pre-commit

[Rajat Khandelwal (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15581922#comment-15581922
 ] 

Rajat Khandelwal commented on LENS-1360:


Taking patch from reviewboard and attaching

> org.apache.lens.driver.jdbc.TestJdbcDriver#testCancelQuery failing in 
> pre-commit 
> -
>
> Key: LENS-1360
> URL: https://issues.apache.org/jira/browse/LENS-1360
> Project: Apache Lens
>  Issue Type: Task
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1360.02.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1360) org.apache.lens.driver.jdbc.TestJdbcDriver#testCancelQuery failing in pre-commit

[Rajat Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-1360:
---
Attachment: LENS-1360.02.patch

> org.apache.lens.driver.jdbc.TestJdbcDriver#testCancelQuery failing in 
> pre-commit 
> -
>
> Key: LENS-1360
> URL: https://issues.apache.org/jira/browse/LENS-1360
> Project: Apache Lens
>  Issue Type: Task
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1360.02.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 52926: LENS-1360: org.apache.lens.driver.jdbc.TestJdbcDriver#testCancelQuery failing in pre-commit

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52926/
---

(Updated Oct. 17, 2016, 4:39 p.m.)


Review request for lens.


Bugs: LENS-1360
https://issues.apache.org/jira/browse/LENS-1360


Repository: lens


Description
---


Diffs (updated)
-

  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 
82e023146c0290b5a1e0146a550b6f7a55e7e1b2 
  
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java 
a402f91832bbb7340dfe1ec271f7eee36ce6d758 
  lens-driver-jdbc/src/test/resources/logback.xml PRE-CREATION 

Diff: https://reviews.apache.org/r/52926/diff/


Testing
---


Thanks,

Rajat Khandelwal

[jira] [Work started] (LENS-1360) org.apache.lens.driver.jdbc.TestJdbcDriver#testCancelQuery failing in pre-commit

[Rajat Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on LENS-1360 started by Rajat Khandelwal.
--
> org.apache.lens.driver.jdbc.TestJdbcDriver#testCancelQuery failing in 
> pre-commit 
> -
>
> Key: LENS-1360
> URL: https://issues.apache.org/jira/browse/LENS-1360
> Project: Apache Lens
>  Issue Type: Task
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Review Request 52926: LENS-1360: org.apache.lens.driver.jdbc.TestJdbcDriver#testCancelQuery failing in pre-commit

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52926/
---

Review request for lens.


Bugs: LENS-1360
https://issues.apache.org/jira/browse/LENS-1360


Repository: lens


Description
---


Diffs
-

  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 
82e023146c0290b5a1e0146a550b6f7a55e7e1b2 
  
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java 
a402f91832bbb7340dfe1ec271f7eee36ce6d758 
  lens-driver-jdbc/src/test/resources/logback.xml PRE-CREATION 

Diff: https://reviews.apache.org/r/52926/diff/


Testing
---


Thanks,

Rajat Khandelwal

Review Request 52925: LENS-1360: org.apache.lens.driver.jdbc.TestJdbcDriver#testCancelQuery failing in pre-commit

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52925/
---

Review request for lens.


Bugs: LENS-1360
https://issues.apache.org/jira/browse/LENS-1360


Repository: lens


Description
---


Diffs
-

  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 
82e023146c0290b5a1e0146a550b6f7a55e7e1b2 
  
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java 
a402f91832bbb7340dfe1ec271f7eee36ce6d758 

Diff: https://reviews.apache.org/r/52925/diff/


Testing
---


Thanks,

Rajat Khandelwal

[jira] [Created] (LENS-1360) org.apache.lens.driver.jdbc.TestJdbcDriver#testCancelQuery failing in pre-commit

[Rajat Khandelwal (JIRA)]

Rajat Khandelwal created LENS-1360:
--

 Summary: 
org.apache.lens.driver.jdbc.TestJdbcDriver#testCancelQuery failing in 
pre-commit 
 Key: LENS-1360
 URL: https://issues.apache.org/jira/browse/LENS-1360
 Project: Apache Lens
  Issue Type: Task
Reporter: Rajat Khandelwal
Assignee: Rajat Khandelwal






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1359) Add driver hooks for user based filtering of queries

[Rajat Khandelwal (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15581884#comment-15581884
 ] 

Rajat Khandelwal commented on LENS-1359:


Taking patch from reviewboard and attaching

> Add driver hooks for user based filtering of queries
> 
>
> Key: LENS-1359
> URL: https://issues.apache.org/jira/browse/LENS-1359
> Project: Apache Lens
>  Issue Type: Task
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1359.01.patch, LENS-1359.02.patch, 
> LENS-1359.03.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1359) Add driver hooks for user based filtering of queries

[Rajat Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-1359:
---
Attachment: LENS-1359.03.patch

> Add driver hooks for user based filtering of queries
> 
>
> Key: LENS-1359
> URL: https://issues.apache.org/jira/browse/LENS-1359
> Project: Apache Lens
>  Issue Type: Task
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1359.01.patch, LENS-1359.02.patch, 
> LENS-1359.03.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 52924: LENS-1359: Add driver hooks for user based filtering of queries

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52924/
---

(Updated Oct. 17, 2016, 4:22 p.m.)


Review request for lens.


Bugs: LENS-1359
https://issues.apache.org/jira/browse/LENS-1359


Repository: lens


Description
---


Diffs (updated)
-

  lens-driver-hive/src/main/resources/hivedriver-default.xml 
f5fd3bb20b9d6b82292c4483d860ea14c8104c5c 
  
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 
43b33f331f4d9017d76bccbe0f6936aaeb184f8f 
  
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java
 961ec4ec781d3d7fd0f28edc4f23e9b39549592f 
  
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 
3ae59c6ca126f0a3535974352adf97e7a495838f 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java
 8f30aa06ab234cedb53acb17544210ba4190ab53 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverConfiguration.java
 69a1a0b7ce57c24602a17ea7c97c0664a77c6568 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryHook.java
 f8a9ee07d8c8b737a41de339ab44ca7752c90748 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 
146223942d05cfd952599297144e2a6bc02df273 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/NoOpDriverQueryHook.java
 4f1f2eb99ed0bec8e6e471a9723a6b002a092202 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/ChainedDriverQueryHook.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/DriverQueryHook.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/NoOpDriverQueryHook.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHook.java
 PRE-CREATION 
  
lens-server-api/src/test/java/org/apache/lens/server/api/driver/DriverConfigurationTest.java
 PRE-CREATION 
  
lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHookTest.java
 PRE-CREATION 
  
lens-server-api/src/test/java/org/apache/lens/server/api/user/MockDriverQueryHook.java
 f70979abf7c44d3b4ed3588628de5a7517adfa81 
  src/site/apt/admin/hivedriver-config.apt 
b1a25c3b5bb58fc2d0773dc168c110ee5e60c635 

Diff: https://reviews.apache.org/r/52924/diff/


Testing
---


Thanks,

Rajat Khandelwal

Re: Review Request 52924: LENS-1359: Add driver hooks for user based filtering of queries

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52924/#review152845
---




lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/ChainedDriverQueryHook.java
 (line 38)


Can we add a  simple test case for this? To keep it simple we can use 
mutiple usser hooks in the chain and test pre rewrite.



lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHook.java
 (line 28)


Should we add class level documentation expaling when this will be useful ?



lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHook.java
 (lines 31 - 32)


Can we use a Set instead for faster search/conatins opeartion ?


- Puneet Gupta


On Oct. 17, 2016, 10:25 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52924/
> ---
> 
> (Updated Oct. 17, 2016, 10:25 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1359
> https://issues.apache.org/jira/browse/LENS-1359
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   lens-driver-hive/src/main/resources/hivedriver-default.xml 
> f5fd3bb20b9d6b82292c4483d860ea14c8104c5c 
>   
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java
>  43b33f331f4d9017d76bccbe0f6936aaeb184f8f 
>   
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java
>  961ec4ec781d3d7fd0f28edc4f23e9b39549592f 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  3ae59c6ca126f0a3535974352adf97e7a495838f 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java
>  8f30aa06ab234cedb53acb17544210ba4190ab53 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverConfiguration.java
>  69a1a0b7ce57c24602a17ea7c97c0664a77c6568 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryHook.java
>  f8a9ee07d8c8b737a41de339ab44ca7752c90748 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java
>  146223942d05cfd952599297144e2a6bc02df273 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/NoOpDriverQueryHook.java
>  4f1f2eb99ed0bec8e6e471a9723a6b002a092202 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/ChainedDriverQueryHook.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/DriverQueryHook.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/NoOpDriverQueryHook.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHook.java
>  PRE-CREATION 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/DriverConfigurationTest.java
>  PRE-CREATION 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHookTest.java
>  PRE-CREATION 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/user/MockDriverQueryHook.java
>  f70979abf7c44d3b4ed3588628de5a7517adfa81 
>   src/site/apt/admin/hivedriver-config.apt 
> b1a25c3b5bb58fc2d0773dc168c110ee5e60c635 
> 
> Diff: https://reviews.apache.org/r/52924/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

[jira] [Commented] (LENS-1359) Add driver hooks for user based filtering of queries

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15581843#comment-15581843
 ] 

Hadoop QA commented on LENS-1359:
-

Applied patch: 
[LENS-1359.02.patch|https://issues.apache.org/jira/secure/attachment/12833711/LENS-1359.02.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1087/

> Add driver hooks for user based filtering of queries
> 
>
> Key: LENS-1359
> URL: https://issues.apache.org/jira/browse/LENS-1359
> Project: Apache Lens
>  Issue Type: Task
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1359.01.patch, LENS-1359.02.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1359) Add driver hooks for user based filtering of queries

[Rajat Khandelwal (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15581838#comment-15581838
 ] 

Rajat Khandelwal commented on LENS-1359:


Taking patch from reviewboard and attaching

> Add driver hooks for user based filtering of queries
> 
>
> Key: LENS-1359
> URL: https://issues.apache.org/jira/browse/LENS-1359
> Project: Apache Lens
>  Issue Type: Task
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1359.01.patch, LENS-1359.02.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1359) Add driver hooks for user based filtering of queries

[Rajat Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-1359:
---
Attachment: LENS-1359.02.patch

> Add driver hooks for user based filtering of queries
> 
>
> Key: LENS-1359
> URL: https://issues.apache.org/jira/browse/LENS-1359
> Project: Apache Lens
>  Issue Type: Task
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1359.01.patch, LENS-1359.02.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 52924: LENS-1359: Add driver hooks for user based filtering of queries

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52924/
---

(Updated Oct. 17, 2016, 3:55 p.m.)


Review request for lens.


Bugs: LENS-1359
https://issues.apache.org/jira/browse/LENS-1359


Repository: lens


Description
---


Diffs (updated)
-

  lens-driver-hive/src/main/resources/hivedriver-default.xml 
f5fd3bb20b9d6b82292c4483d860ea14c8104c5c 
  
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 
43b33f331f4d9017d76bccbe0f6936aaeb184f8f 
  
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java
 961ec4ec781d3d7fd0f28edc4f23e9b39549592f 
  
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 
3ae59c6ca126f0a3535974352adf97e7a495838f 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java
 8f30aa06ab234cedb53acb17544210ba4190ab53 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverConfiguration.java
 69a1a0b7ce57c24602a17ea7c97c0664a77c6568 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryHook.java
 f8a9ee07d8c8b737a41de339ab44ca7752c90748 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 
146223942d05cfd952599297144e2a6bc02df273 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/NoOpDriverQueryHook.java
 4f1f2eb99ed0bec8e6e471a9723a6b002a092202 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/ChainedDriverQueryHook.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/DriverQueryHook.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/NoOpDriverQueryHook.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHook.java
 PRE-CREATION 
  
lens-server-api/src/test/java/org/apache/lens/server/api/driver/DriverConfigurationTest.java
 PRE-CREATION 
  
lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHookTest.java
 PRE-CREATION 
  
lens-server-api/src/test/java/org/apache/lens/server/api/user/MockDriverQueryHook.java
 f70979abf7c44d3b4ed3588628de5a7517adfa81 
  src/site/apt/admin/hivedriver-config.apt 
b1a25c3b5bb58fc2d0773dc168c110ee5e60c635 

Diff: https://reviews.apache.org/r/52924/diff/


Testing
---


Thanks,

Rajat Khandelwal

[jira] [Commented] (LENS-1359) Add driver hooks for user based filtering of queries

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15581821#comment-15581821
 ] 

Hadoop QA commented on LENS-1359:
-

Applied patch: 
[LENS-1359.01.patch|https://issues.apache.org/jira/secure/attachment/12833710/LENS-1359.01.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1086/

> Add driver hooks for user based filtering of queries
> 
>
> Key: LENS-1359
> URL: https://issues.apache.org/jira/browse/LENS-1359
> Project: Apache Lens
>  Issue Type: Task
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1359.01.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1359) Add driver hooks for user based filtering of queries

[Rajat Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-1359:
---
Attachment: LENS-1359.01.patch

> Add driver hooks for user based filtering of queries
> 
>
> Key: LENS-1359
> URL: https://issues.apache.org/jira/browse/LENS-1359
> Project: Apache Lens
>  Issue Type: Task
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1359.01.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1359) Add driver hooks for user based filtering of queries

[Rajat Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-1359:
---
Status: Patch Available  (was: In Progress)

> Add driver hooks for user based filtering of queries
> 
>
> Key: LENS-1359
> URL: https://issues.apache.org/jira/browse/LENS-1359
> Project: Apache Lens
>  Issue Type: Task
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1359.01.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1359) Add driver hooks for user based filtering of queries

[Rajat Khandelwal (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15581809#comment-15581809
 ] 

Rajat Khandelwal commented on LENS-1359:


Taking patch from reviewboard and attaching

> Add driver hooks for user based filtering of queries
> 
>
> Key: LENS-1359
> URL: https://issues.apache.org/jira/browse/LENS-1359
> Project: Apache Lens
>  Issue Type: Task
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1359.01.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1359) Add driver hooks for user based filtering of queries

[Rajat Khandelwal (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15581806#comment-15581806
 ] 

Rajat Khandelwal commented on LENS-1359:


Created https://reviews.apache.org/r/52924/

> Add driver hooks for user based filtering of queries
> 
>
> Key: LENS-1359
> URL: https://issues.apache.org/jira/browse/LENS-1359
> Project: Apache Lens
>  Issue Type: Task
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work started] (LENS-1359) Add driver hooks for user based filtering of queries

[Rajat Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on LENS-1359 started by Rajat Khandelwal.
--
> Add driver hooks for user based filtering of queries
> 
>
> Key: LENS-1359
> URL: https://issues.apache.org/jira/browse/LENS-1359
> Project: Apache Lens
>  Issue Type: Task
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Review Request 52924: LENS-1359: Add driver hooks for user based filtering of queries

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52924/
---

Review request for lens.


Bugs: LENS-1359
https://issues.apache.org/jira/browse/LENS-1359


Repository: lens


Description
---


Diffs
-

  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 
f307cccfc634d7742ca13da50169e88e56e98613 
  lens-driver-hive/src/main/resources/hivedriver-default.xml 
f5fd3bb20b9d6b82292c4483d860ea14c8104c5c 
  
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 
43b33f331f4d9017d76bccbe0f6936aaeb184f8f 
  
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java
 961ec4ec781d3d7fd0f28edc4f23e9b39549592f 
  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 
82e023146c0290b5a1e0146a550b6f7a55e7e1b2 
  
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 
3ae59c6ca126f0a3535974352adf97e7a495838f 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java
 8f30aa06ab234cedb53acb17544210ba4190ab53 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverConfiguration.java
 69a1a0b7ce57c24602a17ea7c97c0664a77c6568 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryHook.java
 f8a9ee07d8c8b737a41de339ab44ca7752c90748 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 
146223942d05cfd952599297144e2a6bc02df273 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/NoOpDriverQueryHook.java
 4f1f2eb99ed0bec8e6e471a9723a6b002a092202 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/ChainedDriverQueryHook.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/DriverQueryHook.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/NoOpDriverQueryHook.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHook.java
 PRE-CREATION 
  
lens-server-api/src/test/java/org/apache/lens/server/api/driver/DriverConfigurationTest.java
 PRE-CREATION 
  
lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHookTest.java
 PRE-CREATION 
  
lens-server-api/src/test/java/org/apache/lens/server/api/user/MockDriverQueryHook.java
 f70979abf7c44d3b4ed3588628de5a7517adfa81 
  src/site/apt/admin/hivedriver-config.apt 
b1a25c3b5bb58fc2d0773dc168c110ee5e60c635 

Diff: https://reviews.apache.org/r/52924/diff/


Testing
---


Thanks,

Rajat Khandelwal

[jira] [Created] (LENS-1359) Add driver hooks for user based filtering of queries

[Rajat Khandelwal (JIRA)]

Rajat Khandelwal created LENS-1359:
--

 Summary: Add driver hooks for user based filtering of queries
 Key: LENS-1359
 URL: https://issues.apache.org/jira/browse/LENS-1359
 Project: Apache Lens
  Issue Type: Task
Reporter: Rajat Khandelwal
Assignee: Rajat Khandelwal






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1327) Handle Data delay for scheduled jobs

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15581654#comment-15581654
 ] 

Hadoop QA commented on LENS-1327:
-

Applied patch: 
[0001-Data-dealy.patch|https://issues.apache.org/jira/secure/attachment/12833686/0001-Data-dealy.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1085/

> Handle Data delay for scheduled jobs
> 
>
> Key: LENS-1327
> URL: https://issues.apache.org/jira/browse/LENS-1327
> Project: Apache Lens
>  Issue Type: Sub-task
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Attachments: 0001-Data-dealy.patch, data-delay.patch, 
> data-delay.patch, data-delay.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1358) Lens server snapshotter failing when there's a jdbc query running while snapshotting

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15581608#comment-15581608
 ] 

Hudson commented on LENS-1358:
--

UNSTABLE: Integrated in Jenkins build Lens-Commit #1361 (See 
[https://builds.apache.org/job/Lens-Commit/1361/])
LENS-1358: Lens server snapshotter failing when there's a jdbc query 
(rajatgupta59: rev 34f15c6e24ef4604ef431765c3f23c799a44bec1)
* (edit) 
lens-server-api/src/test/java/org/apache/lens/server/api/query/TestQueryContext.java
* (edit) 
lens-server-api/src/test/java/org/apache/lens/server/api/query/TestAbstractQueryContext.java
* (edit) 
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java


> Lens server snapshotter failing when there's a jdbc query running while 
> snapshotting
> 
>
> Key: LENS-1358
> URL: https://issues.apache.org/jira/browse/LENS-1358
> Project: Apache Lens
>  Issue Type: Bug
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Fix For: 2.7
>
> Attachments: LENS-1358.01.patch, LENS-1358.02.patch, 
> LENS-1358.03.patch, LENS-1358.04.patch, LENS-1358.05.patch, LENS-1358.06.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1358) Lens server snapshotter failing when there's a jdbc query running while snapshotting

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15581598#comment-15581598
 ] 

Hudson commented on LENS-1358:
--

UNSTABLE: Integrated in Jenkins build Lens-Commit-Java8 #278 (See 
[https://builds.apache.org/job/Lens-Commit-Java8/278/])
LENS-1358: Lens server snapshotter failing when there's a jdbc query 
(rajatgupta59: rev 34f15c6e24ef4604ef431765c3f23c799a44bec1)
* (edit) 
lens-server-api/src/test/java/org/apache/lens/server/api/query/TestAbstractQueryContext.java
* (edit) 
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
* (edit) 
lens-server-api/src/test/java/org/apache/lens/server/api/query/TestQueryContext.java


> Lens server snapshotter failing when there's a jdbc query running while 
> snapshotting
> 
>
> Key: LENS-1358
> URL: https://issues.apache.org/jira/browse/LENS-1358
> Project: Apache Lens
>  Issue Type: Bug
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Fix For: 2.7
>
> Attachments: LENS-1358.01.patch, LENS-1358.02.patch, 
> LENS-1358.03.patch, LENS-1358.04.patch, LENS-1358.05.patch, LENS-1358.06.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1357) Seeing NPE in stop lens services after a failed attempt of start

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15581571#comment-15581571
 ] 

Hadoop QA commented on LENS-1357:
-

Applied patch: 
[LENS-1357.03.patch|https://issues.apache.org/jira/secure/attachment/12833678/LENS-1357.03.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1082/

> Seeing NPE in stop lens services after a failed attempt of start
> 
>
> Key: LENS-1357
> URL: https://issues.apache.org/jira/browse/LENS-1357
> Project: Apache Lens
>  Issue Type: Bug
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1357.01.patch, LENS-1357.02.patch, 
> LENS-1357.03.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1342) Unclosed InputStreamReader in PropertyBasedUserConfigLoader

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15581559#comment-15581559
 ] 

Hadoop QA commented on LENS-1342:
-

Applied patch: 
[1342.v1.txt|https://issues.apache.org/jira/secure/attachment/12833671/1342.v1.txt]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1084/

> Unclosed InputStreamReader in PropertyBasedUserConfigLoader
> ---
>
> Key: LENS-1342
> URL: https://issues.apache.org/jira/browse/LENS-1342
> Project: Apache Lens
>  Issue Type: Bug
>Reporter: Ted Yu
>Priority: Minor
> Attachments: 1342.v1.txt
>
>
> {code}
> try {
>   properties.load(new InputStreamReader(new FileInputStream(new 
> File(filename)), "UTF-8"));
> } catch (IOException e) {
>   throw new UserConfigLoaderException("property file not found. Provided 
> path was: " + filename);
> }
> {code}
> The InputStreamReader should be closed upon return from the method.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1327) Handle Data delay for scheduled jobs

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15581551#comment-15581551
 ] 

Hadoop QA commented on LENS-1327:
-

Applied patch: 
[0001-Data-dealy.patch|https://issues.apache.org/jira/secure/attachment/12833686/0001-Data-dealy.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1083/

> Handle Data delay for scheduled jobs
> 
>
> Key: LENS-1327
> URL: https://issues.apache.org/jira/browse/LENS-1327
> Project: Apache Lens
>  Issue Type: Sub-task
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Attachments: 0001-Data-dealy.patch, data-delay.patch, 
> data-delay.patch, data-delay.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1358) Lens server snapshotter failing when there's a jdbc query running while snapshotting

[Rajat Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-1358:
---
Fix Version/s: 2.7

> Lens server snapshotter failing when there's a jdbc query running while 
> snapshotting
> 
>
> Key: LENS-1358
> URL: https://issues.apache.org/jira/browse/LENS-1358
> Project: Apache Lens
>  Issue Type: Bug
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Fix For: 2.7
>
> Attachments: LENS-1358.01.patch, LENS-1358.02.patch, 
> LENS-1358.03.patch, LENS-1358.04.patch, LENS-1358.05.patch, LENS-1358.06.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1358) Lens server snapshotter failing when there's a jdbc query running while snapshotting

[Rajat Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-1358:
---
Resolution: Fixed
Status: Resolved  (was: Patch Available)

> Lens server snapshotter failing when there's a jdbc query running while 
> snapshotting
> 
>
> Key: LENS-1358
> URL: https://issues.apache.org/jira/browse/LENS-1358
> Project: Apache Lens
>  Issue Type: Bug
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Fix For: 2.7
>
> Attachments: LENS-1358.01.patch, LENS-1358.02.patch, 
> LENS-1358.03.patch, LENS-1358.04.patch, LENS-1358.05.patch, LENS-1358.06.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1358) Lens server snapshotter failing when there's a jdbc query running while snapshotting

[Rajat Khandelwal (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15581486#comment-15581486
 ] 

Rajat Khandelwal commented on LENS-1358:


Committed myself.

> Lens server snapshotter failing when there's a jdbc query running while 
> snapshotting
> 
>
> Key: LENS-1358
> URL: https://issues.apache.org/jira/browse/LENS-1358
> Project: Apache Lens
>  Issue Type: Bug
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Fix For: 2.7
>
> Attachments: LENS-1358.01.patch, LENS-1358.02.patch, 
> LENS-1358.03.patch, LENS-1358.04.patch, LENS-1358.05.patch, LENS-1358.06.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1358) Lens server snapshotter failing when there's a jdbc query running while snapshotting

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15581461#comment-15581461
 ] 

Hadoop QA commented on LENS-1358:
-

Applied patch: 
[LENS-1358.06.patch|https://issues.apache.org/jira/secure/attachment/12833680/LENS-1358.06.patch]
 and ran command: mvn clean install -fae. Result: Success. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1079/

> Lens server snapshotter failing when there's a jdbc query running while 
> snapshotting
> 
>
> Key: LENS-1358
> URL: https://issues.apache.org/jira/browse/LENS-1358
> Project: Apache Lens
>  Issue Type: Bug
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1358.01.patch, LENS-1358.02.patch, 
> LENS-1358.03.patch, LENS-1358.04.patch, LENS-1358.05.patch, LENS-1358.06.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)