> On Nov. 4, 2016, 5:45 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java, > > line 529 > > <https://reviews.apache.org/r/52514/diff/4/?file=1552900#file1552900line529> > > > > Measures are getting added, by iterating over queried phrases below. > > But empty check is happening here. Populating measures should be moved up.
With the empty check for the measures, there is also the empty check of the queriedPhrases with the AND clause. Hence, this check seems to be alright. > On Nov. 4, 2016, 5:45 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java, > > line 939 > > <https://reviews.apache.org/r/52514/diff/4/?file=1552906#file1552906line939> > > > > Why didn't the query fail here ? If the test is to check no failure on > > partial data, can you update testname and comment above. Yes, The test is to check no failure on partial data as the flag FAIL_QUERY_ON_PARTIAL_DATA is not set. Will update the test name and add appropriate comment. > On Nov. 4, 2016, 5:45 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java, > > line 973 > > <https://reviews.apache.org/r/52514/diff/4/?file=1552906#file1552906line973> > > > > Can you share the reason being shown up, as a comment? Sure...will add the comment. > On Nov. 4, 2016, 5:45 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java, > > line 596 > > <https://reviews.apache.org/r/52514/diff/4/?file=1552900#file1552900line596> > > > > Shall we rename variable to incompletePartition, instead of > > partitionCompleteness ? Will rename it. > On Nov. 4, 2016, 5:45 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java, > > lines 565-566 > > <https://reviews.apache.org/r/52514/diff/4/?file=1552900#file1552900line565> > > > > Why do you need this formatter? And why is formatting done upto hours? Actually we can use the Date as well. Agreed, If we use formattter, we should give formatting upto seconds. - Narayan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52514/#review154865 ----------------------------------------------------------- On Nov. 3, 2016, 11:13 a.m., Narayan Periwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52514/ > ----------------------------------------------------------- > > (Updated Nov. 3, 2016, 11:13 a.m.) > > > Review request for lens. > > > Bugs: LENS-1333 > https://issues.apache.org/jira/browse/LENS-1333 > > > Repository: lens > > > Description > ------- > > Though lens has partition registration being done whenever data is available, > there is no guarantee the partition registered is complete. There can be > different ways to know if the data is complete for partition. One option > could be to have a partition property saying whether it is complete or not. > Other could be to do a http call to another hosted service and more. > > Proposal here is to add an interface for DataCompletenessChecker and do the > check while resolving partitions. > > Here are some of the capabilities we would like to add in Lens : > # Lens will check partition existence first, if it exists, then check the > completeness percentage. If the completeness percentage is less than a > configured threshold (default should be 98, 99 or even 100), Lens will fail > the query. > # Lens's accept query on partial data will accept on incomplete data as well. > # Lens will also option to override the completeness percentage threshold > value at query level > # Lens will still have look ahead capability of daily being incomplete, then > it will union with hourly. > # If same measure is there in two different facts , Lens will we pick the one > with higher availability. > # In case of completeness percentage threshold missed, Lens will respond back > with available percentage. > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java > fb958c3 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > e14c43f > > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java > 4585ef7 > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java > 5dc9dc9 > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java > 78fb21d > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java > f20f105 > lens-cube/src/main/java/org/apache/lens/cube/parse/DefaultChecker.java > PRE-CREATION > > lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java > 13f1aa4 > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java > db26718 > lens-cube/src/main/resources/olap-query-conf.xml 0c888ca > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > 0c43cb5 > > lens-cube/src/test/java/org/apache/lens/cube/parse/FieldsCannotBeQueriedTogetherTest.java > 7afa32e > > lens-cube/src/test/java/org/apache/lens/cube/parse/MockCompletenessChecker.java > PRE-CREATION > lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java > f6cec1b > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java > b90d4d3 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java > 0aa31f4 > lens-server/src/main/resources/lenssession-default.xml 9a8f9da > src/site/apt/admin/session-config.apt d480f88 > src/site/apt/user/olap-query-conf.apt ce35ec4 > > Diff: https://reviews.apache.org/r/52514/diff/ > > > Testing > ------- > > > Thanks, > > Narayan Periwal > >
